From: Ola Lilja <ola.o.lilja@stericsson.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
Roger NILSSON1 <roger.xr.nilsson@stericsson.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 06/17] Documentation: Define the MOP500 Audio Machine Driver Device Tree bindings
Date: Tue, 11 Sep 2012 11:06:00 +0200 [thread overview]
Message-ID: <504EFEF8.6020707@stericsson.com> (raw)
In-Reply-To: <20120910164413.GC24506@gmail.com>
On 09/10/2012 06:44 PM, Lee Jones wrote:
> Ola poke.
>
> On Fri, Aug 24, 2012 at 03:01:42PM +0100, Lee Jones wrote:
>> Here we add the required documentation for the new Device Tree
>> bindings pertaining to the MOP500 Audio Machine driver.
>>
>> CC: alsa-devel@alsa-project.org
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>> ---
>> .../devicetree/bindings/sound/ux500-mop500.txt | 39 ++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/ux500-mop500.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/ux500-mop500.txt b/Documentation/devicetree/bindings/sound/ux500-mop500.txt
>> new file mode 100644
>> index 0000000..48e071c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/ux500-mop500.txt
>> @@ -0,0 +1,39 @@
>> +* MOP500 Audio Machine Driver
>> +
>> +This node is responsible for linking together all ux500 Audio Driver components.
>> +
>> +Required properties:
>> + - compatible : "stericsson,snd-soc-mop500"
>> +
>> +Non-standard properties:
>> + - stericsson,cpu-dai : Phandle to the CPU-side DAI
>> + - stericsson,audio-codec : Phandle to the Audio CODEC
>> + - stericsson,card-name : Over-ride default card name
>> +
>> +Example:
>> +
>> + sound {
>> + compatible = "stericsson,snd-soc-mop500";
>> +
>> + stericsson,cpu-dai = <&msp1 &msp3>;
>> + stericsson,audio-codec = <&codec>;
>> + };
>> +
>> + msp1: msp@80124000 {
>> + compatible = "stericsson,ux500-msp-i2s";
>> + reg = <0x80124000 0x1000>;
>> + interrupts = <0 62 0x4>;
>> + v-ape-supply = <&db8500_vape_reg>;
I'm no DT-expert, but why are you adding MSP-stuff in the machine-driver? They
are also added in the next patch.
>> + };
>> +
>> + msp3: msp@80125000 {
>> + compatible = "stericsson,ux500-msp-i2s";
>> + reg = <0x80125000 0x1000>;
>> + interrupts = <0 62 0x4>;
>> + v-ape-supply = <&db8500_vape_reg>;
>> + };
>> +
>> + codec: ab8500-codec {
>> + compatible = "stericsson,ab8500-codec";
>> + stericsson,earpeice-cmv = <950>; /* Units in mV. */
Only four voltages are allowed here. Maybe enumerate them in the comment?
>> + };
>> --
>> 1.7.9.5
>>
>
next prev parent reply other threads:[~2012-09-11 9:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 14:01 [PATCH 00/17] MOP500 Audio fix-ups and DT enablement Lee Jones
2012-08-24 14:01 ` [PATCH 01/17] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Lee Jones
2012-08-30 23:46 ` Linus Walleij
2012-09-10 16:46 ` Lee Jones
2012-09-11 9:28 ` Ola Lilja
2012-08-24 14:01 ` [PATCH 02/17] ASoC: Ux500: Enable MOP500 driver for Device Tree Lee Jones
2012-08-24 14:01 ` [PATCH 03/17] ASoC: Ux500: Enable ux500 MSP " Lee Jones
2012-08-24 14:01 ` [PATCH 04/17] ASoC: codecs: Enable AB8500 CODEC " Lee Jones
2012-08-24 14:01 ` [PATCH 05/17] ASoC: Ux500: Minor coding layout changes Lee Jones
2012-09-10 16:44 ` Lee Jones
2012-09-11 0:27 ` Mark Brown
2012-09-11 9:03 ` Ola Lilja
2012-08-24 14:01 ` [PATCH 06/17] Documentation: Define the MOP500 Audio Machine Driver Device Tree bindings Lee Jones
2012-09-10 16:44 ` Lee Jones
2012-09-11 9:06 ` Ola Lilja [this message]
2012-09-11 9:08 ` Mark Brown
2012-09-14 10:02 ` Lee Jones
2012-08-24 14:01 ` [PATCH 07/17] Documentation: Define the MSP " Lee Jones
2012-09-10 16:43 ` Lee Jones
2012-09-11 9:08 ` Ola Lilja
2012-09-14 9:57 ` Lee Jones
2012-08-24 14:01 ` [PATCH 08/17] ARM: ux500: Clean-up MSP platform code Lee Jones
2012-08-24 14:01 ` [PATCH 09/17] ARM: ux500: Add AB8500 CODEC node to DB8500 Device Tree Lee Jones
2012-08-30 23:50 ` Linus Walleij
2012-08-24 14:01 ` [PATCH 10/17] ARM: ux500: Fork MSP platform registration for step-by-step DT enablement Lee Jones
2012-08-24 14:01 ` [PATCH 11/17] ARM: ux500: Pass MSP DMA platform data though AUXDATA Lee Jones
2012-08-24 14:01 ` [PATCH 12/17] ARM: ux500: Stop registering the MOP500 Audio driver from platform code Lee Jones
2012-08-24 14:01 ` [PATCH 13/17] ARM: ux500: Remove platform registration of MSP devices Lee Jones
2012-08-24 14:01 ` [PATCH 14/17] ARM: ux500: Rename MSP board file to something more meaningful Lee Jones
2012-08-24 15:05 ` [alsa-devel] " Hebbar, Gururaja
2012-08-24 15:08 ` Lee Jones
2012-08-24 15:14 ` Lee Jones
2012-08-24 15:16 ` Hebbar, Gururaja
2012-08-24 14:01 ` [PATCH 15/17] ARM: ux500: Add nodes for the MSP into Device Tree Lee Jones
2012-08-24 14:01 ` [PATCH 16/17] ARM: ux500: Add all encompassing sound node to the Snowball " Lee Jones
2012-08-24 14:01 ` [PATCH 17/17] Documentation: Add the AB8500 CODEC device to the MFD AB8500 doc Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504EFEF8.6020707@stericsson.com \
--to=ola.o.lilja@stericsson.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.xr.nilsson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).