* [GIT PULL 00/12] perf/core improvements and fixes @ 2012-10-24 21:50 Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 01/12] perf tools: Diplays more output on features check for make V=1 Arnaldo Carvalho de Melo ` (12 more replies) 0 siblings, 13 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Borislav Petkov, Corey Ashford, David Ahern, Frederic Weisbecker, Irina Tirdea, Jiri Olsa, Mike Galbraith, Namhyung Kim, Namhyung Kim, Paul Mackerras, Pekka Enberg, Peter Zijlstra, Robert Richter, Stephane Eranian, Steven Rostedt, Suzuki K. Poulose, Thomas Gleixner, arnaldo.melo, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling. I'll continue processing patchsets by Jiri, Namhyung, David, Irina and others tomorrow. I also have to rework the pagefaults patches, as the code it touches changed lately, will add that NUMA node info you suggested. - Arnaldo The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163: x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b: perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200) ---------------------------------------------------------------- perf/core improvements and fixes . Align the 'Ok'/'FAILED!' test results in 'perf test. . Support interrupted syscalls in 'trace' . Add an event duration column and filter in 'trace'. . There are references to the man pages in some tools, so try to build Documentation when installing, warning the user if that is not possible, from Borislav Petkov. . Give user better message if precise is not supported, from David Ahern. . Try to find cross-built objdump path by using the session environment information in the perf.data file header, from Irina Tirdea, original patch and idea by Namhyung Kim. . Diplays more output on features check for make V=1, so that one can figure out what is happening by looking at gcc output, etc. From Jiri Olsa. . Account the nr_entries in rblist properly, fix by Suzuki K. Poulose. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Arnaldo Carvalho de Melo (7): perf tools: Remove noise in python version feature test perf test: Align the 'Ok'/'FAILED!' test results perf trace: Support interrupted syscalls perf trace: Add an event duration column perf trace: Add duration filter perf tools: Pretty print errno for some more functions perf trace: Print the name of a syscall when failing to read its info Borislav Petkov (1): perf tools: Try to build Documentation when installing David Ahern (1): perf tools: Give user better message if precise is not supported Irina Tirdea (1): perf tools: Try to find cross-built objdump path Jiri Olsa (1): perf tools: Diplays more output on features check for make V=1 Suzuki K. Poulose (1): Account the nr_entries in rblist properly tools/perf/Documentation/Makefile | 31 +++- tools/perf/Documentation/perf-trace.txt | 3 + tools/perf/Makefile | 53 ++++--- tools/perf/arch/common.c | 178 ++++++++++++++++++++++ tools/perf/arch/common.h | 10 ++ tools/perf/builtin-annotate.c | 7 + tools/perf/builtin-record.c | 5 + tools/perf/builtin-report.c | 7 + tools/perf/builtin-test.c | 18 ++- tools/perf/builtin-top.c | 4 + tools/perf/builtin-trace.c | 250 ++++++++++++++++++++++++++++--- tools/perf/config/feature-tests.mak | 5 +- tools/perf/config/utilities.mak | 11 +- tools/perf/util/annotate.h | 1 - tools/perf/util/parse-events.c | 2 +- tools/perf/util/rblist.c | 4 +- tools/perf/util/util.h | 4 + 17 files changed, 535 insertions(+), 58 deletions(-) create mode 100644 tools/perf/arch/common.c create mode 100644 tools/perf/arch/common.h ^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH 01/12] perf tools: Diplays more output on features check for make V=1 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 02/12] perf tools: Remove noise in python version feature test Arnaldo Carvalho de Melo ` (11 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Jiri Olsa, Corey Ashford, Frederic Weisbecker, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Arnaldo Carvalho de Melo From: Jiri Olsa <jolsa@redhat.com> Adding more verbose output for compile time features checking, to ease up debuging of feature detection failures. Suggested-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Jiri Olsa <jolsa@redhat.com> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/n/tip-fbjha6xs5soyaiek8j4142xg@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Makefile | 46 +++++++++++++++++++-------------------- tools/perf/config/utilities.mak | 11 ++++++++-- 2 files changed, 32 insertions(+), 25 deletions(-) diff --git a/tools/perf/Makefile b/tools/perf/Makefile index f530502..6790cb4 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -155,15 +155,15 @@ SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__ -include config/feature-tests.mak -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -fstack-protector-all),y) +ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -fstack-protector-all,-fstack-protector-all),y) CFLAGS := $(CFLAGS) -fstack-protector-all endif -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wstack-protector),y) +ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wstack-protector,-Wstack-protector),y) CFLAGS := $(CFLAGS) -Wstack-protector endif -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wvolatile-register-var),y) +ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wvolatile-register-var,-Wvolatile-register-var),y) CFLAGS := $(CFLAGS) -Wvolatile-register-var endif @@ -172,7 +172,7 @@ endif BASIC_CFLAGS = -Iutil/include -Iarch/$(ARCH)/include -I$(OUTPUT)util -I$(TRACE_EVENT_DIR) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE BASIC_LDFLAGS = -ifeq ($(call try-cc,$(SOURCE_BIONIC),$(CFLAGS)),y) +ifeq ($(call try-cc,$(SOURCE_BIONIC),$(CFLAGS),bionic),y) BIONIC := 1 EXTLIBS := $(filter-out -lrt,$(EXTLIBS)) EXTLIBS := $(filter-out -lpthread,$(EXTLIBS)) @@ -477,9 +477,9 @@ ifdef NO_LIBELF NO_LIBUNWIND := 1 else FLAGS_LIBELF=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -ifneq ($(call try-cc,$(SOURCE_LIBELF),$(FLAGS_LIBELF)),y) +ifneq ($(call try-cc,$(SOURCE_LIBELF),$(FLAGS_LIBELF),libelf),y) FLAGS_GLIBC=$(ALL_CFLAGS) $(ALL_LDFLAGS) - ifeq ($(call try-cc,$(SOURCE_GLIBC),$(FLAGS_GLIBC)),y) + ifeq ($(call try-cc,$(SOURCE_GLIBC),$(FLAGS_GLIBC),glibc),y) LIBC_SUPPORT := 1 endif ifeq ($(BIONIC),1) @@ -494,7 +494,7 @@ ifneq ($(call try-cc,$(SOURCE_LIBELF),$(FLAGS_LIBELF)),y) endif else FLAGS_DWARF=$(ALL_CFLAGS) -ldw -lelf $(ALL_LDFLAGS) $(EXTLIBS) - ifneq ($(call try-cc,$(SOURCE_DWARF),$(FLAGS_DWARF)),y) + ifneq ($(call try-cc,$(SOURCE_DWARF),$(FLAGS_DWARF),libdw),y) msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev); NO_DWARF := 1 endif # Dwarf support @@ -510,7 +510,7 @@ ifdef LIBUNWIND_DIR endif FLAGS_UNWIND=$(LIBUNWIND_CFLAGS) $(ALL_CFLAGS) $(LIBUNWIND_LDFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(LIBUNWIND_LIBS) -ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND)),y) +ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND),libunwind),y) msg := $(warning No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 0.99); NO_LIBUNWIND := 1 endif # Libunwind support @@ -539,7 +539,7 @@ LIB_OBJS += $(OUTPUT)util/symbol-minimal.o else # NO_LIBELF BASIC_CFLAGS += -DLIBELF_SUPPORT -ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_COMMON)),y) +ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_COMMON),-DLIBELF_MMAP),y) BASIC_CFLAGS += -DLIBELF_MMAP endif @@ -565,7 +565,7 @@ endif ifndef NO_LIBAUDIT FLAGS_LIBAUDIT = $(ALL_CFLAGS) $(ALL_LDFLAGS) -laudit - ifneq ($(call try-cc,$(SOURCE_LIBAUDIT),$(FLAGS_LIBAUDIT)),y) + ifneq ($(call try-cc,$(SOURCE_LIBAUDIT),$(FLAGS_LIBAUDIT),libaudit),y) msg := $(warning No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev); else BASIC_CFLAGS += -DLIBAUDIT_SUPPORT @@ -576,7 +576,7 @@ endif ifndef NO_NEWT FLAGS_NEWT=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -lnewt - ifneq ($(call try-cc,$(SOURCE_NEWT),$(FLAGS_NEWT)),y) + ifneq ($(call try-cc,$(SOURCE_NEWT),$(FLAGS_NEWT),libnewt),y) msg := $(warning newt not found, disables TUI support. Please install newt-devel or libnewt-dev); else # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h @@ -605,10 +605,10 @@ endif ifndef NO_GTK2 FLAGS_GTK2=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null) - ifneq ($(call try-cc,$(SOURCE_GTK2),$(FLAGS_GTK2)),y) + ifneq ($(call try-cc,$(SOURCE_GTK2),$(FLAGS_GTK2),gtk2),y) msg := $(warning GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev); else - ifeq ($(call try-cc,$(SOURCE_GTK2_INFOBAR),$(FLAGS_GTK2)),y) + ifeq ($(call try-cc,$(SOURCE_GTK2_INFOBAR),$(FLAGS_GTK2),-DHAVE_GTK_INFO_BAR),y) BASIC_CFLAGS += -DHAVE_GTK_INFO_BAR endif BASIC_CFLAGS += -DGTK2_SUPPORT @@ -635,7 +635,7 @@ else PERL_EMBED_CCOPTS = `perl -MExtUtils::Embed -e ccopts 2>/dev/null` FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS) - ifneq ($(call try-cc,$(SOURCE_PERL_EMBED),$(FLAGS_PERL_EMBED)),y) + ifneq ($(call try-cc,$(SOURCE_PERL_EMBED),$(FLAGS_PERL_EMBED),perl),y) BASIC_CFLAGS += -DNO_LIBPERL else ALL_LDFLAGS += $(PERL_EMBED_LDFLAGS) @@ -689,11 +689,11 @@ else PYTHON_EMBED_CCOPTS := $(shell $(PYTHON_CONFIG_SQ) --cflags 2>/dev/null) FLAGS_PYTHON_EMBED := $(PYTHON_EMBED_CCOPTS) $(PYTHON_EMBED_LDOPTS) - ifneq ($(call try-cc,$(SOURCE_PYTHON_EMBED),$(FLAGS_PYTHON_EMBED)),y) + ifneq ($(call try-cc,$(SOURCE_PYTHON_EMBED),$(FLAGS_PYTHON_EMBED),python),y) $(call disable-python,Python.h (for Python 2.x)) else - ifneq ($(call try-cc,$(SOURCE_PYTHON_VERSION),$(FLAGS_PYTHON_EMBED)),y) + ifneq ($(call try-cc,$(SOURCE_PYTHON_VERSION),$(FLAGS_PYTHON_EMBED),python version),y) $(warning Python 3 is not yet supported; please set) $(warning PYTHON and/or PYTHON_CONFIG appropriately.) $(warning If you also have Python 2 installed, then) @@ -727,22 +727,22 @@ else BASIC_CFLAGS += -DHAVE_CPLUS_DEMANGLE else FLAGS_BFD=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -DPACKAGE='perf' -lbfd - has_bfd := $(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD)) + has_bfd := $(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD),libbfd) ifeq ($(has_bfd),y) EXTLIBS += -lbfd else FLAGS_BFD_IBERTY=$(FLAGS_BFD) -liberty - has_bfd_iberty := $(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD_IBERTY)) + has_bfd_iberty := $(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD_IBERTY),liberty) ifeq ($(has_bfd_iberty),y) EXTLIBS += -lbfd -liberty else FLAGS_BFD_IBERTY_Z=$(FLAGS_BFD_IBERTY) -lz - has_bfd_iberty_z := $(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD_IBERTY_Z)) + has_bfd_iberty_z := $(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD_IBERTY_Z),libz) ifeq ($(has_bfd_iberty_z),y) EXTLIBS += -lbfd -liberty -lz else FLAGS_CPLUS_DEMANGLE=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -liberty - has_cplus_demangle := $(call try-cc,$(SOURCE_CPLUS_DEMANGLE),$(FLAGS_CPLUS_DEMANGLE)) + has_cplus_demangle := $(call try-cc,$(SOURCE_CPLUS_DEMANGLE),$(FLAGS_CPLUS_DEMANGLE),demangle) ifeq ($(has_cplus_demangle),y) EXTLIBS += -liberty BASIC_CFLAGS += -DHAVE_CPLUS_DEMANGLE @@ -764,19 +764,19 @@ ifeq ($(NO_PERF_REGS),0) endif ifndef NO_STRLCPY - ifeq ($(call try-cc,$(SOURCE_STRLCPY),),y) + ifeq ($(call try-cc,$(SOURCE_STRLCPY),,-DHAVE_STRLCPY),y) BASIC_CFLAGS += -DHAVE_STRLCPY endif endif ifndef NO_ON_EXIT - ifeq ($(call try-cc,$(SOURCE_ON_EXIT),),y) + ifeq ($(call try-cc,$(SOURCE_ON_EXIT),,-DHAVE_ON_EXIT),y) BASIC_CFLAGS += -DHAVE_ON_EXIT endif endif ifndef NO_BACKTRACE - ifeq ($(call try-cc,$(SOURCE_BACKTRACE),),y) + ifeq ($(call try-cc,$(SOURCE_BACKTRACE),,-DBACKTRACE_SUPPORT),y) BASIC_CFLAGS += -DBACKTRACE_SUPPORT endif endif diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak index 8046182..ea853c2 100644 --- a/tools/perf/config/utilities.mak +++ b/tools/perf/config/utilities.mak @@ -180,9 +180,16 @@ _gea_warn = $(warning The path '$(1)' is not executable.) _gea_err = $(if $(1),$(error Please set '$(1)' appropriately)) # try-cc -# Usage: option = $(call try-cc, source-to-build, cc-options) +# Usage: option = $(call try-cc, source-to-build, cc-options, msg) +ifndef V +TRY_CC_OUTPUT= > /dev/null 2>&1 +else +TRY_CC_MSG=echo "CHK $(3)" 1>&2; +endif + try-cc = $(shell sh -c \ 'TMP="$(OUTPUT)$(TMPOUT).$$$$"; \ + $(TRY_CC_MSG) \ echo "$(1)" | \ - $(CC) -x c - $(2) -o "$$TMP" > /dev/null 2>&1 && echo y; \ + $(CC) -x c - $(2) -o "$$TMP" $(TRY_CC_OUTPUT) && echo y; \ rm -f "$$TMP"') -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 02/12] perf tools: Remove noise in python version feature test 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 01/12] perf tools: Diplays more output on features check for make V=1 Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 03/12] perf tools: Try to find cross-built objdump path Arnaldo Carvalho de Melo ` (10 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian From: Arnaldo Carvalho de Melo <acme@redhat.com> Now that the feature tests honours the V=1 make verbosity switch, add a return to the main() routine in the python version test, to avoid this distraction: CHK python version <stdin>: In function 'main': <stdin>:5: warning: control reaches end of non-void function Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-999no5yxlc2oqo9xjeez5zmv@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/config/feature-tests.mak | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak index 3ef5ec9..f5ac774 100644 --- a/tools/perf/config/feature-tests.mak +++ b/tools/perf/config/feature-tests.mak @@ -121,7 +121,10 @@ define SOURCE_PYTHON_VERSION #if PY_VERSION_HEX >= 0x03000000 #error #endif -int main(void){} +int main(void) +{ + return 0; +} endef define SOURCE_PYTHON_EMBED #include <Python.h> -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 03/12] perf tools: Try to find cross-built objdump path 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 01/12] perf tools: Diplays more output on features check for make V=1 Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 02/12] perf tools: Remove noise in python version feature test Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 04/12] Account the nr_entries in rblist properly Arnaldo Carvalho de Melo ` (9 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Irina Tirdea, David Ahern, Jiri Olsa, Namhyung Kim, Paul Mackerras, Pekka Enberg, Peter Zijlstra, Steven Rostedt, Arnaldo Carvalho de Melo From: Irina Tirdea <irina.tirdea@intel.com> As we have architecture information of saved perf.data file, we can try to find cross-built objdump path. The triplets include support for Android (arm, x86 and mips architectures). Signed-off-by: Irina Tirdea <irina.tirdea@intel.com> Originally-by: Namhyung Kim <namhyung@kernel.org> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: David Ahern <dsahern@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung.kim@lge.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Pekka Enberg <penberg@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Steven Rostedt <rostedt@goodmis.org> Link: http://lkml.kernel.org/r/1350344020-8071-5-git-send-email-irina.tirdea@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Makefile | 2 + tools/perf/arch/common.c | 178 +++++++++++++++++++++++++++++++++++++++++ tools/perf/arch/common.h | 10 +++ tools/perf/builtin-annotate.c | 7 ++ tools/perf/builtin-report.c | 7 ++ tools/perf/util/annotate.h | 1 - 6 files changed, 204 insertions(+), 1 deletion(-) create mode 100644 tools/perf/arch/common.c create mode 100644 tools/perf/arch/common.h diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 6790cb4..78a81ed 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -426,6 +426,8 @@ LIB_OBJS += $(OUTPUT)ui/helpline.o LIB_OBJS += $(OUTPUT)ui/hist.o LIB_OBJS += $(OUTPUT)ui/stdio/hist.o +LIB_OBJS += $(OUTPUT)arch/common.o + BUILTIN_OBJS += $(OUTPUT)builtin-annotate.o BUILTIN_OBJS += $(OUTPUT)builtin-bench.o # Benchmark modules diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c new file mode 100644 index 0000000..2367b25 --- /dev/null +++ b/tools/perf/arch/common.c @@ -0,0 +1,178 @@ +#include <stdio.h> +#include <sys/utsname.h> +#include "common.h" +#include "../util/debug.h" + +const char *const arm_triplets[] = { + "arm-eabi-", + "arm-linux-androideabi-", + "arm-unknown-linux-", + "arm-unknown-linux-gnu-", + "arm-unknown-linux-gnueabi-", + NULL +}; + +const char *const powerpc_triplets[] = { + "powerpc-unknown-linux-gnu-", + "powerpc64-unknown-linux-gnu-", + NULL +}; + +const char *const s390_triplets[] = { + "s390-ibm-linux-", + NULL +}; + +const char *const sh_triplets[] = { + "sh-unknown-linux-gnu-", + "sh64-unknown-linux-gnu-", + NULL +}; + +const char *const sparc_triplets[] = { + "sparc-unknown-linux-gnu-", + "sparc64-unknown-linux-gnu-", + NULL +}; + +const char *const x86_triplets[] = { + "x86_64-pc-linux-gnu-", + "x86_64-unknown-linux-gnu-", + "i686-pc-linux-gnu-", + "i586-pc-linux-gnu-", + "i486-pc-linux-gnu-", + "i386-pc-linux-gnu-", + "i686-linux-android-", + "i686-android-linux-", + NULL +}; + +const char *const mips_triplets[] = { + "mips-unknown-linux-gnu-", + "mipsel-linux-android-", + NULL +}; + +static bool lookup_path(char *name) +{ + bool found = false; + char *path, *tmp; + char buf[PATH_MAX]; + char *env = getenv("PATH"); + + if (!env) + return false; + + env = strdup(env); + if (!env) + return false; + + path = strtok_r(env, ":", &tmp); + while (path) { + scnprintf(buf, sizeof(buf), "%s/%s", path, name); + if (access(buf, F_OK) == 0) { + found = true; + break; + } + path = strtok_r(NULL, ":", &tmp); + } + free(env); + return found; +} + +static int lookup_triplets(const char *const *triplets, const char *name) +{ + int i; + char buf[PATH_MAX]; + + for (i = 0; triplets[i] != NULL; i++) { + scnprintf(buf, sizeof(buf), "%s%s", triplets[i], name); + if (lookup_path(buf)) + return i; + } + return -1; +} + +static int perf_session_env__lookup_binutils_path(struct perf_session_env *env, + const char *name, + const char **path) +{ + int idx; + char *arch, *cross_env; + struct utsname uts; + const char *const *path_list; + char *buf = NULL; + + if (uname(&uts) < 0) + goto out; + + /* + * We don't need to try to find objdump path for native system. + * Just use default binutils path (e.g.: "objdump"). + */ + if (!strcmp(uts.machine, env->arch)) + goto out; + + cross_env = getenv("CROSS_COMPILE"); + if (cross_env) { + if (asprintf(&buf, "%s%s", cross_env, name) < 0) + goto out_error; + if (buf[0] == '/') { + if (access(buf, F_OK) == 0) + goto out; + goto out_error; + } + if (lookup_path(buf)) + goto out; + free(buf); + } + + arch = env->arch; + + if (!strcmp(arch, "arm")) + path_list = arm_triplets; + else if (!strcmp(arch, "powerpc")) + path_list = powerpc_triplets; + else if (!strcmp(arch, "sh")) + path_list = sh_triplets; + else if (!strcmp(arch, "s390")) + path_list = s390_triplets; + else if (!strcmp(arch, "sparc")) + path_list = sparc_triplets; + else if (!strcmp(arch, "x86") || !strcmp(arch, "i386") || + !strcmp(arch, "i486") || !strcmp(arch, "i586") || + !strcmp(arch, "i686")) + path_list = x86_triplets; + else if (!strcmp(arch, "mips")) + path_list = mips_triplets; + else { + ui__error("binutils for %s not supported.\n", arch); + goto out_error; + } + + idx = lookup_triplets(path_list, name); + if (idx < 0) { + ui__error("Please install %s for %s.\n" + "You can add it to PATH, set CROSS_COMPILE or " + "override the default using --%s.\n", + name, arch, name); + goto out_error; + } + + if (asprintf(&buf, "%s%s", path_list[idx], name) < 0) + goto out_error; + +out: + *path = buf; + return 0; +out_error: + free(buf); + *path = NULL; + return -1; +} + +int perf_session_env__lookup_objdump(struct perf_session_env *env) +{ + return perf_session_env__lookup_binutils_path(env, "objdump", + &objdump_path); +} diff --git a/tools/perf/arch/common.h b/tools/perf/arch/common.h new file mode 100644 index 0000000..ede246e --- /dev/null +++ b/tools/perf/arch/common.h @@ -0,0 +1,10 @@ +#ifndef ARCH_PERF_COMMON_H +#define ARCH_PERF_COMMON_H + +#include "../util/session.h" + +extern const char *objdump_path; + +int perf_session_env__lookup_objdump(struct perf_session_env *env); + +#endif /* ARCH_PERF_COMMON_H */ diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index 690fa9a..c4bb645 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c @@ -28,6 +28,7 @@ #include "util/hist.h" #include "util/session.h" #include "util/tool.h" +#include "arch/common.h" #include <linux/bitmap.h> @@ -186,6 +187,12 @@ static int __cmd_annotate(struct perf_annotate *ann) goto out_delete; } + if (!objdump_path) { + ret = perf_session_env__lookup_objdump(&session->header.env); + if (ret) + goto out_delete; + } + ret = perf_session__process_events(session, &ann->tool); if (ret) goto out_delete; diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 5104a40..90d1162 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -33,6 +33,7 @@ #include "util/thread.h" #include "util/sort.h" #include "util/hist.h" +#include "arch/common.h" #include <linux/bitmap.h> @@ -672,6 +673,12 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused) has_br_stack = perf_header__has_feat(&session->header, HEADER_BRANCH_STACK); + if (!objdump_path) { + ret = perf_session_env__lookup_objdump(&session->header.env); + if (ret) + goto error; + } + if (sort__branch_mode == -1 && has_br_stack) sort__branch_mode = 1; diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h index 39242dc..a4dd25a 100644 --- a/tools/perf/util/annotate.h +++ b/tools/perf/util/annotate.h @@ -154,6 +154,5 @@ static inline int symbol__tui_annotate(struct symbol *sym __maybe_unused, #endif extern const char *disassembler_style; -extern const char *objdump_path; #endif /* __PERF_ANNOTATE_H */ -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 04/12] Account the nr_entries in rblist properly 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (2 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 03/12] perf tools: Try to find cross-built objdump path Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 05/12] perf tools: Give user better message if precise is not supported Arnaldo Carvalho de Melo ` (8 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Suzuki K. Poulose, David S. Ahern, Arnaldo Carvalho de Melo From: "Suzuki K. Poulose" <suzuki@in.ibm.com> The nr_entries in rblist is never decremented when an element is deleted. Also, use rblist__remove_node to delete a node in rblist__delete(). This would keep the nr_entries sane. Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com> Acked-by: David S. Ahern <dsahern@gmail.com> Cc: David S. Ahern <dsahern@gmail.com> Link: http://lkml.kernel.org/r/20120831070834.14806.87398.stgit@suzukikp.in.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/rblist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/rblist.c b/tools/perf/util/rblist.c index 0171fb6..a16cdd2 100644 --- a/tools/perf/util/rblist.c +++ b/tools/perf/util/rblist.c @@ -44,6 +44,7 @@ int rblist__add_node(struct rblist *rblist, const void *new_entry) void rblist__remove_node(struct rblist *rblist, struct rb_node *rb_node) { rb_erase(rb_node, &rblist->entries); + --rblist->nr_entries; rblist->node_delete(rblist, rb_node); } @@ -87,8 +88,7 @@ void rblist__delete(struct rblist *rblist) while (next) { pos = next; next = rb_next(pos); - rb_erase(pos, &rblist->entries); - rblist->node_delete(rblist, pos); + rblist__remove_node(rblist, pos); } free(rblist); } -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 05/12] perf tools: Give user better message if precise is not supported 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (3 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 04/12] Account the nr_entries in rblist properly Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 06/12] perf test: Align the 'Ok'/'FAILED!' test results Arnaldo Carvalho de Melo ` (7 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, David Ahern, Peter Zijlstra, Robert Richter, Arnaldo Carvalho de Melo From: David Ahern <dsahern@gmail.com> Platforms (e.g., VM's) without support for precise mode get a confusing error message. e.g., $ perf record -e cycles:p -a -- sleep 1 Error: sys_perf_event_open() syscall returned with 95 (Operation not supported). /bin/dmesg may provide additional information. No hardware sampling interrupt available. No APIC? If so then you can boot the kernel with the "lapic" boot parameter to force-enable it. sleep: Terminated which is not clear that precise mode might be the root problem. With this patch: $ perf record -e cycles:p -fo /tmp/perf.data -- sleep 1 Error: 'precise' request may not be supported. Try removing 'p' modifier sleep: Terminated v2: softened message to 'may not be' supported per Robert's suggestion Signed-off-by: David Ahern <dsahern@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Robert Richter <robert.richter@amd.com> Link: http://lkml.kernel.org/r/1347569955-54626-4-git-send-email-dsahern@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-record.c | 5 +++++ tools/perf/builtin-top.c | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 73b5d7f..53c9892 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -317,6 +317,11 @@ try_again: perf_evsel__name(pos)); rc = -err; goto out; + } else if ((err == EOPNOTSUPP) && (attr->precise_ip)) { + ui__error("\'precise\' request may not be supported. " + "Try removing 'p' modifier\n"); + rc = -err; + goto out; } printf("\n"); diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index fb9da71..f2ecd49 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -977,6 +977,10 @@ try_again: ui__error("Too many events are opened.\n" "Try again after reducing the number of events\n"); goto out_err; + } else if ((err == EOPNOTSUPP) && (attr->precise_ip)) { + ui__error("\'precise\' request may not be supported. " + "Try removing 'p' modifier\n"); + goto out_err; } ui__error("The sys_perf_event_open() syscall " -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 06/12] perf test: Align the 'Ok'/'FAILED!' test results 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (4 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 05/12] perf tools: Give user better message if precise is not supported Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 07/12] perf trace: Support interrupted syscalls Arnaldo Carvalho de Melo ` (6 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian From: Arnaldo Carvalho de Melo <acme@redhat.com> And also print 'FAILED!' in red. Suggested-by: Ingo Molnar <mingo@kernel.org> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-rkisq85w24il3e2yl3nzumhu@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-test.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c index e2d9872d..a04276e 100644 --- a/tools/perf/builtin-test.c +++ b/tools/perf/builtin-test.c @@ -6,6 +6,7 @@ #include "builtin.h" #include "util/cache.h" +#include "util/color.h" #include "util/debug.h" #include "util/debugfs.h" #include "util/evlist.h" @@ -1485,18 +1486,31 @@ static bool perf_test__matches(int curr, int argc, const char *argv[]) static int __cmd_test(int argc, const char *argv[]) { int i = 0; + int width = 0; while (tests[i].func) { + int len = strlen(tests[i].desc); + + if (width < len) + width = len; + ++i; + } + + i = 0; + while (tests[i].func) { int curr = i++, err; if (!perf_test__matches(curr, argc, argv)) continue; - pr_info("%2d: %s:", i, tests[curr].desc); + pr_info("%2d: %-*s:", i, width, tests[curr].desc); pr_debug("\n--- start ---\n"); err = tests[curr].func(); pr_debug("---- end ----\n%s:", tests[curr].desc); - pr_info(" %s\n", err ? "FAILED!\n" : "Ok"); + if (err) + color_fprintf(stderr, PERF_COLOR_RED, " FAILED!\n"); + else + pr_info(" Ok\n"); } return 0; -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 07/12] perf trace: Support interrupted syscalls 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (5 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 06/12] perf test: Align the 'Ok'/'FAILED!' test results Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 08/12] perf trace: Add an event duration column Arnaldo Carvalho de Melo ` (5 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian From: Arnaldo Carvalho de Melo <acme@redhat.com> Using the same strategies as in the tmp.perf/trace2, i.e. the 'trace' tool implemented by tglx, just updated to the current codebase. Example: [root@sandy linux]# perf trace usleep 1 | tail 2.003: mmap(addr: 0, len: 4096, prot: 3, flags: 34, fd: 4294967295, off: 0 ) = -2128396288 2.017: mmap(addr: 0, len: 4096, prot: 3, flags: 34, fd: 4294967295, off: 0 ) = -2128400384 2.029: arch_prctl(option: 4098, arg2: 140146949441280, arg3: 140146949435392, arg4: 34, arg5: 4294967295) = 0 2.084: mprotect(start: 208741634048, len: 16384, prot: 1 ) = 0 2.098: mprotect(start: 208735956992, len: 4096, prot: 1 ) = 0 2.122: munmap(addr: 140146949447680, len: 91882 ) = 0 2.359: brk(brk: 0 ) = 28987392 2.371: brk(brk: 29122560 ) = 29122560 2.490: nanosleep(rqtp: 140735694241504, rmtp: 0 ) = 0 2.507: exit_group(error_code: 0 [root@sandy linux]# For now the timestamp and duration are always on, will be selectable. Also if multiple threads are being monitored, its tid will appear. The ret output continues to be interpreted a la strace. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-ly9ulroru4my5isn0xe9gr0m@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-trace.c | 199 +++++++++++++++++++++++++++++++++++++++----- tools/perf/util/util.h | 4 + 2 files changed, 181 insertions(+), 22 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 14b3229..873f50b 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -1,5 +1,8 @@ #include "builtin.h" +#include "util/color.h" #include "util/evlist.h" +#include "util/machine.h" +#include "util/thread.h" #include "util/parse-options.h" #include "util/thread_map.h" #include "event-parse.h" @@ -43,6 +46,36 @@ struct syscall { struct syscall_fmt *fmt; }; +struct thread_trace { + u64 entry_time; + u64 exit_time; + bool entry_pending; + char *entry_str; +}; + +static struct thread_trace *thread_trace__new(void) +{ + return zalloc(sizeof(struct thread_trace)); +} + +static struct thread_trace *thread__trace(struct thread *thread) +{ + if (thread == NULL) + goto fail; + + if (thread->priv == NULL) + thread->priv = thread_trace__new(); + + if (thread->priv == NULL) + goto fail; + + return thread->priv; +fail: + color_fprintf(stdout, PERF_COLOR_RED, + "WARNING: not enough memory, dropping samples!\n"); + return NULL; +} + struct trace { int audit_machine; struct { @@ -50,8 +83,18 @@ struct trace { struct syscall *table; } syscalls; struct perf_record_opts opts; + struct machine host; + u64 base_time; + bool multiple_threads; }; +static size_t trace__fprintf_tstamp(struct trace *trace, u64 tstamp, FILE *fp) +{ + double ts = (double)(tstamp - trace->base_time) / NSEC_PER_MSEC; + + return fprintf(fp, "%10.3f: ", ts); +} + static bool done = false; static void sig_handler(int sig __maybe_unused) @@ -59,6 +102,67 @@ static void sig_handler(int sig __maybe_unused) done = true; } +static size_t trace__fprintf_entry_head(struct trace *trace, struct thread *thread, + u64 tstamp, FILE *fp) +{ + size_t printed = trace__fprintf_tstamp(trace, tstamp, fp); + + if (trace->multiple_threads) + printed += fprintf(fp, "%d ", thread->pid); + + return printed; +} + +static int trace__process_event(struct machine *machine, union perf_event *event) +{ + int ret = 0; + + switch (event->header.type) { + case PERF_RECORD_LOST: + color_fprintf(stdout, PERF_COLOR_RED, + "LOST %" PRIu64 " events!\n", event->lost.lost); + ret = machine__process_lost_event(machine, event); + default: + ret = machine__process_event(machine, event); + break; + } + + return ret; +} + +static int trace__tool_process(struct perf_tool *tool __maybe_unused, + union perf_event *event, + struct perf_sample *sample __maybe_unused, + struct machine *machine) +{ + return trace__process_event(machine, event); +} + +static int trace__symbols_init(struct trace *trace, struct perf_evlist *evlist) +{ + int err = symbol__init(); + + if (err) + return err; + + machine__init(&trace->host, "", HOST_KERNEL_ID); + machine__create_kernel_maps(&trace->host); + + if (perf_target__has_task(&trace->opts.target)) { + err = perf_event__synthesize_thread_map(NULL, evlist->threads, + trace__tool_process, + &trace->host); + } else { + err = perf_event__synthesize_threads(NULL, trace__tool_process, + &trace->host); + } + + if (err) + symbol__exit(); + + return err; +} + static int trace__read_syscall_info(struct trace *trace, int id) { char tp_name[128]; @@ -100,7 +204,8 @@ static int trace__read_syscall_info(struct trace *trace, int id) return sc->tp_format != NULL ? 0 : -1; } -static size_t syscall__fprintf_args(struct syscall *sc, unsigned long *args, FILE *fp) +static size_t syscall__scnprintf_args(struct syscall *sc, char *bf, size_t size, + unsigned long *args) { int i = 0; size_t printed = 0; @@ -109,12 +214,15 @@ static size_t syscall__fprintf_args(struct syscall *sc, unsigned long *args, FIL struct format_field *field; for (field = sc->tp_format->format.fields->next; field; field = field->next) { - printed += fprintf(fp, "%s%s: %ld", printed ? ", " : "", - field->name, args[i++]); + printed += scnprintf(bf + printed, size - printed, + "%s%s: %ld", printed ? ", " : "", + field->name, args[i++]); } } else { while (i < 6) { - printed += fprintf(fp, "%sarg%d: %ld", printed ? ", " : "", i, args[i]); + printed += scnprintf(bf + printed, size - printed, + "%sarg%d: %ld", + printed ? ", " : "", i, args[i]); ++i; } } @@ -153,10 +261,14 @@ out_cant_read: static int trace__sys_enter(struct trace *trace, struct perf_evsel *evsel, struct perf_sample *sample) { + char *msg; void *args; + size_t printed = 0; + struct thread *thread = machine__findnew_thread(&trace->host, sample->tid); struct syscall *sc = trace__syscall_info(trace, evsel, sample); + struct thread_trace *ttrace = thread__trace(thread); - if (sc == NULL) + if (ttrace == NULL || sc == NULL) return -1; args = perf_evsel__rawptr(evsel, sample, "args"); @@ -165,8 +277,25 @@ static int trace__sys_enter(struct trace *trace, struct perf_evsel *evsel, return -1; } - printf("%s(", sc->name); - syscall__fprintf_args(sc, args, stdout); + ttrace = thread->priv; + + if (ttrace->entry_str == NULL) { + ttrace->entry_str = malloc(1024); + if (!ttrace->entry_str) + return -1; + } + + ttrace->entry_time = sample->time; + msg = ttrace->entry_str; + printed += scnprintf(msg + printed, 1024 - printed, "%s(", sc->name); + + printed += syscall__scnprintf_args(sc, msg + printed, 1024 - printed, args); + + if (!strcmp(sc->name, "exit_group") || !strcmp(sc->name, "exit")) { + trace__fprintf_entry_head(trace, thread, sample->time, stdout); + printf("%-70s\n", ttrace->entry_str); + } else + ttrace->entry_pending = true; return 0; } @@ -175,13 +304,29 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel, struct perf_sample *sample) { int ret; + struct thread *thread = machine__findnew_thread(&trace->host, sample->tid); + struct thread_trace *ttrace = thread__trace(thread); struct syscall *sc = trace__syscall_info(trace, evsel, sample); - if (sc == NULL) + if (ttrace == NULL || sc == NULL) return -1; ret = perf_evsel__intval(evsel, sample, "ret"); + ttrace = thread->priv; + + ttrace->exit_time = sample->time; + + trace__fprintf_entry_head(trace, thread, sample->time, stdout); + + if (ttrace->entry_pending) { + printf("%-70s", ttrace->entry_str); + } else { + printf(" ... ["); + color_fprintf(stdout, PERF_COLOR_YELLOW, "continued"); + printf("]: %s()", sc->name); + } + if (ret < 0 && sc->fmt && sc->fmt->errmsg) { char bf[256]; const char *emsg = strerror_r(-ret, bf, sizeof(bf)), @@ -194,6 +339,9 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel, printf(") = %d", ret); putchar('\n'); + + ttrace->entry_pending = false; + return 0; } @@ -221,6 +369,12 @@ static int trace__run(struct trace *trace, int argc, const char **argv) goto out_delete_evlist; } + err = trace__symbols_init(trace, evlist); + if (err < 0) { + printf("Problems initializing symbol libraries!\n"); + goto out_delete_evlist; + } + perf_evlist__config_attrs(evlist, &trace->opts); signal(SIGCHLD, sig_handler); @@ -251,6 +405,7 @@ static int trace__run(struct trace *trace, int argc, const char **argv) if (forks) perf_evlist__start_workload(evlist); + trace->multiple_threads = evlist->threads->map[0] == -1 || evlist->threads->nr > 1; again: before = nr_events; @@ -264,32 +419,32 @@ again: ++nr_events; - switch (type) { - case PERF_RECORD_SAMPLE: - break; - case PERF_RECORD_LOST: - printf("LOST %" PRIu64 " events!\n", event->lost.lost); - continue; - default: - printf("Unexpected %s event, skipping...\n", - perf_event__name(type)); - continue; - } - err = perf_evlist__parse_sample(evlist, event, &sample); if (err) { printf("Can't parse sample, err = %d, skipping...\n", err); continue; } + if (trace->base_time == 0) + trace->base_time = sample.time; + + if (type != PERF_RECORD_SAMPLE) { + trace__process_event(&trace->host, event); + continue; + } + evsel = perf_evlist__id2evsel(evlist, sample.id); if (evsel == NULL) { printf("Unknown tp ID %" PRIu64 ", skipping...\n", sample.id); continue; } - if (evlist->threads->map[0] == -1 || evlist->threads->nr > 1) - printf("%d ", sample.tid); + if (sample.raw_data == NULL) { + printf("%s sample with no payload for tid: %d, cpu %d, raw_size=%d, skipping...\n", + perf_evsel__name(evsel), sample.tid, + sample.cpu, sample.raw_size); + continue; + } if (sample.raw_data == NULL) { printf("%s sample with no payload for tid: %d, cpu %d, raw_size=%d, skipping...\n", diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h index a6b83f8..0d85209 100644 --- a/tools/perf/util/util.h +++ b/tools/perf/util/util.h @@ -198,6 +198,10 @@ static inline int has_extension(const char *filename, const char *ext) #undef tolower #undef toupper +#ifndef NSEC_PER_MSEC +#define NSEC_PER_MSEC 1000000L +#endif + extern unsigned char sane_ctype[256]; #define GIT_SPACE 0x01 #define GIT_DIGIT 0x02 -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 08/12] perf trace: Add an event duration column 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (6 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 07/12] perf trace: Support interrupted syscalls Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 09/12] perf trace: Add duration filter Arnaldo Carvalho de Melo ` (4 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Gleixner From: Arnaldo Carvalho de Melo <acme@redhat.com> # perf trace usleep 1 | tail -10 0.453 ( 0.002 ms): mmap(addr: 0, len: 4096, prot: 3, flags: 34, fd: 4294967295, off: 0 ) = -763342848 0.456 ( 0.001 ms): mmap(addr: 0, len: 4096, prot: 3, flags: 34, fd: 4294967295, off: 0 ) = -763346944 0.459 ( 0.001 ms): arch_prctl(option: 4098, arg2: 140126839658240, arg3: 140126839652352, arg4: 34, arg5: 4294967295) = 0 0.473 ( 0.003 ms): mprotect(start: 208741634048, len: 16384, prot: 1 ) = 0 0.477 ( 0.003 ms): mprotect(start: 208735956992, len: 4096, prot: 1 ) = 0 0.483 ( 0.004 ms): munmap(addr: 140126839664640, len: 91882 ) = 0 0.540 ( 0.001 ms): brk(brk: 0 ) = 31928320 0.542 ( 0.002 ms): brk(brk: 32063488 ) = 32063488 1.456 ( 0.901 ms): nanosleep(rqtp: 140735472817168, rmtp: 0 ) = 0 1.462 ( 0.000 ms): exit_group(error_code: 0 # This also comes from the tmp.perf/trace2 branch. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/n/tip-g9akh5hjw2kvjerpo9xror6f@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-trace.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 873f50b..ddb6e37 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -46,6 +46,20 @@ struct syscall { struct syscall_fmt *fmt; }; +static size_t fprintf_duration(unsigned long t, FILE *fp) +{ + double duration = (double)t / NSEC_PER_MSEC; + size_t printed = fprintf(fp, "("); + + if (duration >= 1.0) + printed += color_fprintf(fp, PERF_COLOR_RED, "%6.3f ms", duration); + else if (duration >= 0.01) + printed += color_fprintf(fp, PERF_COLOR_YELLOW, "%6.3f ms", duration); + else + printed += color_fprintf(fp, PERF_COLOR_NORMAL, "%6.3f ms", duration); + return printed + fprintf(stdout, "): "); +} + struct thread_trace { u64 entry_time; u64 exit_time; @@ -92,7 +106,7 @@ static size_t trace__fprintf_tstamp(struct trace *trace, u64 tstamp, FILE *fp) { double ts = (double)(tstamp - trace->base_time) / NSEC_PER_MSEC; - return fprintf(fp, "%10.3f: ", ts); + return fprintf(fp, "%10.3f ", ts); } static bool done = false; @@ -103,9 +117,10 @@ static void sig_handler(int sig __maybe_unused) } static size_t trace__fprintf_entry_head(struct trace *trace, struct thread *thread, - u64 tstamp, FILE *fp) + u64 duration, u64 tstamp, FILE *fp) { size_t printed = trace__fprintf_tstamp(trace, tstamp, fp); + printed += fprintf_duration(duration, fp); if (trace->multiple_threads) printed += fprintf(fp, "%d ", thread->pid); @@ -292,7 +307,7 @@ static int trace__sys_enter(struct trace *trace, struct perf_evsel *evsel, printed += syscall__scnprintf_args(sc, msg + printed, 1024 - printed, args); if (!strcmp(sc->name, "exit_group") || !strcmp(sc->name, "exit")) { - trace__fprintf_entry_head(trace, thread, sample->time, stdout); + trace__fprintf_entry_head(trace, thread, 1, sample->time, stdout); printf("%-70s\n", ttrace->entry_str); } else ttrace->entry_pending = true; @@ -304,6 +319,7 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel, struct perf_sample *sample) { int ret; + u64 duration = 0; struct thread *thread = machine__findnew_thread(&trace->host, sample->tid); struct thread_trace *ttrace = thread__trace(thread); struct syscall *sc = trace__syscall_info(trace, evsel, sample); @@ -317,7 +333,10 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel, ttrace->exit_time = sample->time; - trace__fprintf_entry_head(trace, thread, sample->time, stdout); + if (ttrace->entry_time) + duration = sample->time - ttrace->entry_time; + + trace__fprintf_entry_head(trace, thread, duration, sample->time, stdout); if (ttrace->entry_pending) { printf("%-70s", ttrace->entry_str); -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 09/12] perf trace: Add duration filter 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (7 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 08/12] perf trace: Add an event duration column Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 10/12] perf tools: Pretty print errno for some more functions Arnaldo Carvalho de Melo ` (3 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Gleixner From: Arnaldo Carvalho de Melo <acme@redhat.com> Example: [acme@sandy linux]$ perf trace --duration 0.025 usleep 1 2.221 ( 0.958 ms): 6724 execve(arg0: 140733557168278, arg1: 140733557178768, arg2: 16134304, arg3: 140733557167840, arg4: 7955998171588342573, arg5: 6723) = -2 3.690 ( 1.443 ms): 6724 execve(arg0: 140733557168295, arg1: 140733557178768, arg2: 16134304, arg3: 140733557167840, arg4: 7955998171588342573, arg5: 6723) = 0 3.979 ( 0.048 ms): 6724 open(filename: 208733843841, flags: 0, mode: 1 ) = 3 4.071 ( 0.075 ms): 6724 open(filename: 139744419925673, flags: 0, mode: 0 ) = 3 4.318 ( 0.056 ms): 6724 nanosleep(rqtp: 140734030404608, rmtp: 0 ) = 0 [acme@sandy linux]$ perf trace --duration 0.100 usleep 1 1.143 ( 1.021 ms): 6726 execve(arg0: 140736323962279, arg1: 140736323972752, arg2: 34926752, arg3: 140736323961824, arg4: 7955998171588342573, arg5: 6725) = 0 [acme@sandy linux]$ Cherry picked from tmp.perf/trace2 branch. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/n/tip-oslw2j2958we9qf0ctra4whd@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Documentation/perf-trace.txt | 3 +++ tools/perf/builtin-trace.c | 32 +++++++++++++++++++++++++++---- 2 files changed, 31 insertions(+), 4 deletions(-) diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt index 3a2ae37..38d4b68 100644 --- a/tools/perf/Documentation/perf-trace.txt +++ b/tools/perf/Documentation/perf-trace.txt @@ -48,6 +48,9 @@ comma-separated list with no space: 0,1. Ranges of CPUs are specified with -: 0- In per-thread mode with inheritance mode on (default), Events are captured only when the thread executes on the designated CPUs. Default is to monitor all CPUs. +--duration: + Show only events that had a duration greater than N.M ms. + SEE ALSO -------- linkperf:perf-record[1], linkperf:perf-script[1] diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index ddb6e37..82ffa6c 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -100,8 +100,14 @@ struct trace { struct machine host; u64 base_time; bool multiple_threads; + double duration_filter; }; +static bool trace__filter_duration(struct trace *trace, double t) +{ + return t < (trace->duration_filter * NSEC_PER_MSEC); +} + static size_t trace__fprintf_tstamp(struct trace *trace, u64 tstamp, FILE *fp) { double ts = (double)(tstamp - trace->base_time) / NSEC_PER_MSEC; @@ -307,8 +313,10 @@ static int trace__sys_enter(struct trace *trace, struct perf_evsel *evsel, printed += syscall__scnprintf_args(sc, msg + printed, 1024 - printed, args); if (!strcmp(sc->name, "exit_group") || !strcmp(sc->name, "exit")) { - trace__fprintf_entry_head(trace, thread, 1, sample->time, stdout); - printf("%-70s\n", ttrace->entry_str); + if (!trace->duration_filter) { + trace__fprintf_entry_head(trace, thread, 1, sample->time, stdout); + printf("%-70s\n", ttrace->entry_str); + } } else ttrace->entry_pending = true; @@ -333,8 +341,12 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel, ttrace->exit_time = sample->time; - if (ttrace->entry_time) + if (ttrace->entry_time) { duration = sample->time - ttrace->entry_time; + if (trace__filter_duration(trace, duration)) + goto out; + } else if (trace->duration_filter) + goto out; trace__fprintf_entry_head(trace, thread, duration, sample->time, stdout); @@ -358,7 +370,7 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel, printf(") = %d", ret); putchar('\n'); - +out: ttrace->entry_pending = false; return 0; @@ -495,6 +507,15 @@ out: return err; } +static int trace__set_duration(const struct option *opt, const char *str, + int unset __maybe_unused) +{ + struct trace *trace = opt->value; + + trace->duration_filter = atof(str); + return 0; +} + int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused) { const char * const trace_usage[] = { @@ -533,6 +554,9 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused) "number of mmap data pages"), OPT_STRING(0, "uid", &trace.opts.target.uid_str, "user", "user to profile"), + OPT_CALLBACK(0, "duration", &trace, "float", + "show only events with duration > N.M ms", + trace__set_duration), OPT_END() }; int err; -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 10/12] perf tools: Pretty print errno for some more functions 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (8 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 09/12] perf trace: Add duration filter Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 11/12] perf trace: Print the name of a syscall when failing to read its info Arnaldo Carvalho de Melo ` (2 subsequent siblings) 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian From: Arnaldo Carvalho de Melo <acme@redhat.com> This time: access, open and socket. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-e19dmpz8zxqo2uebxnp7ilkf@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-trace.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 82ffa6c..fb83cfe 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -16,15 +16,18 @@ static struct syscall_fmt { bool errmsg; bool timeout; } syscall_fmts[] = { + { .name = "access", .errmsg = true, }, { .name = "arch_prctl", .errmsg = true, .alias = "prctl", }, { .name = "fstat", .errmsg = true, .alias = "newfstat", }, { .name = "fstatat", .errmsg = true, .alias = "newfstatat", }, { .name = "futex", .errmsg = true, }, + { .name = "open", .errmsg = true, }, { .name = "poll", .errmsg = true, .timeout = true, }, { .name = "ppoll", .errmsg = true, .timeout = true, }, { .name = "read", .errmsg = true, }, { .name = "recvfrom", .errmsg = true, }, { .name = "select", .errmsg = true, .timeout = true, }, + { .name = "socket", .errmsg = true, }, { .name = "stat", .errmsg = true, .alias = "newstat", }, }; -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 11/12] perf trace: Print the name of a syscall when failing to read its info 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (9 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 10/12] perf tools: Pretty print errno for some more functions Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 12/12] perf tools: Try to build Documentation when installing Arnaldo Carvalho de Melo 2012-10-25 7:43 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar 12 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Steven Rostedt, Thomas Gleixner From: Arnaldo Carvalho de Melo <acme@redhat.com> When failing to read the tracepoint event format, like currently with sys_execve, that is not defined via SYSCALL_DEFINE macros and thus doesn't have an entry in: $ ls -d /sys/kernel/debug/tracing/events/syscalls/sys_enter_*exec* /sys/kernel/debug/tracing/events/syscalls/sys_enter_kexec_load $ Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> echo Link: http://lkml.kernel.org/n/tip-`ranpwd -l 24`@git.kernel.org Link: http://lkml.kernel.org/n/tip-q3ak0j8b81yxylykq5wp2uwi@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-trace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index fb83cfe..ba05510 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -278,7 +278,10 @@ static struct syscall *trace__syscall_info(struct trace *trace, return &trace->syscalls.table[id]; out_cant_read: - printf("Problems reading syscall %d information\n", id); + printf("Problems reading syscall %d", id); + if (id <= trace->syscalls.max && trace->syscalls.table[id].name != NULL) + printf("(%s)", trace->syscalls.table[id].name); + puts(" information"); return NULL; } -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* [PATCH 12/12] perf tools: Try to build Documentation when installing 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (10 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 11/12] perf trace: Print the name of a syscall when failing to read its info Arnaldo Carvalho de Melo @ 2012-10-24 21:50 ` Arnaldo Carvalho de Melo 2012-10-25 2:09 ` Namhyung Kim 2012-10-25 7:43 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar 12 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Borislav Petkov, Namhyung Kim, Arnaldo Carvalho de Melo From: Borislav Petkov <borislav.petkov@amd.com> There's a portion in the "perf list" output refering to the exact specification of raw hardware events. Since this description is in the perf-list manpage, try to build and install the man pages, warning the user when that is not possible due to missing packages (xmlto and asciidoc). Signed-off-by: Borislav Petkov <borislav.petkov@amd.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lkml.kernel.org/n/tip-ij71ysszkdvz3fy3wr331bke@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Documentation/Makefile | 31 +++++++++++++++++++++++++++++-- tools/perf/Makefile | 5 ++++- tools/perf/util/parse-events.c | 2 +- 3 files changed, 34 insertions(+), 4 deletions(-) diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile index 9f2e44f..ef6d22e 100644 --- a/tools/perf/Documentation/Makefile +++ b/tools/perf/Documentation/Makefile @@ -1,3 +1,5 @@ +include ../config/utilities.mak + OUTPUT := ./ ifeq ("$(origin O)", "command line") ifneq ($(O),) @@ -64,6 +66,7 @@ MAKEINFO=makeinfo INSTALL_INFO=install-info DOCBOOK2X_TEXI=docbook2x-texi DBLATEX=dblatex +XMLTO=xmlto ifndef PERL_PATH PERL_PATH = /usr/bin/perl endif @@ -71,6 +74,16 @@ endif -include ../config.mak.autogen -include ../config.mak +_tmp_tool_path := $(call get-executable,$(ASCIIDOC)) +ifeq ($(_tmp_tool_path),) + missing_tools = $(ASCIIDOC) +endif + +_tmp_tool_path := $(call get-executable,$(XMLTO)) +ifeq ($(_tmp_tool_path),) + missing_tools += $(XMLTO) +endif + # # For asciidoc ... # -7.1.2, no extra settings are needed. @@ -170,7 +183,12 @@ pdf: $(OUTPUT)user-manual.pdf install: install-man -install-man: man +check-man-tools: +ifdef missing_tools + $(error "You need to install $(missing_tools) for man pages") +endif + +do-install-man: man $(INSTALL) -d -m 755 $(DESTDIR)$(man1dir) # $(INSTALL) -d -m 755 $(DESTDIR)$(man5dir) # $(INSTALL) -d -m 755 $(DESTDIR)$(man7dir) @@ -178,6 +196,15 @@ install-man: man # $(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir) # $(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir) +install-man: check-man-tools man + +try-install-man: +ifdef missing_tools + $(warning Please install $(missing_tools) to have the man pages installed) +else + $(MAKE) do-install-man +endif + install-info: info $(INSTALL) -d -m 755 $(DESTDIR)$(infodir) $(INSTALL) -m 644 $(OUTPUT)perf.info $(OUTPUT)perfman.info $(DESTDIR)$(infodir) @@ -246,7 +273,7 @@ $(MAN_HTML): $(OUTPUT)%.html : %.txt $(OUTPUT)%.1 $(OUTPUT)%.5 $(OUTPUT)%.7 : $(OUTPUT)%.xml $(QUIET_XMLTO)$(RM) $@ && \ - xmlto -o $(OUTPUT) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $< + $(XMLTO) -o $(OUTPUT) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $< $(OUTPUT)%.xml : %.txt $(QUIET_ASCIIDOC)$(RM) $@+ $@ && \ diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 78a81ed..b14eeb8 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -1041,7 +1041,7 @@ perfexec_instdir = $(prefix)/$(perfexecdir) endif perfexec_instdir_SQ = $(subst ','\'',$(perfexec_instdir)) -install: all +install: all try-install-man $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)' $(INSTALL) $(OUTPUT)perf '$(DESTDIR_SQ)$(bindir_SQ)' $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/perl/Perf-Trace-Util/lib/Perf/Trace' @@ -1067,6 +1067,9 @@ install-doc: install-man: $(MAKE) -C Documentation install-man +try-install-man: + $(MAKE) -C Documentation try-install-man + install-html: $(MAKE) -C Documentation install-html diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 2fe1587..3a3efcf 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -1081,7 +1081,7 @@ void print_events(const char *event_glob, bool name_only) printf(" %-50s [%s]\n", "cpu/t1=v1[,t2=v2,t3 ...]/modifier", event_type_descriptors[PERF_TYPE_RAW]); - printf(" (see 'perf list --help' on how to encode it)\n"); + printf(" (see 'man perf-list' on how to encode it)\n"); printf("\n"); printf(" %-50s [%s]\n", -- 1.7.9.2.358.g22243 ^ permalink raw reply related [flat|nested] 41+ messages in thread
* Re: [PATCH 12/12] perf tools: Try to build Documentation when installing 2012-10-24 21:50 ` [PATCH 12/12] perf tools: Try to build Documentation when installing Arnaldo Carvalho de Melo @ 2012-10-25 2:09 ` Namhyung Kim 0 siblings, 0 replies; 41+ messages in thread From: Namhyung Kim @ 2012-10-25 2:09 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Ingo Molnar, linux-kernel, Borislav Petkov, Arnaldo Carvalho de Melo On Thu, Oct 25, 2012 at 6:50 AM, Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > From: Borislav Petkov <borislav.petkov@amd.com> > > There's a portion in the "perf list" output refering to the exact > specification of raw hardware events. > > Since this description is in the perf-list manpage, try to build and > install the man pages, warning the user when that is not possible > due to missing packages (xmlto and asciidoc). > > Signed-off-by: Borislav Petkov <borislav.petkov@amd.com> > Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Link: http://lkml.kernel.org/n/tip-ij71ysszkdvz3fy3wr331bke@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Thanks, Namhyung ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo ` (11 preceding siblings ...) 2012-10-24 21:50 ` [PATCH 12/12] perf tools: Try to build Documentation when installing Arnaldo Carvalho de Melo @ 2012-10-25 7:43 ` Ingo Molnar 12 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2012-10-25 7:43 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Borislav Petkov, Corey Ashford, David Ahern, Frederic Weisbecker, Irina Tirdea, Jiri Olsa, Mike Galbraith, Namhyung Kim, Namhyung Kim, Paul Mackerras, Pekka Enberg, Peter Zijlstra, Robert Richter, Stephane Eranian, Steven Rostedt, Suzuki K. Poulose, Thomas Gleixner, arnaldo.melo, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > Hi Ingo, > > Please consider pulling. > > I'll continue processing patchsets by Jiri, Namhyung, David, Irina and > others tomorrow. > > I also have to rework the pagefaults patches, as the code it touches > changed lately, will add that NUMA node info you suggested. > > - Arnaldo > > The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163: > > x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo > > for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b: > > perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200) > > ---------------------------------------------------------------- > perf/core improvements and fixes > > . Align the 'Ok'/'FAILED!' test results in 'perf test. > > . Support interrupted syscalls in 'trace' > > . Add an event duration column and filter in 'trace'. > > . There are references to the man pages in some tools, so try to build > Documentation when installing, warning the user if that is not possible, > from Borislav Petkov. > > . Give user better message if precise is not supported, from David Ahern. > > . Try to find cross-built objdump path by using the session environment > information in the perf.data file header, from Irina Tirdea, original > patch and idea by Namhyung Kim. > > . Diplays more output on features check for make V=1, so that one can figure > out what is happening by looking at gcc output, etc. From Jiri Olsa. > > . Account the nr_entries in rblist properly, fix by Suzuki K. Poulose. > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (7): > perf tools: Remove noise in python version feature test > perf test: Align the 'Ok'/'FAILED!' test results > perf trace: Support interrupted syscalls > perf trace: Add an event duration column > perf trace: Add duration filter > perf tools: Pretty print errno for some more functions > perf trace: Print the name of a syscall when failing to read its info > > Borislav Petkov (1): > perf tools: Try to build Documentation when installing > > David Ahern (1): > perf tools: Give user better message if precise is not supported > > Irina Tirdea (1): > perf tools: Try to find cross-built objdump path > > Jiri Olsa (1): > perf tools: Diplays more output on features check for make V=1 > > Suzuki K. Poulose (1): > Account the nr_entries in rblist properly > > tools/perf/Documentation/Makefile | 31 +++- > tools/perf/Documentation/perf-trace.txt | 3 + > tools/perf/Makefile | 53 ++++--- > tools/perf/arch/common.c | 178 ++++++++++++++++++++++ > tools/perf/arch/common.h | 10 ++ > tools/perf/builtin-annotate.c | 7 + > tools/perf/builtin-record.c | 5 + > tools/perf/builtin-report.c | 7 + > tools/perf/builtin-test.c | 18 ++- > tools/perf/builtin-top.c | 4 + > tools/perf/builtin-trace.c | 250 ++++++++++++++++++++++++++++--- > tools/perf/config/feature-tests.mak | 5 +- > tools/perf/config/utilities.mak | 11 +- > tools/perf/util/annotate.h | 1 - > tools/perf/util/parse-events.c | 2 +- > tools/perf/util/rblist.c | 4 +- > tools/perf/util/util.h | 4 + > 17 files changed, 535 insertions(+), 58 deletions(-) > create mode 100644 tools/perf/arch/common.c > create mode 100644 tools/perf/arch/common.h Pulled, thanks a lot Arnado! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2013-12-02 20:48 Arnaldo Carvalho de Melo 2013-12-04 9:18 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2013-12-02 20:48 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Corey Ashford, David Ahern, Dongsheng Yang, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Hurley, Peter Zijlstra, Stanislav Fomichev, Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256: perf trace: Honour -m option (2013-12-02 16:29:40 -0300) ---------------------------------------------------------------- perf/tools improvements and fixes: . Honour -m option in 'trace', the tool was offering the option to set the mmap size, but wasn't using it when doing the actual mmap on the events file descriptors, fix from Jiri Olsa. . Correct the message in feature-libnuma checking, swowing the right devel package names for various distros, from Dongsheng Yang. . Polish 'readn' function and introduce its counterpart, 'writen', from Jiri Olsa. . Start moving timechart state from global variables to a 'perf_tool' derived 'timechart' struct. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Arnaldo Carvalho de Melo (4): perf timechart: Introduce tool struct perf timechart: Move all_data per_pid list to 'struct timechart' perf timechart: Move power_events list to 'struct timechart' perf timechart: Move wake_events list to 'struct timechart' Dongsheng Yang (1): perf tools: Correct the message in feature-libnuma checking. Jiri Olsa (7): perf record: Unify data output code into perf_record__write function perf tools: Use correct return type for readn function perf tools: Fine tune readn function perf tools: Add writen function perf tools: Add perf_data_file__write interface perf tools: Include test-stackprotector-all.c in test-all perf trace: Honour -m option tools/perf/builtin-record.c | 20 +- tools/perf/builtin-timechart.c | 364 +++++++++++++++------------- tools/perf/builtin-trace.c | 2 +- tools/perf/config/Makefile | 2 +- tools/perf/config/feature-checks/test-all.c | 5 + tools/perf/util/data.c | 6 + tools/perf/util/data.h | 14 +- tools/perf/util/header.c | 18 +- tools/perf/util/session.c | 2 +- tools/perf/util/util.c | 32 ++- tools/perf/util/util.h | 3 +- 11 files changed, 256 insertions(+), 212 deletions(-) ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2013-12-02 20:48 Arnaldo Carvalho de Melo @ 2013-12-04 9:18 ` Ingo Molnar 0 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2013-12-04 9:18 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Corey Ashford, David Ahern, Dongsheng Yang, Frederic Weisbecker, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Hurley, Peter Zijlstra, Stanislav Fomichev, Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8: > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100) > > are available in the git repository at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo > > for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256: > > perf trace: Honour -m option (2013-12-02 16:29:40 -0300) > > ---------------------------------------------------------------- > perf/tools improvements and fixes: > > . Honour -m option in 'trace', the tool was offering the option to > set the mmap size, but wasn't using it when doing the actual mmap > on the events file descriptors, fix from Jiri Olsa. > > . Correct the message in feature-libnuma checking, swowing the right > devel package names for various distros, from Dongsheng Yang. > > . Polish 'readn' function and introduce its counterpart, 'writen', from > Jiri Olsa. > > . Start moving timechart state from global variables to a 'perf_tool' derived > 'timechart' struct. > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (4): > perf timechart: Introduce tool struct > perf timechart: Move all_data per_pid list to 'struct timechart' > perf timechart: Move power_events list to 'struct timechart' > perf timechart: Move wake_events list to 'struct timechart' > > Dongsheng Yang (1): > perf tools: Correct the message in feature-libnuma checking. > > Jiri Olsa (7): > perf record: Unify data output code into perf_record__write function > perf tools: Use correct return type for readn function > perf tools: Fine tune readn function > perf tools: Add writen function > perf tools: Add perf_data_file__write interface > perf tools: Include test-stackprotector-all.c in test-all > perf trace: Honour -m option > > tools/perf/builtin-record.c | 20 +- > tools/perf/builtin-timechart.c | 364 +++++++++++++++------------- > tools/perf/builtin-trace.c | 2 +- > tools/perf/config/Makefile | 2 +- > tools/perf/config/feature-checks/test-all.c | 5 + > tools/perf/util/data.c | 6 + > tools/perf/util/data.h | 14 +- > tools/perf/util/header.c | 18 +- > tools/perf/util/session.c | 2 +- > tools/perf/util/util.c | 32 ++- > tools/perf/util/util.h | 3 +- > 11 files changed, 256 insertions(+), 212 deletions(-) Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2014-02-24 19:56 Arnaldo Carvalho de Melo 2014-02-27 11:46 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2014-02-24 19:56 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584: perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300) ---------------------------------------------------------------- perf/core improvements and fixes . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa) . Fix build race in the generation of bison files (Jiri Olsa) . Further streamline the feature detection display, trimming it a bit to show just the libraries detected, using VF=1 gets a more verbose output, showing the less interesting feature checks as well (Jiri Olsa). . Check compatible symtab type before loading dso (Namhyung Kim) . Check return value of filename__read_debuglink() (Stephane Eranian) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Arnaldo Carvalho de Melo (1): perf tools: Warn the user about how to enable libunwind support Jiri Olsa (9): perf tests: Fix *.o make tests perf tests: Add pmu-bison.o make test perf tools: Fix bison OUTPUT directories dependency perf tools: Factor features display code perf tools: Add variable display for VF make output perf tools: Add feature check for libdw dwarf unwind perf tools: Add libdw DWARF post unwind support perf tools: Setup default dwarf post unwinder perf tests: Add NO_LIBDW_DWARF_UNWIND make test Namhyung Kim (1): perf symbols: Check compatible symtab type before loading dso Stephane Eranian (1): perf symbols: Check return value of filename__read_debuglink() tools/perf/Makefile.perf | 24 ++- tools/perf/arch/x86/Makefile | 5 + tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++ tools/perf/config/Makefile | 232 +++++++++++++++------ tools/perf/config/feature-checks/Makefile | 6 +- tools/perf/config/feature-checks/test-all.c | 5 + .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++ tools/perf/tests/make | 25 ++- tools/perf/util/dso.c | 4 +- tools/perf/util/symbol-elf.c | 2 + tools/perf/util/symbol.c | 61 +++++- tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++ tools/perf/util/unwind-libdw.h | 21 ++ 13 files changed, 569 insertions(+), 90 deletions(-) create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c create mode 100644 tools/perf/util/unwind-libdw.c create mode 100644 tools/perf/util/unwind-libdw.h ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2014-02-24 19:56 Arnaldo Carvalho de Melo @ 2014-02-27 11:46 ` Ingo Molnar 2014-02-27 12:02 ` Jiri Olsa 2014-02-27 12:04 ` Jiri Olsa 0 siblings, 2 replies; 41+ messages in thread From: Ingo Molnar @ 2014-02-27 11:46 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa: > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100) > > are available in the git repository at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo > > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584: > > perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes > > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa) > > . Fix build race in the generation of bison files (Jiri Olsa) > > . Further streamline the feature detection display, trimming it a bit to > show just the libraries detected, using VF=1 gets a more verbose output, > showing the less interesting feature checks as well (Jiri Olsa). > > . Check compatible symtab type before loading dso (Namhyung Kim) > > . Check return value of filename__read_debuglink() (Stephane Eranian) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (1): > perf tools: Warn the user about how to enable libunwind support > > Jiri Olsa (9): > perf tests: Fix *.o make tests > perf tests: Add pmu-bison.o make test > perf tools: Fix bison OUTPUT directories dependency > perf tools: Factor features display code > perf tools: Add variable display for VF make output > perf tools: Add feature check for libdw dwarf unwind > perf tools: Add libdw DWARF post unwind support > perf tools: Setup default dwarf post unwinder > perf tests: Add NO_LIBDW_DWARF_UNWIND make test > > Namhyung Kim (1): > perf symbols: Check compatible symtab type before loading dso > > Stephane Eranian (1): > perf symbols: Check return value of filename__read_debuglink() > > tools/perf/Makefile.perf | 24 ++- > tools/perf/arch/x86/Makefile | 5 + > tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++ > tools/perf/config/Makefile | 232 +++++++++++++++------ > tools/perf/config/feature-checks/Makefile | 6 +- > tools/perf/config/feature-checks/test-all.c | 5 + > .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++ > tools/perf/tests/make | 25 ++- > tools/perf/util/dso.c | 4 +- > tools/perf/util/symbol-elf.c | 2 + > tools/perf/util/symbol.c | 61 +++++- > tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++ > tools/perf/util/unwind-libdw.h | 21 ++ > 13 files changed, 569 insertions(+), 90 deletions(-) > create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c > create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c > create mode 100644 tools/perf/util/unwind-libdw.c > create mode 100644 tools/perf/util/unwind-libdw.h Pulled, thanks a lot Arnaldo! Btw., the build output looks weird now - on a system that used to pass all feature tests there's this output: BUILD: Doing 'make -j12' parallel build config/Makefile:288: No libdw DWARF unwind found, Please install elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR Auto-detecting system features: ... dwarf: [ on ] ... glibc: [ on ] ... gtk2: [ on ] ... libaudit: [ on ] ... libbfd: [ on ] ... libelf: [ on ] ... libnuma: [ on ] ... libperl: [ on ] ... libpython: [ on ] ... libslang: [ on ] ... libunwind: [ on ] ... libdw-dwarf-unwind: [ OFF ] ... DWARF post unwind library: libunwind but: Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version Also, the information content of this line is unclear to me: ... DWARF post unwind library: libunwind what does that line want to tell? Thanks, Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2014-02-27 11:46 ` Ingo Molnar @ 2014-02-27 12:02 ` Jiri Olsa 2014-02-27 12:30 ` Ingo Molnar 2014-02-27 12:04 ` Jiri Olsa 1 sibling, 1 reply; 41+ messages in thread From: Jiri Olsa @ 2014-02-27 12:02 UTC (permalink / raw) To: Ingo Molnar Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > > > > Hi Ingo, > > > > Please consider pulling, > > > > - Arnaldo > > > > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa: > > > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100) > > > > are available in the git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo > > > > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584: > > > > perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300) > > > > ---------------------------------------------------------------- > > perf/core improvements and fixes > > > > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa) > > > > . Fix build race in the generation of bison files (Jiri Olsa) > > > > . Further streamline the feature detection display, trimming it a bit to > > show just the libraries detected, using VF=1 gets a more verbose output, > > showing the less interesting feature checks as well (Jiri Olsa). > > > > . Check compatible symtab type before loading dso (Namhyung Kim) > > > > . Check return value of filename__read_debuglink() (Stephane Eranian) > > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > ---------------------------------------------------------------- > > Arnaldo Carvalho de Melo (1): > > perf tools: Warn the user about how to enable libunwind support > > > > Jiri Olsa (9): > > perf tests: Fix *.o make tests > > perf tests: Add pmu-bison.o make test > > perf tools: Fix bison OUTPUT directories dependency > > perf tools: Factor features display code > > perf tools: Add variable display for VF make output > > perf tools: Add feature check for libdw dwarf unwind > > perf tools: Add libdw DWARF post unwind support > > perf tools: Setup default dwarf post unwinder > > perf tests: Add NO_LIBDW_DWARF_UNWIND make test > > > > Namhyung Kim (1): > > perf symbols: Check compatible symtab type before loading dso > > > > Stephane Eranian (1): > > perf symbols: Check return value of filename__read_debuglink() > > > > tools/perf/Makefile.perf | 24 ++- > > tools/perf/arch/x86/Makefile | 5 + > > tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++ > > tools/perf/config/Makefile | 232 +++++++++++++++------ > > tools/perf/config/feature-checks/Makefile | 6 +- > > tools/perf/config/feature-checks/test-all.c | 5 + > > .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++ > > tools/perf/tests/make | 25 ++- > > tools/perf/util/dso.c | 4 +- > > tools/perf/util/symbol-elf.c | 2 + > > tools/perf/util/symbol.c | 61 +++++- > > tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++ > > tools/perf/util/unwind-libdw.h | 21 ++ > > 13 files changed, 569 insertions(+), 90 deletions(-) > > create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c > > create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c > > create mode 100644 tools/perf/util/unwind-libdw.c > > create mode 100644 tools/perf/util/unwind-libdw.h > > Pulled, thanks a lot Arnaldo! > > Btw., the build output looks weird now - on a system that used to pass > all feature tests there's this output: > > BUILD: Doing 'make -j12' parallel build > config/Makefile:288: No libdw DWARF unwind found, Please install > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > > Auto-detecting system features: > ... dwarf: [ on ] > ... glibc: [ on ] > ... gtk2: [ on ] > ... libaudit: [ on ] > ... libbfd: [ on ] > ... libelf: [ on ] > ... libnuma: [ on ] > ... libperl: [ on ] > ... libpython: [ on ] > ... libslang: [ on ] > ... libunwind: [ on ] > ... libdw-dwarf-unwind: [ OFF ] > ... DWARF post unwind library: libunwind > > but: > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version > > Also, the information content of this line is unclear to me: > > ... DWARF post unwind library: libunwind > > > what does that line want to tell? this tells what DWARF unwind library is compiled in.. 'libunwind' in this case the other choice is 'libdw', which was not detected in your case (and thats what the 1st message tells you) we discussed with Arnaldo, that we would not display warnings for missing features by default.. only tell that there are missing features and display them for verbose (VF=1) output jirka ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2014-02-27 12:02 ` Jiri Olsa @ 2014-02-27 12:30 ` Ingo Molnar 2014-02-27 12:40 ` Jiri Olsa 0 siblings, 1 reply; 41+ messages in thread From: Ingo Molnar @ 2014-02-27 12:30 UTC (permalink / raw) To: Jiri Olsa Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo * Jiri Olsa <jolsa@redhat.com> wrote: > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote: > > > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > > > > > > Hi Ingo, > > > > > > Please consider pulling, > > > > > > - Arnaldo > > > > > > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa: > > > > > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100) > > > > > > are available in the git repository at: > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo > > > > > > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584: > > > > > > perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300) > > > > > > ---------------------------------------------------------------- > > > perf/core improvements and fixes > > > > > > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa) > > > > > > . Fix build race in the generation of bison files (Jiri Olsa) > > > > > > . Further streamline the feature detection display, trimming it a bit to > > > show just the libraries detected, using VF=1 gets a more verbose output, > > > showing the less interesting feature checks as well (Jiri Olsa). > > > > > > . Check compatible symtab type before loading dso (Namhyung Kim) > > > > > > . Check return value of filename__read_debuglink() (Stephane Eranian) > > > > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > > > ---------------------------------------------------------------- > > > Arnaldo Carvalho de Melo (1): > > > perf tools: Warn the user about how to enable libunwind support > > > > > > Jiri Olsa (9): > > > perf tests: Fix *.o make tests > > > perf tests: Add pmu-bison.o make test > > > perf tools: Fix bison OUTPUT directories dependency > > > perf tools: Factor features display code > > > perf tools: Add variable display for VF make output > > > perf tools: Add feature check for libdw dwarf unwind > > > perf tools: Add libdw DWARF post unwind support > > > perf tools: Setup default dwarf post unwinder > > > perf tests: Add NO_LIBDW_DWARF_UNWIND make test > > > > > > Namhyung Kim (1): > > > perf symbols: Check compatible symtab type before loading dso > > > > > > Stephane Eranian (1): > > > perf symbols: Check return value of filename__read_debuglink() > > > > > > tools/perf/Makefile.perf | 24 ++- > > > tools/perf/arch/x86/Makefile | 5 + > > > tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++ > > > tools/perf/config/Makefile | 232 +++++++++++++++------ > > > tools/perf/config/feature-checks/Makefile | 6 +- > > > tools/perf/config/feature-checks/test-all.c | 5 + > > > .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++ > > > tools/perf/tests/make | 25 ++- > > > tools/perf/util/dso.c | 4 +- > > > tools/perf/util/symbol-elf.c | 2 + > > > tools/perf/util/symbol.c | 61 +++++- > > > tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++ > > > tools/perf/util/unwind-libdw.h | 21 ++ > > > 13 files changed, 569 insertions(+), 90 deletions(-) > > > create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c > > > create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c > > > create mode 100644 tools/perf/util/unwind-libdw.c > > > create mode 100644 tools/perf/util/unwind-libdw.h > > > > Pulled, thanks a lot Arnaldo! > > > > Btw., the build output looks weird now - on a system that used to pass > > all feature tests there's this output: > > > > BUILD: Doing 'make -j12' parallel build > > config/Makefile:288: No libdw DWARF unwind found, Please install > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > > > > Auto-detecting system features: > > ... dwarf: [ on ] > > ... glibc: [ on ] > > ... gtk2: [ on ] > > ... libaudit: [ on ] > > ... libbfd: [ on ] > > ... libelf: [ on ] > > ... libnuma: [ on ] > > ... libperl: [ on ] > > ... libpython: [ on ] > > ... libslang: [ on ] > > ... libunwind: [ on ] > > ... libdw-dwarf-unwind: [ OFF ] > > ... DWARF post unwind library: libunwind > > > > but: > > > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version > > > > Also, the information content of this line is unclear to me: > > > > ... DWARF post unwind library: libunwind > > > > > > what does that line want to tell? > > this tells what DWARF unwind library is compiled > in.. 'libunwind' in this case So my (stylistic) complaint is that it's really reading weird in a table generated with the following purpose: Auto-detecting system features: Also, we already know that libunwind is present, because just in the line before it, it says: ... libunwind: [ on ] So it's doubly confusing. How about not displaying that line at all? Is there a strong reason to not keep 'OFF' messages on a single line? > the other choice is 'libdw', which was not detected in your case > (and thats what the 1st message tells you) > > we discussed with Arnaldo, that we would not display warnings for > missing features by default.. only tell that there are missing > features and display them for verbose (VF=1) output That's probably a good plan. I'd suggest the following 'short log' for failures: # Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list. I.e. that way people can notice if the count goes up or down after an update. Also, that too should be a single line, so that it does not spam people. Thanks, Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2014-02-27 12:30 ` Ingo Molnar @ 2014-02-27 12:40 ` Jiri Olsa 2014-02-27 12:45 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Jiri Olsa @ 2014-02-27 12:40 UTC (permalink / raw) To: Ingo Molnar Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote: > > * Jiri Olsa <jolsa@redhat.com> wrote: > > > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote: > > > > > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > > > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > > > > SNIP > > > Pulled, thanks a lot Arnaldo! > > > > > > Btw., the build output looks weird now - on a system that used to pass > > > all feature tests there's this output: > > > > > > BUILD: Doing 'make -j12' parallel build > > > config/Makefile:288: No libdw DWARF unwind found, Please install > > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > > > > > > Auto-detecting system features: > > > ... dwarf: [ on ] > > > ... glibc: [ on ] > > > ... gtk2: [ on ] > > > ... libaudit: [ on ] > > > ... libbfd: [ on ] > > > ... libelf: [ on ] > > > ... libnuma: [ on ] > > > ... libperl: [ on ] > > > ... libpython: [ on ] > > > ... libslang: [ on ] > > > ... libunwind: [ on ] > > > ... libdw-dwarf-unwind: [ OFF ] > > > ... DWARF post unwind library: libunwind > > > > > > but: > > > > > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version > > > > > > Also, the information content of this line is unclear to me: > > > > > > ... DWARF post unwind library: libunwind > > > > > > > > > what does that line want to tell? > > > > this tells what DWARF unwind library is compiled > > in.. 'libunwind' in this case > > So my (stylistic) complaint is that it's really reading weird in a > table generated with the following purpose: > > Auto-detecting system features: > > Also, we already know that libunwind is present, because just in the > line before it, it says: > > ... libunwind: [ on ] > > So it's doubly confusing. How about not displaying that line at all? > Is there a strong reason to not keep 'OFF' messages on a single line? well, on/OFF lines are only about detecting libs this line: 'DWARF post unwind library: libunwind' is about telling which one goes in.. could be you have both libraries detected and need to choose one or keep default > > > the other choice is 'libdw', which was not detected in your case > > (and thats what the 1st message tells you) > > > > we discussed with Arnaldo, that we would not display warnings for > > missing features by default.. only tell that there are missing > > features and display them for verbose (VF=1) output > > That's probably a good plan. I'd suggest the following 'short log' for > failures: > > # Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list. > > I.e. that way people can notice if the count goes up or down after an > update. Also, that too should be a single line, so that it does not > spam people. ook jirka ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2014-02-27 12:40 ` Jiri Olsa @ 2014-02-27 12:45 ` Ingo Molnar 0 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2014-02-27 12:45 UTC (permalink / raw) To: Jiri Olsa Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo * Jiri Olsa <jolsa@redhat.com> wrote: > On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote: > > > > * Jiri Olsa <jolsa@redhat.com> wrote: > > > > > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote: > > > > > > > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > > > > > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > > > > > > > SNIP > > > > > Pulled, thanks a lot Arnaldo! > > > > > > > > Btw., the build output looks weird now - on a system that used to pass > > > > all feature tests there's this output: > > > > > > > > BUILD: Doing 'make -j12' parallel build > > > > config/Makefile:288: No libdw DWARF unwind found, Please install > > > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > > > > > > > > Auto-detecting system features: > > > > ... dwarf: [ on ] > > > > ... glibc: [ on ] > > > > ... gtk2: [ on ] > > > > ... libaudit: [ on ] > > > > ... libbfd: [ on ] > > > > ... libelf: [ on ] > > > > ... libnuma: [ on ] > > > > ... libperl: [ on ] > > > > ... libpython: [ on ] > > > > ... libslang: [ on ] > > > > ... libunwind: [ on ] > > > > ... libdw-dwarf-unwind: [ OFF ] > > > > ... DWARF post unwind library: libunwind > > > > > > > > but: > > > > > > > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version > > > > > > > > Also, the information content of this line is unclear to me: > > > > > > > > ... DWARF post unwind library: libunwind > > > > > > > > > > > > what does that line want to tell? > > > > > > this tells what DWARF unwind library is compiled > > > in.. 'libunwind' in this case > > > > So my (stylistic) complaint is that it's really reading weird in a > > table generated with the following purpose: > > > > Auto-detecting system features: > > > > Also, we already know that libunwind is present, because just in the > > line before it, it says: > > > > ... libunwind: [ on ] > > > > So it's doubly confusing. How about not displaying that line at all? > > Is there a strong reason to not keep 'OFF' messages on a single line? > > well, on/OFF lines are only about detecting libs > > this line: > 'DWARF post unwind library: libunwind' > > is about telling which one goes in.. could be you have both > libraries detected and need to choose one or keep default Okay - but that is not at all clear from the output. Thanks, Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2014-02-27 11:46 ` Ingo Molnar 2014-02-27 12:02 ` Jiri Olsa @ 2014-02-27 12:04 ` Jiri Olsa 1 sibling, 0 replies; 41+ messages in thread From: Jiri Olsa @ 2014-02-27 12:04 UTC (permalink / raw) To: Ingo Molnar Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > > > > Hi Ingo, > > > > Please consider pulling, > > > > - Arnaldo > > > > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa: > > > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100) > > > > are available in the git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo > > > > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584: > > > > perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300) > > > > ---------------------------------------------------------------- > > perf/core improvements and fixes > > > > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa) > > > > . Fix build race in the generation of bison files (Jiri Olsa) > > > > . Further streamline the feature detection display, trimming it a bit to > > show just the libraries detected, using VF=1 gets a more verbose output, > > showing the less interesting feature checks as well (Jiri Olsa). > > > > . Check compatible symtab type before loading dso (Namhyung Kim) > > > > . Check return value of filename__read_debuglink() (Stephane Eranian) > > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > ---------------------------------------------------------------- > > Arnaldo Carvalho de Melo (1): > > perf tools: Warn the user about how to enable libunwind support > > > > Jiri Olsa (9): > > perf tests: Fix *.o make tests > > perf tests: Add pmu-bison.o make test > > perf tools: Fix bison OUTPUT directories dependency > > perf tools: Factor features display code > > perf tools: Add variable display for VF make output > > perf tools: Add feature check for libdw dwarf unwind > > perf tools: Add libdw DWARF post unwind support > > perf tools: Setup default dwarf post unwinder > > perf tests: Add NO_LIBDW_DWARF_UNWIND make test > > > > Namhyung Kim (1): > > perf symbols: Check compatible symtab type before loading dso > > > > Stephane Eranian (1): > > perf symbols: Check return value of filename__read_debuglink() > > > > tools/perf/Makefile.perf | 24 ++- > > tools/perf/arch/x86/Makefile | 5 + > > tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++ > > tools/perf/config/Makefile | 232 +++++++++++++++------ > > tools/perf/config/feature-checks/Makefile | 6 +- > > tools/perf/config/feature-checks/test-all.c | 5 + > > .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++ > > tools/perf/tests/make | 25 ++- > > tools/perf/util/dso.c | 4 +- > > tools/perf/util/symbol-elf.c | 2 + > > tools/perf/util/symbol.c | 61 +++++- > > tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++ > > tools/perf/util/unwind-libdw.h | 21 ++ > > 13 files changed, 569 insertions(+), 90 deletions(-) > > create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c > > create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c > > create mode 100644 tools/perf/util/unwind-libdw.c > > create mode 100644 tools/perf/util/unwind-libdw.h > > Pulled, thanks a lot Arnaldo! > > Btw., the build output looks weird now - on a system that used to pass > all feature tests there's this output: > > BUILD: Doing 'make -j12' parallel build > config/Makefile:288: No libdw DWARF unwind found, Please install > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > > Auto-detecting system features: > ... dwarf: [ on ] > ... glibc: [ on ] > ... gtk2: [ on ] > ... libaudit: [ on ] > ... libbfd: [ on ] > ... libelf: [ on ] > ... libnuma: [ on ] > ... libperl: [ on ] > ... libpython: [ on ] > ... libslang: [ on ] > ... libunwind: [ on ] > ... libdw-dwarf-unwind: [ OFF ] > ... DWARF post unwind library: libunwind > > but: > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version forgot.. remote unwind in libdw is supported from version 0.158, which I guess wasn't updated in FC19 yet jirka ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2014-11-25 13:21 Arnaldo Carvalho de Melo 0 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2014-11-25 13:21 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Andi Kleen, Borislav Petkov, Corey Ashford, David Ahern, Don Zickus, Frederic Weisbecker, Jiri Olsa, Matt Fleming, Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 4e6e311e596eadba30d4f56f64eae7d45611a01c: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-11-20 08:32:01 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo for you to fetch changes up to 1d9e446b91e182055d874fbb30150aad479a4981: perf tools: Add snapshot format file parsing (2014-11-24 18:03:51 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: User visible: - Callchain improvements from Andi Kleen including: * Enable printing the srcline in the history * Make get_srcline fall back to sym+offset - Allow to force redirect pr_debug to stderr. (Andi Kleen) - TUI hist_entry browser fixes, including showing missing overhead value for first level callchain. Detected comparing the output of --stdio/--gui (that matched) with --tui, that had this problem. (Namhyung Kim) - Fix segfault due to invalid kernel dso access (Namhyung Kim) Infrastructure: - Move bfd_demangle stubbing to its only user (Arnaldo Carvalho de Melo) - 'perf stat' refactorings, moving stuff from it to evsel.c to use in per-pkg/snapshot format changes (Jiri Olsa) - Add per-pkg format file parsing (Matt Fleming) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Andi Kleen (3): perf callchain: Enable printing the srcline in the history perf callchain: Make get_srcline fall back to sym+offset perf tools: Allow to force redirect pr_debug to stderr. Arnaldo Carvalho de Melo (1): perf symbols: Move bfd_demangle stubbing to its only user Jiri Olsa (4): perf evsel: Introduce perf_evsel__compute_deltas function perf evsel: Introduce perf_counts_values__scale function perf evsel: Introduce perf_evsel__read_cb function perf tools: Add snapshot format file parsing Matt Fleming (1): perf tools: Add per-pkg format file parsing Namhyung Kim (3): perf hists browser: Print overhead percent value for first-level callchain perf tools: Collapse first level callchain entry if it has sibling perf tools: Fix segfault due to invalid kernel dso access tools/perf/ui/browsers/hists.c | 25 +++++++++++--- tools/perf/util/annotate.c | 2 +- tools/perf/util/callchain.c | 12 ++++++- tools/perf/util/callchain.h | 1 + tools/perf/util/debug.c | 4 ++- tools/perf/util/evsel.c | 72 +++++++++++++++++++++++----------------- tools/perf/util/evsel.h | 15 +++++++++ tools/perf/util/machine.c | 4 +-- tools/perf/util/map.c | 2 +- tools/perf/util/parse-events.c | 2 ++ tools/perf/util/pmu.c | 74 +++++++++++++++++++++++++++++++++++------- tools/perf/util/pmu.h | 4 +++ tools/perf/util/sort.c | 6 ++-- tools/perf/util/srcline.c | 15 +++++++-- tools/perf/util/symbol-elf.c | 21 ++++++++++++ tools/perf/util/symbol.h | 21 ------------ tools/perf/util/util.h | 4 ++- 17 files changed, 205 insertions(+), 79 deletions(-) ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2015-08-05 20:11 Arnaldo Carvalho de Melo 0 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-08-05 20:11 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Andi Kleen, Borislav Petkov, David Ahern, Frederic Weisbecker, Jiri Olsa, Kan Liang, Milian Wolff, Namhyung Kim, Peter Zijlstra, Petri Gynther, Stephane Eranian, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, way more to process in the next days, with the patchkit for eBPF looking good, perf stat stuff from Jiri and some new hardware stuff from Andi. - Arnaldo The following changes since commit 75f80859b130a1cc84e59e71295ce2dd51fe1c81: perf/x86/intel/pebs: Robustify PEBS buffer drain (2015-08-04 10:17:01 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo for you to fetch changes up to f151f53aa4f54a647353e1935e4c6cef7f094dd4: perf tools: Fix build errors with mipsel-linux-uclibc compiler (2015-08-05 16:56:16 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: New features: - Deref sys_enter pointer args with contents from probe:vfs_getname, showing pathnames instead of pointers in many syscalls in 'perf trace' (Arnaldo Carvalho de Melo) - Make 'perf trace' write to stderr by default, just like 'strace' (Milian Woff) Infrastructure: - color_vfprintf() fixes (Andi Kleen, Jiri Olsa) - Allow enabling/disabling PERF_SAMPLE_TIME per event (Kan Liang) - Fix build errors with mipsel-linux-uclibc compiler (Petri Gynther) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Andi Kleen (1): perf tools: Do not include escape sequences in color_vfprintf return Arnaldo Carvalho de Melo (6): perf script: No tracepoints? Don't call libtraceevent. perf trace: Do not show syscall tracepoint filter in the --no-syscalls case perf trace: Remember if the vfs_getname tracepoint/kprobe is in place perf trace: Use a constant for the syscall formatting buffer perf trace: Deref sys_enter pointer args with contents from probe:vfs_getname perf trace: Use vfs_getname syscall arg beautifier in more syscalls Jiri Olsa (1): perf tools: Remove trail argument to color vsprintf Kan Liang (2): perf tools: Per-event time support perf tools: Refine parse/config callchain functions Milian Wolff (1): perf trace: Write to stderr by default Petri Gynther (1): perf tools: Fix build errors with mipsel-linux-uclibc compiler tools/build/feature/test-glibc.c | 11 ++ tools/perf/Documentation/perf-record.txt | 4 +- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-script.c | 3 +- tools/perf/builtin-trace.c | 175 +++++++++++++++++++++++++++---- tools/perf/util/callchain.c | 14 +-- tools/perf/util/callchain.h | 2 +- tools/perf/util/cloexec.h | 2 +- tools/perf/util/color.c | 21 +--- tools/perf/util/color.h | 1 - tools/perf/util/evsel.c | 25 +++-- tools/perf/util/evsel.h | 2 + tools/perf/util/parse-events.c | 12 +++ tools/perf/util/parse-events.h | 1 + tools/perf/util/parse-events.l | 1 + tools/perf/util/pmu.c | 2 +- 16 files changed, 220 insertions(+), 58 deletions(-) ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2015-10-28 15:30 Arnaldo Carvalho de Melo 2015-10-29 9:36 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-10-28 15:30 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Alexei Starovoitov, Andi Kleen, Borislav Petkov, Brendan Gregg, Chandler Carruth, David Ahern, David S . Miller, Dima Kogan, Frederic Weisbecker, Jiri Olsa, Kan Liang, Li Zefan, Masami Hiramatsu, Michael Petlan, Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41: perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: User visible: - Enable per-event perf_event_attr.inherit setting by config terms, i.e. this becomes possible: $ perf record -e cycles/inherit/ -e instructions/no-inherit/ This affects the default, that can be changed globally using the --no-inherit option. This fine grained control appeared in the eBPF patchkit, but this added flexibility may end up being useful in other scenarios (Wang Nan) - Setup pager when printing usage and help, we have long lists of options, better use the pager like we do with normal tooling output, i.e. when needed, and including any error messages in the paged output (Namhyung Kim) - Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo) $ perf report -h interface Usage: perf report [<options>] --gtk Use the GTK2 interface --stdio Use the stdio interface --tui Use the TUI interface - Fix reading separate debuginfo files based on a build-id, problem found on a Debian system (Dima Kogan) - Fix endless loop when splitting kallsyms symbols per section for handling kcore files, problem found on a s390x system (Jiri Olsa) Infrastructure: - Prep work for the 'perf stat record' work that will allow generating perf.data files with counting data in addition to the sampling mode we have now (Jiri Olsa) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Arnaldo Carvalho de Melo (1): perf tools: Search for more options when passing args to -h Dima Kogan (2): perf symbols: Fix type error when reading a build-id perf symbols: we can now read separate debug-info files based on a build ID Jiri Olsa (4): perf evsel: Move id_offset out of struct perf_evsel union member perf cpu_map: Add cpu_map__empty_new function perf stat: Cache aggregated map entries in extra cpumap perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore Namhyung Kim (4): perf tools: Improve ambiguous option help message perf report: Rename to --show-cpu-utilization perf tools: Setup pager when printing usage and help perf tools: Introduce usage_with_options_msg() Wang Nan (1): perf tools: Enable pre-event inherit setting by config terms tools/perf/Documentation/perf-report.txt | 2 +- tools/perf/builtin-evlist.c | 4 +-- tools/perf/builtin-probe.c | 20 ++++++----- tools/perf/builtin-record.c | 11 +++--- tools/perf/builtin-report.c | 4 ++- tools/perf/builtin-sched.c | 4 +-- tools/perf/builtin-script.c | 8 ++--- tools/perf/builtin-stat.c | 59 +++++++++++++++++++++++++++--- tools/perf/util/cpumap.c | 17 +++++++++ tools/perf/util/cpumap.h | 1 + tools/perf/util/evsel.c | 9 +++++ tools/perf/util/evsel.h | 4 ++- tools/perf/util/parse-events.c | 14 ++++++++ tools/perf/util/parse-events.h | 2 ++ tools/perf/util/parse-events.l | 2 ++ tools/perf/util/parse-options.c | 62 +++++++++++++++++++++++++------- tools/perf/util/parse-options.h | 5 +++ tools/perf/util/strbuf.c | 22 ++++++++---- tools/perf/util/strbuf.h | 2 ++ tools/perf/util/symbol-minimal.c | 2 +- tools/perf/util/symbol.c | 11 +++++- 21 files changed, 216 insertions(+), 49 deletions(-) ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2015-10-28 15:30 Arnaldo Carvalho de Melo @ 2015-10-29 9:36 ` Ingo Molnar 2015-10-29 9:51 ` Ingo Molnar 2015-10-29 9:55 ` Jiri Olsa 0 siblings, 2 replies; 41+ messages in thread From: Ingo Molnar @ 2015-10-29 9:36 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen, Borislav Petkov, Brendan Gregg, Chandler Carruth, David Ahern, David S . Miller, Dima Kogan, Frederic Weisbecker, Jiri Olsa, Kan Liang, Li Zefan, Masami Hiramatsu, Michael Petlan, Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f: > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo > > for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41: > > perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > User visible: > > - Enable per-event perf_event_attr.inherit setting by config terms, i.e. > this becomes possible: > > $ perf record -e cycles/inherit/ -e instructions/no-inherit/ > > This affects the default, that can be changed globally using the --no-inherit > option. > > This fine grained control appeared in the eBPF patchkit, but this added > flexibility may end up being useful in other scenarios (Wang Nan) > > - Setup pager when printing usage and help, we have long lists of options, > better use the pager like we do with normal tooling output, i.e. when needed, > and including any error messages in the paged output (Namhyung Kim) > > - Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo) > > $ perf report -h interface > > Usage: perf report [<options>] > > --gtk Use the GTK2 interface > --stdio Use the stdio interface > --tui Use the TUI interface I love this! For example if I'd like to know what symbol related options we have, I only have to type: triton:~/tip> perf top -h sym Usage: perf top [<options>] -D, --dump-symtab dump the symbol table used for profiling -K, --hide_kernel_symbols hide kernel symbols -s, --sort <key[,key2...]> sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ... Please refer the man page for the complete list. -U, --hide_user_symbols hide user symbols --comms <comm[,comm...]> only consider symbols in these comms --demangle-kernel Enable kernel symbol demangling --dsos <dso[,dso...]> only consider symbols in these dsos --sym-annotate <symbol name> symbol to annotate --symbols <symbol[,symbol...]> only consider these symbols and it's a nice touch that it's searching in the parameter descriptions as well, not just the parameter name. Thus if I only remember some sort of keyword that's enough to narrow things down and figure out the option. One small detail I noticed, for some reason the following search does not work: triton:~/tip> perf report -h --invert Usage: perf report [<options>] It only works if I don't use the dashes: triton:~/tip> perf report -h invert Usage: perf report [<options>] -G, --inverted alias for inverted call graph ... which is a bit surprising, agreed? > - Fix reading separate debuginfo files based on a build-id, problem > found on a Debian system (Dima Kogan) > > - Fix endless loop when splitting kallsyms symbols per section for > handling kcore files, problem found on a s390x system (Jiri Olsa) Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well? > > Infrastructure: > > - Prep work for the 'perf stat record' work that will allow generating > perf.data files with counting data in addition to the sampling mode > we have now (Jiri Olsa) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (1): > perf tools: Search for more options when passing args to -h > > Dima Kogan (2): > perf symbols: Fix type error when reading a build-id > perf symbols: we can now read separate debug-info files based on a build ID > > Jiri Olsa (4): > perf evsel: Move id_offset out of struct perf_evsel union member > perf cpu_map: Add cpu_map__empty_new function > perf stat: Cache aggregated map entries in extra cpumap > perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore > > Namhyung Kim (4): > perf tools: Improve ambiguous option help message > perf report: Rename to --show-cpu-utilization > perf tools: Setup pager when printing usage and help > perf tools: Introduce usage_with_options_msg() > > Wang Nan (1): > perf tools: Enable pre-event inherit setting by config terms > > tools/perf/Documentation/perf-report.txt | 2 +- > tools/perf/builtin-evlist.c | 4 +-- > tools/perf/builtin-probe.c | 20 ++++++----- > tools/perf/builtin-record.c | 11 +++--- > tools/perf/builtin-report.c | 4 ++- > tools/perf/builtin-sched.c | 4 +-- > tools/perf/builtin-script.c | 8 ++--- > tools/perf/builtin-stat.c | 59 +++++++++++++++++++++++++++--- > tools/perf/util/cpumap.c | 17 +++++++++ > tools/perf/util/cpumap.h | 1 + > tools/perf/util/evsel.c | 9 +++++ > tools/perf/util/evsel.h | 4 ++- > tools/perf/util/parse-events.c | 14 ++++++++ > tools/perf/util/parse-events.h | 2 ++ > tools/perf/util/parse-events.l | 2 ++ > tools/perf/util/parse-options.c | 62 +++++++++++++++++++++++++------- > tools/perf/util/parse-options.h | 5 +++ > tools/perf/util/strbuf.c | 22 ++++++++---- > tools/perf/util/strbuf.h | 2 ++ > tools/perf/util/symbol-minimal.c | 2 +- > tools/perf/util/symbol.c | 11 +++++- > 21 files changed, 216 insertions(+), 49 deletions(-) Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2015-10-29 9:36 ` Ingo Molnar @ 2015-10-29 9:51 ` Ingo Molnar 2015-10-29 9:55 ` Jiri Olsa 1 sibling, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2015-10-29 9:51 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen, Borislav Petkov, Brendan Gregg, Chandler Carruth, David Ahern, David S . Miller, Dima Kogan, Frederic Weisbecker, Jiri Olsa, Kan Liang, Li Zefan, Masami Hiramatsu, Michael Petlan, Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo * Ingo Molnar <mingo@kernel.org> wrote: > One small detail I noticed, for some reason the following search does not work: > > triton:~/tip> perf report -h --invert > > Usage: perf report [<options>] > Btw., another detail, if it searches but does not try, I think we should output a warning to the user. Printing something like this would be more helpful: triton:~/tip> perf report -h --invert Search pattern '--invert' not found amongst the parameters. To resolve this use a different search pattern or use '-h' to list all parameters. Thanks, Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2015-10-29 9:36 ` Ingo Molnar 2015-10-29 9:51 ` Ingo Molnar @ 2015-10-29 9:55 ` Jiri Olsa 1 sibling, 0 replies; 41+ messages in thread From: Jiri Olsa @ 2015-10-29 9:55 UTC (permalink / raw) To: Ingo Molnar Cc: Arnaldo Carvalho de Melo, linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen, Borislav Petkov, Brendan Gregg, Chandler Carruth, David Ahern, David S . Miller, Dima Kogan, Frederic Weisbecker, Kan Liang, Li Zefan, Masami Hiramatsu, Michael Petlan, Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo On Thu, Oct 29, 2015 at 10:36:36AM +0100, Ingo Molnar wrote: SNIP > > > - Fix reading separate debuginfo files based on a build-id, problem > > found on a Debian system (Dima Kogan) > > > > - Fix endless loop when splitting kallsyms symbols per section for > > handling kcore files, problem found on a s390x system (Jiri Olsa) > > Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well? it could go to perf/urgent as well jirka ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2015-11-05 16:02 Arnaldo Carvalho de Melo 0 siblings, 0 replies; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2015-11-05 16:02 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Alexei Starovoitov, Andi Kleen, Andrew Morton, David Ahern, Jiri Olsa, Kan Liang, Markus Trippelsdorf, Masami Hiramatsu, Namhyung Kim, Paul Mackerras, Peter Feiner, Peter Zijlstra, pi3orama, Thomas Gleixner, Wang Nan, Yunlong Song, Zefan Li, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit bebd23a2ed31d47e7dd746d3b125068aa2c42d85: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-30 10:09:37 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo for you to fetch changes up to 0014de172d228e450377d1fd079d94e67128d27f: perf sched latency: Fix thread pid reuse issue (2015-11-05 12:51:00 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: User visible: - Fix 'perf top' segfault related to splitting overlapping mmaps (Jiri Olsa) - Fix 'perf sched latency' when there is pid/tid reuse (Jiri Olsa) - Fix documentation for 'perf trace -i' (Peter Feiner) Infrastructure: - Make the LINUX_VERSION_CODE define available for bpf scriptlets to use (Wang Nan) - Pass the number of configured CPUs via the __NR_CPUS__ define to bpf scriptlets (Wang Nan) - Fix libbpf compiler warning on CentOS 6 (Namhyung Kim) - Only be verbose in several perf test entries, bpf included, when -v is used (Wang Nan) - Don't run the 'build-test' entries always in the same order, the full set takes a long time, so sometimes we interrupt, shuffling them avoids running just the first same few in interrupted runs (Arnaldo Carvalho de Melo) - Change FEATURE-DUMP to FEATURE-DUMP.libbpf in .gitignore and 'clean' make target (Yunlong Song) - 'perf stat' refactorings to avoid duplicated code (Andi Kleen) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Andi Kleen (2): perf stat: Move sw clock metrics printout to stat-shadow perf stat: Use common printout function to avoid duplicated code Arnaldo Carvalho de Melo (1): perf tools: Allow shuffling the build tests Jiri Olsa (2): perf tools: Insert split maps correctly into origin group perf sched latency: Fix thread pid reuse issue Namhyung Kim (1): tools lib bpf: Fix compiler warning on CentOS 6 Peter Feiner (1): perf trace: Fix documentation for -i Wang Nan (5): perf test: Keep test result clean if '-v' not set perf bpf: Mute libbpf when '-v' not set perf llvm: Pass number of configured CPUs to clang compiler perf llvm: Pass LINUX_VERSION_CODE to BPF program when compiling perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success Yunlong Song (1): tools lib bpf: Change FEATURE-DUMP to FEATURE-DUMP.libbpf tools/lib/bpf/.gitignore | 2 +- tools/lib/bpf/Makefile | 2 +- tools/lib/bpf/libbpf.c | 4 +-- tools/lib/bpf/libbpf.h | 2 +- tools/perf/Documentation/perf-trace.txt | 1 - tools/perf/Makefile | 2 +- tools/perf/builtin-sched.c | 5 +-- tools/perf/builtin-stat.c | 59 +++++++++++---------------------- tools/perf/tests/attr.c | 3 +- tools/perf/tests/code-reading.c | 8 ++--- tools/perf/tests/keep-tracking.c | 4 +-- tools/perf/tests/llvm.c | 11 +++--- tools/perf/tests/make | 5 +++ tools/perf/tests/switch-tracking.c | 4 +-- tools/perf/util/bpf-loader.c | 4 +-- tools/perf/util/llvm-utils.c | 51 ++++++++++++++++++++++++---- tools/perf/util/map.c | 10 ++++-- tools/perf/util/probe-event.c | 3 ++ tools/perf/util/stat-shadow.c | 5 +++ 19 files changed, 110 insertions(+), 75 deletions(-) ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2016-05-17 2:45 Arnaldo Carvalho de Melo 2016-05-20 6:23 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2016-05-17 2:45 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin, Alexei Starovoitov, Ananth N Mavinakayanahalli, Andi Kleen, Brendan Gregg, David Ahern, Ekaterina Tumanova, Frederic Weisbecker, He Kuang, Hemant Kumar, Jiri Olsa, Josh Poimboeuf, Kan Liang, Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim, Pekka Enberg, Peter Zijlstra, Stephane Eranian, Sukadev Bhattiprolu, Thomas Gleixner, Vince Weaver, Wang Nan, Zefan Li From: Arnaldo Carvalho de Melo <acme@redhat.com> Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020: perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516 for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e: perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: User visible: - Honour the kernel.perf_event_max_stack knob more precisely by not counting PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo) - Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim) - Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim) - Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim) - Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen) - Store vdso buildid unconditionally, as it appears in callchains and we're not checking those when creating the build-id table, so we end up not being able to resolve VDSO symbols when doing analysis on a different machine than the one where recording was done, possibly of a different arch even (arm -> x86_64) (He Kuang) Infrastructure: - Generalize max_stack sysctl handler, will be used for configuring multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo) Cleanups: - Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using open coded strings (Masami Hiramatsu) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Andi Kleen (1): perf stat: Avoid fractional digits for integer scales Arnaldo Carvalho de Melo (6): perf core: Generalize max_stack sysctl handler perf core: Pass max stack as a perf_callchain_entry context perf core: Add a 'nr' field to perf_event_callchain_context perf core: Add perf_callchain_store_context() helper perf core: Separate accounting of contexts and real addresses in a stack trace perf tools: Separate accounting of contexts and real addresses in a stack trace He Kuang (1): perf symbols: Store vdso buildid unconditionally Masami Hiramatsu (1): perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE Namhyung Kim (3): perf stat: Fix indentation of stalled backend cycle perf stat: Update runtime using cpu-clock event perf stat: Use cpu-clock event for cpu targets Documentation/sysctl/kernel.txt | 14 ++++++++++++++ arch/arc/kernel/perf_event.c | 6 +++--- arch/arm/kernel/perf_callchain.c | 10 +++++----- arch/arm64/kernel/perf_callchain.c | 14 +++++++------- arch/metag/kernel/perf_callchain.c | 10 +++++----- arch/mips/kernel/perf_event.c | 12 ++++++------ arch/powerpc/perf/callchain.c | 20 ++++++++++---------- arch/s390/kernel/perf_event.c | 4 ++-- arch/sh/kernel/perf_callchain.c | 4 ++-- arch/sparc/kernel/perf_event.c | 14 +++++++------- arch/tile/kernel/perf_event.c | 6 +++--- arch/x86/events/core.c | 14 +++++++------- arch/xtensa/kernel/perf_event.c | 10 +++++----- include/linux/perf_event.h | 34 +++++++++++++++++++++++++++++----- include/uapi/linux/perf_event.h | 1 + kernel/bpf/stackmap.c | 3 ++- kernel/events/callchain.c | 36 ++++++++++++++++++++++++------------ kernel/sysctl.c | 11 ++++++++++- tools/perf/builtin-buildid-cache.c | 8 ++++---- tools/perf/builtin-stat.c | 22 +++++++++++++--------- tools/perf/perf.c | 3 +++ tools/perf/util/annotate.c | 2 +- tools/perf/util/build-id.c | 2 +- tools/perf/util/dso.c | 3 ++- tools/perf/util/machine.c | 28 ++++++++++++++++++---------- tools/perf/util/stat-shadow.c | 8 +++++--- tools/perf/util/symbol.c | 10 +++++----- tools/perf/util/symbol.h | 3 +++ tools/perf/util/util.c | 3 ++- tools/perf/util/util.h | 3 ++- 30 files changed, 201 insertions(+), 117 deletions(-) ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2016-05-17 2:45 Arnaldo Carvalho de Melo @ 2016-05-20 6:23 ` Ingo Molnar 0 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2016-05-20 6:23 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin, Alexei Starovoitov, Ananth N Mavinakayanahalli, Andi Kleen, Brendan Gregg, David Ahern, Ekaterina Tumanova, Frederic Weisbecker, He Kuang, Hemant Kumar, Jiri Olsa, Josh Poimboeuf, Kan Liang, Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim, Pekka Enberg, Peter Zijlstra, Stephane Eranian, Sukadev Bhattiprolu, Thomas Gleixner, Vince Weaver, Wang Nan, Zefan Li * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > From: Arnaldo Carvalho de Melo <acme@redhat.com> > > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020: > > perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516 > > for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e: > > perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > User visible: > > - Honour the kernel.perf_event_max_stack knob more precisely by not counting > PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to > the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo) > > - Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim) > > - Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim) > > - Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim) > > - Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen) > > - Store vdso buildid unconditionally, as it appears in callchains and > we're not checking those when creating the build-id table, so we > end up not being able to resolve VDSO symbols when doing analysis > on a different machine than the one where recording was done, possibly > of a different arch even (arm -> x86_64) (He Kuang) > > Infrastructure: > > - Generalize max_stack sysctl handler, will be used for configuring > multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo) > > Cleanups: > > - Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using > open coded strings (Masami Hiramatsu) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Andi Kleen (1): > perf stat: Avoid fractional digits for integer scales > > Arnaldo Carvalho de Melo (6): > perf core: Generalize max_stack sysctl handler > perf core: Pass max stack as a perf_callchain_entry context > perf core: Add a 'nr' field to perf_event_callchain_context > perf core: Add perf_callchain_store_context() helper > perf core: Separate accounting of contexts and real addresses in a stack trace > perf tools: Separate accounting of contexts and real addresses in a stack trace > > He Kuang (1): > perf symbols: Store vdso buildid unconditionally > > Masami Hiramatsu (1): > perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE > > Namhyung Kim (3): > perf stat: Fix indentation of stalled backend cycle > perf stat: Update runtime using cpu-clock event > perf stat: Use cpu-clock event for cpu targets > > Documentation/sysctl/kernel.txt | 14 ++++++++++++++ > arch/arc/kernel/perf_event.c | 6 +++--- > arch/arm/kernel/perf_callchain.c | 10 +++++----- > arch/arm64/kernel/perf_callchain.c | 14 +++++++------- > arch/metag/kernel/perf_callchain.c | 10 +++++----- > arch/mips/kernel/perf_event.c | 12 ++++++------ > arch/powerpc/perf/callchain.c | 20 ++++++++++---------- > arch/s390/kernel/perf_event.c | 4 ++-- > arch/sh/kernel/perf_callchain.c | 4 ++-- > arch/sparc/kernel/perf_event.c | 14 +++++++------- > arch/tile/kernel/perf_event.c | 6 +++--- > arch/x86/events/core.c | 14 +++++++------- > arch/xtensa/kernel/perf_event.c | 10 +++++----- > include/linux/perf_event.h | 34 +++++++++++++++++++++++++++++----- > include/uapi/linux/perf_event.h | 1 + > kernel/bpf/stackmap.c | 3 ++- > kernel/events/callchain.c | 36 ++++++++++++++++++++++++------------ > kernel/sysctl.c | 11 ++++++++++- > tools/perf/builtin-buildid-cache.c | 8 ++++---- > tools/perf/builtin-stat.c | 22 +++++++++++++--------- > tools/perf/perf.c | 3 +++ > tools/perf/util/annotate.c | 2 +- > tools/perf/util/build-id.c | 2 +- > tools/perf/util/dso.c | 3 ++- > tools/perf/util/machine.c | 28 ++++++++++++++++++---------- > tools/perf/util/stat-shadow.c | 8 +++++--- > tools/perf/util/symbol.c | 10 +++++----- > tools/perf/util/symbol.h | 3 +++ > tools/perf/util/util.c | 3 ++- > tools/perf/util/util.h | 3 ++- > 30 files changed, 201 insertions(+), 117 deletions(-) Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2016-05-30 19:24 Arnaldo Carvalho de Melo 2016-05-31 7:24 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin, Alexei Starovoitov, Ananth N Mavinakayanahalli, Andi Kleen, Brendan Gregg, David Ahern, Frederic Weisbecker, He Kuang, Hemant Kumar, Jiri Olsa, Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian, Taeung Song, Thomas Gleixner, Vince Weaver, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f: Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530 for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6: perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: User visible/kernel ABI: - Per event callchain limit: Recently we introduced a sysctl to tune the max-stack for all events for which callchains were requested: $ sysctl kernel.perf_event_max_stack kernel.perf_event_max_stack = 127 Now this patch introduces a way to configure this per event, i.e. this becomes possible: $ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a allowing finer tuning of how much buffer space callchains use. This uses an u16 from the reserved space at the end, leaving another u16 for future use. There has been interest in even finer tuning, namely to control the max stack for kernel and userspace callchains separately. Further discussion is needed, we may for instance use the remaining u16 for that and when it is present, assume that the sample_max_stack introduced in this patch applies for the kernel, and the u16 left is used for limiting the userspace callchain. (Arnaldo Carvalho de Melo) Infrastructure: - Adopt get_main_thread from db-export.c (Andi Kleen) - More prep work for backward ring buffer support (Wang Nan) - Prep work for supporting SDT (Statically Defined Tracing) tracepoints (Masami Hiramatsu) - Add arch/*/include/generated/ to .gitignore (Taeung Song) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Andi Kleen (1): perf thread: Adopt get_main_thread from db-export.c Arnaldo Carvalho de Melo (2): perf core: Per event callchain limit perf tools: Per event max-stack settings Masami Hiramatsu (3): perf symbols: Introduce filename__readable to check readability perf symbols: Cleanup the code flow of dso__find_kallsyms perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Taeung Song (1): perf tools: Add arch/*/include/generated/ to .gitignore Wang Nan (5): perf record: Robustify perf_event__synth_time_conv() perf evlist: Don't poll and mmap overwritable events perf evlist: Check 'base' pointer before checking refcnt when put a mmap perf evlist: Choose correct reading direction according to evlist->backward tools: Pass arg to fdarray__filter's call back function include/linux/perf_event.h | 2 +- include/uapi/linux/perf_event.h | 6 ++- kernel/bpf/stackmap.c | 2 +- kernel/events/callchain.c | 14 ++++- kernel/events/core.c | 5 +- tools/lib/api/fd/array.c | 5 +- tools/lib/api/fd/array.h | 3 +- tools/perf/.gitignore | 1 + tools/perf/arch/x86/util/tsc.c | 2 + tools/perf/builtin-record.c | 9 +++- tools/perf/tests/fdarray.c | 8 +-- tools/perf/util/build-id.c | 115 ++++++++++++++++++++++++++++++---------- tools/perf/util/build-id.h | 2 + tools/perf/util/callchain.h | 1 + tools/perf/util/db-export.c | 13 +---- tools/perf/util/dso.h | 5 ++ tools/perf/util/evlist.c | 43 +++++++++++---- tools/perf/util/evlist.h | 2 + tools/perf/util/evsel.c | 16 +++++- tools/perf/util/evsel.h | 2 + tools/perf/util/parse-events.c | 8 +++ tools/perf/util/parse-events.h | 1 + tools/perf/util/parse-events.l | 1 + tools/perf/util/session.c | 2 + tools/perf/util/symbol.c | 71 ++++++++++++------------- tools/perf/util/thread.c | 11 ++++ tools/perf/util/thread.h | 2 + 27 files changed, 252 insertions(+), 100 deletions(-) ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2016-05-30 19:24 Arnaldo Carvalho de Melo @ 2016-05-31 7:24 ` Ingo Molnar 0 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2016-05-31 7:24 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, Alexei Starovoitov, Ananth N Mavinakayanahalli, Andi Kleen, Brendan Gregg, David Ahern, Frederic Weisbecker, He Kuang, Hemant Kumar, Jiri Olsa, Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian, Taeung Song, Thomas Gleixner, Vince Weaver, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f: > > Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530 > > for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6: > > perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > User visible/kernel ABI: > > - Per event callchain limit: Recently we introduced a sysctl to tune the > max-stack for all events for which callchains were requested: > > $ sysctl kernel.perf_event_max_stack > kernel.perf_event_max_stack = 127 > > Now this patch introduces a way to configure this per event, i.e. this > becomes possible: > > $ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a > > allowing finer tuning of how much buffer space callchains use. > > This uses an u16 from the reserved space at the end, leaving another > u16 for future use. > > There has been interest in even finer tuning, namely to control the > max stack for kernel and userspace callchains separately. Further > discussion is needed, we may for instance use the remaining u16 for > that and when it is present, assume that the sample_max_stack introduced > in this patch applies for the kernel, and the u16 left is used for > limiting the userspace callchain. (Arnaldo Carvalho de Melo) > > Infrastructure: > > - Adopt get_main_thread from db-export.c (Andi Kleen) > > - More prep work for backward ring buffer support (Wang Nan) > > - Prep work for supporting SDT (Statically Defined Tracing) > tracepoints (Masami Hiramatsu) > > - Add arch/*/include/generated/ to .gitignore (Taeung Song) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Andi Kleen (1): > perf thread: Adopt get_main_thread from db-export.c > > Arnaldo Carvalho de Melo (2): > perf core: Per event callchain limit > perf tools: Per event max-stack settings > > Masami Hiramatsu (3): > perf symbols: Introduce filename__readable to check readability > perf symbols: Cleanup the code flow of dso__find_kallsyms > perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid > > Taeung Song (1): > perf tools: Add arch/*/include/generated/ to .gitignore > > Wang Nan (5): > perf record: Robustify perf_event__synth_time_conv() > perf evlist: Don't poll and mmap overwritable events > perf evlist: Check 'base' pointer before checking refcnt when put a mmap > perf evlist: Choose correct reading direction according to evlist->backward > tools: Pass arg to fdarray__filter's call back function > > include/linux/perf_event.h | 2 +- > include/uapi/linux/perf_event.h | 6 ++- > kernel/bpf/stackmap.c | 2 +- > kernel/events/callchain.c | 14 ++++- > kernel/events/core.c | 5 +- > tools/lib/api/fd/array.c | 5 +- > tools/lib/api/fd/array.h | 3 +- > tools/perf/.gitignore | 1 + > tools/perf/arch/x86/util/tsc.c | 2 + > tools/perf/builtin-record.c | 9 +++- > tools/perf/tests/fdarray.c | 8 +-- > tools/perf/util/build-id.c | 115 ++++++++++++++++++++++++++++++---------- > tools/perf/util/build-id.h | 2 + > tools/perf/util/callchain.h | 1 + > tools/perf/util/db-export.c | 13 +---- > tools/perf/util/dso.h | 5 ++ > tools/perf/util/evlist.c | 43 +++++++++++---- > tools/perf/util/evlist.h | 2 + > tools/perf/util/evsel.c | 16 +++++- > tools/perf/util/evsel.h | 2 + > tools/perf/util/parse-events.c | 8 +++ > tools/perf/util/parse-events.h | 1 + > tools/perf/util/parse-events.l | 1 + > tools/perf/util/session.c | 2 + > tools/perf/util/symbol.c | 71 ++++++++++++------------- > tools/perf/util/thread.c | 11 ++++ > tools/perf/util/thread.h | 2 + > 27 files changed, 252 insertions(+), 100 deletions(-) Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2016-09-08 20:46 Arnaldo Carvalho de Melo 2016-09-09 5:47 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2016-09-08 20:46 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin, Andi Kleen, Anshuman Khandual, David Ahern, David Carrillo-Cisneros, He Kuang, Hou Pengyang, Jiri Olsa, Kan Liang, Linus Torvalds, Mark Rutland, Masami Hiramatsu, Namhyung Kim, Nilay Vaish, Peter Zijlstra, Ravi Bangoria, Stephane Eranian, Wang Nan, Will Deacon, Zefan Li, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d: Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908 for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c: perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: User visible: - Add branch stack / basic block info to 'perf annotate --stdio', where for each branch, we add an asm comment after the instruction with information on how often it was taken and predicted. See example with color output at: http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png (Peter Zijlstra) - Only open an evsel in CPUs in its cpu map, fixing some use cases in systems with multiple PMUs with different CPU maps (Mark Rutland) - Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan) Infrastructure: - Remove the symbol filtering code, i.e. the callbacks passed to all functions that could end up loading a DSO symtab, simplifying the code, eventually allowing what we should have had since day one: removing the 'map' parameter from dso__load() functions (Arnaldo Carvalho de Melo) Arch specific build fixes: - Fix detached tarball build on powerpc, where we were still accessing a file outside tools/ (Ravi Bangoria) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Arnaldo Carvalho de Melo (5): perf symbols: Mark if a symbol is idle in the library perf top: Remove old kernel-only symbol filter perf machine: Remove machine->symbol_filter and friends perf test vmlinux: Remove dead symbol_filter_t code perf symbols: Remove symbol_filter_t machinery Mark Rutland (2): perf evlist: Only open events on CPUs an evsel permits perf pmu: Support alternative sysfs cpumask Peter Zijlstra (1): perf annotate: Add branch stack / basic block Ravi Bangoria (1): perf powerpc: Fix build-test failure Wang Nan (3): perf tools: Recognize hugetlb mapping as anon mapping tools lib api fs: Add hugetlbfs filesystem detector perf record: Mark MAP_HUGETLB when synthesizing mmap events tools/lib/api/fs/fs.c | 15 ++ tools/lib/api/fs/fs.h | 1 + tools/perf/arch/powerpc/util/sym-handling.c | 2 +- tools/perf/builtin-annotate.c | 104 +++++++++ tools/perf/builtin-inject.c | 2 +- tools/perf/builtin-kmem.c | 10 +- tools/perf/builtin-script.c | 4 +- tools/perf/builtin-top.c | 30 --- tools/perf/perf-sys.h | 1 - tools/perf/tests/code-reading.c | 4 +- tools/perf/tests/vmlinux-kallsyms.c | 17 +- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/ui/browsers/map.c | 4 +- tools/perf/util/Build | 1 + tools/perf/util/annotate.c | 95 +++++++- tools/perf/util/annotate.h | 1 + tools/perf/util/block-range.c | 328 ++++++++++++++++++++++++++++ tools/perf/util/block-range.h | 71 ++++++ tools/perf/util/event.c | 21 +- tools/perf/util/evlist.c | 8 +- tools/perf/util/intel-bts.c | 2 +- tools/perf/util/intel-pt.c | 4 +- tools/perf/util/machine.c | 38 +--- tools/perf/util/machine.h | 34 +-- tools/perf/util/map.c | 50 ++--- tools/perf/util/map.h | 32 +-- tools/perf/util/pmu.c | 15 +- tools/perf/util/probe-event.c | 17 +- tools/perf/util/symbol-elf.c | 32 +-- tools/perf/util/symbol-minimal.c | 4 +- tools/perf/util/symbol.c | 134 ++++++------ tools/perf/util/symbol.h | 20 +- 32 files changed, 817 insertions(+), 286 deletions(-) create mode 100644 tools/perf/util/block-range.c create mode 100644 tools/perf/util/block-range.h Build stats: [root@jouet ~]# time dm 1 69.078 alpine:3.4: Ok 2 24.055 android-ndk:r12b-arm: Ok 3 71.911 archlinux:latest: Ok 4 41.209 centos:5: Ok 5 58.240 centos:6: Ok 6 67.238 centos:7: Ok 7 62.040 debian:7: Ok 8 69.061 debian:8: Ok 9 38.124 debian:experimental: Ok 10 67.623 fedora:20: Ok 11 71.458 fedora:21: Ok 12 70.807 fedora:22: Ok 13 71.013 fedora:23: Ok 14 73.330 fedora:24: Ok 15 30.062 fedora:24-x-ARC-uClibc: Ok 16 77.616 fedora:rawhide: Ok 17 73.663 mageia:5: Ok 18 69.264 opensuse:13.2: Ok 19 71.532 opensuse:42.1: Ok 20 76.282 opensuse:tumbleweed: Ok 21 54.666 ubuntu:12.04.5: Ok 22 37.170 ubuntu:14.04: Ok 23 66.101 ubuntu:14.04.4: Ok 24 68.881 ubuntu:15.10: Ok 25 62.698 ubuntu:16.04: Ok 26 53.046 ubuntu:16.04-x-arm: Ok 27 51.609 ubuntu:16.04-x-arm64: Ok 28 51.842 ubuntu:16.04-x-powerpc64: Ok 29 53.347 ubuntu:16.04-x-powerpc64el: Ok 30 72.280 ubuntu:16.10: Ok 31 54.078 ubuntu:16.10-x-s390: Ok real 31m19.919s user 0m1.890s sys 0m2.201s [root@jouet ~]# ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2016-09-08 20:46 Arnaldo Carvalho de Melo @ 2016-09-09 5:47 ` Ingo Molnar 0 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2016-09-09 5:47 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, Andi Kleen, Anshuman Khandual, David Ahern, David Carrillo-Cisneros, He Kuang, Hou Pengyang, Jiri Olsa, Kan Liang, Linus Torvalds, Mark Rutland, Masami Hiramatsu, Namhyung Kim, Nilay Vaish, Peter Zijlstra, Ravi Bangoria, Stephane Eranian, Wang Nan, Will Deacon, Zefan Li, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d: > > Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908 > > for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c: > > perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > User visible: > > - Add branch stack / basic block info to 'perf annotate --stdio', where for > each branch, we add an asm comment after the instruction with information on > how often it was taken and predicted. See example with color output at: > > http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png > > (Peter Zijlstra) > > - Only open an evsel in CPUs in its cpu map, fixing some use cases in > systems with multiple PMUs with different CPU maps (Mark Rutland) > > - Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan) > > Infrastructure: > > - Remove the symbol filtering code, i.e. the callbacks passed to all functions > that could end up loading a DSO symtab, simplifying the code, eventually > allowing what we should have had since day one: removing the 'map' parameter > from dso__load() functions (Arnaldo Carvalho de Melo) > > Arch specific build fixes: > > - Fix detached tarball build on powerpc, where we were still accessing a > file outside tools/ (Ravi Bangoria) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (5): > perf symbols: Mark if a symbol is idle in the library > perf top: Remove old kernel-only symbol filter > perf machine: Remove machine->symbol_filter and friends > perf test vmlinux: Remove dead symbol_filter_t code > perf symbols: Remove symbol_filter_t machinery > > Mark Rutland (2): > perf evlist: Only open events on CPUs an evsel permits > perf pmu: Support alternative sysfs cpumask > > Peter Zijlstra (1): > perf annotate: Add branch stack / basic block > > Ravi Bangoria (1): > perf powerpc: Fix build-test failure > > Wang Nan (3): > perf tools: Recognize hugetlb mapping as anon mapping > tools lib api fs: Add hugetlbfs filesystem detector > perf record: Mark MAP_HUGETLB when synthesizing mmap events > > tools/lib/api/fs/fs.c | 15 ++ > tools/lib/api/fs/fs.h | 1 + > tools/perf/arch/powerpc/util/sym-handling.c | 2 +- > tools/perf/builtin-annotate.c | 104 +++++++++ > tools/perf/builtin-inject.c | 2 +- > tools/perf/builtin-kmem.c | 10 +- > tools/perf/builtin-script.c | 4 +- > tools/perf/builtin-top.c | 30 --- > tools/perf/perf-sys.h | 1 - > tools/perf/tests/code-reading.c | 4 +- > tools/perf/tests/vmlinux-kallsyms.c | 17 +- > tools/perf/ui/browsers/annotate.c | 2 +- > tools/perf/ui/browsers/map.c | 4 +- > tools/perf/util/Build | 1 + > tools/perf/util/annotate.c | 95 +++++++- > tools/perf/util/annotate.h | 1 + > tools/perf/util/block-range.c | 328 ++++++++++++++++++++++++++++ > tools/perf/util/block-range.h | 71 ++++++ > tools/perf/util/event.c | 21 +- > tools/perf/util/evlist.c | 8 +- > tools/perf/util/intel-bts.c | 2 +- > tools/perf/util/intel-pt.c | 4 +- > tools/perf/util/machine.c | 38 +--- > tools/perf/util/machine.h | 34 +-- > tools/perf/util/map.c | 50 ++--- > tools/perf/util/map.h | 32 +-- > tools/perf/util/pmu.c | 15 +- > tools/perf/util/probe-event.c | 17 +- > tools/perf/util/symbol-elf.c | 32 +-- > tools/perf/util/symbol-minimal.c | 4 +- > tools/perf/util/symbol.c | 134 ++++++------ > tools/perf/util/symbol.h | 20 +- > 32 files changed, 817 insertions(+), 286 deletions(-) > create mode 100644 tools/perf/util/block-range.c > create mode 100644 tools/perf/util/block-range.h > > Build stats: > > [root@jouet ~]# time dm > 1 69.078 alpine:3.4: Ok > 2 24.055 android-ndk:r12b-arm: Ok > 3 71.911 archlinux:latest: Ok > 4 41.209 centos:5: Ok > 5 58.240 centos:6: Ok > 6 67.238 centos:7: Ok > 7 62.040 debian:7: Ok > 8 69.061 debian:8: Ok > 9 38.124 debian:experimental: Ok > 10 67.623 fedora:20: Ok > 11 71.458 fedora:21: Ok > 12 70.807 fedora:22: Ok > 13 71.013 fedora:23: Ok > 14 73.330 fedora:24: Ok > 15 30.062 fedora:24-x-ARC-uClibc: Ok > 16 77.616 fedora:rawhide: Ok > 17 73.663 mageia:5: Ok > 18 69.264 opensuse:13.2: Ok > 19 71.532 opensuse:42.1: Ok > 20 76.282 opensuse:tumbleweed: Ok > 21 54.666 ubuntu:12.04.5: Ok > 22 37.170 ubuntu:14.04: Ok > 23 66.101 ubuntu:14.04.4: Ok > 24 68.881 ubuntu:15.10: Ok > 25 62.698 ubuntu:16.04: Ok > 26 53.046 ubuntu:16.04-x-arm: Ok > 27 51.609 ubuntu:16.04-x-arm64: Ok > 28 51.842 ubuntu:16.04-x-powerpc64: Ok > 29 53.347 ubuntu:16.04-x-powerpc64el: Ok > 30 72.280 ubuntu:16.10: Ok > 31 54.078 ubuntu:16.10-x-s390: Ok > > real 31m19.919s > user 0m1.890s > sys 0m2.201s > [root@jouet ~]# Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2016-11-25 15:12 Arnaldo Carvalho de Melo 2016-11-25 17:14 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2016-11-25 15:12 UTC (permalink / raw) To: Ingo Molnar Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin, Alexei Starovoitov, Andi Kleen, Chris Riyder, David Ahern, Eric Leblond, He Kuang, Jiri Olsa, Kim Phillips, Markus Trippelsdorf, Masami Hiramatsu, Namhyung Kim, Naveen N . Rao, Pawel Moll, Peter Zijlstra, pi3orama, Ravi Bangoria, Russell King, Stephane Eranian, Taeung Song, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo Test results at the end of this message. The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2: Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125 for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5: tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: New features: - Improve ARM support in the annotation code, affecting 'perf annotate', 'perf report' and live annotation in 'perf top' (Kim Phillips) - Initial support for PowerPC in the annotation code (Ravi Bangoria) - Skip repetitive scheduler function on the top of the stack in 'perf sched timehist' (Namhyung Kim) Fixes: - Fix maps resolution in libbpf (Eric Leblond) - Get the kernel signature via /proc/version_signature, available on ubuntu systems, to make sure bpf proggies works, as the one provided via 'uname -r' doesn't (Wang Nan) - Fix segfault in 'perf record' when running with suid and kptr_restrict is 1 (Wang Nan) Infrastructure: - Support per-arch instruction tables, kept via a static or dynamic table (Arnaldo Carvalho de Melo) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Arnaldo Carvalho de Melo (4): perf annotate: Remove duplicate 'name' field from disasm_line perf annotate: Introduce alternative method of keeping instructions table perf annotate: Allow arches to have a init routine and a priv area perf annotate: Improve support for ARM Eric Leblond (1): tools lib bpf: Fix maps resolution Namhyung Kim (3): perf callchain: Add option to skip ignore symbol when printing callchains perf sched timehist: Mark schedule function in callchains perf sched timehist: Enlarge max stack depth by 2 Ravi Bangoria (1): perf annotate: Initial PowerPC support Wang Nan (3): perf tools: Fix kernel version error in ubuntu perf record: Fix segfault when running with suid and kptr_restrict is 1 perf tools: Add missing struct definition in probe_event.h tools/lib/bpf/libbpf.c | 142 ++++++++++++++------- tools/perf/arch/arm/annotate/instructions.c | 147 +++++++++------------- tools/perf/arch/powerpc/annotate/instructions.c | 58 +++++++++ tools/perf/builtin-sched.c | 26 +++- tools/perf/ui/browsers/annotate.c | 18 +-- tools/perf/util/annotate.c | 157 +++++++++++++++++------- tools/perf/util/annotate.h | 17 ++- tools/perf/util/evsel.h | 1 + tools/perf/util/evsel_fprintf.c | 7 +- tools/perf/util/probe-event.h | 2 + tools/perf/util/symbol.c | 2 +- tools/perf/util/symbol.h | 1 + tools/perf/util/util.c | 55 ++++++++- 13 files changed, 431 insertions(+), 202 deletions(-) create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c Rebuilding containers, so limited coverage at this time: # dm 1 debian:experimental: Ok 2 fedora:24: Ok 3 fedora:24-x-ARC-uClibc: Ok 4 fedora:rawhide: Ok 5 opensuse:tumbleweed: Ok # perf test 1: vmlinux symtab matches kallsyms : Ok 2: detect openat syscall event : Ok 3: detect openat syscall event on all cpus : Ok 4: read samples using the mmap interface : Ok 5: parse events tests : Ok 6: Validate PERF_RECORD_* events & perf_sample fields : Ok 7: Test perf pmu format parsing : Ok 8: Test dso data read : Ok 9: Test dso data cache : Ok 10: Test dso data reopen : Ok 11: roundtrip evsel->name check : Ok 12: Check parsing of sched tracepoints fields : Ok 13: Generate and check syscalls:sys_enter_openat event fields: Ok 14: struct perf_event_attr setup : Ok 15: Test matching and linking multiple hists : Ok 16: Try 'import perf' in python, checking link problems : Ok 17: Test breakpoint overflow signal handler : Ok 18: Test breakpoint overflow sampling : Ok 19: Test number of exit event of a simple workload : Ok 20: Test software clock events have valid period values : Ok 21: Test object code reading : Ok 22: Test sample parsing : Ok 23: Test using a dummy software event to keep tracking : Ok 24: Test parsing with no sample_id_all bit set : Ok 25: Test filtering hist entries : Ok 26: Test mmap thread lookup : Ok 27: Test thread mg sharing : Ok 28: Test output sorting of hist entries : Ok 29: Test cumulation of child hist entries : Ok 30: Test tracking with sched_switch : Ok 31: Filter fds with revents mask in a fdarray : Ok 32: Add fd to a fdarray, making it autogrow : Ok 33: Test kmod_path__parse function : Ok 34: Test thread map : Ok 35: Test LLVM searching and compiling : 35.1: Basic BPF llvm compiling test : Ok 35.2: Test kbuild searching : Ok 35.3: Compile source for BPF prologue generation test : Ok 35.4: Compile source for BPF relocation test : Ok 36: Test topology in session : Ok 37: Test BPF filter : 37.1: Test basic BPF filtering : Ok 37.2: Test BPF prologue generation : Ok 37.3: Test BPF relocation checker : Ok 38: Test thread map synthesize : Ok 39: Test cpu map synthesize : Ok 40: Test stat config synthesize : Ok 41: Test stat synthesize : Ok 42: Test stat round synthesize : Ok 43: Test attr update synthesize : Ok 44: Test events times : Ok 45: Test backward reading from ring buffer : Ok 46: Test cpu map print : Ok 47: Test SDT event probing : Ok 48: Test is_printable_array function : Ok 49: Test bitmap print : Ok 50: x86 rdpmc test : Ok 51: Test converting perf time to TSC : Ok 52: Test dwarf unwind : Ok 53: Test x86 instruction decoder - new instructions : Ok 54: Test intel cqm nmi context read : Skip # $ make -C tools/perf build-test make: Entering directory '/home/acme/git/linux/tools/perf' - tarpkg: ./tests/perf-targz-src-pkg . make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1 make_no_slang_O: make NO_SLANG=1 make_no_gtk2_O: make NO_GTK2=1 make_no_libperl_O: make NO_LIBPERL=1 make_no_libaudit_O: make NO_LIBAUDIT=1 make_with_babeltrace_O: make LIBBABELTRACE=1 make_no_newt_O: make NO_NEWT=1 make_util_map_o_O: make util/map.o make_pure_O: make make_no_libbpf_O: make NO_LIBBPF=1 make_doc_O: make doc make_no_libnuma_O: make NO_LIBNUMA=1 make_util_pmu_bison_o_O: make util/pmu-bison.o make_tags_O: make tags make_install_prefix_O: make install prefix=/tmp/krava make_no_demangle_O: make NO_DEMANGLE=1 make_no_libpython_O: make NO_LIBPYTHON=1 make_static_O: make LDFLAGS=-static make_debug_O: make DEBUG=1 make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1 make_install_prefix_slash_O: make install prefix=/tmp/krava/ make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1 make_no_auxtrace_O: make NO_AUXTRACE=1 make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1 make_perf_o_O: make perf.o make_no_libbionic_O: make NO_LIBBIONIC=1 make_clean_all_O: make clean all make_no_backtrace_O: make NO_BACKTRACE=1 make_install_O: make install make_no_libunwind_O: make NO_LIBUNWIND=1 make_install_bin_O: make install-bin make_no_libelf_O: make NO_LIBELF=1 make_help_O: make help OK make: Leaving directory '/home/acme/git/linux/tools/perf' $ ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2016-11-25 15:12 Arnaldo Carvalho de Melo @ 2016-11-25 17:14 ` Ingo Molnar 0 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2016-11-25 17:14 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, Alexei Starovoitov, Andi Kleen, Chris Riyder, David Ahern, Eric Leblond, He Kuang, Jiri Olsa, Kim Phillips, Markus Trippelsdorf, Masami Hiramatsu, Namhyung Kim, Naveen N . Rao, Pawel Moll, Peter Zijlstra, pi3orama, Ravi Bangoria, Russell King, Stephane Eranian, Taeung Song, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > Test results at the end of this message. > > The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2: > > Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125 > > for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5: > > tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > New features: > > - Improve ARM support in the annotation code, affecting 'perf annotate', 'perf > report' and live annotation in 'perf top' (Kim Phillips) > > - Initial support for PowerPC in the annotation code (Ravi Bangoria) > > - Skip repetitive scheduler function on the top of the stack in > 'perf sched timehist' (Namhyung Kim) > > Fixes: > > - Fix maps resolution in libbpf (Eric Leblond) > > - Get the kernel signature via /proc/version_signature, available on > ubuntu systems, to make sure bpf proggies works, as the one provided > via 'uname -r' doesn't (Wang Nan) > > - Fix segfault in 'perf record' when running with suid and kptr_restrict > is 1 (Wang Nan) > > Infrastructure: > > - Support per-arch instruction tables, kept via a static or dynamic table > (Arnaldo Carvalho de Melo) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (4): > perf annotate: Remove duplicate 'name' field from disasm_line > perf annotate: Introduce alternative method of keeping instructions table > perf annotate: Allow arches to have a init routine and a priv area > perf annotate: Improve support for ARM > > Eric Leblond (1): > tools lib bpf: Fix maps resolution > > Namhyung Kim (3): > perf callchain: Add option to skip ignore symbol when printing callchains > perf sched timehist: Mark schedule function in callchains > perf sched timehist: Enlarge max stack depth by 2 > > Ravi Bangoria (1): > perf annotate: Initial PowerPC support > > Wang Nan (3): > perf tools: Fix kernel version error in ubuntu > perf record: Fix segfault when running with suid and kptr_restrict is 1 > perf tools: Add missing struct definition in probe_event.h > > tools/lib/bpf/libbpf.c | 142 ++++++++++++++------- > tools/perf/arch/arm/annotate/instructions.c | 147 +++++++++------------- > tools/perf/arch/powerpc/annotate/instructions.c | 58 +++++++++ > tools/perf/builtin-sched.c | 26 +++- > tools/perf/ui/browsers/annotate.c | 18 +-- > tools/perf/util/annotate.c | 157 +++++++++++++++++------- > tools/perf/util/annotate.h | 17 ++- > tools/perf/util/evsel.h | 1 + > tools/perf/util/evsel_fprintf.c | 7 +- > tools/perf/util/probe-event.h | 2 + > tools/perf/util/symbol.c | 2 +- > tools/perf/util/symbol.h | 1 + > tools/perf/util/util.c | 55 ++++++++- > 13 files changed, 431 insertions(+), 202 deletions(-) > create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c > > Rebuilding containers, so limited coverage at this time: > # dm > 1 debian:experimental: Ok > 2 fedora:24: Ok > 3 fedora:24-x-ARC-uClibc: Ok > 4 fedora:rawhide: Ok > 5 opensuse:tumbleweed: Ok > > # perf test > 1: vmlinux symtab matches kallsyms : Ok > 2: detect openat syscall event : Ok > 3: detect openat syscall event on all cpus : Ok > 4: read samples using the mmap interface : Ok > 5: parse events tests : Ok > 6: Validate PERF_RECORD_* events & perf_sample fields : Ok > 7: Test perf pmu format parsing : Ok > 8: Test dso data read : Ok > 9: Test dso data cache : Ok > 10: Test dso data reopen : Ok > 11: roundtrip evsel->name check : Ok > 12: Check parsing of sched tracepoints fields : Ok > 13: Generate and check syscalls:sys_enter_openat event fields: Ok > 14: struct perf_event_attr setup : Ok > 15: Test matching and linking multiple hists : Ok > 16: Try 'import perf' in python, checking link problems : Ok > 17: Test breakpoint overflow signal handler : Ok > 18: Test breakpoint overflow sampling : Ok > 19: Test number of exit event of a simple workload : Ok > 20: Test software clock events have valid period values : Ok > 21: Test object code reading : Ok > 22: Test sample parsing : Ok > 23: Test using a dummy software event to keep tracking : Ok > 24: Test parsing with no sample_id_all bit set : Ok > 25: Test filtering hist entries : Ok > 26: Test mmap thread lookup : Ok > 27: Test thread mg sharing : Ok > 28: Test output sorting of hist entries : Ok > 29: Test cumulation of child hist entries : Ok > 30: Test tracking with sched_switch : Ok > 31: Filter fds with revents mask in a fdarray : Ok > 32: Add fd to a fdarray, making it autogrow : Ok > 33: Test kmod_path__parse function : Ok > 34: Test thread map : Ok > 35: Test LLVM searching and compiling : > 35.1: Basic BPF llvm compiling test : Ok > 35.2: Test kbuild searching : Ok > 35.3: Compile source for BPF prologue generation test : Ok > 35.4: Compile source for BPF relocation test : Ok > 36: Test topology in session : Ok > 37: Test BPF filter : > 37.1: Test basic BPF filtering : Ok > 37.2: Test BPF prologue generation : Ok > 37.3: Test BPF relocation checker : Ok > 38: Test thread map synthesize : Ok > 39: Test cpu map synthesize : Ok > 40: Test stat config synthesize : Ok > 41: Test stat synthesize : Ok > 42: Test stat round synthesize : Ok > 43: Test attr update synthesize : Ok > 44: Test events times : Ok > 45: Test backward reading from ring buffer : Ok > 46: Test cpu map print : Ok > 47: Test SDT event probing : Ok > 48: Test is_printable_array function : Ok > 49: Test bitmap print : Ok > 50: x86 rdpmc test : Ok > 51: Test converting perf time to TSC : Ok > 52: Test dwarf unwind : Ok > 53: Test x86 instruction decoder - new instructions : Ok > 54: Test intel cqm nmi context read : Skip > # > $ make -C tools/perf build-test > make: Entering directory '/home/acme/git/linux/tools/perf' > - tarpkg: ./tests/perf-targz-src-pkg . > make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1 > make_no_slang_O: make NO_SLANG=1 > make_no_gtk2_O: make NO_GTK2=1 > make_no_libperl_O: make NO_LIBPERL=1 > make_no_libaudit_O: make NO_LIBAUDIT=1 > make_with_babeltrace_O: make LIBBABELTRACE=1 > make_no_newt_O: make NO_NEWT=1 > make_util_map_o_O: make util/map.o > make_pure_O: make > make_no_libbpf_O: make NO_LIBBPF=1 > make_doc_O: make doc > make_no_libnuma_O: make NO_LIBNUMA=1 > make_util_pmu_bison_o_O: make util/pmu-bison.o > make_tags_O: make tags > make_install_prefix_O: make install prefix=/tmp/krava > make_no_demangle_O: make NO_DEMANGLE=1 > make_no_libpython_O: make NO_LIBPYTHON=1 > make_static_O: make LDFLAGS=-static > make_debug_O: make DEBUG=1 > make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1 > make_install_prefix_slash_O: make install prefix=/tmp/krava/ > make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1 > make_no_auxtrace_O: make NO_AUXTRACE=1 > make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1 > make_perf_o_O: make perf.o > make_no_libbionic_O: make NO_LIBBIONIC=1 > make_clean_all_O: make clean all > make_no_backtrace_O: make NO_BACKTRACE=1 > make_install_O: make install > make_no_libunwind_O: make NO_LIBUNWIND=1 > make_install_bin_O: make install-bin > make_no_libelf_O: make NO_LIBELF=1 > make_help_O: make help > OK > make: Leaving directory '/home/acme/git/linux/tools/perf' > $ Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes @ 2018-10-09 0:54 Arnaldo Carvalho de Melo 2018-10-09 5:24 ` Ingo Molnar 0 siblings, 1 reply; 41+ messages in thread From: Arnaldo Carvalho de Melo @ 2018-10-09 0:54 UTC (permalink / raw) To: Ingo Molnar Cc: Clark Williams, linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Sverdlin, David Ahern, Eduardo Habkost, Heiko Carstens, Hendrik Brueckner, Jiri Olsa, Joe Lawrence, linux trace devel, Martin Schwidefsky, Namhyung Kim, Ravi Bangoria, Sanskriti Sharma, Steven Rostedt, Thomas Richter, Tzvetomir Stoyanov, Wang Nan, Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo Test results at the end of this message, as usual. The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d: perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008 for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99: tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300) ---------------------------------------------------------------- perf/core improvements and fixes: . Fix building the python bindings with python3, which fixes some problems with building with clang on Clear Linux (Eduardo Habkost) . Fix coverity warnings, fixing up some error paths and plugging some temporary small buffer leaks (Sanskriti Sharma) . Adopt a wrapper for strerror_r() for the same reasons as recently for libbpf (Steven Rostedt) . S390 does not support watchpoints in 'perf test 22', check if that test is supported by the arch. (Thomas Richter) Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> ---------------------------------------------------------------- Arnaldo Carvalho de Melo (2): tools include: Adopt linux/bits.h perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG Eduardo Habkost (2): perf python: Make clang_has_option() work on Python 3 perf python: More portable way to make CFLAGS work with clang Sanskriti Sharma (5): perf strbuf: Match va_{add,copy} with va_end perf tools: Cleanup trace-event-info 'tdata' leak perf tools: Free 'printk' string in parse_ftrace_printk() perf tools: Avoid double free in read_event_file() perf tools: Free temporary 'sys' string in read_event_files() Steven Rostedt (VMware) (1): tools lib traceevent: Separate out tep_strerror() for strerror_r() issues Thomas Richter (1): perf test: S390 does not support watchpoints in test 22 Tzvetomir Stoyanov (1): tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file tools/include/linux/bitops.h | 7 +- tools/include/linux/bits.h | 26 +++ tools/lib/traceevent/Build | 2 + tools/lib/traceevent/event-parse-api.c | 275 +++++++++++++++++++++++++++++++ tools/lib/traceevent/event-parse-local.h | 92 +++++++++++ tools/lib/traceevent/event-parse.c | 32 +--- tools/lib/traceevent/event-parse.h | 228 ++++--------------------- tools/lib/traceevent/event-plugin.c | 1 + tools/lib/traceevent/parse-filter.c | 1 + tools/lib/traceevent/tep_strerror.c | 53 ++++++ tools/perf/check-headers.sh | 1 + tools/perf/tests/builtin-test.c | 1 + tools/perf/tests/tests.h | 1 + tools/perf/tests/wp.c | 12 ++ tools/perf/util/auxtrace.h | 1 + tools/perf/util/setup.py | 16 +- tools/perf/util/strbuf.c | 10 +- tools/perf/util/trace-event-info.c | 2 + tools/perf/util/trace-event-parse.c | 26 +-- tools/perf/util/trace-event-read.c | 11 +- 20 files changed, 539 insertions(+), 259 deletions(-) create mode 100644 tools/include/linux/bits.h create mode 100644 tools/lib/traceevent/event-parse-api.c create mode 100644 tools/lib/traceevent/event-parse-local.h create mode 100644 tools/lib/traceevent/tep_strerror.c Test results: The first ones are container (docker) based builds of tools/perf with and without libelf support. Where clang is available, it is also used to build perf with/without libelf, and building with LIBCLANGLLVM=1 (built-in clang) with gcc and clang when clang and its devel libraries are installed. The objtool and samples/bpf/ builds are disabled now that I'm switching from using the sources in a local volume to fetching them from a http server to build it inside the container, to make it easier to build in a container cluster. Those will come back later. Several are cross builds, the ones with -x-ARCH and the android one, and those may not have all the features built, due to lack of multi-arch devel packages, available and being used so far on just a few, like debian:experimental-x-{arm64,mipsel}. The 'perf test' one will perform a variety of tests exercising tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands with a variety of command line event specifications to then intercept the sys_perf_event syscall to check that the perf_event_attr fields are set up as expected, among a variety of other unit tests. Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/ with a variety of feature sets, exercising the build with an incomplete set of features as well as with a complete one. It is planned to have it run on each of the containers mentioned above, using some container orchestration infrastructure. Get in contact if interested in helping having this in place. The Clear Linux container is building with NO_CLANG=1, some problem preventing its use when building for python3 have been fixed, some more have been identified and the next builds will build in ClearLinux with both gcc and clang. This time around only gcc was used. # dm 1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0 2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822 3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0 4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0 5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0 6 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0 7 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 8 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) 9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55) 12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) 13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 14 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 8.2.1 20180502 15 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2 16 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2 17 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 18 debian:experimental : Ok gcc (Debian 8.2.0-7) 8.2.0 19 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0 20 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0 21 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0 22 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0 23 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7) 24 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) 25 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6) 26 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6) 27 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1) 28 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710 29 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) 30 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2) 31 fedora:27 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6) 32 fedora:28 : Ok gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5) 33 fedora:rawhide : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3) 34 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0 35 mageia:5 : Ok gcc (GCC) 4.9.2 36 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0 37 opensuse:13.2 : Ok gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064] 38 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5 39 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5 40 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5 41 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812] 42 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1) 43 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1) 44 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 45 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 46 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0 47 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609 48 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 49 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 50 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 51 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 52 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 53 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 54 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005 55 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0 56 ubuntu:18.04 : Ok gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 57 ubuntu:18.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0 58 ubuntu:18.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0 59 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 60 ubuntu:18.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 61 ubuntu:18.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 62 ubuntu:18.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 63 ubuntu:18.04-x-riscv64 : Ok riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 64 ubuntu:18.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 65 ubuntu:18.04-x-sh4 : Ok sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 66 ubuntu:18.04-x-sparc64 : Ok sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 67 ubuntu:18.10 : Ok gcc (Ubuntu 8.2.0-4ubuntu1) 8.2.0 # # uname -a Linux jouet 4.19.0-rc4-00022-gad3273d5f1b9 #1 SMP Mon Sep 17 17:18:22 -03 2018 x86_64 x86_64 x86_64 GNU/Linux # git log --oneline -1 bb3dd7e7c4d5 tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file # perf version --build-options perf version 4.19.rc5.gbb3dd7 dwarf: [ on ] # HAVE_DWARF_SUPPORT dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT glibc: [ on ] # HAVE_GLIBC_SUPPORT gtk2: [ on ] # HAVE_GTK2_SUPPORT syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT libbfd: [ on ] # HAVE_LIBBFD_SUPPORT libelf: [ on ] # HAVE_LIBELF_SUPPORT libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT libperl: [ on ] # HAVE_LIBPERL_SUPPORT libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT libslang: [ on ] # HAVE_SLANG_SUPPORT libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT zlib: [ on ] # HAVE_ZLIB_SUPPORT lzma: [ on ] # HAVE_LZMA_SUPPORT get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT bpf: [ on ] # HAVE_LIBBPF_SUPPORT # perf test 1: vmlinux symtab matches kallsyms : Ok 2: Detect openat syscall event : Ok 3: Detect openat syscall event on all cpus : Ok 4: Read samples using the mmap interface : Ok 5: Test data source output : Ok 6: Parse event definition strings : Ok 7: Simple expression parser : Ok 8: PERF_RECORD_* events & perf_sample fields : Ok 9: Parse perf pmu format : Ok 10: DSO data read : Ok 11: DSO data cache : Ok 12: DSO data reopen : Ok 13: Roundtrip evsel->name : Ok 14: Parse sched tracepoints fields : Ok 15: syscalls:sys_enter_openat event fields : Ok 16: Setup struct perf_event_attr : Ok 17: Match and link multiple hists : Ok 18: 'import perf' in python : Ok 19: Breakpoint overflow signal handler : Ok 20: Breakpoint overflow sampling : Ok 21: Breakpoint accounting : Ok 22: Watchpoint : 22.1: Read Only Watchpoint : Skip 22.2: Write Only Watchpoint : Ok 22.3: Read / Write Watchpoint : Ok 22.4: Modify Watchpoint : Ok 23: Number of exit events of a simple workload : Ok 24: Software clock events period values : Ok 25: Object code reading : Ok 26: Sample parsing : Ok 27: Use a dummy software event to keep tracking : Ok 28: Parse with no sample_id_all bit set : Ok 29: Filter hist entries : Ok 30: Lookup mmap thread : Ok 31: Share thread mg : Ok 32: Sort output of hist entries : Ok 33: Cumulate child hist entries : Ok 34: Track with sched_switch : Ok 35: Filter fds with revents mask in a fdarray : Ok 36: Add fd to a fdarray, making it autogrow : Ok 37: kmod_path__parse : Ok 38: Thread map : Ok 39: LLVM search and compile : 39.1: Basic BPF llvm compile : Ok 39.2: kbuild searching : Ok 39.3: Compile source for BPF prologue generation : Ok 39.4: Compile source for BPF relocation : Ok 40: Session topology : Ok 41: BPF filter : 41.1: Basic BPF filtering : Ok 41.2: BPF pinning : Ok 41.3: BPF prologue generation : Ok 41.4: BPF relocation checker : Ok 42: Synthesize thread map : Ok 43: Remove thread map : Ok 44: Synthesize cpu map : Ok 45: Synthesize stat config : Ok 46: Synthesize stat : Ok 47: Synthesize stat round : Ok 48: Synthesize attr update : Ok 49: Event times : Ok 50: Read backward ring buffer : Ok 51: Print cpu map : Ok 52: Probe SDT events : Ok 53: is_printable_array : Ok 54: Print bitmap : Ok 55: perf hooks : Ok 56: builtin clang support : Skip (not compiled in) 57: unit_number__scnprintf : Ok 58: mem2node : Ok 59: x86 rdpmc : Ok 60: Convert perf time to TSC : Ok 61: DWARF unwind : Ok 62: x86 instruction decoder - new instructions : Ok 63: x86 bp modify : Ok 64: Use vfs_getname probe to get syscall args filenames : Ok 65: Check open filename arg using perf trace + vfs_getname: Ok 66: probe libc's inet_pton & backtrace it with ping : Ok 67: Add vfs_getname probe to get syscall args filenames : Ok $ make -C tools/perf build-test make: Entering directory '/home/acme/git/perf/tools/perf' - tarpkg: ./tests/perf-targz-src-pkg . make_install_bin_O: make install-bin make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1 make_no_gtk2_O: make NO_GTK2=1 make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1 make_install_O: make install make_no_backtrace_O: make NO_BACKTRACE=1 make_no_newt_O: make NO_NEWT=1 make_no_libperl_O: make NO_LIBPERL=1 make_util_map_o_O: make util/map.o make_clean_all_O: make clean all make_static_O: make LDFLAGS=-static make_util_pmu_bison_o_O: make util/pmu-bison.o make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1 make_doc_O: make doc make_no_libelf_O: make NO_LIBELF=1 make_pure_O: make make_no_auxtrace_O: make NO_AUXTRACE=1 make_perf_o_O: make perf.o make_tags_O: make tags make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1 make_no_libbpf_O: make NO_LIBBPF=1 make_no_libpython_O: make NO_LIBPYTHON=1 make_no_libaudit_O: make NO_LIBAUDIT=1 make_with_babeltrace_O: make LIBBABELTRACE=1 make_install_prefix_slash_O: make install prefix=/tmp/krava/ make_no_libnuma_O: make NO_LIBNUMA=1 make_with_clangllvm_O: make LIBCLANGLLVM=1 make_debug_O: make DEBUG=1 make_no_libunwind_O: make NO_LIBUNWIND=1 make_no_libbionic_O: make NO_LIBBIONIC=1 make_no_slang_O: make NO_SLANG=1 make_help_O: make help make_no_demangle_O: make NO_DEMANGLE=1 make_install_prefix_O: make install prefix=/tmp/krava OK make: Leaving directory '/home/acme/git/perf/tools/perf' $ ^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes 2018-10-09 0:54 Arnaldo Carvalho de Melo @ 2018-10-09 5:24 ` Ingo Molnar 0 siblings, 0 replies; 41+ messages in thread From: Ingo Molnar @ 2018-10-09 5:24 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter, Alexander Sverdlin, David Ahern, Eduardo Habkost, Heiko Carstens, Hendrik Brueckner, Jiri Olsa, Joe Lawrence, linux trace devel, Martin Schwidefsky, Namhyung Kim, Ravi Bangoria, Sanskriti Sharma, Steven Rostedt, Thomas Richter, Tzvetomir Stoyanov, Wang Nan, Arnaldo Carvalho de Melo * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > Test results at the end of this message, as usual. > > The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d: > > perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008 > > for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99: > > tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > . Fix building the python bindings with python3, which fixes some > problems with building with clang on Clear Linux (Eduardo Habkost) > > . Fix coverity warnings, fixing up some error paths and plugging > some temporary small buffer leaks (Sanskriti Sharma) > > . Adopt a wrapper for strerror_r() for the same reasons as recently > for libbpf (Steven Rostedt) > > . S390 does not support watchpoints in 'perf test 22', check if > that test is supported by the arch. (Thomas Richter) > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (2): > tools include: Adopt linux/bits.h > perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG > > Eduardo Habkost (2): > perf python: Make clang_has_option() work on Python 3 > perf python: More portable way to make CFLAGS work with clang > > Sanskriti Sharma (5): > perf strbuf: Match va_{add,copy} with va_end > perf tools: Cleanup trace-event-info 'tdata' leak > perf tools: Free 'printk' string in parse_ftrace_printk() > perf tools: Avoid double free in read_event_file() > perf tools: Free temporary 'sys' string in read_event_files() > > Steven Rostedt (VMware) (1): > tools lib traceevent: Separate out tep_strerror() for strerror_r() issues > > Thomas Richter (1): > perf test: S390 does not support watchpoints in test 22 > > Tzvetomir Stoyanov (1): > tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file > > tools/include/linux/bitops.h | 7 +- > tools/include/linux/bits.h | 26 +++ > tools/lib/traceevent/Build | 2 + > tools/lib/traceevent/event-parse-api.c | 275 +++++++++++++++++++++++++++++++ > tools/lib/traceevent/event-parse-local.h | 92 +++++++++++ > tools/lib/traceevent/event-parse.c | 32 +--- > tools/lib/traceevent/event-parse.h | 228 ++++--------------------- > tools/lib/traceevent/event-plugin.c | 1 + > tools/lib/traceevent/parse-filter.c | 1 + > tools/lib/traceevent/tep_strerror.c | 53 ++++++ > tools/perf/check-headers.sh | 1 + > tools/perf/tests/builtin-test.c | 1 + > tools/perf/tests/tests.h | 1 + > tools/perf/tests/wp.c | 12 ++ > tools/perf/util/auxtrace.h | 1 + > tools/perf/util/setup.py | 16 +- > tools/perf/util/strbuf.c | 10 +- > tools/perf/util/trace-event-info.c | 2 + > tools/perf/util/trace-event-parse.c | 26 +-- > tools/perf/util/trace-event-read.c | 11 +- > 20 files changed, 539 insertions(+), 259 deletions(-) > create mode 100644 tools/include/linux/bits.h > create mode 100644 tools/lib/traceevent/event-parse-api.c > create mode 100644 tools/lib/traceevent/event-parse-local.h > create mode 100644 tools/lib/traceevent/tep_strerror.c Pulled, thanks a lot Arnaldo! Ingo ^ permalink raw reply [flat|nested] 41+ messages in thread
end of thread, other threads:[~2018-10-09 5:25 UTC | newest] Thread overview: 41+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-10-24 21:50 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 01/12] perf tools: Diplays more output on features check for make V=1 Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 02/12] perf tools: Remove noise in python version feature test Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 03/12] perf tools: Try to find cross-built objdump path Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 04/12] Account the nr_entries in rblist properly Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 05/12] perf tools: Give user better message if precise is not supported Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 06/12] perf test: Align the 'Ok'/'FAILED!' test results Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 07/12] perf trace: Support interrupted syscalls Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 08/12] perf trace: Add an event duration column Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 09/12] perf trace: Add duration filter Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 10/12] perf tools: Pretty print errno for some more functions Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 11/12] perf trace: Print the name of a syscall when failing to read its info Arnaldo Carvalho de Melo 2012-10-24 21:50 ` [PATCH 12/12] perf tools: Try to build Documentation when installing Arnaldo Carvalho de Melo 2012-10-25 2:09 ` Namhyung Kim 2012-10-25 7:43 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar 2013-12-02 20:48 Arnaldo Carvalho de Melo 2013-12-04 9:18 ` Ingo Molnar 2014-02-24 19:56 Arnaldo Carvalho de Melo 2014-02-27 11:46 ` Ingo Molnar 2014-02-27 12:02 ` Jiri Olsa 2014-02-27 12:30 ` Ingo Molnar 2014-02-27 12:40 ` Jiri Olsa 2014-02-27 12:45 ` Ingo Molnar 2014-02-27 12:04 ` Jiri Olsa 2014-11-25 13:21 Arnaldo Carvalho de Melo 2015-08-05 20:11 Arnaldo Carvalho de Melo 2015-10-28 15:30 Arnaldo Carvalho de Melo 2015-10-29 9:36 ` Ingo Molnar 2015-10-29 9:51 ` Ingo Molnar 2015-10-29 9:55 ` Jiri Olsa 2015-11-05 16:02 Arnaldo Carvalho de Melo 2016-05-17 2:45 Arnaldo Carvalho de Melo 2016-05-20 6:23 ` Ingo Molnar 2016-05-30 19:24 Arnaldo Carvalho de Melo 2016-05-31 7:24 ` Ingo Molnar 2016-09-08 20:46 Arnaldo Carvalho de Melo 2016-09-09 5:47 ` Ingo Molnar 2016-11-25 15:12 Arnaldo Carvalho de Melo 2016-11-25 17:14 ` Ingo Molnar 2018-10-09 0:54 Arnaldo Carvalho de Melo 2018-10-09 5:24 ` Ingo Molnar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).