* [GIT PULL 00/12] perf/core improvements and fixes
@ 2016-05-30 19:24 Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 01/12] perf thread: Adopt get_main_thread from db-export.c Arnaldo Carvalho de Melo
` (12 more replies)
0 siblings, 13 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov,
Ananth N Mavinakayanahalli, Andi Kleen, Brendan Gregg,
David Ahern, Frederic Weisbecker, He Kuang, Hemant Kumar,
Jiri Olsa, Linus Torvalds, Masami Hiramatsu, Milian Wolff,
Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian,
Taeung Song, Thomas Gleixner, Vince Weaver, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f:
Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530
for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6:
perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible/kernel ABI:
- Per event callchain limit: Recently we introduced a sysctl to tune the
max-stack for all events for which callchains were requested:
$ sysctl kernel.perf_event_max_stack
kernel.perf_event_max_stack = 127
Now this patch introduces a way to configure this per event, i.e. this
becomes possible:
$ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a
allowing finer tuning of how much buffer space callchains use.
This uses an u16 from the reserved space at the end, leaving another
u16 for future use.
There has been interest in even finer tuning, namely to control the
max stack for kernel and userspace callchains separately. Further
discussion is needed, we may for instance use the remaining u16 for
that and when it is present, assume that the sample_max_stack introduced
in this patch applies for the kernel, and the u16 left is used for
limiting the userspace callchain. (Arnaldo Carvalho de Melo)
Infrastructure:
- Adopt get_main_thread from db-export.c (Andi Kleen)
- More prep work for backward ring buffer support (Wang Nan)
- Prep work for supporting SDT (Statically Defined Tracing)
tracepoints (Masami Hiramatsu)
- Add arch/*/include/generated/ to .gitignore (Taeung Song)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf thread: Adopt get_main_thread from db-export.c
Arnaldo Carvalho de Melo (2):
perf core: Per event callchain limit
perf tools: Per event max-stack settings
Masami Hiramatsu (3):
perf symbols: Introduce filename__readable to check readability
perf symbols: Cleanup the code flow of dso__find_kallsyms
perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
Taeung Song (1):
perf tools: Add arch/*/include/generated/ to .gitignore
Wang Nan (5):
perf record: Robustify perf_event__synth_time_conv()
perf evlist: Don't poll and mmap overwritable events
perf evlist: Check 'base' pointer before checking refcnt when put a mmap
perf evlist: Choose correct reading direction according to evlist->backward
tools: Pass arg to fdarray__filter's call back function
include/linux/perf_event.h | 2 +-
include/uapi/linux/perf_event.h | 6 ++-
kernel/bpf/stackmap.c | 2 +-
kernel/events/callchain.c | 14 ++++-
kernel/events/core.c | 5 +-
tools/lib/api/fd/array.c | 5 +-
tools/lib/api/fd/array.h | 3 +-
tools/perf/.gitignore | 1 +
tools/perf/arch/x86/util/tsc.c | 2 +
tools/perf/builtin-record.c | 9 +++-
tools/perf/tests/fdarray.c | 8 +--
tools/perf/util/build-id.c | 115 ++++++++++++++++++++++++++++++----------
tools/perf/util/build-id.h | 2 +
tools/perf/util/callchain.h | 1 +
tools/perf/util/db-export.c | 13 +----
tools/perf/util/dso.h | 5 ++
tools/perf/util/evlist.c | 43 +++++++++++----
tools/perf/util/evlist.h | 2 +
tools/perf/util/evsel.c | 16 +++++-
tools/perf/util/evsel.h | 2 +
tools/perf/util/parse-events.c | 8 +++
tools/perf/util/parse-events.h | 1 +
tools/perf/util/parse-events.l | 1 +
tools/perf/util/session.c | 2 +
tools/perf/util/symbol.c | 71 ++++++++++++-------------
tools/perf/util/thread.c | 11 ++++
tools/perf/util/thread.h | 2 +
27 files changed, 252 insertions(+), 100 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 01/12] perf thread: Adopt get_main_thread from db-export.c
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 02/12] perf core: Per event callchain limit Arnaldo Carvalho de Melo
` (11 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Andi Kleen, Jiri Olsa, Arnaldo Carvalho de Melo
From: Andi Kleen <ak@linux.intel.com>
Move the get_main_thread function from db-export.c to thread.c so that
it can be used elsewhere.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1464051145-19968-2-git-send-email-andi@firstfloor.org
[ Removed leftover bits from db-export.h ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/db-export.c | 13 +------------
tools/perf/util/thread.c | 11 +++++++++++
tools/perf/util/thread.h | 2 ++
3 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c
index c9a6dc173e74..b0c2b5c5d337 100644
--- a/tools/perf/util/db-export.c
+++ b/tools/perf/util/db-export.c
@@ -233,17 +233,6 @@ int db_export__symbol(struct db_export *dbe, struct symbol *sym,
return 0;
}
-static struct thread *get_main_thread(struct machine *machine, struct thread *thread)
-{
- if (thread->pid_ == thread->tid)
- return thread__get(thread);
-
- if (thread->pid_ == -1)
- return NULL;
-
- return machine__find_thread(machine, thread->pid_, thread->pid_);
-}
-
static int db_ids_from_al(struct db_export *dbe, struct addr_location *al,
u64 *dso_db_id, u64 *sym_db_id, u64 *offset)
{
@@ -382,7 +371,7 @@ int db_export__sample(struct db_export *dbe, union perf_event *event,
if (err)
return err;
- main_thread = get_main_thread(al->machine, thread);
+ main_thread = thread__main_thread(al->machine, thread);
if (main_thread)
comm = machine__thread_exec_comm(al->machine, main_thread);
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 45fcb715a36b..ada58e6070bf 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -265,3 +265,14 @@ void thread__find_cpumode_addr_location(struct thread *thread,
break;
}
}
+
+struct thread *thread__main_thread(struct machine *machine, struct thread *thread)
+{
+ if (thread->pid_ == thread->tid)
+ return thread__get(thread);
+
+ if (thread->pid_ == -1)
+ return NULL;
+
+ return machine__find_thread(machine, thread->pid_, thread->pid_);
+}
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
index 45fba13c800b..08fcb14cf637 100644
--- a/tools/perf/util/thread.h
+++ b/tools/perf/util/thread.h
@@ -81,6 +81,8 @@ void thread__insert_map(struct thread *thread, struct map *map);
int thread__fork(struct thread *thread, struct thread *parent, u64 timestamp);
size_t thread__fprintf(struct thread *thread, FILE *fp);
+struct thread *thread__main_thread(struct machine *machine, struct thread *thread);
+
void thread__find_addr_map(struct thread *thread,
u8 cpumode, enum map_type type, u64 addr,
struct addr_location *al);
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 02/12] perf core: Per event callchain limit
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 01/12] perf thread: Adopt get_main_thread from db-export.c Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 03/12] perf tools: Per event max-stack settings Arnaldo Carvalho de Melo
` (10 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov, Brendan Gregg,
David Ahern, Frederic Weisbecker, He Kuang, Jiri Olsa,
Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim,
Peter Zijlstra, Stephane Eranian, Thomas Gleixner, Vince Weaver,
Wang Nan, Zefan Li
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Additionally to being able to control the system wide maximum depth via
/proc/sys/kernel/perf_event_max_stack, now we are able to ask for
different depths per event, using perf_event_attr.sample_max_stack for
that.
This uses an u16 hole at the end of perf_event_attr, that, when
perf_event_attr.sample_type has the PERF_SAMPLE_CALLCHAIN, if
sample_max_stack is zero, means use perf_event_max_stack, otherwise
it'll be bounds checked under callchain_mutex.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: Zefan Li <lizefan@huawei.com>
Link: http://lkml.kernel.org/n/tip-kolmn1yo40p7jhswxwrc7rrd@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
include/linux/perf_event.h | 2 +-
include/uapi/linux/perf_event.h | 6 +++++-
kernel/bpf/stackmap.c | 2 +-
kernel/events/callchain.c | 14 ++++++++++++--
kernel/events/core.c | 5 ++++-
5 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 6b87be908790..0e43355c7aad 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -1076,7 +1076,7 @@ extern void perf_callchain_kernel(struct perf_callchain_entry_ctx *entry, struct
extern struct perf_callchain_entry *
get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user,
u32 max_stack, bool crosstask, bool add_mark);
-extern int get_callchain_buffers(void);
+extern int get_callchain_buffers(int max_stack);
extern void put_callchain_buffers(void);
extern int sysctl_perf_event_max_stack;
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 36ce552cf6a9..c66a485a24ac 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -276,6 +276,9 @@ enum perf_event_read_format {
/*
* Hardware event_id to monitor via a performance monitoring event:
+ *
+ * @sample_max_stack: Max number of frame pointers in a callchain,
+ * should be < /proc/sys/kernel/perf_event_max_stack
*/
struct perf_event_attr {
@@ -385,7 +388,8 @@ struct perf_event_attr {
* Wakeup watermark for AUX area
*/
__u32 aux_watermark;
- __u32 __reserved_2; /* align to __u64 */
+ __u16 sample_max_stack;
+ __u16 __reserved_2; /* align to __u64 */
};
#define perf_flags(attr) (*(&(attr)->read_format + 1))
diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
index a82d7605db3f..f1de5c1a2af6 100644
--- a/kernel/bpf/stackmap.c
+++ b/kernel/bpf/stackmap.c
@@ -99,7 +99,7 @@ static struct bpf_map *stack_map_alloc(union bpf_attr *attr)
if (err)
goto free_smap;
- err = get_callchain_buffers();
+ err = get_callchain_buffers(sysctl_perf_event_max_stack);
if (err)
goto free_smap;
diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
index 179ef4640964..e9fdb5203de5 100644
--- a/kernel/events/callchain.c
+++ b/kernel/events/callchain.c
@@ -104,7 +104,7 @@ fail:
return -ENOMEM;
}
-int get_callchain_buffers(void)
+int get_callchain_buffers(int event_max_stack)
{
int err = 0;
int count;
@@ -121,6 +121,15 @@ int get_callchain_buffers(void)
/* If the allocation failed, give up */
if (!callchain_cpus_entries)
err = -ENOMEM;
+ /*
+ * If requesting per event more than the global cap,
+ * return a different error to help userspace figure
+ * this out.
+ *
+ * And also do it here so that we have &callchain_mutex held.
+ */
+ if (event_max_stack > sysctl_perf_event_max_stack)
+ err = -EOVERFLOW;
goto exit;
}
@@ -174,11 +183,12 @@ perf_callchain(struct perf_event *event, struct pt_regs *regs)
bool user = !event->attr.exclude_callchain_user;
/* Disallow cross-task user callchains. */
bool crosstask = event->ctx->task && event->ctx->task != current;
+ const u32 max_stack = event->attr.sample_max_stack;
if (!kernel && !user)
return NULL;
- return get_perf_callchain(regs, 0, kernel, user, sysctl_perf_event_max_stack, crosstask, true);
+ return get_perf_callchain(regs, 0, kernel, user, max_stack, crosstask, true);
}
struct perf_callchain_entry *
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 050a290c72c7..79363f298445 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8843,7 +8843,7 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
if (!event->parent) {
if (event->attr.sample_type & PERF_SAMPLE_CALLCHAIN) {
- err = get_callchain_buffers();
+ err = get_callchain_buffers(attr->sample_max_stack);
if (err)
goto err_addr_filters;
}
@@ -9165,6 +9165,9 @@ SYSCALL_DEFINE5(perf_event_open,
return -EINVAL;
}
+ if (!attr.sample_max_stack)
+ attr.sample_max_stack = sysctl_perf_event_max_stack;
+
/*
* In cgroup mode, the pid argument is used to pass the fd
* opened to the cgroup directory in cgroupfs. The cpu argument
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 03/12] perf tools: Per event max-stack settings
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 01/12] perf thread: Adopt get_main_thread from db-export.c Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 02/12] perf core: Per event callchain limit Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 04/12] perf record: Robustify perf_event__synth_time_conv() Arnaldo Carvalho de Melo
` (9 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov, Brendan Gregg,
David Ahern, Frederic Weisbecker, He Kuang, Jiri Olsa,
Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim,
Peter Zijlstra, Stephane Eranian, Thomas Gleixner, Vince Weaver,
Wang Nan, Zefan Li
From: Arnaldo Carvalho de Melo <acme@redhat.com>
The tooling counterpart, now it is possible to do:
# perf record -e sched:sched_switch/max-stack=10/ -e cycles/call-graph=dwarf,max-stack=4/ -e cpu-cycles/call-graph=dwarf,max-stack=1024/ usleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.052 MB perf.data (5 samples) ]
# perf evlist -v
sched:sched_switch: type: 2, size: 112, config: 0x110, { sample_period, sample_freq }: 1, sample_type: IP|TID|TIME|CALLCHAIN|CPU|PERIOD|RAW|IDENTIFIER, read_format: ID, disabled: 1, inherit: 1, mmap: 1, comm: 1, enable_on_exec: 1, task: 1, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1, sample_max_stack: 10
cycles/call-graph=dwarf,max-stack=4/: size: 112, { sample_period, sample_freq }: 4000, sample_type: IP|TID|TIME|CALLCHAIN|PERIOD|REGS_USER|STACK_USER|IDENTIFIER, read_format: ID, disabled: 1, inherit: 1, freq: 1, enable_on_exec: 1, sample_id_all: 1, exclude_guest: 1, exclude_callchain_user: 1, sample_regs_user: 0xff0fff, sample_stack_user: 8192, sample_max_stack: 4
cpu-cycles/call-graph=dwarf,max-stack=1024/: size: 112, { sample_period, sample_freq }: 4000, sample_type: IP|TID|TIME|CALLCHAIN|PERIOD|REGS_USER|STACK_USER|IDENTIFIER, read_format: ID, disabled: 1, inherit: 1, freq: 1, enable_on_exec: 1, sample_id_all: 1, exclude_guest: 1, exclude_callchain_user: 1, sample_regs_user: 0xff0fff, sample_stack_user: 8192, sample_max_stack: 1024
# Tip: use 'perf evlist --trace-fields' to show fields for tracepoint events
Using just /max-stack=N/ means /call-graph=fp,max-stack=N/, that should
be further configurable by means of some .perfconfig knob.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: Zefan Li <lizefan@huawei.com>
Link: http://lkml.kernel.org/n/tip-kolmn1yo40p7jhswxwrc7rrd@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/callchain.h | 1 +
tools/perf/util/evsel.c | 16 ++++++++++++++--
tools/perf/util/evsel.h | 2 ++
tools/perf/util/parse-events.c | 8 ++++++++
tools/perf/util/parse-events.h | 1 +
tools/perf/util/parse-events.l | 1 +
tools/perf/util/session.c | 2 ++
7 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 65e2a4f7cb4e..a70f6b54eb92 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -94,6 +94,7 @@ struct callchain_param {
enum perf_call_graph_mode record_mode;
u32 dump_size;
enum chain_mode mode;
+ u16 max_stack;
u32 print_limit;
double min_percent;
sort_chain_func_t sort;
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 02c177d14c8d..245ac503f211 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -572,6 +572,8 @@ void perf_evsel__config_callchain(struct perf_evsel *evsel,
perf_evsel__set_sample_bit(evsel, CALLCHAIN);
+ attr->sample_max_stack = param->max_stack;
+
if (param->record_mode == CALLCHAIN_LBR) {
if (!opts->branch_stack) {
if (attr->exclude_user) {
@@ -635,7 +637,8 @@ static void apply_config_terms(struct perf_evsel *evsel,
struct perf_event_attr *attr = &evsel->attr;
struct callchain_param param;
u32 dump_size = 0;
- char *callgraph_buf = NULL;
+ int max_stack = 0;
+ const char *callgraph_buf = NULL;
/* callgraph default */
param.record_mode = callchain_param.record_mode;
@@ -662,6 +665,9 @@ static void apply_config_terms(struct perf_evsel *evsel,
case PERF_EVSEL__CONFIG_TERM_STACK_USER:
dump_size = term->val.stack_user;
break;
+ case PERF_EVSEL__CONFIG_TERM_MAX_STACK:
+ max_stack = term->val.max_stack;
+ break;
case PERF_EVSEL__CONFIG_TERM_INHERIT:
/*
* attr->inherit should has already been set by
@@ -677,7 +683,12 @@ static void apply_config_terms(struct perf_evsel *evsel,
}
/* User explicitly set per-event callgraph, clear the old setting and reset. */
- if ((callgraph_buf != NULL) || (dump_size > 0)) {
+ if ((callgraph_buf != NULL) || (dump_size > 0) || max_stack) {
+ if (max_stack) {
+ param.max_stack = max_stack;
+ if (callgraph_buf == NULL)
+ callgraph_buf = "fp";
+ }
/* parse callgraph parameters */
if (callgraph_buf != NULL) {
@@ -1329,6 +1340,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
PRINT_ATTRf(clockid, p_signed);
PRINT_ATTRf(sample_regs_intr, p_hex);
PRINT_ATTRf(aux_watermark, p_unsigned);
+ PRINT_ATTRf(sample_max_stack, p_unsigned);
return ret;
}
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index c1f10159804c..028412b32d5a 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -44,6 +44,7 @@ enum {
PERF_EVSEL__CONFIG_TERM_CALLGRAPH,
PERF_EVSEL__CONFIG_TERM_STACK_USER,
PERF_EVSEL__CONFIG_TERM_INHERIT,
+ PERF_EVSEL__CONFIG_TERM_MAX_STACK,
PERF_EVSEL__CONFIG_TERM_MAX,
};
@@ -56,6 +57,7 @@ struct perf_evsel_config_term {
bool time;
char *callgraph;
u64 stack_user;
+ int max_stack;
bool inherit;
} val;
};
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index bcbc983d4b12..89d40bb425e1 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -900,6 +900,7 @@ static const char *config_term_names[__PARSE_EVENTS__TERM_TYPE_NR] = {
[PARSE_EVENTS__TERM_TYPE_STACKSIZE] = "stack-size",
[PARSE_EVENTS__TERM_TYPE_NOINHERIT] = "no-inherit",
[PARSE_EVENTS__TERM_TYPE_INHERIT] = "inherit",
+ [PARSE_EVENTS__TERM_TYPE_MAX_STACK] = "max-stack",
};
static bool config_term_shrinked;
@@ -995,6 +996,9 @@ do { \
case PARSE_EVENTS__TERM_TYPE_NAME:
CHECK_TYPE_VAL(STR);
break;
+ case PARSE_EVENTS__TERM_TYPE_MAX_STACK:
+ CHECK_TYPE_VAL(NUM);
+ break;
default:
err->str = strdup("unknown term");
err->idx = term->err_term;
@@ -1040,6 +1044,7 @@ static int config_term_tracepoint(struct perf_event_attr *attr,
case PARSE_EVENTS__TERM_TYPE_STACKSIZE:
case PARSE_EVENTS__TERM_TYPE_INHERIT:
case PARSE_EVENTS__TERM_TYPE_NOINHERIT:
+ case PARSE_EVENTS__TERM_TYPE_MAX_STACK:
return config_term_common(attr, term, err);
default:
if (err) {
@@ -1109,6 +1114,9 @@ do { \
case PARSE_EVENTS__TERM_TYPE_NOINHERIT:
ADD_CONFIG_TERM(INHERIT, inherit, term->val.num ? 0 : 1);
break;
+ case PARSE_EVENTS__TERM_TYPE_MAX_STACK:
+ ADD_CONFIG_TERM(MAX_STACK, max_stack, term->val.num);
+ break;
default:
break;
}
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
index d740c3ca9a1d..46c05ccd5dfe 100644
--- a/tools/perf/util/parse-events.h
+++ b/tools/perf/util/parse-events.h
@@ -68,6 +68,7 @@ enum {
PARSE_EVENTS__TERM_TYPE_STACKSIZE,
PARSE_EVENTS__TERM_TYPE_NOINHERIT,
PARSE_EVENTS__TERM_TYPE_INHERIT,
+ PARSE_EVENTS__TERM_TYPE_MAX_STACK,
__PARSE_EVENTS__TERM_TYPE_NR,
};
diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index 1477fbc78993..01af1ee90a27 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -199,6 +199,7 @@ branch_type { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_BRANCH_SAMPLE_TYPE
time { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_TIME); }
call-graph { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_CALLGRAPH); }
stack-size { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_STACKSIZE); }
+max-stack { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_MAX_STACK); }
inherit { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_INHERIT); }
no-inherit { return term(yyscanner, PARSE_EVENTS__TERM_TYPE_NOINHERIT); }
, { return ','; }
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 2335b2824d8a..43d30ea87b7e 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -593,6 +593,7 @@ do { \
if (bswap_safe(f, 0)) \
attr->f = bswap_##sz(attr->f); \
} while(0)
+#define bswap_field_16(f) bswap_field(f, 16)
#define bswap_field_32(f) bswap_field(f, 32)
#define bswap_field_64(f) bswap_field(f, 64)
@@ -608,6 +609,7 @@ do { \
bswap_field_64(sample_regs_user);
bswap_field_32(sample_stack_user);
bswap_field_32(aux_watermark);
+ bswap_field_16(sample_max_stack);
/*
* After read_format are bitfields. Check read_format because
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 04/12] perf record: Robustify perf_event__synth_time_conv()
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 03/12] perf tools: Per event max-stack settings Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 05/12] perf evlist: Don't poll and mmap overwritable events Arnaldo Carvalho de Melo
` (8 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Zefan Li, pi3orama, He Kuang,
Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
It is possible that all events in an evlist are overwritable.
perf_event__synth_time_conv() should not crash in this case.
record__pick_pc() is used to check avaliability.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1464056944-166978-3-git-send-email-wangnan0@huawei.com
Signed-off-by: He Kuang <hekuang@huawei.com>
[ Split from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/arch/x86/util/tsc.c | 2 ++
tools/perf/builtin-record.c | 9 ++++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/perf/arch/x86/util/tsc.c b/tools/perf/arch/x86/util/tsc.c
index 357f1b13b5ae..2e5567c94e09 100644
--- a/tools/perf/arch/x86/util/tsc.c
+++ b/tools/perf/arch/x86/util/tsc.c
@@ -62,6 +62,8 @@ int perf_event__synth_time_conv(const struct perf_event_mmap_page *pc,
struct perf_tsc_conversion tc;
int err;
+ if (!pc)
+ return 0;
err = perf_read_tsc_conversion(pc, &tc);
if (err == -EOPNOTSUPP)
return 0;
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index dc3fcb597e4c..d4cf1b0c88f9 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -655,6 +655,13 @@ perf_event__synth_time_conv(const struct perf_event_mmap_page *pc __maybe_unused
return 0;
}
+static const struct perf_event_mmap_page *record__pick_pc(struct record *rec)
+{
+ if (rec->evlist && rec->evlist->mmap && rec->evlist->mmap[0].base)
+ return rec->evlist->mmap[0].base;
+ return NULL;
+}
+
static int record__synthesize(struct record *rec)
{
struct perf_session *session = rec->session;
@@ -692,7 +699,7 @@ static int record__synthesize(struct record *rec)
}
}
- err = perf_event__synth_time_conv(rec->evlist->mmap[0].base, tool,
+ err = perf_event__synth_time_conv(record__pick_pc(rec), tool,
process_synthesized_event, machine);
if (err)
goto out;
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 05/12] perf evlist: Don't poll and mmap overwritable events
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 04/12] perf record: Robustify perf_event__synth_time_conv() Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 06/12] perf evlist: Check 'base' pointer before checking refcnt when put a mmap Arnaldo Carvalho de Melo
` (7 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Zefan Li, pi3orama, He Kuang,
Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
There's no need to receive events from overwritable ring buffer.
Instead, perf should make them run in background until some external
event of interest takes place. This patch makes ignores normal events from
overwrite evlists.
Overwritable events must be mapped readonly and backward, so if evlist
and evsel doesn't match (evsel->overwrite is true but either evlist is
read/write or evlist is not backward, and vice versa), skip mapping it.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1464056944-166978-3-git-send-email-wangnan0@huawei.com
Signed-off-by: He Kuang <hekuang@huawei.com>
[ Split from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evlist.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index e82ba90cc969..50d7b80987c0 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -462,9 +462,9 @@ int perf_evlist__alloc_pollfd(struct perf_evlist *evlist)
return 0;
}
-static int __perf_evlist__add_pollfd(struct perf_evlist *evlist, int fd, int idx)
+static int __perf_evlist__add_pollfd(struct perf_evlist *evlist, int fd, int idx, short revent)
{
- int pos = fdarray__add(&evlist->pollfd, fd, POLLIN | POLLERR | POLLHUP);
+ int pos = fdarray__add(&evlist->pollfd, fd, revent | POLLERR | POLLHUP);
/*
* Save the idx so that when we filter out fds POLLHUP'ed we can
* close the associated evlist->mmap[] entry.
@@ -480,7 +480,7 @@ static int __perf_evlist__add_pollfd(struct perf_evlist *evlist, int fd, int idx
int perf_evlist__add_pollfd(struct perf_evlist *evlist, int fd)
{
- return __perf_evlist__add_pollfd(evlist, fd, -1);
+ return __perf_evlist__add_pollfd(evlist, fd, -1, POLLIN);
}
static void perf_evlist__munmap_filtered(struct fdarray *fda, int fd)
@@ -983,15 +983,28 @@ static int __perf_evlist__mmap(struct perf_evlist *evlist, int idx,
return 0;
}
+static bool
+perf_evlist__should_poll(struct perf_evlist *evlist __maybe_unused,
+ struct perf_evsel *evsel)
+{
+ if (evsel->overwrite)
+ return false;
+ return true;
+}
+
static int perf_evlist__mmap_per_evsel(struct perf_evlist *evlist, int idx,
struct mmap_params *mp, int cpu,
int thread, int *output)
{
struct perf_evsel *evsel;
+ int revent;
evlist__for_each(evlist, evsel) {
int fd;
+ if (evsel->overwrite != (evlist->overwrite && evlist->backward))
+ continue;
+
if (evsel->system_wide && thread)
continue;
@@ -1008,6 +1021,8 @@ static int perf_evlist__mmap_per_evsel(struct perf_evlist *evlist, int idx,
perf_evlist__mmap_get(evlist, idx);
}
+ revent = perf_evlist__should_poll(evlist, evsel) ? POLLIN : 0;
+
/*
* The system_wide flag causes a selected event to be opened
* always without a pid. Consequently it will never get a
@@ -1016,7 +1031,7 @@ static int perf_evlist__mmap_per_evsel(struct perf_evlist *evlist, int idx,
* Therefore don't add it for polling.
*/
if (!evsel->system_wide &&
- __perf_evlist__add_pollfd(evlist, fd, idx) < 0) {
+ __perf_evlist__add_pollfd(evlist, fd, idx, revent) < 0) {
perf_evlist__mmap_put(evlist, idx);
return -1;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 06/12] perf evlist: Check 'base' pointer before checking refcnt when put a mmap
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 05/12] perf evlist: Don't poll and mmap overwritable events Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 07/12] perf evlist: Choose correct reading direction according to evlist->backward Arnaldo Carvalho de Melo
` (6 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, He Kuang, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Zefan Li, pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
evlist->mmap[i]->refcnt could be 0 if an evlist has no evsel or if all
evsels don't match the evlist during mmap. For example, when all evsels
are overwritable but the evlist itself is normal. To avoid crashing,
perf should check 'base' pointer before checking refcnt, and raise bug
only when base is not NULL.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1464183898-174512-2-git-send-email-wangnan0@huawei.com
[ Renamed 'mmap' variable, it is reserved in old distros such as Ubuntu 12.04, breaking the build ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evlist.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 50d7b80987c0..58ede3257c61 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -856,9 +856,11 @@ static void perf_evlist__mmap_get(struct perf_evlist *evlist, int idx)
static void perf_evlist__mmap_put(struct perf_evlist *evlist, int idx)
{
- BUG_ON(atomic_read(&evlist->mmap[idx].refcnt) == 0);
+ struct perf_mmap *md = &evlist->mmap[idx];
+
+ BUG_ON(md->base && atomic_read(&md->refcnt) == 0);
- if (atomic_dec_and_test(&evlist->mmap[idx].refcnt))
+ if (atomic_dec_and_test(&md->refcnt))
__perf_evlist__munmap(evlist, idx);
}
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 07/12] perf evlist: Choose correct reading direction according to evlist->backward
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (5 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 06/12] perf evlist: Check 'base' pointer before checking refcnt when put a mmap Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 08/12] tools: Pass arg to fdarray__filter's call back function Arnaldo Carvalho de Melo
` (5 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, He Kuang, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Zefan Li, pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
Now we have evlist->backward to indicate the mmap direction. Make
perf_evlist__mmap_read() choose right direction automatically.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1464183898-174512-3-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evlist.c | 9 ++++++++-
tools/perf/util/evlist.h | 2 ++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 58ede3257c61..719729ef9d7c 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -777,7 +777,7 @@ broken_event:
return event;
}
-union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)
+union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int idx)
{
struct perf_mmap *md = &evlist->mmap[idx];
u64 head;
@@ -832,6 +832,13 @@ perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
return perf_mmap__read(md, false, start, end, &md->prev);
}
+union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)
+{
+ if (!evlist->backward)
+ return perf_evlist__mmap_read_forward(evlist, idx);
+ return perf_evlist__mmap_read_backward(evlist, idx);
+}
+
void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx)
{
struct perf_mmap *md = &evlist->mmap[idx];
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
index d740fb877ab6..68cb1361c97c 100644
--- a/tools/perf/util/evlist.h
+++ b/tools/perf/util/evlist.h
@@ -131,6 +131,8 @@ struct perf_sample_id *perf_evlist__id2sid(struct perf_evlist *evlist, u64 id);
union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx);
+union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist,
+ int idx);
union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist,
int idx);
void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx);
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 08/12] tools: Pass arg to fdarray__filter's call back function
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (6 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 07/12] perf evlist: Choose correct reading direction according to evlist->backward Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 09/12] perf tools: Add arch/*/include/generated/ to .gitignore Arnaldo Carvalho de Melo
` (4 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, He Kuang, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Zefan Li, pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
Before this patch there's no way to pass arguments to fdarray__filter's
call back function.
This improvement will be used by 'perf record' to support unmapping ring
buffer for both main evlist and overwrite evlist. Without this patch
there's no way to track overwrite evlist from 'struct fdarray'.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1464183898-174512-10-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/api/fd/array.c | 5 +++--
tools/lib/api/fd/array.h | 3 ++-
tools/perf/tests/fdarray.c | 8 ++++----
tools/perf/util/evlist.c | 5 +++--
4 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/tools/lib/api/fd/array.c b/tools/lib/api/fd/array.c
index 0e636c4339b8..b0a035fc87b3 100644
--- a/tools/lib/api/fd/array.c
+++ b/tools/lib/api/fd/array.c
@@ -85,7 +85,8 @@ int fdarray__add(struct fdarray *fda, int fd, short revents)
}
int fdarray__filter(struct fdarray *fda, short revents,
- void (*entry_destructor)(struct fdarray *fda, int fd))
+ void (*entry_destructor)(struct fdarray *fda, int fd, void *arg),
+ void *arg)
{
int fd, nr = 0;
@@ -95,7 +96,7 @@ int fdarray__filter(struct fdarray *fda, short revents,
for (fd = 0; fd < fda->nr; ++fd) {
if (fda->entries[fd].revents & revents) {
if (entry_destructor)
- entry_destructor(fda, fd);
+ entry_destructor(fda, fd, arg);
continue;
}
diff --git a/tools/lib/api/fd/array.h b/tools/lib/api/fd/array.h
index 45db01818f45..e87fd800fa8d 100644
--- a/tools/lib/api/fd/array.h
+++ b/tools/lib/api/fd/array.h
@@ -34,7 +34,8 @@ void fdarray__delete(struct fdarray *fda);
int fdarray__add(struct fdarray *fda, int fd, short revents);
int fdarray__poll(struct fdarray *fda, int timeout);
int fdarray__filter(struct fdarray *fda, short revents,
- void (*entry_destructor)(struct fdarray *fda, int fd));
+ void (*entry_destructor)(struct fdarray *fda, int fd, void *arg),
+ void *arg);
int fdarray__grow(struct fdarray *fda, int extra);
int fdarray__fprintf(struct fdarray *fda, FILE *fp);
diff --git a/tools/perf/tests/fdarray.c b/tools/perf/tests/fdarray.c
index c809463edbe5..59dbd0550c51 100644
--- a/tools/perf/tests/fdarray.c
+++ b/tools/perf/tests/fdarray.c
@@ -36,7 +36,7 @@ int test__fdarray__filter(int subtest __maybe_unused)
}
fdarray__init_revents(fda, POLLIN);
- nr_fds = fdarray__filter(fda, POLLHUP, NULL);
+ nr_fds = fdarray__filter(fda, POLLHUP, NULL, NULL);
if (nr_fds != fda->nr_alloc) {
pr_debug("\nfdarray__filter()=%d != %d shouldn't have filtered anything",
nr_fds, fda->nr_alloc);
@@ -44,7 +44,7 @@ int test__fdarray__filter(int subtest __maybe_unused)
}
fdarray__init_revents(fda, POLLHUP);
- nr_fds = fdarray__filter(fda, POLLHUP, NULL);
+ nr_fds = fdarray__filter(fda, POLLHUP, NULL, NULL);
if (nr_fds != 0) {
pr_debug("\nfdarray__filter()=%d != %d, should have filtered all fds",
nr_fds, fda->nr_alloc);
@@ -57,7 +57,7 @@ int test__fdarray__filter(int subtest __maybe_unused)
pr_debug("\nfiltering all but fda->entries[2]:");
fdarray__fprintf_prefix(fda, "before", stderr);
- nr_fds = fdarray__filter(fda, POLLHUP, NULL);
+ nr_fds = fdarray__filter(fda, POLLHUP, NULL, NULL);
fdarray__fprintf_prefix(fda, " after", stderr);
if (nr_fds != 1) {
pr_debug("\nfdarray__filter()=%d != 1, should have left just one event", nr_fds);
@@ -78,7 +78,7 @@ int test__fdarray__filter(int subtest __maybe_unused)
pr_debug("\nfiltering all but (fda->entries[0], fda->entries[3]):");
fdarray__fprintf_prefix(fda, "before", stderr);
- nr_fds = fdarray__filter(fda, POLLHUP, NULL);
+ nr_fds = fdarray__filter(fda, POLLHUP, NULL, NULL);
fdarray__fprintf_prefix(fda, " after", stderr);
if (nr_fds != 2) {
pr_debug("\nfdarray__filter()=%d != 2, should have left just two events",
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 719729ef9d7c..e0f30946ed1a 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -483,7 +483,8 @@ int perf_evlist__add_pollfd(struct perf_evlist *evlist, int fd)
return __perf_evlist__add_pollfd(evlist, fd, -1, POLLIN);
}
-static void perf_evlist__munmap_filtered(struct fdarray *fda, int fd)
+static void perf_evlist__munmap_filtered(struct fdarray *fda, int fd,
+ void *arg __maybe_unused)
{
struct perf_evlist *evlist = container_of(fda, struct perf_evlist, pollfd);
@@ -493,7 +494,7 @@ static void perf_evlist__munmap_filtered(struct fdarray *fda, int fd)
int perf_evlist__filter_pollfd(struct perf_evlist *evlist, short revents_and_mask)
{
return fdarray__filter(&evlist->pollfd, revents_and_mask,
- perf_evlist__munmap_filtered);
+ perf_evlist__munmap_filtered, NULL);
}
int perf_evlist__poll(struct perf_evlist *evlist, int timeout)
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 09/12] perf tools: Add arch/*/include/generated/ to .gitignore
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (7 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 08/12] tools: Pass arg to fdarray__filter's call back function Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 10/12] perf symbols: Introduce filename__readable to check readability Arnaldo Carvalho de Melo
` (3 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Taeung Song, Adrian Hunter, Alexander Shishkin,
David Ahern, Jiri Olsa, Masami Hiramatsu, Namhyung Kim,
Peter Zijlstra, Wang Nan, Arnaldo Carvalho de Melo
From: Taeung Song <treeze.taeung@gmail.com>
Commit 1b700c997500 ("perf tools: Build syscall table .c header from
kernel's syscall_64.tbl") automatically generates per-arch syscall table
arrays, e.g.:
arch/x86/include/generated/asm/syscalls_64.c
So add this directory to .gitignore
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: 1b700c997500 ("perf tools: Build syscall table .c header from kernel's syscall_64.tbl")
Link: http://lkml.kernel.org/r/1464343274-19403-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
index 3d1bb802dbf4..3db3db9278be 100644
--- a/tools/perf/.gitignore
+++ b/tools/perf/.gitignore
@@ -30,3 +30,4 @@ config.mak.autogen
*.pyo
.config-detected
util/intel-pt-decoder/inat-tables.c
+arch/*/include/generated/
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 10/12] perf symbols: Introduce filename__readable to check readability
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (8 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 09/12] perf tools: Add arch/*/include/generated/ to .gitignore Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 11/12] perf symbols: Cleanup the code flow of dso__find_kallsyms Arnaldo Carvalho de Melo
` (2 subsequent siblings)
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ananth N Mavinakayanahalli,
Brendan Gregg, Hemant Kumar, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <mhiramat@kernel.org>
Introduce filename__readable to check readability by opening the file
directly. Since the access(R_OK) just checks the readability based on
real UID/GID, it is ignored that the effective UID/GID and capabilities
for some special file (e.g. /proc/kcore).
filename__readable() directly opens given file with O_RDONLY so that the
kernel checks it by effective UID/GID and capabilities.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Hemant Kumar <hemant@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20160528151513.16098.97576.stgit@devbox
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol.c | 32 ++++++++++++++++++++++----------
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 54c4ff2b1cee..a469346a305d 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1641,6 +1641,20 @@ static int find_matching_kcore(struct map *map, char *dir, size_t dir_sz)
return ret;
}
+/*
+ * Use open(O_RDONLY) to check readability directly instead of access(R_OK)
+ * since access(R_OK) only checks with real UID/GID but open() use effective
+ * UID/GID and actual capabilities (e.g. /proc/kcore requires CAP_SYS_RAWIO).
+ */
+static bool filename__readable(const char *file)
+{
+ int fd = open(file, O_RDONLY);
+ if (fd < 0)
+ return false;
+ close(fd);
+ return true;
+}
+
static char *dso__find_kallsyms(struct dso *dso, struct map *map)
{
u8 host_build_id[BUILD_ID_SIZE];
@@ -1668,7 +1682,6 @@ static char *dso__find_kallsyms(struct dso *dso, struct map *map)
/* Use /proc/kallsyms if possible */
if (is_host) {
DIR *d;
- int fd;
/* If no cached kcore go with /proc/kallsyms */
d = opendir(path);
@@ -1677,16 +1690,15 @@ static char *dso__find_kallsyms(struct dso *dso, struct map *map)
closedir(d);
/*
- * Do not check the build-id cache, until we know we cannot use
- * /proc/kcore.
+ * Do not check the build-id cache, unless we know we cannot use
+ * /proc/kcore or module maps don't match to /proc/kallsyms.
+ * To check readability of /proc/kcore, do not use access(R_OK)
+ * since /proc/kcore requires CAP_SYS_RAWIO to read and access
+ * can't check it.
*/
- fd = open("/proc/kcore", O_RDONLY);
- if (fd != -1) {
- close(fd);
- /* If module maps match go with /proc/kallsyms */
- if (!validate_kcore_addresses("/proc/kallsyms", map))
- goto proc_kallsyms;
- }
+ if (filename__readable("/proc/kcore") &&
+ !validate_kcore_addresses("/proc/kallsyms", map))
+ goto proc_kallsyms;
/* Find kallsyms in build-id cache with kcore */
if (!find_matching_kcore(map, path, sizeof(path)))
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 11/12] perf symbols: Cleanup the code flow of dso__find_kallsyms
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (9 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 10/12] perf symbols: Introduce filename__readable to check readability Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 12/12] perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Arnaldo Carvalho de Melo
2016-05-31 7:24 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ananth N Mavinakayanahalli,
Brendan Gregg, Hemant Kumar, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <mhiramat@kernel.org>
Cleanup the code flow of dso__find_kallsyms() to remove redundant
checking code and add some comment for readability.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Hemant Kumar <hemant@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20160528151522.16098.43446.stgit@devbox
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol.c | 36 +++++++++++++-----------------------
1 file changed, 13 insertions(+), 23 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index a469346a305d..1df6092c8665 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1674,21 +1674,8 @@ static char *dso__find_kallsyms(struct dso *dso, struct map *map)
sizeof(host_build_id)) == 0)
is_host = dso__build_id_equal(dso, host_build_id);
- build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id);
-
- scnprintf(path, sizeof(path), "%s/%s/%s", buildid_dir,
- DSO__NAME_KCORE, sbuild_id);
-
- /* Use /proc/kallsyms if possible */
+ /* Try a fast path for /proc/kallsyms if possible */
if (is_host) {
- DIR *d;
-
- /* If no cached kcore go with /proc/kallsyms */
- d = opendir(path);
- if (!d)
- goto proc_kallsyms;
- closedir(d);
-
/*
* Do not check the build-id cache, unless we know we cannot use
* /proc/kcore or module maps don't match to /proc/kallsyms.
@@ -1699,18 +1686,24 @@ static char *dso__find_kallsyms(struct dso *dso, struct map *map)
if (filename__readable("/proc/kcore") &&
!validate_kcore_addresses("/proc/kallsyms", map))
goto proc_kallsyms;
-
- /* Find kallsyms in build-id cache with kcore */
- if (!find_matching_kcore(map, path, sizeof(path)))
- return strdup(path);
-
- goto proc_kallsyms;
}
+ build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id);
+
/* Find kallsyms in build-id cache with kcore */
+ scnprintf(path, sizeof(path), "%s/%s/%s",
+ buildid_dir, DSO__NAME_KCORE, sbuild_id);
+
if (!find_matching_kcore(map, path, sizeof(path)))
return strdup(path);
+ /* Use current /proc/kallsyms if possible */
+ if (is_host) {
+proc_kallsyms:
+ return strdup("/proc/kallsyms");
+ }
+
+ /* Finally, find a cache of kallsyms */
scnprintf(path, sizeof(path), "%s/%s/%s",
buildid_dir, DSO__NAME_KALLSYMS, sbuild_id);
@@ -1721,9 +1714,6 @@ static char *dso__find_kallsyms(struct dso *dso, struct map *map)
}
return strdup(path);
-
-proc_kallsyms:
- return strdup("/proc/kallsyms");
}
static int dso__load_kernel_sym(struct dso *dso, struct map *map,
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 12/12] perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (10 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 11/12] perf symbols: Cleanup the code flow of dso__find_kallsyms Arnaldo Carvalho de Melo
@ 2016-05-30 19:24 ` Arnaldo Carvalho de Melo
2016-05-31 7:24 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar
12 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-30 19:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Masami Hiramatsu,
Ananth N Mavinakayanahalli, Brendan Gregg, Hemant Kumar,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use path/to/bin/buildid/elf instead of path/to/bin/buildid
to store corresponding elf binary.
This also stores vdso in buildid/vdso, kallsyms in buildid/kallsyms.
Note that the existing caches are not updated until user adds
or updates the cache. Anyway, if there is the old style build-id
cache it falls back to use it. (IOW, it is backward compatible)
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Hemant Kumar <hemant@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20160528151537.16098.85815.stgit@devbox
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/build-id.c | 115 ++++++++++++++++++++++++++++++++++-----------
tools/perf/util/build-id.h | 2 +
tools/perf/util/dso.h | 5 ++
tools/perf/util/symbol.c | 5 +-
4 files changed, 96 insertions(+), 31 deletions(-)
diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
index 67e5966503b2..67f986c8c378 100644
--- a/tools/perf/util/build-id.c
+++ b/tools/perf/util/build-id.c
@@ -144,7 +144,32 @@ static int asnprintf(char **strp, size_t size, const char *fmt, ...)
return ret;
}
-static char *build_id__filename(const char *sbuild_id, char *bf, size_t size)
+char *build_id_cache__kallsyms_path(const char *sbuild_id, char *bf,
+ size_t size)
+{
+ bool is_alloc = !!bf;
+ bool retry_old = true;
+
+ asnprintf(&bf, size, "%s/%s/%s/kallsyms",
+ buildid_dir, DSO__NAME_KALLSYMS, sbuild_id);
+retry:
+ if (!access(bf, F_OK))
+ return bf;
+ if (is_alloc)
+ free(bf);
+ if (retry_old) {
+ /* Try old style kallsyms cache */
+ asnprintf(&bf, size, "%s/%s/%s",
+ buildid_dir, DSO__NAME_KALLSYMS, sbuild_id);
+ retry_old = false;
+ goto retry;
+ }
+
+ return NULL;
+}
+
+static char *build_id_cache__linkname(const char *sbuild_id, char *bf,
+ size_t size)
{
char *tmp = bf;
int ret = asnprintf(&bf, size, "%s/.build-id/%.2s/%s", buildid_dir,
@@ -154,23 +179,52 @@ static char *build_id__filename(const char *sbuild_id, char *bf, size_t size)
return bf;
}
+static const char *build_id_cache__basename(bool is_kallsyms, bool is_vdso)
+{
+ return is_kallsyms ? "kallsyms" : (is_vdso ? "vdso" : "elf");
+}
+
char *dso__build_id_filename(const struct dso *dso, char *bf, size_t size)
{
- char build_id_hex[SBUILD_ID_SIZE];
+ bool is_kallsyms = dso__is_kallsyms((struct dso *)dso);
+ bool is_vdso = dso__is_vdso((struct dso *)dso);
+ char sbuild_id[SBUILD_ID_SIZE];
+ char *linkname;
+ bool alloc = (bf == NULL);
+ int ret;
if (!dso->has_build_id)
return NULL;
- build_id__sprintf(dso->build_id, sizeof(dso->build_id), build_id_hex);
- return build_id__filename(build_id_hex, bf, size);
+ build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id);
+ linkname = build_id_cache__linkname(sbuild_id, NULL, 0);
+ if (!linkname)
+ return NULL;
+
+ /* Check if old style build_id cache */
+ if (is_regular_file(linkname))
+ ret = asnprintf(&bf, size, "%s", linkname);
+ else
+ ret = asnprintf(&bf, size, "%s/%s", linkname,
+ build_id_cache__basename(is_kallsyms, is_vdso));
+ if (ret < 0 || (!alloc && size < (unsigned int)ret))
+ bf = NULL;
+ free(linkname);
+
+ return bf;
}
bool dso__build_id_is_kmod(const struct dso *dso, char *bf, size_t size)
{
- char *id_name, *ch;
+ char *id_name = NULL, *ch;
struct stat sb;
+ char sbuild_id[SBUILD_ID_SIZE];
+
+ if (!dso->has_build_id)
+ goto err;
- id_name = dso__build_id_filename(dso, bf, size);
+ build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id);
+ id_name = build_id_cache__linkname(sbuild_id, NULL, 0);
if (!id_name)
goto err;
if (access(id_name, F_OK))
@@ -194,18 +248,14 @@ bool dso__build_id_is_kmod(const struct dso *dso, char *bf, size_t size)
if (ch - 3 < bf)
goto err;
+ free(id_name);
return strncmp(".ko", ch - 3, 3) == 0;
err:
- /*
- * If dso__build_id_filename work, get id_name again,
- * because id_name points to bf and is broken.
- */
- if (id_name)
- id_name = dso__build_id_filename(dso, bf, size);
pr_err("Invalid build id: %s\n", id_name ? :
dso->long_name ? :
dso->short_name ? :
"[unknown]");
+ free(id_name);
return false;
}
@@ -341,7 +391,8 @@ void disable_buildid_cache(void)
}
static char *build_id_cache__dirname_from_path(const char *name,
- bool is_kallsyms, bool is_vdso)
+ bool is_kallsyms, bool is_vdso,
+ const char *sbuild_id)
{
char *realname = (char *)name, *filename;
bool slash = is_kallsyms || is_vdso;
@@ -352,8 +403,9 @@ static char *build_id_cache__dirname_from_path(const char *name,
return NULL;
}
- if (asprintf(&filename, "%s%s%s", buildid_dir, slash ? "/" : "",
- is_vdso ? DSO__NAME_VDSO : realname) < 0)
+ if (asprintf(&filename, "%s%s%s%s%s", buildid_dir, slash ? "/" : "",
+ is_vdso ? DSO__NAME_VDSO : realname,
+ sbuild_id ? "/" : "", sbuild_id ?: "") < 0)
filename = NULL;
if (!slash)
@@ -368,7 +420,8 @@ int build_id_cache__list_build_ids(const char *pathname,
char *dir_name;
int ret = 0;
- dir_name = build_id_cache__dirname_from_path(pathname, false, false);
+ dir_name = build_id_cache__dirname_from_path(pathname, false, false,
+ NULL);
if (!dir_name)
return -ENOMEM;
@@ -385,7 +438,7 @@ int build_id_cache__add_s(const char *sbuild_id, const char *name,
{
const size_t size = PATH_MAX;
char *realname = NULL, *filename = NULL, *dir_name = NULL,
- *linkname = zalloc(size), *targetname, *tmp;
+ *linkname = zalloc(size), *tmp;
int err = -1;
if (!is_kallsyms) {
@@ -394,14 +447,22 @@ int build_id_cache__add_s(const char *sbuild_id, const char *name,
goto out_free;
}
- dir_name = build_id_cache__dirname_from_path(name, is_kallsyms, is_vdso);
+ dir_name = build_id_cache__dirname_from_path(name, is_kallsyms,
+ is_vdso, sbuild_id);
if (!dir_name)
goto out_free;
+ /* Remove old style build-id cache */
+ if (is_regular_file(dir_name))
+ if (unlink(dir_name))
+ goto out_free;
+
if (mkdir_p(dir_name, 0755))
goto out_free;
- if (asprintf(&filename, "%s/%s", dir_name, sbuild_id) < 0) {
+ /* Save the allocated buildid dirname */
+ if (asprintf(&filename, "%s/%s", dir_name,
+ build_id_cache__basename(is_kallsyms, is_vdso)) < 0) {
filename = NULL;
goto out_free;
}
@@ -415,7 +476,7 @@ int build_id_cache__add_s(const char *sbuild_id, const char *name,
goto out_free;
}
- if (!build_id__filename(sbuild_id, linkname, size))
+ if (!build_id_cache__linkname(sbuild_id, linkname, size))
goto out_free;
tmp = strrchr(linkname, '/');
*tmp = '\0';
@@ -424,10 +485,10 @@ int build_id_cache__add_s(const char *sbuild_id, const char *name,
goto out_free;
*tmp = '/';
- targetname = filename + strlen(buildid_dir) - 5;
- memcpy(targetname, "../..", 5);
+ tmp = dir_name + strlen(buildid_dir) - 5;
+ memcpy(tmp, "../..", 5);
- if (symlink(targetname, linkname) == 0)
+ if (symlink(tmp, linkname) == 0)
err = 0;
out_free:
if (!is_kallsyms)
@@ -452,7 +513,7 @@ static int build_id_cache__add_b(const u8 *build_id, size_t build_id_size,
bool build_id_cache__cached(const char *sbuild_id)
{
bool ret = false;
- char *filename = build_id__filename(sbuild_id, NULL, 0);
+ char *filename = build_id_cache__linkname(sbuild_id, NULL, 0);
if (filename && !access(filename, F_OK))
ret = true;
@@ -471,7 +532,7 @@ int build_id_cache__remove_s(const char *sbuild_id)
if (filename == NULL || linkname == NULL)
goto out_free;
- if (!build_id__filename(sbuild_id, linkname, size))
+ if (!build_id_cache__linkname(sbuild_id, linkname, size))
goto out_free;
if (access(linkname, F_OK))
@@ -489,7 +550,7 @@ int build_id_cache__remove_s(const char *sbuild_id)
tmp = strrchr(linkname, '/') + 1;
snprintf(tmp, size - (tmp - linkname), "%s", filename);
- if (unlink(linkname))
+ if (rm_rf(linkname))
goto out_free;
err = 0;
@@ -501,7 +562,7 @@ out_free:
static int dso__cache_build_id(struct dso *dso, struct machine *machine)
{
- bool is_kallsyms = dso->kernel && dso->long_name[0] != '/';
+ bool is_kallsyms = dso__is_kallsyms(dso);
bool is_vdso = dso__is_vdso(dso);
const char *name = dso->long_name;
char nm[PATH_MAX];
diff --git a/tools/perf/util/build-id.h b/tools/perf/util/build-id.h
index 64af3e20610d..e5435f46e48e 100644
--- a/tools/perf/util/build-id.h
+++ b/tools/perf/util/build-id.h
@@ -14,6 +14,8 @@ struct dso;
int build_id__sprintf(const u8 *build_id, int len, char *bf);
int sysfs__sprintf_build_id(const char *root_dir, char *sbuild_id);
int filename__sprintf_build_id(const char *pathname, char *sbuild_id);
+char *build_id_cache__kallsyms_path(const char *sbuild_id, char *bf,
+ size_t size);
char *dso__build_id_filename(const struct dso *dso, char *bf, size_t size);
bool dso__build_id_is_kmod(const struct dso *dso, char *bf, size_t size);
diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
index 0953280629cf..76d79d070e21 100644
--- a/tools/perf/util/dso.h
+++ b/tools/perf/util/dso.h
@@ -349,6 +349,11 @@ static inline bool dso__is_kcore(struct dso *dso)
dso->binary_type == DSO_BINARY_TYPE__GUEST_KCORE;
}
+static inline bool dso__is_kallsyms(struct dso *dso)
+{
+ return dso->kernel && dso->long_name[0] != '/';
+}
+
void dso__free_a2l(struct dso *dso);
enum dso_type dso__type(struct dso *dso, struct machine *machine);
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 1df6092c8665..09c5c34ae38d 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1704,10 +1704,7 @@ proc_kallsyms:
}
/* Finally, find a cache of kallsyms */
- scnprintf(path, sizeof(path), "%s/%s/%s",
- buildid_dir, DSO__NAME_KALLSYMS, sbuild_id);
-
- if (access(path, F_OK)) {
+ if (!build_id_cache__kallsyms_path(sbuild_id, path, sizeof(path))) {
pr_err("No kallsyms or vmlinux with build-id %s was found\n",
sbuild_id);
return NULL;
--
2.5.5
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (11 preceding siblings ...)
2016-05-30 19:24 ` [PATCH 12/12] perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Arnaldo Carvalho de Melo
@ 2016-05-31 7:24 ` Ingo Molnar
12 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2016-05-31 7:24 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin,
Alexei Starovoitov, Ananth N Mavinakayanahalli, Andi Kleen,
Brendan Gregg, David Ahern, Frederic Weisbecker, He Kuang,
Hemant Kumar, Jiri Olsa, Linus Torvalds, Masami Hiramatsu,
Milian Wolff, Namhyung Kim, Peter Zijlstra, pi3orama,
Stephane Eranian, Taeung Song, Thomas Gleixner, Vince Weaver,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f:
>
> Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530
>
> for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6:
>
> perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible/kernel ABI:
>
> - Per event callchain limit: Recently we introduced a sysctl to tune the
> max-stack for all events for which callchains were requested:
>
> $ sysctl kernel.perf_event_max_stack
> kernel.perf_event_max_stack = 127
>
> Now this patch introduces a way to configure this per event, i.e. this
> becomes possible:
>
> $ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a
>
> allowing finer tuning of how much buffer space callchains use.
>
> This uses an u16 from the reserved space at the end, leaving another
> u16 for future use.
>
> There has been interest in even finer tuning, namely to control the
> max stack for kernel and userspace callchains separately. Further
> discussion is needed, we may for instance use the remaining u16 for
> that and when it is present, assume that the sample_max_stack introduced
> in this patch applies for the kernel, and the u16 left is used for
> limiting the userspace callchain. (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> - Adopt get_main_thread from db-export.c (Andi Kleen)
>
> - More prep work for backward ring buffer support (Wang Nan)
>
> - Prep work for supporting SDT (Statically Defined Tracing)
> tracepoints (Masami Hiramatsu)
>
> - Add arch/*/include/generated/ to .gitignore (Taeung Song)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf thread: Adopt get_main_thread from db-export.c
>
> Arnaldo Carvalho de Melo (2):
> perf core: Per event callchain limit
> perf tools: Per event max-stack settings
>
> Masami Hiramatsu (3):
> perf symbols: Introduce filename__readable to check readability
> perf symbols: Cleanup the code flow of dso__find_kallsyms
> perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
>
> Taeung Song (1):
> perf tools: Add arch/*/include/generated/ to .gitignore
>
> Wang Nan (5):
> perf record: Robustify perf_event__synth_time_conv()
> perf evlist: Don't poll and mmap overwritable events
> perf evlist: Check 'base' pointer before checking refcnt when put a mmap
> perf evlist: Choose correct reading direction according to evlist->backward
> tools: Pass arg to fdarray__filter's call back function
>
> include/linux/perf_event.h | 2 +-
> include/uapi/linux/perf_event.h | 6 ++-
> kernel/bpf/stackmap.c | 2 +-
> kernel/events/callchain.c | 14 ++++-
> kernel/events/core.c | 5 +-
> tools/lib/api/fd/array.c | 5 +-
> tools/lib/api/fd/array.h | 3 +-
> tools/perf/.gitignore | 1 +
> tools/perf/arch/x86/util/tsc.c | 2 +
> tools/perf/builtin-record.c | 9 +++-
> tools/perf/tests/fdarray.c | 8 +--
> tools/perf/util/build-id.c | 115 ++++++++++++++++++++++++++++++----------
> tools/perf/util/build-id.h | 2 +
> tools/perf/util/callchain.h | 1 +
> tools/perf/util/db-export.c | 13 +----
> tools/perf/util/dso.h | 5 ++
> tools/perf/util/evlist.c | 43 +++++++++++----
> tools/perf/util/evlist.h | 2 +
> tools/perf/util/evsel.c | 16 +++++-
> tools/perf/util/evsel.h | 2 +
> tools/perf/util/parse-events.c | 8 +++
> tools/perf/util/parse-events.h | 1 +
> tools/perf/util/parse-events.l | 1 +
> tools/perf/util/session.c | 2 +
> tools/perf/util/symbol.c | 71 ++++++++++++-------------
> tools/perf/util/thread.c | 11 ++++
> tools/perf/util/thread.h | 2 +
> 27 files changed, 252 insertions(+), 100 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2018-10-09 0:54 Arnaldo Carvalho de Melo
2018-10-09 5:24 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-10-09 0:54 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Sverdlin,
David Ahern, Eduardo Habkost, Heiko Carstens, Hendrik Brueckner,
Jiri Olsa, Joe Lawrence, linux trace devel, Martin Schwidefsky,
Namhyung Kim, Ravi Bangoria, Sanskriti Sharma, Steven Rostedt,
Thomas Richter, Tzvetomir Stoyanov, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d:
perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008
for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99:
tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
. Fix building the python bindings with python3, which fixes some
problems with building with clang on Clear Linux (Eduardo Habkost)
. Fix coverity warnings, fixing up some error paths and plugging
some temporary small buffer leaks (Sanskriti Sharma)
. Adopt a wrapper for strerror_r() for the same reasons as recently
for libbpf (Steven Rostedt)
. S390 does not support watchpoints in 'perf test 22', check if
that test is supported by the arch. (Thomas Richter)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
tools include: Adopt linux/bits.h
perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG
Eduardo Habkost (2):
perf python: Make clang_has_option() work on Python 3
perf python: More portable way to make CFLAGS work with clang
Sanskriti Sharma (5):
perf strbuf: Match va_{add,copy} with va_end
perf tools: Cleanup trace-event-info 'tdata' leak
perf tools: Free 'printk' string in parse_ftrace_printk()
perf tools: Avoid double free in read_event_file()
perf tools: Free temporary 'sys' string in read_event_files()
Steven Rostedt (VMware) (1):
tools lib traceevent: Separate out tep_strerror() for strerror_r() issues
Thomas Richter (1):
perf test: S390 does not support watchpoints in test 22
Tzvetomir Stoyanov (1):
tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file
tools/include/linux/bitops.h | 7 +-
tools/include/linux/bits.h | 26 +++
tools/lib/traceevent/Build | 2 +
tools/lib/traceevent/event-parse-api.c | 275 +++++++++++++++++++++++++++++++
tools/lib/traceevent/event-parse-local.h | 92 +++++++++++
tools/lib/traceevent/event-parse.c | 32 +---
tools/lib/traceevent/event-parse.h | 228 ++++---------------------
tools/lib/traceevent/event-plugin.c | 1 +
tools/lib/traceevent/parse-filter.c | 1 +
tools/lib/traceevent/tep_strerror.c | 53 ++++++
tools/perf/check-headers.sh | 1 +
tools/perf/tests/builtin-test.c | 1 +
tools/perf/tests/tests.h | 1 +
tools/perf/tests/wp.c | 12 ++
tools/perf/util/auxtrace.h | 1 +
tools/perf/util/setup.py | 16 +-
tools/perf/util/strbuf.c | 10 +-
tools/perf/util/trace-event-info.c | 2 +
tools/perf/util/trace-event-parse.c | 26 +--
tools/perf/util/trace-event-read.c | 11 +-
20 files changed, 539 insertions(+), 259 deletions(-)
create mode 100644 tools/include/linux/bits.h
create mode 100644 tools/lib/traceevent/event-parse-api.c
create mode 100644 tools/lib/traceevent/event-parse-local.h
create mode 100644 tools/lib/traceevent/tep_strerror.c
Test results:
The first ones are container (docker) based builds of tools/perf with
and without libelf support. Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
The Clear Linux container is building with NO_CLANG=1, some problem
preventing its use when building for python3 have been fixed, some more
have been identified and the next builds will build in ClearLinux with
both gcc and clang. This time around only gcc was used.
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0
6 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
7 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
8 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
14 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 8.2.1 20180502
15 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
16 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
17 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
18 debian:experimental : Ok gcc (Debian 8.2.0-7) 8.2.0
19 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0
20 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
21 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0
22 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
23 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
24 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
25 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
26 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
27 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
28 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
29 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
30 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
31 fedora:27 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6)
32 fedora:28 : Ok gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
33 fedora:rawhide : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3)
34 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0
35 mageia:5 : Ok gcc (GCC) 4.9.2
36 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0
37 opensuse:13.2 : Ok gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064]
38 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
39 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
40 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
41 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812]
42 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
43 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1)
44 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
45 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
46 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
47 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
48 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
49 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
50 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
51 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
52 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
53 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
54 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
55 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
56 ubuntu:18.04 : Ok gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
57 ubuntu:18.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
58 ubuntu:18.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
59 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
60 ubuntu:18.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
61 ubuntu:18.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
62 ubuntu:18.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
63 ubuntu:18.04-x-riscv64 : Ok riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
64 ubuntu:18.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
65 ubuntu:18.04-x-sh4 : Ok sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
66 ubuntu:18.04-x-sparc64 : Ok sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
67 ubuntu:18.10 : Ok gcc (Ubuntu 8.2.0-4ubuntu1) 8.2.0
#
# uname -a
Linux jouet 4.19.0-rc4-00022-gad3273d5f1b9 #1 SMP Mon Sep 17 17:18:22 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# git log --oneline -1
bb3dd7e7c4d5 tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file
# perf version --build-options
perf version 4.19.rc5.gbb3dd7
dwarf: [ on ] # HAVE_DWARF_SUPPORT
dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
glibc: [ on ] # HAVE_GLIBC_SUPPORT
gtk2: [ on ] # HAVE_GTK2_SUPPORT
syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
libbfd: [ on ] # HAVE_LIBBFD_SUPPORT
libelf: [ on ] # HAVE_LIBELF_SUPPORT
libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT
numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT
libperl: [ on ] # HAVE_LIBPERL_SUPPORT
libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
libslang: [ on ] # HAVE_SLANG_SUPPORT
libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
zlib: [ on ] # HAVE_ZLIB_SUPPORT
lzma: [ on ] # HAVE_LZMA_SUPPORT
get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT
bpf: [ on ] # HAVE_LIBBPF_SUPPORT
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Watchpoint :
22.1: Read Only Watchpoint : Skip
22.2: Write Only Watchpoint : Ok
22.3: Read / Write Watchpoint : Ok
22.4: Modify Watchpoint : Ok
23: Number of exit events of a simple workload : Ok
24: Software clock events period values : Ok
25: Object code reading : Ok
26: Sample parsing : Ok
27: Use a dummy software event to keep tracking : Ok
28: Parse with no sample_id_all bit set : Ok
29: Filter hist entries : Ok
30: Lookup mmap thread : Ok
31: Share thread mg : Ok
32: Sort output of hist entries : Ok
33: Cumulate child hist entries : Ok
34: Track with sched_switch : Ok
35: Filter fds with revents mask in a fdarray : Ok
36: Add fd to a fdarray, making it autogrow : Ok
37: kmod_path__parse : Ok
38: Thread map : Ok
39: LLVM search and compile :
39.1: Basic BPF llvm compile : Ok
39.2: kbuild searching : Ok
39.3: Compile source for BPF prologue generation : Ok
39.4: Compile source for BPF relocation : Ok
40: Session topology : Ok
41: BPF filter :
41.1: Basic BPF filtering : Ok
41.2: BPF pinning : Ok
41.3: BPF prologue generation : Ok
41.4: BPF relocation checker : Ok
42: Synthesize thread map : Ok
43: Remove thread map : Ok
44: Synthesize cpu map : Ok
45: Synthesize stat config : Ok
46: Synthesize stat : Ok
47: Synthesize stat round : Ok
48: Synthesize attr update : Ok
49: Event times : Ok
50: Read backward ring buffer : Ok
51: Print cpu map : Ok
52: Probe SDT events : Ok
53: is_printable_array : Ok
54: Print bitmap : Ok
55: perf hooks : Ok
56: builtin clang support : Skip (not compiled in)
57: unit_number__scnprintf : Ok
58: mem2node : Ok
59: x86 rdpmc : Ok
60: Convert perf time to TSC : Ok
61: DWARF unwind : Ok
62: x86 instruction decoder - new instructions : Ok
63: x86 bp modify : Ok
64: Use vfs_getname probe to get syscall args filenames : Ok
65: Check open filename arg using perf trace + vfs_getname: Ok
66: probe libc's inet_pton & backtrace it with ping : Ok
67: Add vfs_getname probe to get syscall args filenames : Ok
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_install_bin_O: make install-bin
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_gtk2_O: make NO_GTK2=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_install_O: make install
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_newt_O: make NO_NEWT=1
make_no_libperl_O: make NO_LIBPERL=1
make_util_map_o_O: make util/map.o
make_clean_all_O: make clean all
make_static_O: make LDFLAGS=-static
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_doc_O: make doc
make_no_libelf_O: make NO_LIBELF=1
make_pure_O: make
make_no_auxtrace_O: make NO_AUXTRACE=1
make_perf_o_O: make perf.o
make_tags_O: make tags
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libnuma_O: make NO_LIBNUMA=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_debug_O: make DEBUG=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_slang_O: make NO_SLANG=1
make_help_O: make help
make_no_demangle_O: make NO_DEMANGLE=1
make_install_prefix_O: make install prefix=/tmp/krava
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2018-10-09 0:54 Arnaldo Carvalho de Melo
@ 2018-10-09 5:24 ` Ingo Molnar
0 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2018-10-09 5:24 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Sverdlin, David Ahern, Eduardo Habkost, Heiko Carstens,
Hendrik Brueckner, Jiri Olsa, Joe Lawrence, linux trace devel,
Martin Schwidefsky, Namhyung Kim, Ravi Bangoria,
Sanskriti Sharma, Steven Rostedt, Thomas Richter,
Tzvetomir Stoyanov, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d:
>
> perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008
>
> for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99:
>
> tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Fix building the python bindings with python3, which fixes some
> problems with building with clang on Clear Linux (Eduardo Habkost)
>
> . Fix coverity warnings, fixing up some error paths and plugging
> some temporary small buffer leaks (Sanskriti Sharma)
>
> . Adopt a wrapper for strerror_r() for the same reasons as recently
> for libbpf (Steven Rostedt)
>
> . S390 does not support watchpoints in 'perf test 22', check if
> that test is supported by the arch. (Thomas Richter)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> tools include: Adopt linux/bits.h
> perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG
>
> Eduardo Habkost (2):
> perf python: Make clang_has_option() work on Python 3
> perf python: More portable way to make CFLAGS work with clang
>
> Sanskriti Sharma (5):
> perf strbuf: Match va_{add,copy} with va_end
> perf tools: Cleanup trace-event-info 'tdata' leak
> perf tools: Free 'printk' string in parse_ftrace_printk()
> perf tools: Avoid double free in read_event_file()
> perf tools: Free temporary 'sys' string in read_event_files()
>
> Steven Rostedt (VMware) (1):
> tools lib traceevent: Separate out tep_strerror() for strerror_r() issues
>
> Thomas Richter (1):
> perf test: S390 does not support watchpoints in test 22
>
> Tzvetomir Stoyanov (1):
> tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file
>
> tools/include/linux/bitops.h | 7 +-
> tools/include/linux/bits.h | 26 +++
> tools/lib/traceevent/Build | 2 +
> tools/lib/traceevent/event-parse-api.c | 275 +++++++++++++++++++++++++++++++
> tools/lib/traceevent/event-parse-local.h | 92 +++++++++++
> tools/lib/traceevent/event-parse.c | 32 +---
> tools/lib/traceevent/event-parse.h | 228 ++++---------------------
> tools/lib/traceevent/event-plugin.c | 1 +
> tools/lib/traceevent/parse-filter.c | 1 +
> tools/lib/traceevent/tep_strerror.c | 53 ++++++
> tools/perf/check-headers.sh | 1 +
> tools/perf/tests/builtin-test.c | 1 +
> tools/perf/tests/tests.h | 1 +
> tools/perf/tests/wp.c | 12 ++
> tools/perf/util/auxtrace.h | 1 +
> tools/perf/util/setup.py | 16 +-
> tools/perf/util/strbuf.c | 10 +-
> tools/perf/util/trace-event-info.c | 2 +
> tools/perf/util/trace-event-parse.c | 26 +--
> tools/perf/util/trace-event-read.c | 11 +-
> 20 files changed, 539 insertions(+), 259 deletions(-)
> create mode 100644 tools/include/linux/bits.h
> create mode 100644 tools/lib/traceevent/event-parse-api.c
> create mode 100644 tools/lib/traceevent/event-parse-local.h
> create mode 100644 tools/lib/traceevent/tep_strerror.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2016-11-25 15:12 Arnaldo Carvalho de Melo
2016-11-25 17:14 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-11-25 15:12 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov, Andi Kleen, Chris Riyder,
David Ahern, Eric Leblond, He Kuang, Jiri Olsa, Kim Phillips,
Markus Trippelsdorf, Masami Hiramatsu, Namhyung Kim,
Naveen N . Rao, Pawel Moll, Peter Zijlstra, pi3orama,
Ravi Bangoria, Russell King, Stephane Eranian, Taeung Song,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message.
The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2:
Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125
for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5:
tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Improve ARM support in the annotation code, affecting 'perf annotate', 'perf
report' and live annotation in 'perf top' (Kim Phillips)
- Initial support for PowerPC in the annotation code (Ravi Bangoria)
- Skip repetitive scheduler function on the top of the stack in
'perf sched timehist' (Namhyung Kim)
Fixes:
- Fix maps resolution in libbpf (Eric Leblond)
- Get the kernel signature via /proc/version_signature, available on
ubuntu systems, to make sure bpf proggies works, as the one provided
via 'uname -r' doesn't (Wang Nan)
- Fix segfault in 'perf record' when running with suid and kptr_restrict
is 1 (Wang Nan)
Infrastructure:
- Support per-arch instruction tables, kept via a static or dynamic table
(Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
perf annotate: Remove duplicate 'name' field from disasm_line
perf annotate: Introduce alternative method of keeping instructions table
perf annotate: Allow arches to have a init routine and a priv area
perf annotate: Improve support for ARM
Eric Leblond (1):
tools lib bpf: Fix maps resolution
Namhyung Kim (3):
perf callchain: Add option to skip ignore symbol when printing callchains
perf sched timehist: Mark schedule function in callchains
perf sched timehist: Enlarge max stack depth by 2
Ravi Bangoria (1):
perf annotate: Initial PowerPC support
Wang Nan (3):
perf tools: Fix kernel version error in ubuntu
perf record: Fix segfault when running with suid and kptr_restrict is 1
perf tools: Add missing struct definition in probe_event.h
tools/lib/bpf/libbpf.c | 142 ++++++++++++++-------
tools/perf/arch/arm/annotate/instructions.c | 147 +++++++++-------------
tools/perf/arch/powerpc/annotate/instructions.c | 58 +++++++++
tools/perf/builtin-sched.c | 26 +++-
tools/perf/ui/browsers/annotate.c | 18 +--
tools/perf/util/annotate.c | 157 +++++++++++++++++-------
tools/perf/util/annotate.h | 17 ++-
tools/perf/util/evsel.h | 1 +
tools/perf/util/evsel_fprintf.c | 7 +-
tools/perf/util/probe-event.h | 2 +
tools/perf/util/symbol.c | 2 +-
tools/perf/util/symbol.h | 1 +
tools/perf/util/util.c | 55 ++++++++-
13 files changed, 431 insertions(+), 202 deletions(-)
create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c
Rebuilding containers, so limited coverage at this time:
# dm
1 debian:experimental: Ok
2 fedora:24: Ok
3 fedora:24-x-ARC-uClibc: Ok
4 fedora:rawhide: Ok
5 opensuse:tumbleweed: Ok
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: detect openat syscall event : Ok
3: detect openat syscall event on all cpus : Ok
4: read samples using the mmap interface : Ok
5: parse events tests : Ok
6: Validate PERF_RECORD_* events & perf_sample fields : Ok
7: Test perf pmu format parsing : Ok
8: Test dso data read : Ok
9: Test dso data cache : Ok
10: Test dso data reopen : Ok
11: roundtrip evsel->name check : Ok
12: Check parsing of sched tracepoints fields : Ok
13: Generate and check syscalls:sys_enter_openat event fields: Ok
14: struct perf_event_attr setup : Ok
15: Test matching and linking multiple hists : Ok
16: Try 'import perf' in python, checking link problems : Ok
17: Test breakpoint overflow signal handler : Ok
18: Test breakpoint overflow sampling : Ok
19: Test number of exit event of a simple workload : Ok
20: Test software clock events have valid period values : Ok
21: Test object code reading : Ok
22: Test sample parsing : Ok
23: Test using a dummy software event to keep tracking : Ok
24: Test parsing with no sample_id_all bit set : Ok
25: Test filtering hist entries : Ok
26: Test mmap thread lookup : Ok
27: Test thread mg sharing : Ok
28: Test output sorting of hist entries : Ok
29: Test cumulation of child hist entries : Ok
30: Test tracking with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: Test kmod_path__parse function : Ok
34: Test thread map : Ok
35: Test LLVM searching and compiling :
35.1: Basic BPF llvm compiling test : Ok
35.2: Test kbuild searching : Ok
35.3: Compile source for BPF prologue generation test : Ok
35.4: Compile source for BPF relocation test : Ok
36: Test topology in session : Ok
37: Test BPF filter :
37.1: Test basic BPF filtering : Ok
37.2: Test BPF prologue generation : Ok
37.3: Test BPF relocation checker : Ok
38: Test thread map synthesize : Ok
39: Test cpu map synthesize : Ok
40: Test stat config synthesize : Ok
41: Test stat synthesize : Ok
42: Test stat round synthesize : Ok
43: Test attr update synthesize : Ok
44: Test events times : Ok
45: Test backward reading from ring buffer : Ok
46: Test cpu map print : Ok
47: Test SDT event probing : Ok
48: Test is_printable_array function : Ok
49: Test bitmap print : Ok
50: x86 rdpmc test : Ok
51: Test converting perf time to TSC : Ok
52: Test dwarf unwind : Ok
53: Test x86 instruction decoder - new instructions : Ok
54: Test intel cqm nmi context read : Skip
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_slang_O: make NO_SLANG=1
make_no_gtk2_O: make NO_GTK2=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_newt_O: make NO_NEWT=1
make_util_map_o_O: make util/map.o
make_pure_O: make
make_no_libbpf_O: make NO_LIBBPF=1
make_doc_O: make doc
make_no_libnuma_O: make NO_LIBNUMA=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_tags_O: make tags
make_install_prefix_O: make install prefix=/tmp/krava
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_static_O: make LDFLAGS=-static
make_debug_O: make DEBUG=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_perf_o_O: make perf.o
make_no_libbionic_O: make NO_LIBBIONIC=1
make_clean_all_O: make clean all
make_no_backtrace_O: make NO_BACKTRACE=1
make_install_O: make install
make_no_libunwind_O: make NO_LIBUNWIND=1
make_install_bin_O: make install-bin
make_no_libelf_O: make NO_LIBELF=1
make_help_O: make help
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2016-11-25 15:12 Arnaldo Carvalho de Melo
@ 2016-11-25 17:14 ` Ingo Molnar
0 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2016-11-25 17:14 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin,
Alexei Starovoitov, Andi Kleen, Chris Riyder, David Ahern,
Eric Leblond, He Kuang, Jiri Olsa, Kim Phillips,
Markus Trippelsdorf, Masami Hiramatsu, Namhyung Kim,
Naveen N . Rao, Pawel Moll, Peter Zijlstra, pi3orama,
Ravi Bangoria, Russell King, Stephane Eranian, Taeung Song,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message.
>
> The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2:
>
> Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125
>
> for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5:
>
> tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Improve ARM support in the annotation code, affecting 'perf annotate', 'perf
> report' and live annotation in 'perf top' (Kim Phillips)
>
> - Initial support for PowerPC in the annotation code (Ravi Bangoria)
>
> - Skip repetitive scheduler function on the top of the stack in
> 'perf sched timehist' (Namhyung Kim)
>
> Fixes:
>
> - Fix maps resolution in libbpf (Eric Leblond)
>
> - Get the kernel signature via /proc/version_signature, available on
> ubuntu systems, to make sure bpf proggies works, as the one provided
> via 'uname -r' doesn't (Wang Nan)
>
> - Fix segfault in 'perf record' when running with suid and kptr_restrict
> is 1 (Wang Nan)
>
> Infrastructure:
>
> - Support per-arch instruction tables, kept via a static or dynamic table
> (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
> perf annotate: Remove duplicate 'name' field from disasm_line
> perf annotate: Introduce alternative method of keeping instructions table
> perf annotate: Allow arches to have a init routine and a priv area
> perf annotate: Improve support for ARM
>
> Eric Leblond (1):
> tools lib bpf: Fix maps resolution
>
> Namhyung Kim (3):
> perf callchain: Add option to skip ignore symbol when printing callchains
> perf sched timehist: Mark schedule function in callchains
> perf sched timehist: Enlarge max stack depth by 2
>
> Ravi Bangoria (1):
> perf annotate: Initial PowerPC support
>
> Wang Nan (3):
> perf tools: Fix kernel version error in ubuntu
> perf record: Fix segfault when running with suid and kptr_restrict is 1
> perf tools: Add missing struct definition in probe_event.h
>
> tools/lib/bpf/libbpf.c | 142 ++++++++++++++-------
> tools/perf/arch/arm/annotate/instructions.c | 147 +++++++++-------------
> tools/perf/arch/powerpc/annotate/instructions.c | 58 +++++++++
> tools/perf/builtin-sched.c | 26 +++-
> tools/perf/ui/browsers/annotate.c | 18 +--
> tools/perf/util/annotate.c | 157 +++++++++++++++++-------
> tools/perf/util/annotate.h | 17 ++-
> tools/perf/util/evsel.h | 1 +
> tools/perf/util/evsel_fprintf.c | 7 +-
> tools/perf/util/probe-event.h | 2 +
> tools/perf/util/symbol.c | 2 +-
> tools/perf/util/symbol.h | 1 +
> tools/perf/util/util.c | 55 ++++++++-
> 13 files changed, 431 insertions(+), 202 deletions(-)
> create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c
>
> Rebuilding containers, so limited coverage at this time:
> # dm
> 1 debian:experimental: Ok
> 2 fedora:24: Ok
> 3 fedora:24-x-ARC-uClibc: Ok
> 4 fedora:rawhide: Ok
> 5 opensuse:tumbleweed: Ok
>
> # perf test
> 1: vmlinux symtab matches kallsyms : Ok
> 2: detect openat syscall event : Ok
> 3: detect openat syscall event on all cpus : Ok
> 4: read samples using the mmap interface : Ok
> 5: parse events tests : Ok
> 6: Validate PERF_RECORD_* events & perf_sample fields : Ok
> 7: Test perf pmu format parsing : Ok
> 8: Test dso data read : Ok
> 9: Test dso data cache : Ok
> 10: Test dso data reopen : Ok
> 11: roundtrip evsel->name check : Ok
> 12: Check parsing of sched tracepoints fields : Ok
> 13: Generate and check syscalls:sys_enter_openat event fields: Ok
> 14: struct perf_event_attr setup : Ok
> 15: Test matching and linking multiple hists : Ok
> 16: Try 'import perf' in python, checking link problems : Ok
> 17: Test breakpoint overflow signal handler : Ok
> 18: Test breakpoint overflow sampling : Ok
> 19: Test number of exit event of a simple workload : Ok
> 20: Test software clock events have valid period values : Ok
> 21: Test object code reading : Ok
> 22: Test sample parsing : Ok
> 23: Test using a dummy software event to keep tracking : Ok
> 24: Test parsing with no sample_id_all bit set : Ok
> 25: Test filtering hist entries : Ok
> 26: Test mmap thread lookup : Ok
> 27: Test thread mg sharing : Ok
> 28: Test output sorting of hist entries : Ok
> 29: Test cumulation of child hist entries : Ok
> 30: Test tracking with sched_switch : Ok
> 31: Filter fds with revents mask in a fdarray : Ok
> 32: Add fd to a fdarray, making it autogrow : Ok
> 33: Test kmod_path__parse function : Ok
> 34: Test thread map : Ok
> 35: Test LLVM searching and compiling :
> 35.1: Basic BPF llvm compiling test : Ok
> 35.2: Test kbuild searching : Ok
> 35.3: Compile source for BPF prologue generation test : Ok
> 35.4: Compile source for BPF relocation test : Ok
> 36: Test topology in session : Ok
> 37: Test BPF filter :
> 37.1: Test basic BPF filtering : Ok
> 37.2: Test BPF prologue generation : Ok
> 37.3: Test BPF relocation checker : Ok
> 38: Test thread map synthesize : Ok
> 39: Test cpu map synthesize : Ok
> 40: Test stat config synthesize : Ok
> 41: Test stat synthesize : Ok
> 42: Test stat round synthesize : Ok
> 43: Test attr update synthesize : Ok
> 44: Test events times : Ok
> 45: Test backward reading from ring buffer : Ok
> 46: Test cpu map print : Ok
> 47: Test SDT event probing : Ok
> 48: Test is_printable_array function : Ok
> 49: Test bitmap print : Ok
> 50: x86 rdpmc test : Ok
> 51: Test converting perf time to TSC : Ok
> 52: Test dwarf unwind : Ok
> 53: Test x86 instruction decoder - new instructions : Ok
> 54: Test intel cqm nmi context read : Skip
> #
> $ make -C tools/perf build-test
> make: Entering directory '/home/acme/git/linux/tools/perf'
> - tarpkg: ./tests/perf-targz-src-pkg .
> make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
> make_no_slang_O: make NO_SLANG=1
> make_no_gtk2_O: make NO_GTK2=1
> make_no_libperl_O: make NO_LIBPERL=1
> make_no_libaudit_O: make NO_LIBAUDIT=1
> make_with_babeltrace_O: make LIBBABELTRACE=1
> make_no_newt_O: make NO_NEWT=1
> make_util_map_o_O: make util/map.o
> make_pure_O: make
> make_no_libbpf_O: make NO_LIBBPF=1
> make_doc_O: make doc
> make_no_libnuma_O: make NO_LIBNUMA=1
> make_util_pmu_bison_o_O: make util/pmu-bison.o
> make_tags_O: make tags
> make_install_prefix_O: make install prefix=/tmp/krava
> make_no_demangle_O: make NO_DEMANGLE=1
> make_no_libpython_O: make NO_LIBPYTHON=1
> make_static_O: make LDFLAGS=-static
> make_debug_O: make DEBUG=1
> make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
> make_install_prefix_slash_O: make install prefix=/tmp/krava/
> make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
> make_no_auxtrace_O: make NO_AUXTRACE=1
> make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
> make_perf_o_O: make perf.o
> make_no_libbionic_O: make NO_LIBBIONIC=1
> make_clean_all_O: make clean all
> make_no_backtrace_O: make NO_BACKTRACE=1
> make_install_O: make install
> make_no_libunwind_O: make NO_LIBUNWIND=1
> make_install_bin_O: make install-bin
> make_no_libelf_O: make NO_LIBELF=1
> make_help_O: make help
> OK
> make: Leaving directory '/home/acme/git/linux/tools/perf'
> $
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2016-09-08 20:46 Arnaldo Carvalho de Melo
2016-09-09 5:47 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-09-08 20:46 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Anshuman Khandual, David Ahern,
David Carrillo-Cisneros, He Kuang, Hou Pengyang, Jiri Olsa,
Kan Liang, Linus Torvalds, Mark Rutland, Masami Hiramatsu,
Namhyung Kim, Nilay Vaish, Peter Zijlstra, Ravi Bangoria,
Stephane Eranian, Wang Nan, Will Deacon, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d:
Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908
for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c:
perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Add branch stack / basic block info to 'perf annotate --stdio', where for
each branch, we add an asm comment after the instruction with information on
how often it was taken and predicted. See example with color output at:
http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png
(Peter Zijlstra)
- Only open an evsel in CPUs in its cpu map, fixing some use cases in
systems with multiple PMUs with different CPU maps (Mark Rutland)
- Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan)
Infrastructure:
- Remove the symbol filtering code, i.e. the callbacks passed to all functions
that could end up loading a DSO symtab, simplifying the code, eventually
allowing what we should have had since day one: removing the 'map' parameter
from dso__load() functions (Arnaldo Carvalho de Melo)
Arch specific build fixes:
- Fix detached tarball build on powerpc, where we were still accessing a
file outside tools/ (Ravi Bangoria)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
perf symbols: Mark if a symbol is idle in the library
perf top: Remove old kernel-only symbol filter
perf machine: Remove machine->symbol_filter and friends
perf test vmlinux: Remove dead symbol_filter_t code
perf symbols: Remove symbol_filter_t machinery
Mark Rutland (2):
perf evlist: Only open events on CPUs an evsel permits
perf pmu: Support alternative sysfs cpumask
Peter Zijlstra (1):
perf annotate: Add branch stack / basic block
Ravi Bangoria (1):
perf powerpc: Fix build-test failure
Wang Nan (3):
perf tools: Recognize hugetlb mapping as anon mapping
tools lib api fs: Add hugetlbfs filesystem detector
perf record: Mark MAP_HUGETLB when synthesizing mmap events
tools/lib/api/fs/fs.c | 15 ++
tools/lib/api/fs/fs.h | 1 +
tools/perf/arch/powerpc/util/sym-handling.c | 2 +-
tools/perf/builtin-annotate.c | 104 +++++++++
tools/perf/builtin-inject.c | 2 +-
tools/perf/builtin-kmem.c | 10 +-
tools/perf/builtin-script.c | 4 +-
tools/perf/builtin-top.c | 30 ---
tools/perf/perf-sys.h | 1 -
tools/perf/tests/code-reading.c | 4 +-
tools/perf/tests/vmlinux-kallsyms.c | 17 +-
tools/perf/ui/browsers/annotate.c | 2 +-
tools/perf/ui/browsers/map.c | 4 +-
tools/perf/util/Build | 1 +
tools/perf/util/annotate.c | 95 +++++++-
tools/perf/util/annotate.h | 1 +
tools/perf/util/block-range.c | 328 ++++++++++++++++++++++++++++
tools/perf/util/block-range.h | 71 ++++++
tools/perf/util/event.c | 21 +-
tools/perf/util/evlist.c | 8 +-
tools/perf/util/intel-bts.c | 2 +-
tools/perf/util/intel-pt.c | 4 +-
tools/perf/util/machine.c | 38 +---
tools/perf/util/machine.h | 34 +--
tools/perf/util/map.c | 50 ++---
tools/perf/util/map.h | 32 +--
tools/perf/util/pmu.c | 15 +-
tools/perf/util/probe-event.c | 17 +-
tools/perf/util/symbol-elf.c | 32 +--
tools/perf/util/symbol-minimal.c | 4 +-
tools/perf/util/symbol.c | 134 ++++++------
tools/perf/util/symbol.h | 20 +-
32 files changed, 817 insertions(+), 286 deletions(-)
create mode 100644 tools/perf/util/block-range.c
create mode 100644 tools/perf/util/block-range.h
Build stats:
[root@jouet ~]# time dm
1 69.078 alpine:3.4: Ok
2 24.055 android-ndk:r12b-arm: Ok
3 71.911 archlinux:latest: Ok
4 41.209 centos:5: Ok
5 58.240 centos:6: Ok
6 67.238 centos:7: Ok
7 62.040 debian:7: Ok
8 69.061 debian:8: Ok
9 38.124 debian:experimental: Ok
10 67.623 fedora:20: Ok
11 71.458 fedora:21: Ok
12 70.807 fedora:22: Ok
13 71.013 fedora:23: Ok
14 73.330 fedora:24: Ok
15 30.062 fedora:24-x-ARC-uClibc: Ok
16 77.616 fedora:rawhide: Ok
17 73.663 mageia:5: Ok
18 69.264 opensuse:13.2: Ok
19 71.532 opensuse:42.1: Ok
20 76.282 opensuse:tumbleweed: Ok
21 54.666 ubuntu:12.04.5: Ok
22 37.170 ubuntu:14.04: Ok
23 66.101 ubuntu:14.04.4: Ok
24 68.881 ubuntu:15.10: Ok
25 62.698 ubuntu:16.04: Ok
26 53.046 ubuntu:16.04-x-arm: Ok
27 51.609 ubuntu:16.04-x-arm64: Ok
28 51.842 ubuntu:16.04-x-powerpc64: Ok
29 53.347 ubuntu:16.04-x-powerpc64el: Ok
30 72.280 ubuntu:16.10: Ok
31 54.078 ubuntu:16.10-x-s390: Ok
real 31m19.919s
user 0m1.890s
sys 0m2.201s
[root@jouet ~]#
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2016-09-08 20:46 Arnaldo Carvalho de Melo
@ 2016-09-09 5:47 ` Ingo Molnar
0 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2016-09-09 5:47 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, Andi Kleen,
Anshuman Khandual, David Ahern, David Carrillo-Cisneros,
He Kuang, Hou Pengyang, Jiri Olsa, Kan Liang, Linus Torvalds,
Mark Rutland, Masami Hiramatsu, Namhyung Kim, Nilay Vaish,
Peter Zijlstra, Ravi Bangoria, Stephane Eranian, Wang Nan,
Will Deacon, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d:
>
> Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908
>
> for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c:
>
> perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Add branch stack / basic block info to 'perf annotate --stdio', where for
> each branch, we add an asm comment after the instruction with information on
> how often it was taken and predicted. See example with color output at:
>
> http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png
>
> (Peter Zijlstra)
>
> - Only open an evsel in CPUs in its cpu map, fixing some use cases in
> systems with multiple PMUs with different CPU maps (Mark Rutland)
>
> - Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan)
>
> Infrastructure:
>
> - Remove the symbol filtering code, i.e. the callbacks passed to all functions
> that could end up loading a DSO symtab, simplifying the code, eventually
> allowing what we should have had since day one: removing the 'map' parameter
> from dso__load() functions (Arnaldo Carvalho de Melo)
>
> Arch specific build fixes:
>
> - Fix detached tarball build on powerpc, where we were still accessing a
> file outside tools/ (Ravi Bangoria)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (5):
> perf symbols: Mark if a symbol is idle in the library
> perf top: Remove old kernel-only symbol filter
> perf machine: Remove machine->symbol_filter and friends
> perf test vmlinux: Remove dead symbol_filter_t code
> perf symbols: Remove symbol_filter_t machinery
>
> Mark Rutland (2):
> perf evlist: Only open events on CPUs an evsel permits
> perf pmu: Support alternative sysfs cpumask
>
> Peter Zijlstra (1):
> perf annotate: Add branch stack / basic block
>
> Ravi Bangoria (1):
> perf powerpc: Fix build-test failure
>
> Wang Nan (3):
> perf tools: Recognize hugetlb mapping as anon mapping
> tools lib api fs: Add hugetlbfs filesystem detector
> perf record: Mark MAP_HUGETLB when synthesizing mmap events
>
> tools/lib/api/fs/fs.c | 15 ++
> tools/lib/api/fs/fs.h | 1 +
> tools/perf/arch/powerpc/util/sym-handling.c | 2 +-
> tools/perf/builtin-annotate.c | 104 +++++++++
> tools/perf/builtin-inject.c | 2 +-
> tools/perf/builtin-kmem.c | 10 +-
> tools/perf/builtin-script.c | 4 +-
> tools/perf/builtin-top.c | 30 ---
> tools/perf/perf-sys.h | 1 -
> tools/perf/tests/code-reading.c | 4 +-
> tools/perf/tests/vmlinux-kallsyms.c | 17 +-
> tools/perf/ui/browsers/annotate.c | 2 +-
> tools/perf/ui/browsers/map.c | 4 +-
> tools/perf/util/Build | 1 +
> tools/perf/util/annotate.c | 95 +++++++-
> tools/perf/util/annotate.h | 1 +
> tools/perf/util/block-range.c | 328 ++++++++++++++++++++++++++++
> tools/perf/util/block-range.h | 71 ++++++
> tools/perf/util/event.c | 21 +-
> tools/perf/util/evlist.c | 8 +-
> tools/perf/util/intel-bts.c | 2 +-
> tools/perf/util/intel-pt.c | 4 +-
> tools/perf/util/machine.c | 38 +---
> tools/perf/util/machine.h | 34 +--
> tools/perf/util/map.c | 50 ++---
> tools/perf/util/map.h | 32 +--
> tools/perf/util/pmu.c | 15 +-
> tools/perf/util/probe-event.c | 17 +-
> tools/perf/util/symbol-elf.c | 32 +--
> tools/perf/util/symbol-minimal.c | 4 +-
> tools/perf/util/symbol.c | 134 ++++++------
> tools/perf/util/symbol.h | 20 +-
> 32 files changed, 817 insertions(+), 286 deletions(-)
> create mode 100644 tools/perf/util/block-range.c
> create mode 100644 tools/perf/util/block-range.h
>
> Build stats:
>
> [root@jouet ~]# time dm
> 1 69.078 alpine:3.4: Ok
> 2 24.055 android-ndk:r12b-arm: Ok
> 3 71.911 archlinux:latest: Ok
> 4 41.209 centos:5: Ok
> 5 58.240 centos:6: Ok
> 6 67.238 centos:7: Ok
> 7 62.040 debian:7: Ok
> 8 69.061 debian:8: Ok
> 9 38.124 debian:experimental: Ok
> 10 67.623 fedora:20: Ok
> 11 71.458 fedora:21: Ok
> 12 70.807 fedora:22: Ok
> 13 71.013 fedora:23: Ok
> 14 73.330 fedora:24: Ok
> 15 30.062 fedora:24-x-ARC-uClibc: Ok
> 16 77.616 fedora:rawhide: Ok
> 17 73.663 mageia:5: Ok
> 18 69.264 opensuse:13.2: Ok
> 19 71.532 opensuse:42.1: Ok
> 20 76.282 opensuse:tumbleweed: Ok
> 21 54.666 ubuntu:12.04.5: Ok
> 22 37.170 ubuntu:14.04: Ok
> 23 66.101 ubuntu:14.04.4: Ok
> 24 68.881 ubuntu:15.10: Ok
> 25 62.698 ubuntu:16.04: Ok
> 26 53.046 ubuntu:16.04-x-arm: Ok
> 27 51.609 ubuntu:16.04-x-arm64: Ok
> 28 51.842 ubuntu:16.04-x-powerpc64: Ok
> 29 53.347 ubuntu:16.04-x-powerpc64el: Ok
> 30 72.280 ubuntu:16.10: Ok
> 31 54.078 ubuntu:16.10-x-s390: Ok
>
> real 31m19.919s
> user 0m1.890s
> sys 0m2.201s
> [root@jouet ~]#
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2016-05-17 2:45 Arnaldo Carvalho de Melo
2016-05-20 6:23 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-17 2:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov,
Ananth N Mavinakayanahalli, Andi Kleen, Brendan Gregg,
David Ahern, Ekaterina Tumanova, Frederic Weisbecker, He Kuang,
Hemant Kumar, Jiri Olsa, Josh Poimboeuf, Kan Liang,
Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim,
Pekka Enberg, Peter Zijlstra, Stephane Eranian,
Sukadev Bhattiprolu, Thomas Gleixner, Vince Weaver, Wang Nan,
Zefan Li
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020:
perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516
for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e:
perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Honour the kernel.perf_event_max_stack knob more precisely by not counting
PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to
the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo)
- Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim)
- Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim)
- Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim)
- Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen)
- Store vdso buildid unconditionally, as it appears in callchains and
we're not checking those when creating the build-id table, so we
end up not being able to resolve VDSO symbols when doing analysis
on a different machine than the one where recording was done, possibly
of a different arch even (arm -> x86_64) (He Kuang)
Infrastructure:
- Generalize max_stack sysctl handler, will be used for configuring
multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo)
Cleanups:
- Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using
open coded strings (Masami Hiramatsu)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf stat: Avoid fractional digits for integer scales
Arnaldo Carvalho de Melo (6):
perf core: Generalize max_stack sysctl handler
perf core: Pass max stack as a perf_callchain_entry context
perf core: Add a 'nr' field to perf_event_callchain_context
perf core: Add perf_callchain_store_context() helper
perf core: Separate accounting of contexts and real addresses in a stack trace
perf tools: Separate accounting of contexts and real addresses in a stack trace
He Kuang (1):
perf symbols: Store vdso buildid unconditionally
Masami Hiramatsu (1):
perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE
Namhyung Kim (3):
perf stat: Fix indentation of stalled backend cycle
perf stat: Update runtime using cpu-clock event
perf stat: Use cpu-clock event for cpu targets
Documentation/sysctl/kernel.txt | 14 ++++++++++++++
arch/arc/kernel/perf_event.c | 6 +++---
arch/arm/kernel/perf_callchain.c | 10 +++++-----
arch/arm64/kernel/perf_callchain.c | 14 +++++++-------
arch/metag/kernel/perf_callchain.c | 10 +++++-----
arch/mips/kernel/perf_event.c | 12 ++++++------
arch/powerpc/perf/callchain.c | 20 ++++++++++----------
arch/s390/kernel/perf_event.c | 4 ++--
arch/sh/kernel/perf_callchain.c | 4 ++--
arch/sparc/kernel/perf_event.c | 14 +++++++-------
arch/tile/kernel/perf_event.c | 6 +++---
arch/x86/events/core.c | 14 +++++++-------
arch/xtensa/kernel/perf_event.c | 10 +++++-----
include/linux/perf_event.h | 34 +++++++++++++++++++++++++++++-----
include/uapi/linux/perf_event.h | 1 +
kernel/bpf/stackmap.c | 3 ++-
kernel/events/callchain.c | 36 ++++++++++++++++++++++++------------
kernel/sysctl.c | 11 ++++++++++-
tools/perf/builtin-buildid-cache.c | 8 ++++----
tools/perf/builtin-stat.c | 22 +++++++++++++---------
tools/perf/perf.c | 3 +++
tools/perf/util/annotate.c | 2 +-
tools/perf/util/build-id.c | 2 +-
tools/perf/util/dso.c | 3 ++-
tools/perf/util/machine.c | 28 ++++++++++++++++++----------
tools/perf/util/stat-shadow.c | 8 +++++---
tools/perf/util/symbol.c | 10 +++++-----
tools/perf/util/symbol.h | 3 +++
tools/perf/util/util.c | 3 ++-
tools/perf/util/util.h | 3 ++-
30 files changed, 201 insertions(+), 117 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2016-05-17 2:45 Arnaldo Carvalho de Melo
@ 2016-05-20 6:23 ` Ingo Molnar
0 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2016-05-20 6:23 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov,
Ananth N Mavinakayanahalli, Andi Kleen, Brendan Gregg,
David Ahern, Ekaterina Tumanova, Frederic Weisbecker, He Kuang,
Hemant Kumar, Jiri Olsa, Josh Poimboeuf, Kan Liang,
Linus Torvalds, Masami Hiramatsu, Milian Wolff, Namhyung Kim,
Pekka Enberg, Peter Zijlstra, Stephane Eranian,
Sukadev Bhattiprolu, Thomas Gleixner, Vince Weaver, Wang Nan,
Zefan Li
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020:
>
> perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516
>
> for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e:
>
> perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Honour the kernel.perf_event_max_stack knob more precisely by not counting
> PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to
> the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo)
>
> - Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim)
>
> - Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim)
>
> - Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim)
>
> - Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen)
>
> - Store vdso buildid unconditionally, as it appears in callchains and
> we're not checking those when creating the build-id table, so we
> end up not being able to resolve VDSO symbols when doing analysis
> on a different machine than the one where recording was done, possibly
> of a different arch even (arm -> x86_64) (He Kuang)
>
> Infrastructure:
>
> - Generalize max_stack sysctl handler, will be used for configuring
> multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo)
>
> Cleanups:
>
> - Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using
> open coded strings (Masami Hiramatsu)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf stat: Avoid fractional digits for integer scales
>
> Arnaldo Carvalho de Melo (6):
> perf core: Generalize max_stack sysctl handler
> perf core: Pass max stack as a perf_callchain_entry context
> perf core: Add a 'nr' field to perf_event_callchain_context
> perf core: Add perf_callchain_store_context() helper
> perf core: Separate accounting of contexts and real addresses in a stack trace
> perf tools: Separate accounting of contexts and real addresses in a stack trace
>
> He Kuang (1):
> perf symbols: Store vdso buildid unconditionally
>
> Masami Hiramatsu (1):
> perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE
>
> Namhyung Kim (3):
> perf stat: Fix indentation of stalled backend cycle
> perf stat: Update runtime using cpu-clock event
> perf stat: Use cpu-clock event for cpu targets
>
> Documentation/sysctl/kernel.txt | 14 ++++++++++++++
> arch/arc/kernel/perf_event.c | 6 +++---
> arch/arm/kernel/perf_callchain.c | 10 +++++-----
> arch/arm64/kernel/perf_callchain.c | 14 +++++++-------
> arch/metag/kernel/perf_callchain.c | 10 +++++-----
> arch/mips/kernel/perf_event.c | 12 ++++++------
> arch/powerpc/perf/callchain.c | 20 ++++++++++----------
> arch/s390/kernel/perf_event.c | 4 ++--
> arch/sh/kernel/perf_callchain.c | 4 ++--
> arch/sparc/kernel/perf_event.c | 14 +++++++-------
> arch/tile/kernel/perf_event.c | 6 +++---
> arch/x86/events/core.c | 14 +++++++-------
> arch/xtensa/kernel/perf_event.c | 10 +++++-----
> include/linux/perf_event.h | 34 +++++++++++++++++++++++++++++-----
> include/uapi/linux/perf_event.h | 1 +
> kernel/bpf/stackmap.c | 3 ++-
> kernel/events/callchain.c | 36 ++++++++++++++++++++++++------------
> kernel/sysctl.c | 11 ++++++++++-
> tools/perf/builtin-buildid-cache.c | 8 ++++----
> tools/perf/builtin-stat.c | 22 +++++++++++++---------
> tools/perf/perf.c | 3 +++
> tools/perf/util/annotate.c | 2 +-
> tools/perf/util/build-id.c | 2 +-
> tools/perf/util/dso.c | 3 ++-
> tools/perf/util/machine.c | 28 ++++++++++++++++++----------
> tools/perf/util/stat-shadow.c | 8 +++++---
> tools/perf/util/symbol.c | 10 +++++-----
> tools/perf/util/symbol.h | 3 +++
> tools/perf/util/util.c | 3 ++-
> tools/perf/util/util.h | 3 ++-
> 30 files changed, 201 insertions(+), 117 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2015-11-05 16:02 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-11-05 16:02 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, Andrew Morton, David Ahern,
Jiri Olsa, Kan Liang, Markus Trippelsdorf, Masami Hiramatsu,
Namhyung Kim, Paul Mackerras, Peter Feiner, Peter Zijlstra,
pi3orama, Thomas Gleixner, Wang Nan, Yunlong Song, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit bebd23a2ed31d47e7dd746d3b125068aa2c42d85:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-30 10:09:37 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 0014de172d228e450377d1fd079d94e67128d27f:
perf sched latency: Fix thread pid reuse issue (2015-11-05 12:51:00 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix 'perf top' segfault related to splitting overlapping mmaps (Jiri Olsa)
- Fix 'perf sched latency' when there is pid/tid reuse (Jiri Olsa)
- Fix documentation for 'perf trace -i' (Peter Feiner)
Infrastructure:
- Make the LINUX_VERSION_CODE define available for bpf scriptlets to use (Wang Nan)
- Pass the number of configured CPUs via the __NR_CPUS__ define to bpf scriptlets (Wang Nan)
- Fix libbpf compiler warning on CentOS 6 (Namhyung Kim)
- Only be verbose in several perf test entries, bpf included, when -v is used (Wang Nan)
- Don't run the 'build-test' entries always in the same order, the full
set takes a long time, so sometimes we interrupt, shuffling them avoids
running just the first same few in interrupted runs (Arnaldo Carvalho de Melo)
- Change FEATURE-DUMP to FEATURE-DUMP.libbpf in .gitignore and 'clean' make target (Yunlong Song)
- 'perf stat' refactorings to avoid duplicated code (Andi Kleen)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (2):
perf stat: Move sw clock metrics printout to stat-shadow
perf stat: Use common printout function to avoid duplicated code
Arnaldo Carvalho de Melo (1):
perf tools: Allow shuffling the build tests
Jiri Olsa (2):
perf tools: Insert split maps correctly into origin group
perf sched latency: Fix thread pid reuse issue
Namhyung Kim (1):
tools lib bpf: Fix compiler warning on CentOS 6
Peter Feiner (1):
perf trace: Fix documentation for -i
Wang Nan (5):
perf test: Keep test result clean if '-v' not set
perf bpf: Mute libbpf when '-v' not set
perf llvm: Pass number of configured CPUs to clang compiler
perf llvm: Pass LINUX_VERSION_CODE to BPF program when compiling
perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success
Yunlong Song (1):
tools lib bpf: Change FEATURE-DUMP to FEATURE-DUMP.libbpf
tools/lib/bpf/.gitignore | 2 +-
tools/lib/bpf/Makefile | 2 +-
tools/lib/bpf/libbpf.c | 4 +--
tools/lib/bpf/libbpf.h | 2 +-
tools/perf/Documentation/perf-trace.txt | 1 -
tools/perf/Makefile | 2 +-
tools/perf/builtin-sched.c | 5 +--
tools/perf/builtin-stat.c | 59 +++++++++++----------------------
tools/perf/tests/attr.c | 3 +-
tools/perf/tests/code-reading.c | 8 ++---
tools/perf/tests/keep-tracking.c | 4 +--
tools/perf/tests/llvm.c | 11 +++---
tools/perf/tests/make | 5 +++
tools/perf/tests/switch-tracking.c | 4 +--
tools/perf/util/bpf-loader.c | 4 +--
tools/perf/util/llvm-utils.c | 51 ++++++++++++++++++++++++----
tools/perf/util/map.c | 10 ++++--
tools/perf/util/probe-event.c | 3 ++
tools/perf/util/stat-shadow.c | 5 +++
19 files changed, 110 insertions(+), 75 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2015-10-28 15:30 Arnaldo Carvalho de Melo
2015-10-29 9:36 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-28 15:30 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, Borislav Petkov, Brendan Gregg,
Chandler Carruth, David Ahern, David S . Miller, Dima Kogan,
Frederic Weisbecker, Jiri Olsa, Kan Liang, Li Zefan,
Masami Hiramatsu, Michael Petlan, Namhyung Kim, Peter Zijlstra,
pi3orama, Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41:
perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Enable per-event perf_event_attr.inherit setting by config terms, i.e.
this becomes possible:
$ perf record -e cycles/inherit/ -e instructions/no-inherit/
This affects the default, that can be changed globally using the --no-inherit
option.
This fine grained control appeared in the eBPF patchkit, but this added
flexibility may end up being useful in other scenarios (Wang Nan)
- Setup pager when printing usage and help, we have long lists of options,
better use the pager like we do with normal tooling output, i.e. when needed,
and including any error messages in the paged output (Namhyung Kim)
- Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo)
$ perf report -h interface
Usage: perf report [<options>]
--gtk Use the GTK2 interface
--stdio Use the stdio interface
--tui Use the TUI interface
- Fix reading separate debuginfo files based on a build-id, problem
found on a Debian system (Dima Kogan)
- Fix endless loop when splitting kallsyms symbols per section for
handling kcore files, problem found on a s390x system (Jiri Olsa)
Infrastructure:
- Prep work for the 'perf stat record' work that will allow generating
perf.data files with counting data in addition to the sampling mode
we have now (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf tools: Search for more options when passing args to -h
Dima Kogan (2):
perf symbols: Fix type error when reading a build-id
perf symbols: we can now read separate debug-info files based on a build ID
Jiri Olsa (4):
perf evsel: Move id_offset out of struct perf_evsel union member
perf cpu_map: Add cpu_map__empty_new function
perf stat: Cache aggregated map entries in extra cpumap
perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore
Namhyung Kim (4):
perf tools: Improve ambiguous option help message
perf report: Rename to --show-cpu-utilization
perf tools: Setup pager when printing usage and help
perf tools: Introduce usage_with_options_msg()
Wang Nan (1):
perf tools: Enable pre-event inherit setting by config terms
tools/perf/Documentation/perf-report.txt | 2 +-
tools/perf/builtin-evlist.c | 4 +--
tools/perf/builtin-probe.c | 20 ++++++-----
tools/perf/builtin-record.c | 11 +++---
tools/perf/builtin-report.c | 4 ++-
tools/perf/builtin-sched.c | 4 +--
tools/perf/builtin-script.c | 8 ++---
tools/perf/builtin-stat.c | 59 +++++++++++++++++++++++++++---
tools/perf/util/cpumap.c | 17 +++++++++
tools/perf/util/cpumap.h | 1 +
tools/perf/util/evsel.c | 9 +++++
tools/perf/util/evsel.h | 4 ++-
tools/perf/util/parse-events.c | 14 ++++++++
tools/perf/util/parse-events.h | 2 ++
tools/perf/util/parse-events.l | 2 ++
tools/perf/util/parse-options.c | 62 +++++++++++++++++++++++++-------
tools/perf/util/parse-options.h | 5 +++
tools/perf/util/strbuf.c | 22 ++++++++----
tools/perf/util/strbuf.h | 2 ++
tools/perf/util/symbol-minimal.c | 2 +-
tools/perf/util/symbol.c | 11 +++++-
21 files changed, 216 insertions(+), 49 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2015-10-28 15:30 Arnaldo Carvalho de Melo
@ 2015-10-29 9:36 ` Ingo Molnar
2015-10-29 9:51 ` Ingo Molnar
2015-10-29 9:55 ` Jiri Olsa
0 siblings, 2 replies; 40+ messages in thread
From: Ingo Molnar @ 2015-10-29 9:36 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen,
Borislav Petkov, Brendan Gregg, Chandler Carruth, David Ahern,
David S . Miller, Dima Kogan, Frederic Weisbecker, Jiri Olsa,
Kan Liang, Li Zefan, Masami Hiramatsu, Michael Petlan,
Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian,
Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41:
>
> perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Enable per-event perf_event_attr.inherit setting by config terms, i.e.
> this becomes possible:
>
> $ perf record -e cycles/inherit/ -e instructions/no-inherit/
>
> This affects the default, that can be changed globally using the --no-inherit
> option.
>
> This fine grained control appeared in the eBPF patchkit, but this added
> flexibility may end up being useful in other scenarios (Wang Nan)
>
> - Setup pager when printing usage and help, we have long lists of options,
> better use the pager like we do with normal tooling output, i.e. when needed,
> and including any error messages in the paged output (Namhyung Kim)
>
> - Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo)
>
> $ perf report -h interface
>
> Usage: perf report [<options>]
>
> --gtk Use the GTK2 interface
> --stdio Use the stdio interface
> --tui Use the TUI interface
I love this! For example if I'd like to know what symbol related options we have,
I only have to type:
triton:~/tip> perf top -h sym
Usage: perf top [<options>]
-D, --dump-symtab dump the symbol table used for profiling
-K, --hide_kernel_symbols
hide kernel symbols
-s, --sort <key[,key2...]>
sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ... Please refer the man page for the complete list.
-U, --hide_user_symbols
hide user symbols
--comms <comm[,comm...]>
only consider symbols in these comms
--demangle-kernel
Enable kernel symbol demangling
--dsos <dso[,dso...]>
only consider symbols in these dsos
--sym-annotate <symbol name>
symbol to annotate
--symbols <symbol[,symbol...]>
only consider these symbols
and it's a nice touch that it's searching in the parameter descriptions as well,
not just the parameter name. Thus if I only remember some sort of keyword that's
enough to narrow things down and figure out the option.
One small detail I noticed, for some reason the following search does not work:
triton:~/tip> perf report -h --invert
Usage: perf report [<options>]
It only works if I don't use the dashes:
triton:~/tip> perf report -h invert
Usage: perf report [<options>]
-G, --inverted alias for inverted call graph
... which is a bit surprising, agreed?
> - Fix reading separate debuginfo files based on a build-id, problem
> found on a Debian system (Dima Kogan)
>
> - Fix endless loop when splitting kallsyms symbols per section for
> handling kcore files, problem found on a s390x system (Jiri Olsa)
Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well?
>
> Infrastructure:
>
> - Prep work for the 'perf stat record' work that will allow generating
> perf.data files with counting data in addition to the sampling mode
> we have now (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf tools: Search for more options when passing args to -h
>
> Dima Kogan (2):
> perf symbols: Fix type error when reading a build-id
> perf symbols: we can now read separate debug-info files based on a build ID
>
> Jiri Olsa (4):
> perf evsel: Move id_offset out of struct perf_evsel union member
> perf cpu_map: Add cpu_map__empty_new function
> perf stat: Cache aggregated map entries in extra cpumap
> perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore
>
> Namhyung Kim (4):
> perf tools: Improve ambiguous option help message
> perf report: Rename to --show-cpu-utilization
> perf tools: Setup pager when printing usage and help
> perf tools: Introduce usage_with_options_msg()
>
> Wang Nan (1):
> perf tools: Enable pre-event inherit setting by config terms
>
> tools/perf/Documentation/perf-report.txt | 2 +-
> tools/perf/builtin-evlist.c | 4 +--
> tools/perf/builtin-probe.c | 20 ++++++-----
> tools/perf/builtin-record.c | 11 +++---
> tools/perf/builtin-report.c | 4 ++-
> tools/perf/builtin-sched.c | 4 +--
> tools/perf/builtin-script.c | 8 ++---
> tools/perf/builtin-stat.c | 59 +++++++++++++++++++++++++++---
> tools/perf/util/cpumap.c | 17 +++++++++
> tools/perf/util/cpumap.h | 1 +
> tools/perf/util/evsel.c | 9 +++++
> tools/perf/util/evsel.h | 4 ++-
> tools/perf/util/parse-events.c | 14 ++++++++
> tools/perf/util/parse-events.h | 2 ++
> tools/perf/util/parse-events.l | 2 ++
> tools/perf/util/parse-options.c | 62 +++++++++++++++++++++++++-------
> tools/perf/util/parse-options.h | 5 +++
> tools/perf/util/strbuf.c | 22 ++++++++----
> tools/perf/util/strbuf.h | 2 ++
> tools/perf/util/symbol-minimal.c | 2 +-
> tools/perf/util/symbol.c | 11 +++++-
> 21 files changed, 216 insertions(+), 49 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2015-10-29 9:36 ` Ingo Molnar
@ 2015-10-29 9:51 ` Ingo Molnar
2015-10-29 9:55 ` Jiri Olsa
1 sibling, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2015-10-29 9:51 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen,
Borislav Petkov, Brendan Gregg, Chandler Carruth, David Ahern,
David S . Miller, Dima Kogan, Frederic Weisbecker, Jiri Olsa,
Kan Liang, Li Zefan, Masami Hiramatsu, Michael Petlan,
Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian,
Wang Nan, Arnaldo Carvalho de Melo
* Ingo Molnar <mingo@kernel.org> wrote:
> One small detail I noticed, for some reason the following search does not work:
>
> triton:~/tip> perf report -h --invert
>
> Usage: perf report [<options>]
>
Btw., another detail, if it searches but does not try, I think we should output a
warning to the user.
Printing something like this would be more helpful:
triton:~/tip> perf report -h --invert
Search pattern '--invert' not found amongst the parameters. To resolve this
use a different search pattern or use '-h' to list all parameters.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2015-10-29 9:36 ` Ingo Molnar
2015-10-29 9:51 ` Ingo Molnar
@ 2015-10-29 9:55 ` Jiri Olsa
1 sibling, 0 replies; 40+ messages in thread
From: Jiri Olsa @ 2015-10-29 9:55 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, Borislav Petkov, Brendan Gregg,
Chandler Carruth, David Ahern, David S . Miller, Dima Kogan,
Frederic Weisbecker, Kan Liang, Li Zefan, Masami Hiramatsu,
Michael Petlan, Namhyung Kim, Peter Zijlstra, pi3orama,
Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo
On Thu, Oct 29, 2015 at 10:36:36AM +0100, Ingo Molnar wrote:
SNIP
>
> > - Fix reading separate debuginfo files based on a build-id, problem
> > found on a Debian system (Dima Kogan)
> >
> > - Fix endless loop when splitting kallsyms symbols per section for
> > handling kcore files, problem found on a s390x system (Jiri Olsa)
>
> Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well?
it could go to perf/urgent as well
jirka
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2015-08-05 20:11 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-08-05 20:11 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, David Ahern, Frederic Weisbecker,
Jiri Olsa, Kan Liang, Milian Wolff, Namhyung Kim, Peter Zijlstra,
Petri Gynther, Stephane Eranian, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, way more to process in the next days, with the
patchkit for eBPF looking good, perf stat stuff from Jiri and some new hardware
stuff from Andi.
- Arnaldo
The following changes since commit 75f80859b130a1cc84e59e71295ce2dd51fe1c81:
perf/x86/intel/pebs: Robustify PEBS buffer drain (2015-08-04 10:17:01 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to f151f53aa4f54a647353e1935e4c6cef7f094dd4:
perf tools: Fix build errors with mipsel-linux-uclibc compiler (2015-08-05 16:56:16 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Deref sys_enter pointer args with contents from probe:vfs_getname, showing
pathnames instead of pointers in many syscalls in 'perf trace' (Arnaldo Carvalho de Melo)
- Make 'perf trace' write to stderr by default, just like 'strace' (Milian Woff)
Infrastructure:
- color_vfprintf() fixes (Andi Kleen, Jiri Olsa)
- Allow enabling/disabling PERF_SAMPLE_TIME per event (Kan Liang)
- Fix build errors with mipsel-linux-uclibc compiler (Petri Gynther)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf tools: Do not include escape sequences in color_vfprintf return
Arnaldo Carvalho de Melo (6):
perf script: No tracepoints? Don't call libtraceevent.
perf trace: Do not show syscall tracepoint filter in the --no-syscalls case
perf trace: Remember if the vfs_getname tracepoint/kprobe is in place
perf trace: Use a constant for the syscall formatting buffer
perf trace: Deref sys_enter pointer args with contents from probe:vfs_getname
perf trace: Use vfs_getname syscall arg beautifier in more syscalls
Jiri Olsa (1):
perf tools: Remove trail argument to color vsprintf
Kan Liang (2):
perf tools: Per-event time support
perf tools: Refine parse/config callchain functions
Milian Wolff (1):
perf trace: Write to stderr by default
Petri Gynther (1):
perf tools: Fix build errors with mipsel-linux-uclibc compiler
tools/build/feature/test-glibc.c | 11 ++
tools/perf/Documentation/perf-record.txt | 4 +-
tools/perf/builtin-record.c | 2 +-
tools/perf/builtin-script.c | 3 +-
tools/perf/builtin-trace.c | 175 +++++++++++++++++++++++++++----
tools/perf/util/callchain.c | 14 +--
tools/perf/util/callchain.h | 2 +-
tools/perf/util/cloexec.h | 2 +-
tools/perf/util/color.c | 21 +---
tools/perf/util/color.h | 1 -
tools/perf/util/evsel.c | 25 +++--
tools/perf/util/evsel.h | 2 +
tools/perf/util/parse-events.c | 12 +++
tools/perf/util/parse-events.h | 1 +
tools/perf/util/parse-events.l | 1 +
tools/perf/util/pmu.c | 2 +-
16 files changed, 220 insertions(+), 58 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2014-11-25 13:21 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-11-25 13:21 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, Corey Ashford, David Ahern,
Don Zickus, Frederic Weisbecker, Jiri Olsa, Matt Fleming,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 4e6e311e596eadba30d4f56f64eae7d45611a01c:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-11-20 08:32:01 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 1d9e446b91e182055d874fbb30150aad479a4981:
perf tools: Add snapshot format file parsing (2014-11-24 18:03:51 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Callchain improvements from Andi Kleen including:
* Enable printing the srcline in the history
* Make get_srcline fall back to sym+offset
- Allow to force redirect pr_debug to stderr. (Andi Kleen)
- TUI hist_entry browser fixes, including showing missing overhead
value for first level callchain. Detected comparing the output of
--stdio/--gui (that matched) with --tui, that had this problem. (Namhyung Kim)
- Fix segfault due to invalid kernel dso access (Namhyung Kim)
Infrastructure:
- Move bfd_demangle stubbing to its only user (Arnaldo Carvalho de Melo)
- 'perf stat' refactorings, moving stuff from it to evsel.c to use in
per-pkg/snapshot format changes (Jiri Olsa)
- Add per-pkg format file parsing (Matt Fleming)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (3):
perf callchain: Enable printing the srcline in the history
perf callchain: Make get_srcline fall back to sym+offset
perf tools: Allow to force redirect pr_debug to stderr.
Arnaldo Carvalho de Melo (1):
perf symbols: Move bfd_demangle stubbing to its only user
Jiri Olsa (4):
perf evsel: Introduce perf_evsel__compute_deltas function
perf evsel: Introduce perf_counts_values__scale function
perf evsel: Introduce perf_evsel__read_cb function
perf tools: Add snapshot format file parsing
Matt Fleming (1):
perf tools: Add per-pkg format file parsing
Namhyung Kim (3):
perf hists browser: Print overhead percent value for first-level callchain
perf tools: Collapse first level callchain entry if it has sibling
perf tools: Fix segfault due to invalid kernel dso access
tools/perf/ui/browsers/hists.c | 25 +++++++++++---
tools/perf/util/annotate.c | 2 +-
tools/perf/util/callchain.c | 12 ++++++-
tools/perf/util/callchain.h | 1 +
tools/perf/util/debug.c | 4 ++-
tools/perf/util/evsel.c | 72 +++++++++++++++++++++++-----------------
tools/perf/util/evsel.h | 15 +++++++++
tools/perf/util/machine.c | 4 +--
tools/perf/util/map.c | 2 +-
tools/perf/util/parse-events.c | 2 ++
tools/perf/util/pmu.c | 74 +++++++++++++++++++++++++++++++++++-------
tools/perf/util/pmu.h | 4 +++
tools/perf/util/sort.c | 6 ++--
tools/perf/util/srcline.c | 15 +++++++--
tools/perf/util/symbol-elf.c | 21 ++++++++++++
tools/perf/util/symbol.h | 21 ------------
tools/perf/util/util.h | 4 ++-
17 files changed, 205 insertions(+), 79 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2014-02-24 19:56 Arnaldo Carvalho de Melo
2014-02-27 11:46 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-02-24 19:56 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker,
Jean Pihet, Jiri Olsa, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
----------------------------------------------------------------
perf/core improvements and fixes
. Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
. Fix build race in the generation of bison files (Jiri Olsa)
. Further streamline the feature detection display, trimming it a bit to
show just the libraries detected, using VF=1 gets a more verbose output,
showing the less interesting feature checks as well (Jiri Olsa).
. Check compatible symtab type before loading dso (Namhyung Kim)
. Check return value of filename__read_debuglink() (Stephane Eranian)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf tools: Warn the user about how to enable libunwind support
Jiri Olsa (9):
perf tests: Fix *.o make tests
perf tests: Add pmu-bison.o make test
perf tools: Fix bison OUTPUT directories dependency
perf tools: Factor features display code
perf tools: Add variable display for VF make output
perf tools: Add feature check for libdw dwarf unwind
perf tools: Add libdw DWARF post unwind support
perf tools: Setup default dwarf post unwinder
perf tests: Add NO_LIBDW_DWARF_UNWIND make test
Namhyung Kim (1):
perf symbols: Check compatible symtab type before loading dso
Stephane Eranian (1):
perf symbols: Check return value of filename__read_debuglink()
tools/perf/Makefile.perf | 24 ++-
tools/perf/arch/x86/Makefile | 5 +
tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++
tools/perf/config/Makefile | 232 +++++++++++++++------
tools/perf/config/feature-checks/Makefile | 6 +-
tools/perf/config/feature-checks/test-all.c | 5 +
.../feature-checks/test-libdw-dwarf-unwind.c | 13 ++
tools/perf/tests/make | 25 ++-
tools/perf/util/dso.c | 4 +-
tools/perf/util/symbol-elf.c | 2 +
tools/perf/util/symbol.c | 61 +++++-
tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++
tools/perf/util/unwind-libdw.h | 21 ++
13 files changed, 569 insertions(+), 90 deletions(-)
create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
create mode 100644 tools/perf/util/unwind-libdw.c
create mode 100644 tools/perf/util/unwind-libdw.h
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2014-02-24 19:56 Arnaldo Carvalho de Melo
@ 2014-02-27 11:46 ` Ingo Molnar
2014-02-27 12:02 ` Jiri Olsa
2014-02-27 12:04 ` Jiri Olsa
0 siblings, 2 replies; 40+ messages in thread
From: Ingo Molnar @ 2014-02-27 11:46 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Cody P Schafer, Corey Ashford, David Ahern, Frederic Weisbecker,
Jean Pihet, Jiri Olsa, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
>
> perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes
>
> . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
>
> . Fix build race in the generation of bison files (Jiri Olsa)
>
> . Further streamline the feature detection display, trimming it a bit to
> show just the libraries detected, using VF=1 gets a more verbose output,
> showing the less interesting feature checks as well (Jiri Olsa).
>
> . Check compatible symtab type before loading dso (Namhyung Kim)
>
> . Check return value of filename__read_debuglink() (Stephane Eranian)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf tools: Warn the user about how to enable libunwind support
>
> Jiri Olsa (9):
> perf tests: Fix *.o make tests
> perf tests: Add pmu-bison.o make test
> perf tools: Fix bison OUTPUT directories dependency
> perf tools: Factor features display code
> perf tools: Add variable display for VF make output
> perf tools: Add feature check for libdw dwarf unwind
> perf tools: Add libdw DWARF post unwind support
> perf tools: Setup default dwarf post unwinder
> perf tests: Add NO_LIBDW_DWARF_UNWIND make test
>
> Namhyung Kim (1):
> perf symbols: Check compatible symtab type before loading dso
>
> Stephane Eranian (1):
> perf symbols: Check return value of filename__read_debuglink()
>
> tools/perf/Makefile.perf | 24 ++-
> tools/perf/arch/x86/Makefile | 5 +
> tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++
> tools/perf/config/Makefile | 232 +++++++++++++++------
> tools/perf/config/feature-checks/Makefile | 6 +-
> tools/perf/config/feature-checks/test-all.c | 5 +
> .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++
> tools/perf/tests/make | 25 ++-
> tools/perf/util/dso.c | 4 +-
> tools/perf/util/symbol-elf.c | 2 +
> tools/perf/util/symbol.c | 61 +++++-
> tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++
> tools/perf/util/unwind-libdw.h | 21 ++
> 13 files changed, 569 insertions(+), 90 deletions(-)
> create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> create mode 100644 tools/perf/util/unwind-libdw.c
> create mode 100644 tools/perf/util/unwind-libdw.h
Pulled, thanks a lot Arnaldo!
Btw., the build output looks weird now - on a system that used to pass
all feature tests there's this output:
BUILD: Doing 'make -j12' parallel build
config/Makefile:288: No libdw DWARF unwind found, Please install
elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
Auto-detecting system features:
... dwarf: [ on ]
... glibc: [ on ]
... gtk2: [ on ]
... libaudit: [ on ]
... libbfd: [ on ]
... libelf: [ on ]
... libnuma: [ on ]
... libperl: [ on ]
... libpython: [ on ]
... libslang: [ on ]
... libunwind: [ on ]
... libdw-dwarf-unwind: [ OFF ]
... DWARF post unwind library: libunwind
but:
Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
Also, the information content of this line is unclear to me:
... DWARF post unwind library: libunwind
what does that line want to tell?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2014-02-27 11:46 ` Ingo Molnar
@ 2014-02-27 12:02 ` Jiri Olsa
2014-02-27 12:30 ` Ingo Molnar
2014-02-27 12:04 ` Jiri Olsa
1 sibling, 1 reply; 40+ messages in thread
From: Jiri Olsa @ 2014-02-27 12:02 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo,
Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern,
Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
>
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
>
> > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> >
> > Hi Ingo,
> >
> > Please consider pulling,
> >
> > - Arnaldo
> >
> > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> >
> > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> >
> > are available in the git repository at:
> >
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> >
> > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> >
> > perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> >
> > ----------------------------------------------------------------
> > perf/core improvements and fixes
> >
> > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> >
> > . Fix build race in the generation of bison files (Jiri Olsa)
> >
> > . Further streamline the feature detection display, trimming it a bit to
> > show just the libraries detected, using VF=1 gets a more verbose output,
> > showing the less interesting feature checks as well (Jiri Olsa).
> >
> > . Check compatible symtab type before loading dso (Namhyung Kim)
> >
> > . Check return value of filename__read_debuglink() (Stephane Eranian)
> >
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > ----------------------------------------------------------------
> > Arnaldo Carvalho de Melo (1):
> > perf tools: Warn the user about how to enable libunwind support
> >
> > Jiri Olsa (9):
> > perf tests: Fix *.o make tests
> > perf tests: Add pmu-bison.o make test
> > perf tools: Fix bison OUTPUT directories dependency
> > perf tools: Factor features display code
> > perf tools: Add variable display for VF make output
> > perf tools: Add feature check for libdw dwarf unwind
> > perf tools: Add libdw DWARF post unwind support
> > perf tools: Setup default dwarf post unwinder
> > perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> >
> > Namhyung Kim (1):
> > perf symbols: Check compatible symtab type before loading dso
> >
> > Stephane Eranian (1):
> > perf symbols: Check return value of filename__read_debuglink()
> >
> > tools/perf/Makefile.perf | 24 ++-
> > tools/perf/arch/x86/Makefile | 5 +
> > tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++
> > tools/perf/config/Makefile | 232 +++++++++++++++------
> > tools/perf/config/feature-checks/Makefile | 6 +-
> > tools/perf/config/feature-checks/test-all.c | 5 +
> > .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++
> > tools/perf/tests/make | 25 ++-
> > tools/perf/util/dso.c | 4 +-
> > tools/perf/util/symbol-elf.c | 2 +
> > tools/perf/util/symbol.c | 61 +++++-
> > tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++
> > tools/perf/util/unwind-libdw.h | 21 ++
> > 13 files changed, 569 insertions(+), 90 deletions(-)
> > create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> > create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> > create mode 100644 tools/perf/util/unwind-libdw.c
> > create mode 100644 tools/perf/util/unwind-libdw.h
>
> Pulled, thanks a lot Arnaldo!
>
> Btw., the build output looks weird now - on a system that used to pass
> all feature tests there's this output:
>
> BUILD: Doing 'make -j12' parallel build
> config/Makefile:288: No libdw DWARF unwind found, Please install
> elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... glibc: [ on ]
> ... gtk2: [ on ]
> ... libaudit: [ on ]
> ... libbfd: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libslang: [ on ]
> ... libunwind: [ on ]
> ... libdw-dwarf-unwind: [ OFF ]
> ... DWARF post unwind library: libunwind
>
> but:
>
> Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
>
> Also, the information content of this line is unclear to me:
>
> ... DWARF post unwind library: libunwind
>
>
> what does that line want to tell?
this tells what DWARF unwind library is compiled
in.. 'libunwind' in this case
the other choice is 'libdw', which was not detected
in your case (and thats what the 1st message tells you)
we discussed with Arnaldo, that we would not display warnings
for missing features by default.. only tell that there are
missing features and display them for verbose (VF=1) output
jirka
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2014-02-27 12:02 ` Jiri Olsa
@ 2014-02-27 12:30 ` Ingo Molnar
2014-02-27 12:40 ` Jiri Olsa
0 siblings, 1 reply; 40+ messages in thread
From: Ingo Molnar @ 2014-02-27 12:30 UTC (permalink / raw)
To: Jiri Olsa
Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo,
Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern,
Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Jiri Olsa <jolsa@redhat.com> wrote:
> On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> >
> > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> >
> > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > >
> > > Hi Ingo,
> > >
> > > Please consider pulling,
> > >
> > > - Arnaldo
> > >
> > > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> > >
> > > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> > >
> > > are available in the git repository at:
> > >
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> > >
> > > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> > >
> > > perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> > >
> > > ----------------------------------------------------------------
> > > perf/core improvements and fixes
> > >
> > > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> > >
> > > . Fix build race in the generation of bison files (Jiri Olsa)
> > >
> > > . Further streamline the feature detection display, trimming it a bit to
> > > show just the libraries detected, using VF=1 gets a more verbose output,
> > > showing the less interesting feature checks as well (Jiri Olsa).
> > >
> > > . Check compatible symtab type before loading dso (Namhyung Kim)
> > >
> > > . Check return value of filename__read_debuglink() (Stephane Eranian)
> > >
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > > Arnaldo Carvalho de Melo (1):
> > > perf tools: Warn the user about how to enable libunwind support
> > >
> > > Jiri Olsa (9):
> > > perf tests: Fix *.o make tests
> > > perf tests: Add pmu-bison.o make test
> > > perf tools: Fix bison OUTPUT directories dependency
> > > perf tools: Factor features display code
> > > perf tools: Add variable display for VF make output
> > > perf tools: Add feature check for libdw dwarf unwind
> > > perf tools: Add libdw DWARF post unwind support
> > > perf tools: Setup default dwarf post unwinder
> > > perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> > >
> > > Namhyung Kim (1):
> > > perf symbols: Check compatible symtab type before loading dso
> > >
> > > Stephane Eranian (1):
> > > perf symbols: Check return value of filename__read_debuglink()
> > >
> > > tools/perf/Makefile.perf | 24 ++-
> > > tools/perf/arch/x86/Makefile | 5 +
> > > tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++
> > > tools/perf/config/Makefile | 232 +++++++++++++++------
> > > tools/perf/config/feature-checks/Makefile | 6 +-
> > > tools/perf/config/feature-checks/test-all.c | 5 +
> > > .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++
> > > tools/perf/tests/make | 25 ++-
> > > tools/perf/util/dso.c | 4 +-
> > > tools/perf/util/symbol-elf.c | 2 +
> > > tools/perf/util/symbol.c | 61 +++++-
> > > tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++
> > > tools/perf/util/unwind-libdw.h | 21 ++
> > > 13 files changed, 569 insertions(+), 90 deletions(-)
> > > create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> > > create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> > > create mode 100644 tools/perf/util/unwind-libdw.c
> > > create mode 100644 tools/perf/util/unwind-libdw.h
> >
> > Pulled, thanks a lot Arnaldo!
> >
> > Btw., the build output looks weird now - on a system that used to pass
> > all feature tests there's this output:
> >
> > BUILD: Doing 'make -j12' parallel build
> > config/Makefile:288: No libdw DWARF unwind found, Please install
> > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> >
> > Auto-detecting system features:
> > ... dwarf: [ on ]
> > ... glibc: [ on ]
> > ... gtk2: [ on ]
> > ... libaudit: [ on ]
> > ... libbfd: [ on ]
> > ... libelf: [ on ]
> > ... libnuma: [ on ]
> > ... libperl: [ on ]
> > ... libpython: [ on ]
> > ... libslang: [ on ]
> > ... libunwind: [ on ]
> > ... libdw-dwarf-unwind: [ OFF ]
> > ... DWARF post unwind library: libunwind
> >
> > but:
> >
> > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> >
> > Also, the information content of this line is unclear to me:
> >
> > ... DWARF post unwind library: libunwind
> >
> >
> > what does that line want to tell?
>
> this tells what DWARF unwind library is compiled
> in.. 'libunwind' in this case
So my (stylistic) complaint is that it's really reading weird in a
table generated with the following purpose:
Auto-detecting system features:
Also, we already know that libunwind is present, because just in the
line before it, it says:
... libunwind: [ on ]
So it's doubly confusing. How about not displaying that line at all?
Is there a strong reason to not keep 'OFF' messages on a single line?
> the other choice is 'libdw', which was not detected in your case
> (and thats what the 1st message tells you)
>
> we discussed with Arnaldo, that we would not display warnings for
> missing features by default.. only tell that there are missing
> features and display them for verbose (VF=1) output
That's probably a good plan. I'd suggest the following 'short log' for
failures:
# Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list.
I.e. that way people can notice if the count goes up or down after an
update. Also, that too should be a single line, so that it does not
spam people.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2014-02-27 12:30 ` Ingo Molnar
@ 2014-02-27 12:40 ` Jiri Olsa
2014-02-27 12:45 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Jiri Olsa @ 2014-02-27 12:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo,
Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern,
Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote:
>
> * Jiri Olsa <jolsa@redhat.com> wrote:
>
> > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > >
> > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > >
> > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > >
SNIP
> > > Pulled, thanks a lot Arnaldo!
> > >
> > > Btw., the build output looks weird now - on a system that used to pass
> > > all feature tests there's this output:
> > >
> > > BUILD: Doing 'make -j12' parallel build
> > > config/Makefile:288: No libdw DWARF unwind found, Please install
> > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > >
> > > Auto-detecting system features:
> > > ... dwarf: [ on ]
> > > ... glibc: [ on ]
> > > ... gtk2: [ on ]
> > > ... libaudit: [ on ]
> > > ... libbfd: [ on ]
> > > ... libelf: [ on ]
> > > ... libnuma: [ on ]
> > > ... libperl: [ on ]
> > > ... libpython: [ on ]
> > > ... libslang: [ on ]
> > > ... libunwind: [ on ]
> > > ... libdw-dwarf-unwind: [ OFF ]
> > > ... DWARF post unwind library: libunwind
> > >
> > > but:
> > >
> > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > >
> > > Also, the information content of this line is unclear to me:
> > >
> > > ... DWARF post unwind library: libunwind
> > >
> > >
> > > what does that line want to tell?
> >
> > this tells what DWARF unwind library is compiled
> > in.. 'libunwind' in this case
>
> So my (stylistic) complaint is that it's really reading weird in a
> table generated with the following purpose:
>
> Auto-detecting system features:
>
> Also, we already know that libunwind is present, because just in the
> line before it, it says:
>
> ... libunwind: [ on ]
>
> So it's doubly confusing. How about not displaying that line at all?
> Is there a strong reason to not keep 'OFF' messages on a single line?
well, on/OFF lines are only about detecting libs
this line:
'DWARF post unwind library: libunwind'
is about telling which one goes in.. could be you have both
libraries detected and need to choose one or keep default
>
> > the other choice is 'libdw', which was not detected in your case
> > (and thats what the 1st message tells you)
> >
> > we discussed with Arnaldo, that we would not display warnings for
> > missing features by default.. only tell that there are missing
> > features and display them for verbose (VF=1) output
>
> That's probably a good plan. I'd suggest the following 'short log' for
> failures:
>
> # Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list.
>
> I.e. that way people can notice if the count goes up or down after an
> update. Also, that too should be a single line, so that it does not
> spam people.
ook
jirka
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2014-02-27 12:40 ` Jiri Olsa
@ 2014-02-27 12:45 ` Ingo Molnar
0 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2014-02-27 12:45 UTC (permalink / raw)
To: Jiri Olsa
Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo,
Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern,
Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Jiri Olsa <jolsa@redhat.com> wrote:
> On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote:
> >
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > > >
> > > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > > >
> > > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > > >
>
> SNIP
>
> > > > Pulled, thanks a lot Arnaldo!
> > > >
> > > > Btw., the build output looks weird now - on a system that used to pass
> > > > all feature tests there's this output:
> > > >
> > > > BUILD: Doing 'make -j12' parallel build
> > > > config/Makefile:288: No libdw DWARF unwind found, Please install
> > > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > > >
> > > > Auto-detecting system features:
> > > > ... dwarf: [ on ]
> > > > ... glibc: [ on ]
> > > > ... gtk2: [ on ]
> > > > ... libaudit: [ on ]
> > > > ... libbfd: [ on ]
> > > > ... libelf: [ on ]
> > > > ... libnuma: [ on ]
> > > > ... libperl: [ on ]
> > > > ... libpython: [ on ]
> > > > ... libslang: [ on ]
> > > > ... libunwind: [ on ]
> > > > ... libdw-dwarf-unwind: [ OFF ]
> > > > ... DWARF post unwind library: libunwind
> > > >
> > > > but:
> > > >
> > > > Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > > >
> > > > Also, the information content of this line is unclear to me:
> > > >
> > > > ... DWARF post unwind library: libunwind
> > > >
> > > >
> > > > what does that line want to tell?
> > >
> > > this tells what DWARF unwind library is compiled
> > > in.. 'libunwind' in this case
> >
> > So my (stylistic) complaint is that it's really reading weird in a
> > table generated with the following purpose:
> >
> > Auto-detecting system features:
> >
> > Also, we already know that libunwind is present, because just in the
> > line before it, it says:
> >
> > ... libunwind: [ on ]
> >
> > So it's doubly confusing. How about not displaying that line at all?
> > Is there a strong reason to not keep 'OFF' messages on a single line?
>
> well, on/OFF lines are only about detecting libs
>
> this line:
> 'DWARF post unwind library: libunwind'
>
> is about telling which one goes in.. could be you have both
> libraries detected and need to choose one or keep default
Okay - but that is not at all clear from the output.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2014-02-27 11:46 ` Ingo Molnar
2014-02-27 12:02 ` Jiri Olsa
@ 2014-02-27 12:04 ` Jiri Olsa
1 sibling, 0 replies; 40+ messages in thread
From: Jiri Olsa @ 2014-02-27 12:04 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Arnaldo Carvalho de Melo,
Adrian Hunter, Cody P Schafer, Corey Ashford, David Ahern,
Frederic Weisbecker, Jean Pihet, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
>
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
>
> > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> >
> > Hi Ingo,
> >
> > Please consider pulling,
> >
> > - Arnaldo
> >
> > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> >
> > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> >
> > are available in the git repository at:
> >
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> >
> > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> >
> > perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> >
> > ----------------------------------------------------------------
> > perf/core improvements and fixes
> >
> > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> >
> > . Fix build race in the generation of bison files (Jiri Olsa)
> >
> > . Further streamline the feature detection display, trimming it a bit to
> > show just the libraries detected, using VF=1 gets a more verbose output,
> > showing the less interesting feature checks as well (Jiri Olsa).
> >
> > . Check compatible symtab type before loading dso (Namhyung Kim)
> >
> > . Check return value of filename__read_debuglink() (Stephane Eranian)
> >
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > ----------------------------------------------------------------
> > Arnaldo Carvalho de Melo (1):
> > perf tools: Warn the user about how to enable libunwind support
> >
> > Jiri Olsa (9):
> > perf tests: Fix *.o make tests
> > perf tests: Add pmu-bison.o make test
> > perf tools: Fix bison OUTPUT directories dependency
> > perf tools: Factor features display code
> > perf tools: Add variable display for VF make output
> > perf tools: Add feature check for libdw dwarf unwind
> > perf tools: Add libdw DWARF post unwind support
> > perf tools: Setup default dwarf post unwinder
> > perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> >
> > Namhyung Kim (1):
> > perf symbols: Check compatible symtab type before loading dso
> >
> > Stephane Eranian (1):
> > perf symbols: Check return value of filename__read_debuglink()
> >
> > tools/perf/Makefile.perf | 24 ++-
> > tools/perf/arch/x86/Makefile | 5 +
> > tools/perf/arch/x86/util/unwind-libdw.c | 51 +++++
> > tools/perf/config/Makefile | 232 +++++++++++++++------
> > tools/perf/config/feature-checks/Makefile | 6 +-
> > tools/perf/config/feature-checks/test-all.c | 5 +
> > .../feature-checks/test-libdw-dwarf-unwind.c | 13 ++
> > tools/perf/tests/make | 25 ++-
> > tools/perf/util/dso.c | 4 +-
> > tools/perf/util/symbol-elf.c | 2 +
> > tools/perf/util/symbol.c | 61 +++++-
> > tools/perf/util/unwind-libdw.c | 210 +++++++++++++++++++
> > tools/perf/util/unwind-libdw.h | 21 ++
> > 13 files changed, 569 insertions(+), 90 deletions(-)
> > create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> > create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> > create mode 100644 tools/perf/util/unwind-libdw.c
> > create mode 100644 tools/perf/util/unwind-libdw.h
>
> Pulled, thanks a lot Arnaldo!
>
> Btw., the build output looks weird now - on a system that used to pass
> all feature tests there's this output:
>
> BUILD: Doing 'make -j12' parallel build
> config/Makefile:288: No libdw DWARF unwind found, Please install
> elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... glibc: [ on ]
> ... gtk2: [ on ]
> ... libaudit: [ on ]
> ... libbfd: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libslang: [ on ]
> ... libunwind: [ on ]
> ... libdw-dwarf-unwind: [ OFF ]
> ... DWARF post unwind library: libunwind
>
> but:
>
> Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
forgot.. remote unwind in libdw is supported from version 0.158,
which I guess wasn't updated in FC19 yet
jirka
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2013-12-02 20:48 Arnaldo Carvalho de Melo
2013-12-04 9:18 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-12-02 20:48 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Corey Ashford, David Ahern, Dongsheng Yang, Frederic Weisbecker,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Hurley, Peter Zijlstra, Stanislav Fomichev,
Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256:
perf trace: Honour -m option (2013-12-02 16:29:40 -0300)
----------------------------------------------------------------
perf/tools improvements and fixes:
. Honour -m option in 'trace', the tool was offering the option to
set the mmap size, but wasn't using it when doing the actual mmap
on the events file descriptors, fix from Jiri Olsa.
. Correct the message in feature-libnuma checking, swowing the right
devel package names for various distros, from Dongsheng Yang.
. Polish 'readn' function and introduce its counterpart, 'writen', from
Jiri Olsa.
. Start moving timechart state from global variables to a 'perf_tool' derived
'timechart' struct.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
perf timechart: Introduce tool struct
perf timechart: Move all_data per_pid list to 'struct timechart'
perf timechart: Move power_events list to 'struct timechart'
perf timechart: Move wake_events list to 'struct timechart'
Dongsheng Yang (1):
perf tools: Correct the message in feature-libnuma checking.
Jiri Olsa (7):
perf record: Unify data output code into perf_record__write function
perf tools: Use correct return type for readn function
perf tools: Fine tune readn function
perf tools: Add writen function
perf tools: Add perf_data_file__write interface
perf tools: Include test-stackprotector-all.c in test-all
perf trace: Honour -m option
tools/perf/builtin-record.c | 20 +-
tools/perf/builtin-timechart.c | 364 +++++++++++++++-------------
tools/perf/builtin-trace.c | 2 +-
tools/perf/config/Makefile | 2 +-
tools/perf/config/feature-checks/test-all.c | 5 +
tools/perf/util/data.c | 6 +
tools/perf/util/data.h | 14 +-
tools/perf/util/header.c | 18 +-
tools/perf/util/session.c | 2 +-
tools/perf/util/util.c | 32 ++-
tools/perf/util/util.h | 3 +-
11 files changed, 256 insertions(+), 212 deletions(-)
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2013-12-02 20:48 Arnaldo Carvalho de Melo
@ 2013-12-04 9:18 ` Ingo Molnar
0 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2013-12-04 9:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Corey Ashford, David Ahern, Dongsheng Yang, Frederic Weisbecker,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Hurley, Peter Zijlstra, Stanislav Fomichev,
Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256:
>
> perf trace: Honour -m option (2013-12-02 16:29:40 -0300)
>
> ----------------------------------------------------------------
> perf/tools improvements and fixes:
>
> . Honour -m option in 'trace', the tool was offering the option to
> set the mmap size, but wasn't using it when doing the actual mmap
> on the events file descriptors, fix from Jiri Olsa.
>
> . Correct the message in feature-libnuma checking, swowing the right
> devel package names for various distros, from Dongsheng Yang.
>
> . Polish 'readn' function and introduce its counterpart, 'writen', from
> Jiri Olsa.
>
> . Start moving timechart state from global variables to a 'perf_tool' derived
> 'timechart' struct.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
> perf timechart: Introduce tool struct
> perf timechart: Move all_data per_pid list to 'struct timechart'
> perf timechart: Move power_events list to 'struct timechart'
> perf timechart: Move wake_events list to 'struct timechart'
>
> Dongsheng Yang (1):
> perf tools: Correct the message in feature-libnuma checking.
>
> Jiri Olsa (7):
> perf record: Unify data output code into perf_record__write function
> perf tools: Use correct return type for readn function
> perf tools: Fine tune readn function
> perf tools: Add writen function
> perf tools: Add perf_data_file__write interface
> perf tools: Include test-stackprotector-all.c in test-all
> perf trace: Honour -m option
>
> tools/perf/builtin-record.c | 20 +-
> tools/perf/builtin-timechart.c | 364 +++++++++++++++-------------
> tools/perf/builtin-trace.c | 2 +-
> tools/perf/config/Makefile | 2 +-
> tools/perf/config/feature-checks/test-all.c | 5 +
> tools/perf/util/data.c | 6 +
> tools/perf/util/data.h | 14 +-
> tools/perf/util/header.c | 18 +-
> tools/perf/util/session.c | 2 +-
> tools/perf/util/util.c | 32 ++-
> tools/perf/util/util.h | 3 +-
> 11 files changed, 256 insertions(+), 212 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* [GIT PULL 00/12] perf/core improvements and fixes
@ 2012-10-24 21:50 Arnaldo Carvalho de Melo
2012-10-25 7:43 ` Ingo Molnar
0 siblings, 1 reply; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-10-24 21:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Borislav Petkov,
Corey Ashford, David Ahern, Frederic Weisbecker, Irina Tirdea,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Namhyung Kim,
Paul Mackerras, Pekka Enberg, Peter Zijlstra, Robert Richter,
Stephane Eranian, Steven Rostedt, Suzuki K. Poulose,
Thomas Gleixner, arnaldo.melo, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling.
I'll continue processing patchsets by Jiri, Namhyung, David, Irina and
others tomorrow.
I also have to rework the pagefaults patches, as the code it touches
changed lately, will add that NUMA node info you suggested.
- Arnaldo
The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163:
x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b:
perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200)
----------------------------------------------------------------
perf/core improvements and fixes
. Align the 'Ok'/'FAILED!' test results in 'perf test.
. Support interrupted syscalls in 'trace'
. Add an event duration column and filter in 'trace'.
. There are references to the man pages in some tools, so try to build
Documentation when installing, warning the user if that is not possible,
from Borislav Petkov.
. Give user better message if precise is not supported, from David Ahern.
. Try to find cross-built objdump path by using the session environment
information in the perf.data file header, from Irina Tirdea, original
patch and idea by Namhyung Kim.
. Diplays more output on features check for make V=1, so that one can figure
out what is happening by looking at gcc output, etc. From Jiri Olsa.
. Account the nr_entries in rblist properly, fix by Suzuki K. Poulose.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (7):
perf tools: Remove noise in python version feature test
perf test: Align the 'Ok'/'FAILED!' test results
perf trace: Support interrupted syscalls
perf trace: Add an event duration column
perf trace: Add duration filter
perf tools: Pretty print errno for some more functions
perf trace: Print the name of a syscall when failing to read its info
Borislav Petkov (1):
perf tools: Try to build Documentation when installing
David Ahern (1):
perf tools: Give user better message if precise is not supported
Irina Tirdea (1):
perf tools: Try to find cross-built objdump path
Jiri Olsa (1):
perf tools: Diplays more output on features check for make V=1
Suzuki K. Poulose (1):
Account the nr_entries in rblist properly
tools/perf/Documentation/Makefile | 31 +++-
tools/perf/Documentation/perf-trace.txt | 3 +
tools/perf/Makefile | 53 ++++---
tools/perf/arch/common.c | 178 ++++++++++++++++++++++
tools/perf/arch/common.h | 10 ++
tools/perf/builtin-annotate.c | 7 +
tools/perf/builtin-record.c | 5 +
tools/perf/builtin-report.c | 7 +
tools/perf/builtin-test.c | 18 ++-
tools/perf/builtin-top.c | 4 +
tools/perf/builtin-trace.c | 250 ++++++++++++++++++++++++++++---
tools/perf/config/feature-tests.mak | 5 +-
tools/perf/config/utilities.mak | 11 +-
tools/perf/util/annotate.h | 1 -
tools/perf/util/parse-events.c | 2 +-
tools/perf/util/rblist.c | 4 +-
tools/perf/util/util.h | 4 +
17 files changed, 535 insertions(+), 58 deletions(-)
create mode 100644 tools/perf/arch/common.c
create mode 100644 tools/perf/arch/common.h
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [GIT PULL 00/12] perf/core improvements and fixes
2012-10-24 21:50 Arnaldo Carvalho de Melo
@ 2012-10-25 7:43 ` Ingo Molnar
0 siblings, 0 replies; 40+ messages in thread
From: Ingo Molnar @ 2012-10-25 7:43 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Borislav Petkov, Corey Ashford, David Ahern,
Frederic Weisbecker, Irina Tirdea, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Namhyung Kim, Paul Mackerras, Pekka Enberg,
Peter Zijlstra, Robert Richter, Stephane Eranian, Steven Rostedt,
Suzuki K. Poulose, Thomas Gleixner, arnaldo.melo,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling.
>
> I'll continue processing patchsets by Jiri, Namhyung, David, Irina and
> others tomorrow.
>
> I also have to rework the pagefaults patches, as the code it touches
> changed lately, will add that NUMA node info you suggested.
>
> - Arnaldo
>
> The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163:
>
> x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b:
>
> perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes
>
> . Align the 'Ok'/'FAILED!' test results in 'perf test.
>
> . Support interrupted syscalls in 'trace'
>
> . Add an event duration column and filter in 'trace'.
>
> . There are references to the man pages in some tools, so try to build
> Documentation when installing, warning the user if that is not possible,
> from Borislav Petkov.
>
> . Give user better message if precise is not supported, from David Ahern.
>
> . Try to find cross-built objdump path by using the session environment
> information in the perf.data file header, from Irina Tirdea, original
> patch and idea by Namhyung Kim.
>
> . Diplays more output on features check for make V=1, so that one can figure
> out what is happening by looking at gcc output, etc. From Jiri Olsa.
>
> . Account the nr_entries in rblist properly, fix by Suzuki K. Poulose.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (7):
> perf tools: Remove noise in python version feature test
> perf test: Align the 'Ok'/'FAILED!' test results
> perf trace: Support interrupted syscalls
> perf trace: Add an event duration column
> perf trace: Add duration filter
> perf tools: Pretty print errno for some more functions
> perf trace: Print the name of a syscall when failing to read its info
>
> Borislav Petkov (1):
> perf tools: Try to build Documentation when installing
>
> David Ahern (1):
> perf tools: Give user better message if precise is not supported
>
> Irina Tirdea (1):
> perf tools: Try to find cross-built objdump path
>
> Jiri Olsa (1):
> perf tools: Diplays more output on features check for make V=1
>
> Suzuki K. Poulose (1):
> Account the nr_entries in rblist properly
>
> tools/perf/Documentation/Makefile | 31 +++-
> tools/perf/Documentation/perf-trace.txt | 3 +
> tools/perf/Makefile | 53 ++++---
> tools/perf/arch/common.c | 178 ++++++++++++++++++++++
> tools/perf/arch/common.h | 10 ++
> tools/perf/builtin-annotate.c | 7 +
> tools/perf/builtin-record.c | 5 +
> tools/perf/builtin-report.c | 7 +
> tools/perf/builtin-test.c | 18 ++-
> tools/perf/builtin-top.c | 4 +
> tools/perf/builtin-trace.c | 250 ++++++++++++++++++++++++++++---
> tools/perf/config/feature-tests.mak | 5 +-
> tools/perf/config/utilities.mak | 11 +-
> tools/perf/util/annotate.h | 1 -
> tools/perf/util/parse-events.c | 2 +-
> tools/perf/util/rblist.c | 4 +-
> tools/perf/util/util.h | 4 +
> 17 files changed, 535 insertions(+), 58 deletions(-)
> create mode 100644 tools/perf/arch/common.c
> create mode 100644 tools/perf/arch/common.h
Pulled, thanks a lot Arnado!
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
end of thread, other threads:[~2018-10-09 5:25 UTC | newest]
Thread overview: 40+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-30 19:24 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 01/12] perf thread: Adopt get_main_thread from db-export.c Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 02/12] perf core: Per event callchain limit Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 03/12] perf tools: Per event max-stack settings Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 04/12] perf record: Robustify perf_event__synth_time_conv() Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 05/12] perf evlist: Don't poll and mmap overwritable events Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 06/12] perf evlist: Check 'base' pointer before checking refcnt when put a mmap Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 07/12] perf evlist: Choose correct reading direction according to evlist->backward Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 08/12] tools: Pass arg to fdarray__filter's call back function Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 09/12] perf tools: Add arch/*/include/generated/ to .gitignore Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 10/12] perf symbols: Introduce filename__readable to check readability Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 11/12] perf symbols: Cleanup the code flow of dso__find_kallsyms Arnaldo Carvalho de Melo
2016-05-30 19:24 ` [PATCH 12/12] perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid Arnaldo Carvalho de Melo
2016-05-31 7:24 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2018-10-09 0:54 Arnaldo Carvalho de Melo
2018-10-09 5:24 ` Ingo Molnar
2016-11-25 15:12 Arnaldo Carvalho de Melo
2016-11-25 17:14 ` Ingo Molnar
2016-09-08 20:46 Arnaldo Carvalho de Melo
2016-09-09 5:47 ` Ingo Molnar
2016-05-17 2:45 Arnaldo Carvalho de Melo
2016-05-20 6:23 ` Ingo Molnar
2015-11-05 16:02 Arnaldo Carvalho de Melo
2015-10-28 15:30 Arnaldo Carvalho de Melo
2015-10-29 9:36 ` Ingo Molnar
2015-10-29 9:51 ` Ingo Molnar
2015-10-29 9:55 ` Jiri Olsa
2015-08-05 20:11 Arnaldo Carvalho de Melo
2014-11-25 13:21 Arnaldo Carvalho de Melo
2014-02-24 19:56 Arnaldo Carvalho de Melo
2014-02-27 11:46 ` Ingo Molnar
2014-02-27 12:02 ` Jiri Olsa
2014-02-27 12:30 ` Ingo Molnar
2014-02-27 12:40 ` Jiri Olsa
2014-02-27 12:45 ` Ingo Molnar
2014-02-27 12:04 ` Jiri Olsa
2013-12-02 20:48 Arnaldo Carvalho de Melo
2013-12-04 9:18 ` Ingo Molnar
2012-10-24 21:50 Arnaldo Carvalho de Melo
2012-10-25 7:43 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).