linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuansheng Liu <chuansheng.liu@intel.com>
To: FlorianSchandinat@gmx.de
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: [PATCH 6/7] mx3fb: Fix the usage of wait_for_completion_timeout
Date: Wed, 07 Nov 2012 01:33:14 +0800	[thread overview]
Message-ID: <1352223194.15558.1601.camel@cliu38-desktop-build> (raw)
In-Reply-To: <1352223097.15558.1599.camel@cliu38-desktop-build>


The return value of wait_for_completion_timeout() is always
>= 0 with unsigned int type.

So the condition "ret < 0" or "ret >= 0" is pointless.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
 drivers/video/mx3fb.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index ce1d452..88bf368 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -1110,12 +1110,11 @@ static int mx3fb_pan_display(struct fb_var_screeninfo *var,
 	enable_irq(mx3_fbi->idmac_channel->eof_irq);
 
 	ret = wait_for_completion_timeout(&mx3_fbi->flip_cmpl, HZ / 10);
-	if (ret <= 0) {
+	if (ret == 0) {
 		mutex_unlock(&mx3_fbi->mutex);
-		dev_info(fbi->device, "Panning failed due to %s\n", ret < 0 ?
-			 "user interrupt" : "timeout");
+		dev_info(fbi->device, "Panning failed due to timeout\n");
 		disable_irq(mx3_fbi->idmac_channel->eof_irq);
-		return ret ? : -ETIMEDOUT;
+		return -ETIMEDOUT;
 	}
 
 	mx3_fbi->cur_ipu_buf = !mx3_fbi->cur_ipu_buf;
-- 
1.7.0.4




  parent reply	other threads:[~2012-11-06  8:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 17:18 [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Chuansheng Liu
2012-11-06 17:21 ` [PATCH 2/7] OMAPDSS: DISPC: " Chuansheng Liu
2012-11-06 11:30   ` Tomi Valkeinen
2012-11-06 17:22   ` [PATCH 3/7] OMAPDSS: APPLY: " Chuansheng Liu
2012-11-06 11:31     ` Tomi Valkeinen
2012-11-06 17:28     ` [PATCH 4/7] wlcore: " Chuansheng Liu
2012-11-06 17:31       ` [PATCH 5/7] can: janz-ican3: " Chuansheng Liu
2012-11-06 11:43         ` Marc Kleine-Budde
2012-11-06 17:33         ` Chuansheng Liu [this message]
2012-11-06 17:36           ` [PATCH 7/7] IB/srpt: " Chuansheng Liu
2012-11-16 18:23       ` [PATCH 4/7] wlcore: " Luciano Coelho
2012-11-12 17:26 ` [PATCH 1/7] I2c-nomadik: " Wolfram Sang
2012-11-13  1:21   ` Liu, Chuansheng
2012-11-13  7:58     ` Wolfram Sang
2012-11-13  8:00       ` Liu, Chuansheng
     [not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15  8:49   ` Fwd: " Srinidhi Kasagar
2012-11-15  9:29     ` Wolfram Sang
2012-11-15  9:57       ` Srinidhi Kasagar
2012-11-15 10:18         ` Wolfram Sang
2012-11-15 11:18           ` Srinidhi Kasagar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352223194.15558.1601.camel@cliu38-desktop-build \
    --to=chuansheng.liu@intel.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).