From: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: "chuansheng.liu@intel.com" <chuansheng.liu@intel.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
Date: Thu, 15 Nov 2012 16:48:23 +0530 [thread overview]
Message-ID: <20121115111822.GA3911@bnru10> (raw)
In-Reply-To: <20121115101820.GC418@pengutronix.de>
On Thu, Nov 15, 2012 at 11:18:20 +0100, Wolfram Sang wrote:
> On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote:
> > On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
> > >
> > > > > - if (timeout < 0) {
> > > > > - dev_err(&dev->adev->dev,
> > > > > - "wait_for_completion_timeout "
> > > > > - "returned %d waiting for event\n", timeout);
> > > > > - status = timeout;
> > > > > - }
> > > > > -
> > > > No, it is wrong. You need to update the status variable in the case of timeout.
> > >
> > > Looking at the patch context, such code comes later.
> > But it causes regressions; without looking at the "later" code, we can't afford merging
> > this code now.
>
> Later as in "a few lines later" not "some time later". Or am I missing
> something else?
I was too fast in reading emails after my short vacation...Sorry.
Acked-by: srinidhi kasagar <srinidhi.kasagar@stericsson.com>
regards/srinidhi
prev parent reply other threads:[~2012-11-15 11:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 17:18 [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Chuansheng Liu
2012-11-06 17:21 ` [PATCH 2/7] OMAPDSS: DISPC: " Chuansheng Liu
2012-11-06 11:30 ` Tomi Valkeinen
2012-11-06 17:22 ` [PATCH 3/7] OMAPDSS: APPLY: " Chuansheng Liu
2012-11-06 11:31 ` Tomi Valkeinen
2012-11-06 17:28 ` [PATCH 4/7] wlcore: " Chuansheng Liu
2012-11-06 17:31 ` [PATCH 5/7] can: janz-ican3: " Chuansheng Liu
2012-11-06 11:43 ` Marc Kleine-Budde
2012-11-06 17:33 ` [PATCH 6/7] mx3fb: " Chuansheng Liu
2012-11-06 17:36 ` [PATCH 7/7] IB/srpt: " Chuansheng Liu
2012-11-16 18:23 ` [PATCH 4/7] wlcore: " Luciano Coelho
2012-11-12 17:26 ` [PATCH 1/7] I2c-nomadik: " Wolfram Sang
2012-11-13 1:21 ` Liu, Chuansheng
2012-11-13 7:58 ` Wolfram Sang
2012-11-13 8:00 ` Liu, Chuansheng
[not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15 8:49 ` Fwd: " Srinidhi Kasagar
2012-11-15 9:29 ` Wolfram Sang
2012-11-15 9:57 ` Srinidhi Kasagar
2012-11-15 10:18 ` Wolfram Sang
2012-11-15 11:18 ` Srinidhi Kasagar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115111822.GA3911@bnru10 \
--to=srinidhi.kasagar@stericsson.com \
--cc=chuansheng.liu@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).