From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: <FlorianSchandinat@gmx.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] OMAPDSS: APPLY: Fix the usage of wait_for_completion_timeout
Date: Tue, 6 Nov 2012 13:31:20 +0200 [thread overview]
Message-ID: <5098F508.60100@ti.com> (raw)
In-Reply-To: <1352222555.15558.1589.camel@cliu38-desktop-build>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On 2012-11-06 19:22, Chuansheng Liu wrote:
>
> The return value of wait_for_completion_timeout() is always
>> = 0 with unsigned int type.
>
> So the condition "ret < 0" or "ret >= 0" is pointless.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
> ---
> drivers/video/omap2/dss/apply.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/apply.c b/drivers/video/omap2/dss/apply.c
> index 19d66f4..ec42a6a 100644
> --- a/drivers/video/omap2/dss/apply.c
> +++ b/drivers/video/omap2/dss/apply.c
> @@ -414,8 +414,6 @@ static void wait_pending_extra_info_updates(void)
> r = wait_for_completion_timeout(&extra_updated_completion, t);
> if (r == 0)
> DSSWARN("timeout in wait_pending_extra_info_updates\n");
> - else if (r < 0)
> - DSSERR("wait_pending_extra_info_updates failed: %d\n", r);
> }
>
> int dss_mgr_wait_for_go(struct omap_overlay_manager *mgr)
Thanks. I'll apply this to omapdss tree to avoid any conflicts.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
next prev parent reply other threads:[~2012-11-06 11:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 17:18 [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Chuansheng Liu
2012-11-06 17:21 ` [PATCH 2/7] OMAPDSS: DISPC: " Chuansheng Liu
2012-11-06 11:30 ` Tomi Valkeinen
2012-11-06 17:22 ` [PATCH 3/7] OMAPDSS: APPLY: " Chuansheng Liu
2012-11-06 11:31 ` Tomi Valkeinen [this message]
2012-11-06 17:28 ` [PATCH 4/7] wlcore: " Chuansheng Liu
2012-11-06 17:31 ` [PATCH 5/7] can: janz-ican3: " Chuansheng Liu
2012-11-06 11:43 ` Marc Kleine-Budde
2012-11-06 17:33 ` [PATCH 6/7] mx3fb: " Chuansheng Liu
2012-11-06 17:36 ` [PATCH 7/7] IB/srpt: " Chuansheng Liu
2012-11-16 18:23 ` [PATCH 4/7] wlcore: " Luciano Coelho
2012-11-12 17:26 ` [PATCH 1/7] I2c-nomadik: " Wolfram Sang
2012-11-13 1:21 ` Liu, Chuansheng
2012-11-13 7:58 ` Wolfram Sang
2012-11-13 8:00 ` Liu, Chuansheng
[not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15 8:49 ` Fwd: " Srinidhi Kasagar
2012-11-15 9:29 ` Wolfram Sang
2012-11-15 9:57 ` Srinidhi Kasagar
2012-11-15 10:18 ` Wolfram Sang
2012-11-15 11:18 ` Srinidhi Kasagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5098F508.60100@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=FlorianSchandinat@gmx.de \
--cc=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).