From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Chris Ball <cjb@laptop.org>
Subject: [PATCH 1/3] regulator: fix voltage check in regulator_is_supported_voltage()
Date: Tue, 13 Nov 2012 09:48:51 +0100 [thread overview]
Message-ID: <1352796533-12350-2-git-send-email-m.szyprowski@samsung.com> (raw)
In-Reply-To: <1352796533-12350-1-git-send-email-m.szyprowski@samsung.com>
regulator_is_supported_voltage() should return true only if the voltage
of fixed/constant regulator is between min_uV and max_uV.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/regulator/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 1a35251..042c1ff 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1974,7 +1974,7 @@ int regulator_is_supported_voltage(struct regulator *regulator,
if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) {
ret = regulator_get_voltage(regulator);
if (ret >= 0)
- return (min_uV >= ret && ret <= max_uV);
+ return (min_uV <= ret && ret <= max_uV);
else
return ret;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-11-13 8:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 8:48 [PATCH 0/3] Fix fixed regulators support Marek Szyprowski
2012-11-13 8:48 ` Marek Szyprowski [this message]
2012-11-13 9:01 ` [PATCH 1/3] regulator: fix voltage check in regulator_is_supported_voltage() Mark Brown
2012-11-13 8:48 ` [PATCH 2/3] regulator: threat regulators with constant volatage as fixed Marek Szyprowski
2012-11-13 9:00 ` Mark Brown
2012-11-13 9:35 ` [PATCH v2] regulator: treat " Marek Szyprowski
2012-11-13 9:42 ` Mark Brown
2012-11-13 9:49 ` [PATCH v3] " Marek Szyprowski
2012-11-14 2:01 ` Mark Brown
2012-11-20 13:20 ` Marek Szyprowski
2012-11-13 8:48 ` [PATCH 3/3] mmc: sdhci: apply voltage range check only for non-fixed regulators Marek Szyprowski
2012-11-13 12:45 ` Chris Ball
2012-11-13 13:32 ` [PATCH v2] " Marek Szyprowski
2012-11-13 13:45 ` Chris Ball
2012-11-13 14:09 ` Marek Szyprowski
2012-11-13 14:14 ` Chris Ball
2012-11-13 21:23 ` Philip Rakity
2012-11-20 8:42 ` Marek Szyprowski
2012-11-14 1:10 ` [PATCH 3/3] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352796533-12350-2-git-send-email-m.szyprowski@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).