From: Chris Ball <cjb@laptop.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 3/3] mmc: sdhci: apply voltage range check only for non-fixed regulators
Date: Tue, 13 Nov 2012 07:45:07 -0500 [thread overview]
Message-ID: <87fw4dn030.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1352796533-12350-4-git-send-email-m.szyprowski@samsung.com> (Marek Szyprowski's message of "Tue, 13 Nov 2012 09:48:53 +0100")
Hi Marek,
On Tue, Nov 13 2012, Marek Szyprowski wrote:
> Fixed regulators cannot change their voltage, so disable all voltage range
> checking for them, otherwise the driver fails to operate with fixed
> regulators.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Perhaps it's a good idea to mention that the regulator API is changing
(being fixed) at the same time, and that's why this patch is necessary.
> ---
> drivers/mmc/host/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index c7851c0..6f6534e 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2923,7 +2923,7 @@ int sdhci_add_host(struct sdhci_host *host)
> regulator_enable(host->vmmc);
>
> #ifdef CONFIG_REGULATOR
> - if (host->vmmc) {
> + if (host->vmmc && regulator_count_voltages(host->vmmc) > 1) {
> ret = regulator_is_supported_voltage(host->vmmc, 3300000,
> 3300000);
> if ((ret <= 0) || (!(caps[0] & SDHCI_CAN_VDD_330)))
What about other occasions where is_supported_voltage() is used, like
this one -- is it necessary here too?
else if (regulator_is_supported_voltage(host->vqmmc, 1800000, 1800000))
regulator_enable(host->vqmmc);
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-11-13 12:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 8:48 [PATCH 0/3] Fix fixed regulators support Marek Szyprowski
2012-11-13 8:48 ` [PATCH 1/3] regulator: fix voltage check in regulator_is_supported_voltage() Marek Szyprowski
2012-11-13 9:01 ` Mark Brown
2012-11-13 8:48 ` [PATCH 2/3] regulator: threat regulators with constant volatage as fixed Marek Szyprowski
2012-11-13 9:00 ` Mark Brown
2012-11-13 9:35 ` [PATCH v2] regulator: treat " Marek Szyprowski
2012-11-13 9:42 ` Mark Brown
2012-11-13 9:49 ` [PATCH v3] " Marek Szyprowski
2012-11-14 2:01 ` Mark Brown
2012-11-20 13:20 ` Marek Szyprowski
2012-11-13 8:48 ` [PATCH 3/3] mmc: sdhci: apply voltage range check only for non-fixed regulators Marek Szyprowski
2012-11-13 12:45 ` Chris Ball [this message]
2012-11-13 13:32 ` [PATCH v2] " Marek Szyprowski
2012-11-13 13:45 ` Chris Ball
2012-11-13 14:09 ` Marek Szyprowski
2012-11-13 14:14 ` Chris Ball
2012-11-13 21:23 ` Philip Rakity
2012-11-20 8:42 ` Marek Szyprowski
2012-11-14 1:10 ` [PATCH 3/3] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw4dn030.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).