From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chris Ball <cjb@laptop.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 3/3] mmc: sdhci: apply voltage range check only for non-fixed regulators
Date: Wed, 14 Nov 2012 10:10:43 +0900 [thread overview]
Message-ID: <20121114011042.GC4415@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <87fw4dn030.fsf@octavius.laptop.org>
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
On Tue, Nov 13, 2012 at 07:45:07AM -0500, Chris Ball wrote:
> On Tue, Nov 13 2012, Marek Szyprowski wrote:
> > Fixed regulators cannot change their voltage, so disable all voltage range
> > checking for them, otherwise the driver fails to operate with fixed
> > regulators.
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Perhaps it's a good idea to mention that the regulator API is changing
> (being fixed) at the same time, and that's why this patch is necessary.
This should be totally unrelated to any externally visible change in the
regulator API, if anything I would expect fixes in the API to *improve*
the ability of clients to work with fixed voltage regulators. What's
missing here is some explanation as to what the problem is and how it's
being fixed.
As I understand it this should really be a workaround for hardware which
runs cards at out of spec voltages; we have a fixed voltage regulator
which claims to not support any of the voltages that are in spec (due to
this being what the hardware does) so if we try to use the voltage
management stuff in the MMC API it gets upset. As a workaround if we
can't change the voltage we just ignore the voltage aspects of the API.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-11-14 1:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 8:48 [PATCH 0/3] Fix fixed regulators support Marek Szyprowski
2012-11-13 8:48 ` [PATCH 1/3] regulator: fix voltage check in regulator_is_supported_voltage() Marek Szyprowski
2012-11-13 9:01 ` Mark Brown
2012-11-13 8:48 ` [PATCH 2/3] regulator: threat regulators with constant volatage as fixed Marek Szyprowski
2012-11-13 9:00 ` Mark Brown
2012-11-13 9:35 ` [PATCH v2] regulator: treat " Marek Szyprowski
2012-11-13 9:42 ` Mark Brown
2012-11-13 9:49 ` [PATCH v3] " Marek Szyprowski
2012-11-14 2:01 ` Mark Brown
2012-11-20 13:20 ` Marek Szyprowski
2012-11-13 8:48 ` [PATCH 3/3] mmc: sdhci: apply voltage range check only for non-fixed regulators Marek Szyprowski
2012-11-13 12:45 ` Chris Ball
2012-11-13 13:32 ` [PATCH v2] " Marek Szyprowski
2012-11-13 13:45 ` Chris Ball
2012-11-13 14:09 ` Marek Szyprowski
2012-11-13 14:14 ` Chris Ball
2012-11-13 21:23 ` Philip Rakity
2012-11-20 8:42 ` Marek Szyprowski
2012-11-14 1:10 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114011042.GC4415@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).