From: Joe Perches <joe@perches.com>
To: George Zhang <georgezhang@vmware.com>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 01/12] VMCI: context implementation.
Date: Wed, 21 Nov 2012 13:04:46 -0800 [thread overview]
Message-ID: <1353531886.24807.43.camel@joe-AO722> (raw)
In-Reply-To: <20121121203109.13252.92744.stgit@promb-2n-dhcp175.eng.vmware.com>
On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote:
> VMCI Context code maintains state for vmci and allows the driver to communicate
> with multiple VMs
Just some trivial notes.
> diff --git a/drivers/misc/vmw_vmci/vmci_context.c b/drivers/misc/vmw_vmci/vmci_context.c
[]
It'd be nicer if you added this #define before any #include
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
so that pr_<level> messages are prefixed.
(never mind, found a similar macro in patch 12/12)
> +#include <linux/vmw_vmci_defs.h>
> +#include <linux/vmw_vmci_api.h>
[]
> + context = kzalloc(sizeof(*context), GFP_KERNEL);
> + if (!context) {
> + pr_warn("Failed to allocate memory for VMCI context.\n");
OOM logging messages aren't necessary as alloc failures
are already logged with a stack trace.
That goes for the entire patch series.
> + /* Fire event to all subscribers. */
> + array_size = vmci_handle_arr_get_size(subscriber_array);
> + for (i = 0; i < array_size; i++) {
> + int result;
> + struct vmci_event_msg *e_msg;
> + struct vmci_event_payld_ctx *ev_payload;
> + char buf[sizeof(*e_msg) + sizeof(*ev_payload)];
Maybe just use
struct vmci_event_msg e_msg;
struct vmci_event_payld_ctx ev_payload;
and change the addressing or use a cast as appropriate?
> + /* Allocate guest call entry and add it to the target VM's queue. */
> + dq_entry = kmalloc(sizeof(*dq_entry), GFP_KERNEL);
> + if (dq_entry == NULL) {
> + pr_warn("Failed to allocate memory for datagram.\n");
Another unnecessary OOM message.
You also have some inconsistency in whether or not your
logging messages use a terminating period. I suggest
you just delete all the periods.
s/\.\\n"/\\n"/g
next prev parent reply other threads:[~2012-11-21 21:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:31 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-21 21:04 ` Joe Perches [this message]
2012-11-21 21:10 ` [Pv-drivers] " Andy King
2012-11-21 21:29 ` Dmitry Torokhov
2012-11-21 21:35 ` Joe Perches
2012-11-21 20:32 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-21 20:32 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-11-21 20:33 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-11-21 20:33 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-11-21 20:34 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-11-21 20:34 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-21 20:34 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-11-21 20:35 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-11-21 20:35 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-11-21 20:35 ` [PATCH 11/12] VMCI: host " George Zhang
2012-11-21 20:36 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-26 22:37 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
2012-11-26 23:01 ` [Pv-drivers] " Dmitry Torokhov
2012-11-26 23:23 ` Greg KH
2012-11-26 23:36 ` Dmitry Torokhov
2012-11-26 23:44 ` Greg KH
2012-11-26 23:52 ` Dmitry Torokhov
2012-11-26 23:56 ` George Zhang
2012-11-27 0:03 ` Greg KH
2012-11-27 0:27 ` Woody Suwalski
2012-11-27 0:47 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2013-01-08 23:52 George Zhang
2013-01-08 23:52 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-07 18:40 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-07 18:41 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-01 17:28 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-01 17:28 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-10-30 1:03 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-10-30 1:03 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-10-30 2:07 ` Greg KH
2012-10-30 2:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353531886.24807.43.camel@joe-AO722 \
--to=joe@perches.com \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).