From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dtor@vmware.com>
Cc: George Zhang <georgezhang@vmware.com>,
pv-drivers@vmware.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.
Date: Wed, 21 Nov 2012 13:35:51 -0800 [thread overview]
Message-ID: <1353533751.24807.49.camel@joe-AO722> (raw)
In-Reply-To: <20121121212908.GA16131@dtor-ws.eng.vmware.com>
On Wed, 2012-11-21 at 13:29 -0800, Dmitry Torokhov wrote:
> Hi Joe,
Howdy.
> On Wed, Nov 21, 2012 at 01:04:46PM -0800, Joe Perches wrote:
> > On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote:
> > > + context = kzalloc(sizeof(*context), GFP_KERNEL);
> > > + if (!context) {
> > > + pr_warn("Failed to allocate memory for VMCI context.\n");
> >
> > OOM logging messages aren't necessary as alloc failures
> > are already logged with a stack trace.
> >
>
> Are we sure we are going to keep this policy forever?
As in geological eras? Hard to say. It's been there awhile.
If more OOM logging messages are removed, it's more likely
for the core facility to stay.
There is an __GFP_NOWARN override to avoid the stack trace.
> I'd rather keep the OOM warnings.
Your choice.
cheers, Joe
next prev parent reply other threads:[~2012-11-22 20:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:31 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-21 21:04 ` Joe Perches
2012-11-21 21:10 ` [Pv-drivers] " Andy King
2012-11-21 21:29 ` Dmitry Torokhov
2012-11-21 21:35 ` Joe Perches [this message]
2012-11-21 20:32 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-21 20:32 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-11-21 20:33 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-11-21 20:33 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-11-21 20:34 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-11-21 20:34 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-21 20:34 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-11-21 20:35 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-11-21 20:35 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-11-21 20:35 ` [PATCH 11/12] VMCI: host " George Zhang
2012-11-21 20:36 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-26 22:37 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
2012-11-26 23:01 ` [Pv-drivers] " Dmitry Torokhov
2012-11-26 23:23 ` Greg KH
2012-11-26 23:36 ` Dmitry Torokhov
2012-11-26 23:44 ` Greg KH
2012-11-26 23:52 ` Dmitry Torokhov
2012-11-26 23:56 ` George Zhang
2012-11-27 0:03 ` Greg KH
2012-11-27 0:27 ` Woody Suwalski
2012-11-27 0:47 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2012-10-30 1:03 George Zhang
2012-10-30 1:03 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-10-30 2:10 ` Greg KH
2012-10-30 4:01 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:46 ` Greg KH
2012-10-30 15:56 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353533751.24807.49.camel@joe-AO722 \
--to=joe@perches.com \
--cc=dtor@vmware.com \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).