From: Dmitry Torokhov <dtor@vmware.com>
To: pv-drivers@vmware.com
Cc: Greg KH <gregkh@linuxfoundation.org>,
George Zhang <georgezhang@vmware.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Pv-drivers] [PATCH 00/12] VMCI for Linux upstreaming
Date: Mon, 26 Nov 2012 15:01:04 -0800 [thread overview]
Message-ID: <1975718.7UL0qBEfzR@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <20121126223754.GA28681@kroah.com>
On Monday, November 26, 2012 02:37:54 PM Greg KH wrote:
> On Wed, Nov 21, 2012 at 12:31:04PM -0800, George Zhang wrote:
> > * * *
> > This series of VMCI linux upstreaming patches include latest udpate from
> > VMware.
> >
> > Summary of changes:
> > - Sparse clean.
> > - Checkpatch clean with one exception, a "complex macro" in
> >
> > which we can't add parentheses.
> >
> > - Remove all runtime assertions.
> > - Fix device name, so that existing user clients work.
> > - Fix VMCI handle lookup.
>
> Given that you failed to answer the questions I asked the last time you
> posted this series, and you did not make any of the changes I asked for,
> I can't accept this (nor should you expect me to.)
>
> And people wonder why reviewers get so grumpy...
>
> My trees are now closed for the 3.8 merge window, so feel free to try
> again after 3.8-rc1 is out, and you have answered, and addressed, the
> questions and comments I made.
Greg, there were 3 specific complaints from you:
1. "Given that this is a static function, there's no need for these
"asserts", right? Please send a follow-on patch removing all BUG_ON()
calls from these files, it's not acceptable to crash a user's box from
a driver that is handling parameters you are feeding it."
2. "You obviously didn't run checkpatch on this file"
3. "This line causes sparse to complain. The odds that userspace knows
what gcc is using for "bool" is pretty low."
Given the fact that the series addresses all 3 I fail to understand why
you would be grumpy.
Anyway, since there vsock has not been reviewed yet we are OK with
postponing this patch series till 3.9.
Thanks,
Dmitry
next prev parent reply other threads:[~2012-11-26 23:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:31 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-21 21:04 ` Joe Perches
2012-11-21 21:10 ` [Pv-drivers] " Andy King
2012-11-21 21:29 ` Dmitry Torokhov
2012-11-21 21:35 ` Joe Perches
2012-11-21 20:32 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-21 20:32 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-11-21 20:33 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-11-21 20:33 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-11-21 20:34 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-11-21 20:34 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-21 20:34 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-11-21 20:35 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-11-21 20:35 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-11-21 20:35 ` [PATCH 11/12] VMCI: host " George Zhang
2012-11-21 20:36 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-26 22:37 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
2012-11-26 23:01 ` Dmitry Torokhov [this message]
2012-11-26 23:23 ` [Pv-drivers] " Greg KH
2012-11-26 23:36 ` Dmitry Torokhov
2012-11-26 23:44 ` Greg KH
2012-11-26 23:52 ` Dmitry Torokhov
2012-11-26 23:56 ` George Zhang
2012-11-27 0:03 ` Greg KH
2012-11-27 0:27 ` Woody Suwalski
2012-11-27 0:47 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2012-10-30 1:03 George Zhang
2012-10-30 2:19 ` Greg KH
2012-10-30 4:07 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:48 ` Greg KH
2012-10-30 16:18 ` Dmitry Torokhov
2012-10-30 16:27 ` Greg KH
2012-10-30 19:43 ` Dmitry Torokhov
2012-10-30 19:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1975718.7UL0qBEfzR@dtor-d630.eng.vmware.com \
--to=dtor@vmware.com \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).