[PATCH] clk: mxs: Fix sparse warnings

[PATCH] clk: mxs: Fix sparse warnings

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Fix the following sparse warnings:

drivers/clk/mxs/clk.c:17:1: warning: symbol 'mxs_lock' was not declared. Should it be static?
drivers/clk/mxs/clk.c:19:5: warning: symbol 'mxs_clk_wait' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/clk/mxs/clk.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/mxs/clk.c b/drivers/clk/mxs/clk.c
index b24d560..5301bce 100644
--- a/drivers/clk/mxs/clk.c
+++ b/drivers/clk/mxs/clk.c
@@ -13,6 +13,7 @@
 #include <linux/io.h>
 #include <linux/jiffies.h>
 #include <linux/spinlock.h>
+#include "clk.h"
 
 DEFINE_SPINLOCK(mxs_lock);
 
-- 
1.7.9.5

Re: [PATCH] clk: mxs: Fix sparse warnings

[Shawn Guo]

On Mon, Feb 11, 2013 at 12:07:16PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Fix the following sparse warnings:
> 
> drivers/clk/mxs/clk.c:17:1: warning: symbol 'mxs_lock' was not declared. Should it be static?
> drivers/clk/mxs/clk.c:19:5: warning: symbol 'mxs_clk_wait' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

> ---
>  drivers/clk/mxs/clk.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/mxs/clk.c b/drivers/clk/mxs/clk.c
> index b24d560..5301bce 100644
> --- a/drivers/clk/mxs/clk.c
> +++ b/drivers/clk/mxs/clk.c
> @@ -13,6 +13,7 @@
>  #include <linux/io.h>
>  #include <linux/jiffies.h>
>  #include <linux/spinlock.h>
> +#include "clk.h"
>  
>  DEFINE_SPINLOCK(mxs_lock);
>  
> -- 
> 1.7.9.5
> 

Re: [PATCH] clk: mxs: Fix sparse warnings

[Mike Turquette]

Quoting Shawn Guo (2013-02-17 00:02:20)
> On Mon, Feb 11, 2013 at 12:07:16PM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Fix the following sparse warnings:
> > 
> > drivers/clk/mxs/clk.c:17:1: warning: symbol 'mxs_lock' was not declared. Should it be static?
> > drivers/clk/mxs/clk.c:19:5: warning: symbol 'mxs_clk_wait' was not declared. Should it be static?
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> 

Taken into clk-next.

Thanks,
Mike

> > ---
> >  drivers/clk/mxs/clk.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/mxs/clk.c b/drivers/clk/mxs/clk.c
> > index b24d560..5301bce 100644
> > --- a/drivers/clk/mxs/clk.c
> > +++ b/drivers/clk/mxs/clk.c
> > @@ -13,6 +13,7 @@
> >  #include <linux/io.h>
> >  #include <linux/jiffies.h>
> >  #include <linux/spinlock.h>
> > +#include "clk.h"
> >  
> >  DEFINE_SPINLOCK(mxs_lock);
> >  
> > -- 
> > 1.7.9.5
> >