From: Colin Cross <ccross@android.com>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
arve@android.com, Tejun Heo <tj@kernel.org>,
Oleg Nesterov <oleg@redhat.com>, Colin Cross <ccross@android.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Gao feng <gaofeng@cn.fujitsu.com>,
netdev@vger.kernel.org
Subject: [PATCH v2 10/10] af_unix: use freezable blocking calls in read
Date: Wed, 1 May 2013 18:35:08 -0700 [thread overview]
Message-ID: <1367458508-9133-11-git-send-email-ccross@android.com> (raw)
In-Reply-To: <1367458508-9133-1-git-send-email-ccross@android.com>
Avoid waking up every thread sleeping in read call on an AF_UNIX
socket during suspend and resume by calling a freezable blocking
call. Previous patches modified the freezer to avoid sending
wakeups to threads that are blocked in freezable blocking calls.
This call was selected to be converted to a freezable call because
it doesn't hold any locks or release any resources when interrupted
that might be needed by another freezing task or a kernel driver
during suspend, and is a common site where idle userspace tasks are
blocked.
Signed-off-by: Colin Cross <ccross@android.com>
---
net/unix/af_unix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 2db702d..2bcac57 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -114,6 +114,7 @@
#include <linux/mount.h>
#include <net/checksum.h>
#include <linux/security.h>
+#include <linux/freezer.h>
struct hlist_head unix_socket_table[2 * UNIX_HASH_SIZE];
EXPORT_SYMBOL_GPL(unix_socket_table);
@@ -1880,7 +1881,7 @@ static long unix_stream_data_wait(struct sock *sk, long timeo)
set_bit(SOCK_ASYNC_WAITDATA, &sk->sk_socket->flags);
unix_state_unlock(sk);
- timeo = schedule_timeout(timeo);
+ timeo = freezable_schedule_timeout(timeo);
unix_state_lock(sk);
clear_bit(SOCK_ASYNC_WAITDATA, &sk->sk_socket->flags);
}
--
1.8.2.1
next prev parent reply other threads:[~2013-05-02 1:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 1:34 [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups Colin Cross
2013-05-02 1:34 ` [PATCH v2 01/10] freezer: shorten freezer sleep time using exponential backoff Colin Cross
2013-05-02 23:20 ` Tejun Heo
2013-05-02 1:35 ` [PATCH v2 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set Colin Cross
2013-05-02 23:24 ` Tejun Heo
2013-05-03 9:24 ` Pavel Machek
2013-05-02 1:35 ` [PATCH v2 03/10] freezer: add new freezable helpers using freezer_do_not_count() Colin Cross
2013-05-02 23:55 ` Tejun Heo
2013-05-03 0:03 ` Tejun Heo
2013-05-03 2:16 ` Colin Cross
2013-05-03 2:41 ` Colin Cross
2013-05-03 4:09 ` Tejun Heo
2013-05-03 4:12 ` Tejun Heo
2013-05-03 4:17 ` Colin Cross
2013-05-03 4:20 ` Tejun Heo
2013-05-03 14:18 ` Alan Stern
2013-05-03 16:54 ` Tejun Heo
2013-05-02 1:35 ` [PATCH v2 04/10] binder: use freezable blocking calls Colin Cross
2013-05-02 1:35 ` [PATCH v2 05/10] epoll: use freezable blocking call Colin Cross
2013-05-02 1:35 ` [PATCH v2 06/10] select: " Colin Cross
2013-05-02 1:35 ` [PATCH v2 07/10] futex: " Colin Cross
2013-05-02 19:45 ` Thomas Gleixner
2013-05-03 3:12 ` Darren Hart
2013-06-25 21:15 ` [tip:core/locking] futex: Use " tip-bot for Colin Cross
2013-05-02 1:35 ` [PATCH v2 08/10] nanosleep: use " Colin Cross
2013-05-02 19:46 ` Thomas Gleixner
2013-05-02 1:35 ` [PATCH v2 09/10] sigtimedwait: " Colin Cross
2013-05-02 1:35 ` Colin Cross [this message]
2013-05-03 0:08 ` [PATCH v2 10/10] af_unix: use freezable blocking calls in read Tejun Heo
2013-05-04 19:19 ` Rafael J. Wysocki
2013-05-04 20:39 ` Tejun Heo
2013-05-04 22:23 ` Colin Cross
2013-05-05 11:23 ` Rafael J. Wysocki
2013-05-02 21:06 ` [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups Rafael J. Wysocki
2013-05-03 0:10 ` Tejun Heo
2013-05-03 11:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367458508-9133-11-git-send-email-ccross@android.com \
--to=ccross@android.com \
--cc=arve@android.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).