From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Tejun Heo <tj@kernel.org>
Cc: Colin Cross <ccross@android.com>, Oleg Nesterov <oleg@redhat.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
arve@android.com
Subject: Re: [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups
Date: Fri, 03 May 2013 13:43:46 +0200 [thread overview]
Message-ID: <6539209.phsENQLmv5@vostro.rjw.lan> (raw)
In-Reply-To: <20130503001026.GZ19814@mtj.dyndns.org>
On Thursday, May 02, 2013 05:10:26 PM Tejun Heo wrote:
> Hey, Rafael.
>
> On Thu, May 02, 2013 at 11:06:35PM +0200, Rafael J. Wysocki wrote:
> > > v2 moves the skip check to freeze_task(), and expands the commit
> > > messages.
> >
> > The entire series makes sense to me, so are there any objections?
> >
> > Tejun, Oleg??
>
> Generally looks good to me. I'm a bit uncomfortable with the
> generic-looking expansion of the freezable API as it can't be
> something which can be used in any generic manner. It'd be great if
> we just add only the used ones (do we already?)
I'm not sure about that, unfortunately.
> and add some sort of lockdep annotation so that people don't use them while
> holding any locks.
I guess we can add that anyway?
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-05-03 11:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 1:34 [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups Colin Cross
2013-05-02 1:34 ` [PATCH v2 01/10] freezer: shorten freezer sleep time using exponential backoff Colin Cross
2013-05-02 23:20 ` Tejun Heo
2013-05-02 1:35 ` [PATCH v2 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set Colin Cross
2013-05-02 23:24 ` Tejun Heo
2013-05-03 9:24 ` Pavel Machek
2013-05-02 1:35 ` [PATCH v2 03/10] freezer: add new freezable helpers using freezer_do_not_count() Colin Cross
2013-05-02 23:55 ` Tejun Heo
2013-05-03 0:03 ` Tejun Heo
2013-05-03 2:16 ` Colin Cross
2013-05-03 2:41 ` Colin Cross
2013-05-03 4:09 ` Tejun Heo
2013-05-03 4:12 ` Tejun Heo
2013-05-03 4:17 ` Colin Cross
2013-05-03 4:20 ` Tejun Heo
2013-05-03 14:18 ` Alan Stern
2013-05-03 16:54 ` Tejun Heo
2013-05-02 1:35 ` [PATCH v2 04/10] binder: use freezable blocking calls Colin Cross
2013-05-02 1:35 ` [PATCH v2 05/10] epoll: use freezable blocking call Colin Cross
2013-05-02 1:35 ` [PATCH v2 06/10] select: " Colin Cross
2013-05-02 1:35 ` [PATCH v2 07/10] futex: " Colin Cross
2013-05-02 19:45 ` Thomas Gleixner
2013-05-03 3:12 ` Darren Hart
2013-06-25 21:15 ` [tip:core/locking] futex: Use " tip-bot for Colin Cross
2013-05-02 1:35 ` [PATCH v2 08/10] nanosleep: use " Colin Cross
2013-05-02 19:46 ` Thomas Gleixner
2013-05-02 1:35 ` [PATCH v2 09/10] sigtimedwait: " Colin Cross
2013-05-02 1:35 ` [PATCH v2 10/10] af_unix: use freezable blocking calls in read Colin Cross
2013-05-03 0:08 ` Tejun Heo
2013-05-04 19:19 ` Rafael J. Wysocki
2013-05-04 20:39 ` Tejun Heo
2013-05-04 22:23 ` Colin Cross
2013-05-05 11:23 ` Rafael J. Wysocki
2013-05-02 21:06 ` [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups Rafael J. Wysocki
2013-05-03 0:10 ` Tejun Heo
2013-05-03 11:43 ` Rafael J. Wysocki [this message]
2013-05-06 23:50 Colin Cross
2013-05-07 18:12 ` Tejun Heo
2013-05-08 0:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6539209.phsENQLmv5@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).