linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	Ingo Molnar <mingo@kernel.org>,
	Linux EFI <linux-efi@vger.kernel.org>,
	Matt Fleming <matt@console-pimps.org>, X86 ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH -v2 0/4] EFI 1:1 mapping
Date: Wed, 19 Jun 2013 09:50:40 -0700	[thread overview]
Message-ID: <1371660640.2409.44.camel@dabdike> (raw)
In-Reply-To: <20130619163804.GG28300@pd.tnic>

On Wed, 2013-06-19 at 18:38 +0200, Borislav Petkov wrote:
> On Wed, Jun 19, 2013 at 05:21:15PM +0100, Matthew Garrett wrote:
> > Yes, kexec needs a different solution.
> 
> No need. If we say, "efi=use_11_map", the 1:1 map will be shoved down
> SetVirtualAddressMap. Otherwise the high mappings.
> 
> > Because firmware images don't always update all of the pointers, and
> > so will crash if the 1:1 mappings aren't present.
> 
> Ok, so it sounds like we want to *always* create both mappings but,
> depending on what we want, to shove down SetVirtualAddressMap a
> different set. And the 1:1 map will be the optional one which we give
> SetVirtualAddressMap only when user wants it, i.e. when booting with
> "efi=1:1_map".
> 
> Makes sense?

I think it will work.  The only thing I'd worry about is aliasing.  This
scheme clearly won't work for any virtually indexed processor (so it's
basically x86 only) but even on Physically Indexed, you do have to make
sure the cache attributes of any given page are the same for all virtual
address aliases.  As long as the 1:1 mapping is writeback, I think this
is satisfied.

James



  parent reply	other threads:[~2013-06-19 16:50 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 17:50 [PATCH -v2 0/4] EFI 1:1 mapping Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 1/4] efi: Convert runtime services function ptrs Borislav Petkov
2013-06-20 18:15   ` [PATCH] [IA64] sim: Add casts to avoid assignment warnings Luck, Tony
2013-06-20 23:43     ` Tony Luck
2013-06-21 10:26       ` Fleming, Matt
2013-06-17 17:50 ` [PATCH -v2 2/4] x86, cpa: Map in an arbitrary pgd Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 3/4] x86, efi: Add an efi= kernel command line parameter Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 4/4] x86, efi: Map runtime services 1:1 Borislav Petkov
2013-06-21 11:56   ` Matt Fleming
2013-07-03  6:19   ` joeyli
2013-06-19 12:52 ` [PATCH -v2 0/4] EFI 1:1 mapping Ingo Molnar
2013-06-19 13:02   ` Borislav Petkov
2013-06-19 13:04     ` Ingo Molnar
2013-06-19 13:25       ` Borislav Petkov
2013-06-19 16:08       ` Matthew Garrett
2013-06-19 16:18         ` Borislav Petkov
2013-06-19 16:21           ` Matthew Garrett
2013-06-19 16:38             ` Borislav Petkov
2013-06-19 16:48               ` Matthew Garrett
2013-06-19 16:59                 ` Borislav Petkov
2013-06-20 21:26                   ` H. Peter Anvin
2013-06-21  6:34                   ` Matt Fleming
2013-06-19 16:50               ` James Bottomley [this message]
2013-06-20  9:13         ` Ingo Molnar
2013-06-20  9:15           ` Matthew Garrett
2013-06-20  9:22             ` Ingo Molnar
2013-06-20  9:33               ` Borislav Petkov
2013-06-20  9:44                 ` Matthew Garrett
2013-06-20 14:33                   ` Jiri Kosina
2013-06-20 14:53                   ` James Bottomley
2013-06-20 16:29                     ` Matthew Garrett
2013-06-20 16:44                       ` Jiri Kosina
2013-06-20 16:53                         ` Matthew Garrett
2013-06-20 16:46                       ` James Bottomley
2013-06-20 16:54                         ` Matthew Garrett
2013-06-20 17:01                           ` Borislav Petkov
2013-06-20 17:12                             ` Matthew Garrett
2013-06-20 18:08                               ` Borislav Petkov
2013-06-20 18:10                                 ` Matthew Garrett
2013-06-20 18:14                                   ` Borislav Petkov
2013-06-20 18:17                                     ` Matthew Garrett
2013-06-20 18:47                                       ` Borislav Petkov
2013-06-20 22:35                                         ` H. Peter Anvin
2013-06-21  7:23                                           ` Borislav Petkov
2013-06-21 10:05                                             ` H. Peter Anvin
2013-06-21 14:21                                               ` Borislav Petkov
2013-06-21 16:42                                                 ` H. Peter Anvin
2013-07-02  7:29                                                   ` Pavel Machek
2013-06-19 16:05     ` Matthew Garrett
2013-06-19 17:25     ` H. Peter Anvin
2013-06-19 17:37       ` Borislav Petkov
2013-06-19 17:38         ` H. Peter Anvin
2013-06-19 17:50           ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371660640.2409.44.camel@dabdike \
    --to=james.bottomley@hansenpartnership.com \
    --cc=bp@alien8.de \
    --cc=bp@suse.de \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=mingo@kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).