From: Tony Luck <tony.luck@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Matt Fleming <matt.fleming@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [IA64] sim: Add casts to avoid assignment warnings
Date: Thu, 20 Jun 2013 16:43:42 -0700 [thread overview]
Message-ID: <CA+8MBbKQ9qTUvzkQO+c68JvF=TJ0rvs+yc5XzQ1o7EyvKY64fA@mail.gmail.com> (raw)
In-Reply-To: <084100@agluck-desk.sc.intel.com>
Oops - pasted in old e-mail address for Boris
On Thu, Jun 20, 2013 at 11:15 AM, Luck, Tony <tony.luck@intel.com> wrote:
> Pointers in the efi_runtime_services_t structure now have type
> "void *" (formerly they were "unsigned long"). So we now see a
> bunch of warnings like this:
>
> arch/ia64/hp/sim/boot/fw-emu.c:293: warning: assignment makes pointer from integer without a cast
>
> Add (void *) casts to the 10 affected lines to make the build quiet again.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
>
> ---
>
> Boris, Matt - Can you add this patch to the same tree that
>
> commit 43ab0476a648053e5998bf081f47f215375a4502 [linux-next id]
> efi: Convert runtime services function ptrs
>
> is in so that it will follow along behind it. Thanks.
>
> arch/ia64/hp/sim/boot/fw-emu.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/ia64/hp/sim/boot/fw-emu.c b/arch/ia64/hp/sim/boot/fw-emu.c
> index 271f412..87bf9ad 100644
> --- a/arch/ia64/hp/sim/boot/fw-emu.c
> +++ b/arch/ia64/hp/sim/boot/fw-emu.c
> @@ -290,16 +290,16 @@ sys_fw_init (const char *args, int arglen)
> efi_runtime->hdr.signature = EFI_RUNTIME_SERVICES_SIGNATURE;
> efi_runtime->hdr.revision = EFI_RUNTIME_SERVICES_REVISION;
> efi_runtime->hdr.headersize = sizeof(efi_runtime->hdr);
> - efi_runtime->get_time = __pa(&fw_efi_get_time);
> - efi_runtime->set_time = __pa(&efi_unimplemented);
> - efi_runtime->get_wakeup_time = __pa(&efi_unimplemented);
> - efi_runtime->set_wakeup_time = __pa(&efi_unimplemented);
> - efi_runtime->set_virtual_address_map = __pa(&efi_unimplemented);
> - efi_runtime->get_variable = __pa(&efi_unimplemented);
> - efi_runtime->get_next_variable = __pa(&efi_unimplemented);
> - efi_runtime->set_variable = __pa(&efi_unimplemented);
> - efi_runtime->get_next_high_mono_count = __pa(&efi_unimplemented);
> - efi_runtime->reset_system = __pa(&efi_reset_system);
> + efi_runtime->get_time = (void *)__pa(&fw_efi_get_time);
> + efi_runtime->set_time = (void *)__pa(&efi_unimplemented);
> + efi_runtime->get_wakeup_time = (void *)__pa(&efi_unimplemented);
> + efi_runtime->set_wakeup_time = (void *)__pa(&efi_unimplemented);
> + efi_runtime->set_virtual_address_map = (void *)__pa(&efi_unimplemented);
> + efi_runtime->get_variable = (void *)__pa(&efi_unimplemented);
> + efi_runtime->get_next_variable = (void *)__pa(&efi_unimplemented);
> + efi_runtime->set_variable = (void *)__pa(&efi_unimplemented);
> + efi_runtime->get_next_high_mono_count = (void *)__pa(&efi_unimplemented);
> + efi_runtime->reset_system = (void *)__pa(&efi_reset_system);
>
> efi_tables->guid = SAL_SYSTEM_TABLE_GUID;
> efi_tables->table = __pa(sal_systab);
> --
> 1.8.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-06-20 23:43 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 17:50 [PATCH -v2 0/4] EFI 1:1 mapping Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 1/4] efi: Convert runtime services function ptrs Borislav Petkov
2013-06-20 18:15 ` [PATCH] [IA64] sim: Add casts to avoid assignment warnings Luck, Tony
2013-06-20 23:43 ` Tony Luck [this message]
2013-06-21 10:26 ` Fleming, Matt
2013-06-17 17:50 ` [PATCH -v2 2/4] x86, cpa: Map in an arbitrary pgd Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 3/4] x86, efi: Add an efi= kernel command line parameter Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 4/4] x86, efi: Map runtime services 1:1 Borislav Petkov
2013-06-21 11:56 ` Matt Fleming
2013-07-03 6:19 ` joeyli
2013-06-19 12:52 ` [PATCH -v2 0/4] EFI 1:1 mapping Ingo Molnar
2013-06-19 13:02 ` Borislav Petkov
2013-06-19 13:04 ` Ingo Molnar
2013-06-19 13:25 ` Borislav Petkov
2013-06-19 16:08 ` Matthew Garrett
2013-06-19 16:18 ` Borislav Petkov
2013-06-19 16:21 ` Matthew Garrett
2013-06-19 16:38 ` Borislav Petkov
2013-06-19 16:48 ` Matthew Garrett
2013-06-19 16:59 ` Borislav Petkov
2013-06-20 21:26 ` H. Peter Anvin
2013-06-21 6:34 ` Matt Fleming
2013-06-19 16:50 ` James Bottomley
2013-06-20 9:13 ` Ingo Molnar
2013-06-20 9:15 ` Matthew Garrett
2013-06-20 9:22 ` Ingo Molnar
2013-06-20 9:33 ` Borislav Petkov
2013-06-20 9:44 ` Matthew Garrett
2013-06-20 14:33 ` Jiri Kosina
2013-06-20 14:53 ` James Bottomley
2013-06-20 16:29 ` Matthew Garrett
2013-06-20 16:44 ` Jiri Kosina
2013-06-20 16:53 ` Matthew Garrett
2013-06-20 16:46 ` James Bottomley
2013-06-20 16:54 ` Matthew Garrett
2013-06-20 17:01 ` Borislav Petkov
2013-06-20 17:12 ` Matthew Garrett
2013-06-20 18:08 ` Borislav Petkov
2013-06-20 18:10 ` Matthew Garrett
2013-06-20 18:14 ` Borislav Petkov
2013-06-20 18:17 ` Matthew Garrett
2013-06-20 18:47 ` Borislav Petkov
2013-06-20 22:35 ` H. Peter Anvin
2013-06-21 7:23 ` Borislav Petkov
2013-06-21 10:05 ` H. Peter Anvin
2013-06-21 14:21 ` Borislav Petkov
2013-06-21 16:42 ` H. Peter Anvin
2013-07-02 7:29 ` Pavel Machek
2013-06-19 16:05 ` Matthew Garrett
2013-06-19 17:25 ` H. Peter Anvin
2013-06-19 17:37 ` Borislav Petkov
2013-06-19 17:38 ` H. Peter Anvin
2013-06-19 17:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+8MBbKQ9qTUvzkQO+c68JvF=TJ0rvs+yc5XzQ1o7EyvKY64fA@mail.gmail.com' \
--to=tony.luck@gmail.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).