From: joeyli <jlee@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Linux EFI <linux-efi@vger.kernel.org>,
Matt Fleming <matt@console-pimps.org>,
Matthew Garrett <mjg59@srcf.ucam.org>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH -v2 4/4] x86, efi: Map runtime services 1:1
Date: Wed, 03 Jul 2013 14:19:03 +0800 [thread overview]
Message-ID: <1372832343.26878.6.camel@linux-s257.site> (raw)
In-Reply-To: <1371491416-11037-5-git-send-email-bp@alien8.de>
於 一,2013-06-17 於 19:50 +0200,Borislav Petkov 提到:
> +#ifdef CONFIG_X86_64
> + efi_scratch.pgt11 = (pgd_t *)(unsigned long)real_mode_header->trampoline_pgd;
> +#endif
> + efi_use_11_map = true;
> +
I think "efi_use_11_map = true" should moved to before "#endif",
otherwise kernel will build fail on i586 architecture.
I got build error:
arch/x86/platform/efi/efi.c:1074: error: ‘efi_use_11_map’ undeclared (first use in this function)
arch/x86/platform/efi/efi.c:1074: error: (Each undeclared identifier is reported only once
arch/x86/platform/efi/efi.c:1074: error: for each function it appears in.)
Thanks a lot!
Joey Lee
next prev parent reply other threads:[~2013-07-03 6:19 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 17:50 [PATCH -v2 0/4] EFI 1:1 mapping Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 1/4] efi: Convert runtime services function ptrs Borislav Petkov
2013-06-20 18:15 ` [PATCH] [IA64] sim: Add casts to avoid assignment warnings Luck, Tony
2013-06-20 23:43 ` Tony Luck
2013-06-21 10:26 ` Fleming, Matt
2013-06-17 17:50 ` [PATCH -v2 2/4] x86, cpa: Map in an arbitrary pgd Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 3/4] x86, efi: Add an efi= kernel command line parameter Borislav Petkov
2013-06-17 17:50 ` [PATCH -v2 4/4] x86, efi: Map runtime services 1:1 Borislav Petkov
2013-06-21 11:56 ` Matt Fleming
2013-07-03 6:19 ` joeyli [this message]
2013-06-19 12:52 ` [PATCH -v2 0/4] EFI 1:1 mapping Ingo Molnar
2013-06-19 13:02 ` Borislav Petkov
2013-06-19 13:04 ` Ingo Molnar
2013-06-19 13:25 ` Borislav Petkov
2013-06-19 16:08 ` Matthew Garrett
2013-06-19 16:18 ` Borislav Petkov
2013-06-19 16:21 ` Matthew Garrett
2013-06-19 16:38 ` Borislav Petkov
2013-06-19 16:48 ` Matthew Garrett
2013-06-19 16:59 ` Borislav Petkov
2013-06-20 21:26 ` H. Peter Anvin
2013-06-21 6:34 ` Matt Fleming
2013-06-19 16:50 ` James Bottomley
2013-06-20 9:13 ` Ingo Molnar
2013-06-20 9:15 ` Matthew Garrett
2013-06-20 9:22 ` Ingo Molnar
2013-06-20 9:33 ` Borislav Petkov
2013-06-20 9:44 ` Matthew Garrett
2013-06-20 14:33 ` Jiri Kosina
2013-06-20 14:53 ` James Bottomley
2013-06-20 16:29 ` Matthew Garrett
2013-06-20 16:44 ` Jiri Kosina
2013-06-20 16:53 ` Matthew Garrett
2013-06-20 16:46 ` James Bottomley
2013-06-20 16:54 ` Matthew Garrett
2013-06-20 17:01 ` Borislav Petkov
2013-06-20 17:12 ` Matthew Garrett
2013-06-20 18:08 ` Borislav Petkov
2013-06-20 18:10 ` Matthew Garrett
2013-06-20 18:14 ` Borislav Petkov
2013-06-20 18:17 ` Matthew Garrett
2013-06-20 18:47 ` Borislav Petkov
2013-06-20 22:35 ` H. Peter Anvin
2013-06-21 7:23 ` Borislav Petkov
2013-06-21 10:05 ` H. Peter Anvin
2013-06-21 14:21 ` Borislav Petkov
2013-06-21 16:42 ` H. Peter Anvin
2013-07-02 7:29 ` Pavel Machek
2013-06-19 16:05 ` Matthew Garrett
2013-06-19 17:25 ` H. Peter Anvin
2013-06-19 17:37 ` Borislav Petkov
2013-06-19 17:38 ` H. Peter Anvin
2013-06-19 17:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372832343.26878.6.camel@linux-s257.site \
--to=jlee@suse.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).