linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, jkosina@suse.cz, elias.vds@gmail.com,
	anssi.hannula@iki.fi, simon@mungewell.org
Subject: [PATCH v2 18/24] input: Port hid-wiimote-modules to ff-memless-next
Date: Tue, 22 Apr 2014 16:00:03 +0200	[thread overview]
Message-ID: <1398175209-9565-19-git-send-email-madcatxster@devoid-pointer.net> (raw)
In-Reply-To: <1398175209-9565-1-git-send-email-madcatxster@devoid-pointer.net>

Port hid-wiimote-modules to ff-memless-next

Signed-off-by: Michal Malý <madcatxster@devoid-pointer.net>
---
 drivers/hid/Kconfig               |  2 +-
 drivers/hid/hid-wiimote-modules.c | 74 ++++++++++++++++++++++++---------------
 2 files changed, 46 insertions(+), 30 deletions(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index ee999bc..d1cbad6 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -738,7 +738,7 @@ config HID_WIIMOTE
 	depends on HID
 	depends on LEDS_CLASS
 	select POWER_SUPPLY
-	select INPUT_FF_MEMLESS
+	select INPUT_FF_MEMLESS_NEXT
 	---help---
 	Support for Nintendo Wii and Wii U Bluetooth peripherals. Supported
 	devices are the Wii Remote and its extension devices, but also devices
diff --git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-modules.c
index 6b61f01..95b20ea 100644
--- a/drivers/hid/hid-wiimote-modules.c
+++ b/drivers/hid/hid-wiimote-modules.c
@@ -37,8 +37,11 @@
 #include <linux/hid.h>
 #include <linux/input.h>
 #include <linux/spinlock.h>
+#include <linux/input/ff-memless-next.h>
 #include "hid-wiimote.h"
 
+#define FF_UPDATE_RATE 50
+
 /*
  * Keys
  * The initial Wii Remote provided a bunch of buttons that are reported as
@@ -131,21 +134,27 @@ static void wiimod_rumble_worker(struct work_struct *work)
 }
 
 static int wiimod_rumble_play(struct input_dev *dev, void *data,
-			      struct ff_effect *eff)
+			      const struct mlnx_effect_command *command)
 {
 	struct wiimote_data *wdata = input_get_drvdata(dev);
-	__u8 value;
-
-	/*
-	 * The wiimote supports only a single rumble motor so if any magnitude
-	 * is set to non-zero then we start the rumble motor. If both are set to
-	 * zero, we stop the rumble motor.
-	 */
-
-	if (eff->u.rumble.strong_magnitude || eff->u.rumble.weak_magnitude)
-		value = 1;
-	else
-		value = 0;
+	const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force;
+	__u8 value = 0;
+
+	switch (command->cmd) {
+	case MLNX_START_RUMBLE:
+		/*
+		 * The wiimote supports only a single rumble motor so if any magnitude
+		 * is set to non-zero then we start the rumble motor. If both are set to
+		 * zero, we stop the rumble motor.
+		 */
+		if (rumble_force->strong || rumble_force->weak)
+			value = 1;
+		break;
+	case MLNX_STOP_RUMBLE:
+		break;
+	default:
+		return -EINVAL;
+	}
 
 	/* Locking state.lock here might deadlock with input_event() calls.
 	 * schedule_work acts as barrier. Merging multiple changes is fine. */
@@ -161,7 +170,7 @@ static int wiimod_rumble_probe(const struct wiimod_ops *ops,
 	INIT_WORK(&wdata->rumble_worker, wiimod_rumble_worker);
 
 	set_bit(FF_RUMBLE, wdata->input->ffbit);
-	if (input_ff_create_memless(wdata->input, NULL, wiimod_rumble_play))
+	if (input_ff_create_mlnx(wdata->input, NULL, wiimod_rumble_play, FF_UPDATE_RATE))
 		return -ENOMEM;
 
 	return 0;
@@ -1771,21 +1780,28 @@ static void wiimod_pro_close(struct input_dev *dev)
 }
 
 static int wiimod_pro_play(struct input_dev *dev, void *data,
-			   struct ff_effect *eff)
+			   const struct mlnx_effect_command *command)
 {
 	struct wiimote_data *wdata = input_get_drvdata(dev);
-	__u8 value;
-
-	/*
-	 * The wiimote supports only a single rumble motor so if any magnitude
-	 * is set to non-zero then we start the rumble motor. If both are set to
-	 * zero, we stop the rumble motor.
-	 */
-
-	if (eff->u.rumble.strong_magnitude || eff->u.rumble.weak_magnitude)
-		value = 1;
-	else
-		value = 0;
+	const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force;
+	__u8 value = 0;
+
+	switch (command->cmd) {
+	case MLNX_START_RUMBLE:
+		/*
+		 * The wiimote supports only a single rumble motor so if any magnitude
+		 * is set to non-zero then we start the rumble motor. If both are set to
+		 * zero, we stop the rumble motor.
+		 */
+
+		if (rumble_force->strong || rumble_force->weak)
+			value = 1;
+		break;
+	case MLNX_STOP_RUMBLE:
+		break;
+	default:
+		return -EINVAL;
+	}
 
 	/* Locking state.lock here might deadlock with input_event() calls.
 	 * schedule_work acts as barrier. Merging multiple changes is fine. */
@@ -1867,8 +1883,8 @@ static int wiimod_pro_probe(const struct wiimod_ops *ops,
 	set_bit(FF_RUMBLE, wdata->extension.input->ffbit);
 	input_set_drvdata(wdata->extension.input, wdata);
 
-	if (input_ff_create_memless(wdata->extension.input, NULL,
-				    wiimod_pro_play)) {
+	if (input_ff_create_mlnx(wdata->extension.input, NULL,
+				 wiimod_pro_play, FF_UPDATE_RATE)) {
 		ret = -ENOMEM;
 		goto err_free;
 	}
-- 
1.9.2


  parent reply	other threads:[~2014-04-22 14:05 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 13:59 [PATCH v2 00/24] input: Introduce ff-memless-next as an improved replacement for ff-memless Michal Malý
2014-04-22 13:59 ` [PATCH v2 01/24] input: Add ff-memless-next module Michal Malý
2014-04-23 12:12   ` Oliver Neukum
2014-04-23 12:30     ` Michal Malý
2014-04-23 13:31       ` Oliver Neukum
2014-04-23 15:59     ` Dmitry Torokhov
2014-04-23 17:06       ` Oliver Neukum
2014-04-23 17:24         ` Dmitry Torokhov
2014-04-22 13:59 ` [PATCH v2 02/24] input: Port arizona-haptics to ff-memless-next Michal Malý
2014-04-22 13:59 ` [PATCH v2 03/24] input: Port twl4030-vibra " Michal Malý
2014-04-22 13:59 ` [PATCH v2 04/24] input: Port twl6040-vibra " Michal Malý
2014-04-22 13:59 ` [PATCH v2 05/24] input: Port max8997_haptic " Michal Malý
2014-04-22 13:59 ` [PATCH v2 06/24] input: Port pm8xxx-vibrator " Michal Malý
2014-04-22 13:59 ` [PATCH v2 07/24] input: Port hid-axff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 08/24] input: Port hid-emsff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 09/24] input: Port hid-dr " Michal Malý
2014-04-23 13:41   ` Oliver Neukum
     [not found]     ` <5sjip0.n4hp0o.2szhuh-qmf@smtp.devoid-pointer.net>
     [not found]       ` <20140423154201.GA10531@core.coreip.homeip.net>
2014-04-23 15:47         ` simon
2014-04-23 15:57           ` Michal Malý
2014-04-24 10:32     ` Michal Malý
2014-04-27  8:22       ` Oliver Neukum
2014-04-22 13:59 ` [PATCH v2 10/24] input: Port hid-gaff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 11/24] input: Port hid-holtekff " Michal Malý
2014-04-23 12:17   ` Oliver Neukum
2014-04-23 12:31     ` Michal Malý
2014-04-23 16:02     ` Dmitry Torokhov
2014-04-22 13:59 ` [PATCH v2 12/24] input: Port hid-lgff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 13/24] input: Port hid-lg3ff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 14/24] input: Port hid-pl " Michal Malý
2014-04-22 14:00 ` [PATCH v2 15/24] input: Port hid-sjoy " Michal Malý
2014-04-22 14:00 ` [PATCH v2 16/24] input: Port hid-sony " Michal Malý
2014-04-22 14:00 ` [PATCH v2 17/24] input: Port hid-tmff " Michal Malý
2014-04-22 14:00 ` Michal Malý [this message]
2014-04-22 14:00 ` [PATCH v2 19/24] input: Port hid-zpff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 20/24] input: Port gamecon " Michal Malý
2014-04-22 14:00 ` [PATCH v2 21/24] input: Port xpad " Michal Malý
2014-04-22 14:00 ` [PATCH v2 22/24] input: Port hid-lg2ff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 23/24] input: Port hid-lg4ff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 24/24] input: Replace ff-memless with ff-memless-next Michal Malý

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398175209-9565-19-git-send-email-madcatxster@devoid-pointer.net \
    --to=madcatxster@devoid-pointer.net \
    --cc=anssi.hannula@iki.fi \
    --cc=dmitry.torokhov@gmail.com \
    --cc=elias.vds@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@mungewell.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).