From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: Oliver Neukum <oneukum@suse.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.torokhov@gmail.com, jkosina@suse.cz, elias.vds@gmail.com,
anssi.hannula@iki.fi, simon@mungewell.org
Subject: Re: [PATCH v2 11/24] input: Port hid-holtekff to ff-memless-next
Date: Wed, 23 Apr 2014 14:31:42 +0200 [thread overview]
Message-ID: <1592278.pD8vu465lA@sigyn> (raw)
In-Reply-To: <1398255470.32091.3.camel@linux-fkkt.site>
On Wednesday 23 of April 2014 14:17:50 Oliver Neukum wrote:
> On Tue, 2014-04-22 at 15:59 +0200, Michal Malý wrote:
> > static int holtekff_play(struct input_dev *dev, void *data,
> >
> > - struct ff_effect *effect)
> > + const struct mlnx_effect_command *command)
> >
> > {
> >
> > struct hid_device *hid = input_get_drvdata(dev);
> > struct holtekff_device *holtekff = data;
> >
> > + const struct mlnx_rumble_force *rumble_force =
> > &command->u.rumble_force;
> >
> > int left, right;
> > /* effect type 1, length 65535 msec */
> > u8 buf[HOLTEKFF_MSG_LENGTH] =
> >
> > { 0x01, 0x01, 0xff, 0xff, 0x10, 0xe0, 0x00 };
>
> On the kernel stack.
>
> > - left = effect->u.rumble.strong_magnitude;
> > - right = effect->u.rumble.weak_magnitude;
> > - dbg_hid("called with 0x%04x 0x%04x\n", left, right);
> > + switch (command->cmd) {
> > + case MLNX_START_RUMBLE:
> > + left = rumble_force->strong;
> > + right = rumble_force->weak;
> > + dbg_hid("called with 0x%04x 0x%04x\n", left, right);
> >
> > - if (!left && !right) {
> > - holtekff_send(holtekff, hid, stop_all6);
> > - return 0;
> > - }
> > + if (!left && !right) {
> > + holtekff_send(holtekff, hid, stop_all6);
> > + return 0;
> > + }
> >
> > - if (left)
> > - buf[1] |= 0x80;
> > - if (right)
> > - buf[1] |= 0x40;
> > + if (left)
> > + buf[1] |= 0x80;
> > + if (right)
> > + buf[1] |= 0x40;
> >
> > - /* The device takes a single magnitude, so we just sum them
> > up. */
> > - buf[6] = min(0xf, (left >> 12) + (right >> 12));
> > + /* The device takes a single magnitude, so we just sum
> > them up. */
> > + buf[6] = min(0xf, (left >> 12) + (right >> 12));
> >
> > - holtekff_send(holtekff, hid, buf);
> > - holtekff_send(holtekff, hid, start_effect_1);
> > + holtekff_send(holtekff, hid, buf);
> > + holtekff_send(holtekff, hid, start_effect_1);
> > + return 0;
> > + case MLNX_STOP_RUMBLE:
> > + holtekff_send(holtekff, hid, stop_all6);
> > + return 0;
> > + default:
> > + return -EINVAL;
> > + }
> >
> > return 0;
> >
> > }
>
> This looks very much like doing DMA on the kernel stack.
> That is very strictly forbidden. The bug is also in the current
> code, but would you care to fix it up?
Okay, I'll look into it.
Michal
next prev parent reply other threads:[~2014-04-23 12:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 13:59 [PATCH v2 00/24] input: Introduce ff-memless-next as an improved replacement for ff-memless Michal Malý
2014-04-22 13:59 ` [PATCH v2 01/24] input: Add ff-memless-next module Michal Malý
2014-04-23 12:12 ` Oliver Neukum
2014-04-23 12:30 ` Michal Malý
2014-04-23 13:31 ` Oliver Neukum
2014-04-23 15:59 ` Dmitry Torokhov
2014-04-23 17:06 ` Oliver Neukum
2014-04-23 17:24 ` Dmitry Torokhov
2014-04-22 13:59 ` [PATCH v2 02/24] input: Port arizona-haptics to ff-memless-next Michal Malý
2014-04-22 13:59 ` [PATCH v2 03/24] input: Port twl4030-vibra " Michal Malý
2014-04-22 13:59 ` [PATCH v2 04/24] input: Port twl6040-vibra " Michal Malý
2014-04-22 13:59 ` [PATCH v2 05/24] input: Port max8997_haptic " Michal Malý
2014-04-22 13:59 ` [PATCH v2 06/24] input: Port pm8xxx-vibrator " Michal Malý
2014-04-22 13:59 ` [PATCH v2 07/24] input: Port hid-axff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 08/24] input: Port hid-emsff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 09/24] input: Port hid-dr " Michal Malý
2014-04-23 13:41 ` Oliver Neukum
[not found] ` <5sjip0.n4hp0o.2szhuh-qmf@smtp.devoid-pointer.net>
[not found] ` <20140423154201.GA10531@core.coreip.homeip.net>
2014-04-23 15:47 ` simon
2014-04-23 15:57 ` Michal Malý
2014-04-24 10:32 ` Michal Malý
2014-04-27 8:22 ` Oliver Neukum
2014-04-22 13:59 ` [PATCH v2 10/24] input: Port hid-gaff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 11/24] input: Port hid-holtekff " Michal Malý
2014-04-23 12:17 ` Oliver Neukum
2014-04-23 12:31 ` Michal Malý [this message]
2014-04-23 16:02 ` Dmitry Torokhov
2014-04-22 13:59 ` [PATCH v2 12/24] input: Port hid-lgff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 13/24] input: Port hid-lg3ff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 14/24] input: Port hid-pl " Michal Malý
2014-04-22 14:00 ` [PATCH v2 15/24] input: Port hid-sjoy " Michal Malý
2014-04-22 14:00 ` [PATCH v2 16/24] input: Port hid-sony " Michal Malý
2014-04-22 14:00 ` [PATCH v2 17/24] input: Port hid-tmff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 18/24] input: Port hid-wiimote-modules " Michal Malý
2014-04-22 14:00 ` [PATCH v2 19/24] input: Port hid-zpff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 20/24] input: Port gamecon " Michal Malý
2014-04-22 14:00 ` [PATCH v2 21/24] input: Port xpad " Michal Malý
2014-04-22 14:00 ` [PATCH v2 22/24] input: Port hid-lg2ff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 23/24] input: Port hid-lg4ff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 24/24] input: Replace ff-memless with ff-memless-next Michal Malý
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592278.pD8vu465lA@sigyn \
--to=madcatxster@devoid-pointer.net \
--cc=anssi.hannula@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=elias.vds@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).