From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, jkosina@suse.cz, elias.vds@gmail.com,
anssi.hannula@iki.fi, simon@mungewell.org
Subject: [PATCH v2 08/24] input: Port hid-emsff to ff-memless-next
Date: Tue, 22 Apr 2014 15:59:53 +0200 [thread overview]
Message-ID: <1398175209-9565-9-git-send-email-madcatxster@devoid-pointer.net> (raw)
In-Reply-To: <1398175209-9565-1-git-send-email-madcatxster@devoid-pointer.net>
Port hid-emsff to ff-memless-next
Signed-off-by: Michal Malý <madcatxster@devoid-pointer.net>
---
drivers/hid/Kconfig | 2 +-
drivers/hid/hid-emsff.c | 38 ++++++++++++++++++++++++++------------
2 files changed, 27 insertions(+), 13 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 68c19a0..6e233d2 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -204,7 +204,7 @@ config DRAGONRISE_FF
config HID_EMS_FF
tristate "EMS Production Inc. force feedback support"
depends on HID
- select INPUT_FF_MEMLESS
+ select INPUT_FF_MEMLESS_NEXT
---help---
Say Y here if you want to enable force feedback support for devices by
EMS Production Ltd.
diff --git a/drivers/hid/hid-emsff.c b/drivers/hid/hid-emsff.c
index d82d75b..c0cbe50 100644
--- a/drivers/hid/hid-emsff.c
+++ b/drivers/hid/hid-emsff.c
@@ -24,30 +24,44 @@
#include <linux/hid.h>
#include <linux/input.h>
#include <linux/module.h>
+#include <linux/input/ff-memless-next.h>
#include "hid-ids.h"
+#define FF_UPDATE_RATE 50
+
struct emsff_device {
struct hid_report *report;
};
static int emsff_play(struct input_dev *dev, void *data,
- struct ff_effect *effect)
+ const struct mlnx_effect_command *command)
{
struct hid_device *hid = input_get_drvdata(dev);
struct emsff_device *emsff = data;
+ const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force;
int weak, strong;
- weak = effect->u.rumble.weak_magnitude;
- strong = effect->u.rumble.strong_magnitude;
-
- dbg_hid("called with 0x%04x 0x%04x\n", strong, weak);
-
- weak = weak * 0xff / 0xffff;
- strong = strong * 0xff / 0xffff;
-
- emsff->report->field[0]->value[1] = weak;
- emsff->report->field[0]->value[2] = strong;
+ switch (command->cmd) {
+ case MLNX_START_RUMBLE:
+ weak = rumble_force->weak;
+ strong = rumble_force->strong;
+
+ dbg_hid("called with 0x%04x 0x%04x\n", strong, weak);
+
+ weak = weak * 0xff / 0xffff;
+ strong = strong * 0xff / 0xffff;
+
+ emsff->report->field[0]->value[1] = weak;
+ emsff->report->field[0]->value[2] = strong;
+ break;
+ case MLNX_STOP_RUMBLE:
+ weak = 0;
+ strong = 0;
+ break;
+ default:
+ return -EINVAL;
+ }
dbg_hid("running with 0x%02x 0x%02x\n", strong, weak);
hid_hw_request(hid, emsff->report, HID_REQ_SET_REPORT);
@@ -88,7 +102,7 @@ static int emsff_init(struct hid_device *hid)
set_bit(FF_RUMBLE, dev->ffbit);
- error = input_ff_create_memless(dev, emsff, emsff_play);
+ error = input_ff_create_mlnx(dev, emsff, emsff_play, FF_UPDATE_RATE);
if (error) {
kfree(emsff);
return error;
--
1.9.2
next prev parent reply other threads:[~2014-04-22 14:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 13:59 [PATCH v2 00/24] input: Introduce ff-memless-next as an improved replacement for ff-memless Michal Malý
2014-04-22 13:59 ` [PATCH v2 01/24] input: Add ff-memless-next module Michal Malý
2014-04-23 12:12 ` Oliver Neukum
2014-04-23 12:30 ` Michal Malý
2014-04-23 13:31 ` Oliver Neukum
2014-04-23 15:59 ` Dmitry Torokhov
2014-04-23 17:06 ` Oliver Neukum
2014-04-23 17:24 ` Dmitry Torokhov
2014-04-22 13:59 ` [PATCH v2 02/24] input: Port arizona-haptics to ff-memless-next Michal Malý
2014-04-22 13:59 ` [PATCH v2 03/24] input: Port twl4030-vibra " Michal Malý
2014-04-22 13:59 ` [PATCH v2 04/24] input: Port twl6040-vibra " Michal Malý
2014-04-22 13:59 ` [PATCH v2 05/24] input: Port max8997_haptic " Michal Malý
2014-04-22 13:59 ` [PATCH v2 06/24] input: Port pm8xxx-vibrator " Michal Malý
2014-04-22 13:59 ` [PATCH v2 07/24] input: Port hid-axff " Michal Malý
2014-04-22 13:59 ` Michal Malý [this message]
2014-04-22 13:59 ` [PATCH v2 09/24] input: Port hid-dr " Michal Malý
2014-04-23 13:41 ` Oliver Neukum
[not found] ` <5sjip0.n4hp0o.2szhuh-qmf@smtp.devoid-pointer.net>
[not found] ` <20140423154201.GA10531@core.coreip.homeip.net>
2014-04-23 15:47 ` simon
2014-04-23 15:57 ` Michal Malý
2014-04-24 10:32 ` Michal Malý
2014-04-27 8:22 ` Oliver Neukum
2014-04-22 13:59 ` [PATCH v2 10/24] input: Port hid-gaff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 11/24] input: Port hid-holtekff " Michal Malý
2014-04-23 12:17 ` Oliver Neukum
2014-04-23 12:31 ` Michal Malý
2014-04-23 16:02 ` Dmitry Torokhov
2014-04-22 13:59 ` [PATCH v2 12/24] input: Port hid-lgff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 13/24] input: Port hid-lg3ff " Michal Malý
2014-04-22 13:59 ` [PATCH v2 14/24] input: Port hid-pl " Michal Malý
2014-04-22 14:00 ` [PATCH v2 15/24] input: Port hid-sjoy " Michal Malý
2014-04-22 14:00 ` [PATCH v2 16/24] input: Port hid-sony " Michal Malý
2014-04-22 14:00 ` [PATCH v2 17/24] input: Port hid-tmff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 18/24] input: Port hid-wiimote-modules " Michal Malý
2014-04-22 14:00 ` [PATCH v2 19/24] input: Port hid-zpff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 20/24] input: Port gamecon " Michal Malý
2014-04-22 14:00 ` [PATCH v2 21/24] input: Port xpad " Michal Malý
2014-04-22 14:00 ` [PATCH v2 22/24] input: Port hid-lg2ff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 23/24] input: Port hid-lg4ff " Michal Malý
2014-04-22 14:00 ` [PATCH v2 24/24] input: Replace ff-memless with ff-memless-next Michal Malý
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398175209-9565-9-git-send-email-madcatxster@devoid-pointer.net \
--to=madcatxster@devoid-pointer.net \
--cc=anssi.hannula@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=elias.vds@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).