* [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420
2014-05-09 13:23 [PATCH v2 0/4] dts: Add usb2phy to Exynos 5250/5420 Vivek Gautam
@ 2014-05-09 13:23 ` Vivek Gautam
2014-05-19 9:28 ` Kukjin Kim
2014-05-09 13:23 ` [PATCH v9 2/4] ARM: dts: Add usb2phy to Exynos 5250 Vivek Gautam
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Vivek Gautam @ 2014-05-09 13:23 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: linux-kernel, devicetree, linux-arm-kernel, kgene.kim, robh+dt,
stern, kishon, k.debski, jg1.han, Vivek Gautam
This patch adds sysreg-syscon node to exynos5250 and exynos5420 device
tree, to access System Register's registers using syscon driver.
Signed-off-by: Kamil Debski <k.debski@samsung.com>
[gautam.vivek@samsung.com: Split this syreg-syscon dts entry from
dts: Add usb2phy to Exynos 5250 patch]
[gautam.vivek@samsung.com: added similar syscon entry for exynos5420]
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
Changes since v7:
None
arch/arm/boot/dts/exynos5250.dtsi | 5 +++++
arch/arm/boot/dts/exynos5420.dtsi | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 3742331..70f0cd5 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -175,6 +175,11 @@
reg = <0x10040000 0x5000>;
};
+ sysreg_system_controller: syscon@10050000 {
+ compatible = "samsung,exynos5250-sys", "syscon";
+ reg = <0x10050000 0x5000>;
+ };
+
watchdog@101D0000 {
compatible = "samsung,exynos5250-wdt";
reg = <0x101D0000 0x100>;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index a802f74..5d5d6e3 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -682,6 +682,11 @@
reg = <0x10040000 0x5000>;
};
+ sysreg_system_controller: syscon@10050000 {
+ compatible = "samsung,exynos5420-sys", "syscon";
+ reg = <0x10050000 0x5000>;
+ };
+
tmu_cpu0: tmu@10060000 {
compatible = "samsung,exynos5420-tmu";
reg = <0x10060000 0x100>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420
2014-05-09 13:23 ` [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420 Vivek Gautam
@ 2014-05-19 9:28 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2014-05-19 9:28 UTC (permalink / raw)
To: 'Vivek Gautam', linux-usb, linux-samsung-soc
Cc: linux-kernel, devicetree, linux-arm-kernel, robh+dt, stern,
kishon, k.debski, jg1.han
Vivek Gautam wrote:
>
> This patch adds sysreg-syscon node to exynos5250 and exynos5420 device
> tree, to access System Register's registers using syscon driver.
>
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> [gautam.vivek@samsung.com: Split this syreg-syscon dts entry from
> dts: Add usb2phy to Exynos 5250 patch]
> [gautam.vivek@samsung.com: added similar syscon entry for exynos5420]
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
>
Vivek,
See my comment below.
And please don't version each patch in series...it's really not a good way.
It cause very big confusing...
> Changes since v7:
> None
>
> arch/arm/boot/dts/exynos5250.dtsi | 5 +++++
> arch/arm/boot/dts/exynos5420.dtsi | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 3742331..70f0cd5 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -175,6 +175,11 @@
> reg = <0x10040000 0x5000>;
> };
>
> + sysreg_system_controller: syscon@10050000 {
> + compatible = "samsung,exynos5250-sys", "syscon";
Maybe exynos5250-sysreg?
And need to add/modify binding doc?
- Kukjin
> + reg = <0x10050000 0x5000>;
> + };
> +
> watchdog@101D0000 {
> compatible = "samsung,exynos5250-wdt";
> reg = <0x101D0000 0x100>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index a802f74..5d5d6e3 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -682,6 +682,11 @@
> reg = <0x10040000 0x5000>;
> };
>
> + sysreg_system_controller: syscon@10050000 {
> + compatible = "samsung,exynos5420-sys", "syscon";
> + reg = <0x10050000 0x5000>;
> + };
> +
> tmu_cpu0: tmu@10060000 {
> compatible = "samsung,exynos5420-tmu";
> reg = <0x10060000 0x100>;
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v9 2/4] ARM: dts: Add usb2phy to Exynos 5250
2014-05-09 13:23 [PATCH v2 0/4] dts: Add usb2phy to Exynos 5250/5420 Vivek Gautam
2014-05-09 13:23 ` [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420 Vivek Gautam
@ 2014-05-09 13:23 ` Vivek Gautam
2014-05-09 13:23 ` [PATCH v2 3/4] ARM: dts: Add usb2phy support on exynos5420 Vivek Gautam
2014-05-09 13:23 ` [PATCH v2 4/4] ARM: dts: Add usb 2.0 " Vivek Gautam
3 siblings, 0 replies; 6+ messages in thread
From: Vivek Gautam @ 2014-05-09 13:23 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: linux-kernel, devicetree, linux-arm-kernel, kgene.kim, robh+dt,
stern, kishon, k.debski, jg1.han, Vivek Gautam
From: Kamil Debski <k.debski@samsung.com>
Add support to PHY of USB2 of the Exynos 5250 SoC.
Signed-off-by: Kamil Debski <k.debski@samsung.com>
[gautam.vivek@samsung.com: Split the usb phy entries from
syscon entries from earlier patch: dts: Add usb2phy to Exynos 5250]
[gautam.vivek@samsung.com: Added phy entry for OHCI also along with EHCI]
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
Changes from v8:
- Removed 'phy-names' property from the 'port'.
- Dropped 'status' property, since default also takes status = okay.
arch/arm/boot/dts/exynos5250.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 70f0cd5..782c524 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -563,6 +563,12 @@
clocks = <&clock CLK_USB2>;
clock-names = "usbhost";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ phys = <&usb2_phy_gen 1>;
+ };
};
usb@12120000 {
@@ -572,6 +578,12 @@
clocks = <&clock CLK_USB2>;
clock-names = "usbhost";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ phys = <&usb2_phy_gen 1>;
+ };
};
usb2_phy: usbphy@12130000 {
@@ -589,6 +601,16 @@
};
};
+ usb2_phy_gen: phy@12130000 {
+ compatible = "samsung,exynos5250-usb2-phy";
+ reg = <0x12130000 0x100>;
+ clocks = <&clock CLK_USB2>, <&clock CLK_FIN_PLL>;
+ clock-names = "phy", "ref";
+ #phy-cells = <1>;
+ samsung,sysreg-phandle = <&sysreg_system_controller>;
+ samsung,pmureg-phandle = <&pmu_system_controller>;
+ };
+
pwm: pwm@12dd0000 {
compatible = "samsung,exynos4210-pwm";
reg = <0x12dd0000 0x100>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/4] ARM: dts: Add usb2phy support on exynos5420
2014-05-09 13:23 [PATCH v2 0/4] dts: Add usb2phy to Exynos 5250/5420 Vivek Gautam
2014-05-09 13:23 ` [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420 Vivek Gautam
2014-05-09 13:23 ` [PATCH v9 2/4] ARM: dts: Add usb2phy to Exynos 5250 Vivek Gautam
@ 2014-05-09 13:23 ` Vivek Gautam
2014-05-09 13:23 ` [PATCH v2 4/4] ARM: dts: Add usb 2.0 " Vivek Gautam
3 siblings, 0 replies; 6+ messages in thread
From: Vivek Gautam @ 2014-05-09 13:23 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: linux-kernel, devicetree, linux-arm-kernel, kgene.kim, robh+dt,
stern, kishon, k.debski, jg1.han, Vivek Gautam
Add required device node for usb2phy to let enable USB 2.0
support.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
Changes from v1:
- Added node references for the phy node.
arch/arm/boot/dts/exynos5420.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 5d5d6e3..ddd09a3 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -744,4 +744,14 @@
clock-names = "secss";
samsung,power-domain = <&g2d_pd>;
};
+
+ usb2_phy: phy@12130000 {
+ compatible = "samsung,exynos5250-usb2-phy";
+ reg = <0x12130000 0x100>;
+ clocks = <&clock CLK_USBH20>, <&clock CLK_SCLK_USBPHY300>;
+ clock-names = "phy", "ref";
+ #phy-cells = <1>;
+ samsung,sysreg-phandle = <&sysreg_system_controller>;
+ samsung,pmureg-phandle = <&pmu_system_controller>;
+ };
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 4/4] ARM: dts: Add usb 2.0 support on exynos5420
2014-05-09 13:23 [PATCH v2 0/4] dts: Add usb2phy to Exynos 5250/5420 Vivek Gautam
` (2 preceding siblings ...)
2014-05-09 13:23 ` [PATCH v2 3/4] ARM: dts: Add usb2phy support on exynos5420 Vivek Gautam
@ 2014-05-09 13:23 ` Vivek Gautam
3 siblings, 0 replies; 6+ messages in thread
From: Vivek Gautam @ 2014-05-09 13:23 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: linux-kernel, devicetree, linux-arm-kernel, kgene.kim, robh+dt,
stern, kishon, k.debski, jg1.han, Vivek Gautam
Add required device node for ehci and ohci controllers to
enable USB 2.0 support.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
Changes from v1:
- Removed 'phy-names' property from the 'port'.
- Added node references for the nodes.
arch/arm/boot/dts/exynos5420.dtsi | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index ddd09a3..77ccefd 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -745,6 +745,36 @@
samsung,power-domain = <&g2d_pd>;
};
+ usbhost2: usb@12110000 {
+ compatible = "samsung,exynos4210-ehci";
+ reg = <0x12110000 0x100>;
+ interrupts = <0 71 0>;
+
+ clocks = <&clock CLK_USBH20>;
+ clock-names = "usbhost";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ phys = <&usb2_phy 1>;
+ };
+ };
+
+ usbhost1: usb@12120000 {
+ compatible = "samsung,exynos4210-ohci";
+ reg = <0x12120000 0x100>;
+ interrupts = <0 71 0>;
+
+ clocks = <&clock CLK_USBH20>;
+ clock-names = "usbhost";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ phys = <&usb2_phy 1>;
+ };
+ };
+
usb2_phy: phy@12130000 {
compatible = "samsung,exynos5250-usb2-phy";
reg = <0x12130000 0x100>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread