* [PATCH v7 0/3] ARM: sunxi: Add support for consumer infrared devices @ 2014-05-14 21:56 Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 1/3] ARM: sunxi: Add documentation for sunxi " Alexander Bersenev ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Alexander Bersenev @ 2014-05-14 21:56 UTC (permalink / raw) To: linux-sunxi, david, devicetree, galak, grant.likely, ijc+devicetree, james.hogan, linux-arm-kernel, linux, m.chehab, mark.rutland, maxime.ripard, pawel.moll, rdunlap, robh+dt, sean, srinivas.kandagatla, wingrime, linux-doc, linux-kernel, linux-media Cc: Alexander Bersenev This patch introduces Consumer IR(CIR) support for sunxi boards. This is based on Alexsey Shestacov's work based on the original driver supplied by Allwinner. Signed-off-by: Alexander Bersenev <bay@hackerdom.ru> Signed-off-by: Alexsey Shestacov <wingrime@linux-sunxi.org> --- Changes since version 1: - Fix timer memory leaks - Fix race condition when driver unloads while interrupt handler is active - Support Cubieboard 2(need testing) Changes since version 2: - More reliable keydown events - Documentation fixes - Rename registers accurding to A20 user manual - Remove some includes, order includes alphabetically - Use BIT macro - Typo fixes Changes since version 3: - Split the patch on smaller parts - More documentation fixes - Add clock-names in DT - Use devm_clk_get function to get the clocks - Removed gpios property from ir's DT - Changed compatible from allwinner,sunxi-ir to allwinner,sun7i-a20-ir in DT - Use spin_lock_irq instead spin_lock_irqsave in interrupt handler - Add myself in the copyright ;) - Coding style and indentation fixes Changes since version 4: - Try to fix indentation errors by sending patches with git send-mail Changes since version 5: - More indentation fixes - Make patches pass checkpatch with --strict option - Replaced magic numbers with defines(patch by Priit Laes) - Fixed oops on loading(patch by Hans de Goede) Changes since version 6: - Removed constants from code - Better errrors handling on loading - Renamed sunxi-ir.c to sunxi-cir.c - Changed description of second commit - Order entries in dts and dtsi by register address - Code style fixes Alexander Bersenev (3): ARM: sunxi: Add documentation for sunxi consumer infrared devices [media] rc: add sunxi-ir driver ARM: sunxi: Add IR controller support in DT on A20 .../devicetree/bindings/media/sunxi-ir.txt | 23 ++ arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 6 + arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 + arch/arm/boot/dts/sun7i-a20.dtsi | 32 ++ drivers/media/rc/Kconfig | 10 + drivers/media/rc/Makefile | 1 + drivers/media/rc/sunxi-cir.c | 334 +++++++++++++++++++++ 7 files changed, 412 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/sunxi-ir.txt create mode 100644 drivers/media/rc/sunxi-cir.c -- 1.9.3 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v7 1/3] ARM: sunxi: Add documentation for sunxi consumer infrared devices 2014-05-14 21:56 [PATCH v7 0/3] ARM: sunxi: Add support for consumer infrared devices Alexander Bersenev @ 2014-05-14 21:56 ` Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 2/3] [media] rc: add sunxi-ir driver Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 3/3] ARM: sunxi: Add IR controller support in DT on A20 Alexander Bersenev 2 siblings, 0 replies; 7+ messages in thread From: Alexander Bersenev @ 2014-05-14 21:56 UTC (permalink / raw) To: linux-sunxi, david, devicetree, galak, grant.likely, ijc+devicetree, james.hogan, linux-arm-kernel, linux, m.chehab, mark.rutland, maxime.ripard, pawel.moll, rdunlap, robh+dt, sean, srinivas.kandagatla, wingrime, linux-doc, linux-kernel, linux-media Cc: Alexander Bersenev This patch adds documentation for Device-Tree bindings for sunxi IR controller. Signed-off-by: Alexander Bersenev <bay@hackerdom.ru> Signed-off-by: Alexsey Shestacov <wingrime@linux-sunxi.org> --- .../devicetree/bindings/media/sunxi-ir.txt | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/sunxi-ir.txt diff --git a/Documentation/devicetree/bindings/media/sunxi-ir.txt b/Documentation/devicetree/bindings/media/sunxi-ir.txt new file mode 100644 index 0000000..014dd8b --- /dev/null +++ b/Documentation/devicetree/bindings/media/sunxi-ir.txt @@ -0,0 +1,23 @@ +Device-Tree bindings for SUNXI IR controller found in sunXi SoC family + +Required properties: +- compatible : should be "allwinner,sun7i-a20-ir"; +- clocks : list of clock specifiers, corresponding to + entries in clock-names property; +- clock-names : should contain "apb" and "ir" entries; +- interrupts : should contain IR IRQ number; +- reg : should contain IO map address for IR. + +Optional properties: +- linux,rc-map-name : Remote control map name. + +Example: + +ir0: ir@01c21800 { + compatible = "allwinner,sun7i-a20-ir"; + clocks = <&apb0_gates 6>, <&ir0_clk>; + clock-names = "apb", "ir"; + interrupts = <0 5 1>; + reg = <0x01C21800 0x40>; + linux,rc-map-name = "rc-rc6-mce"; +}; -- 1.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v7 2/3] [media] rc: add sunxi-ir driver 2014-05-14 21:56 [PATCH v7 0/3] ARM: sunxi: Add support for consumer infrared devices Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 1/3] ARM: sunxi: Add documentation for sunxi " Alexander Bersenev @ 2014-05-14 21:56 ` Alexander Bersenev 2014-05-15 7:24 ` Maxime Ripard ` (2 more replies) 2014-05-14 21:56 ` [PATCH v7 3/3] ARM: sunxi: Add IR controller support in DT on A20 Alexander Bersenev 2 siblings, 3 replies; 7+ messages in thread From: Alexander Bersenev @ 2014-05-14 21:56 UTC (permalink / raw) To: linux-sunxi, david, devicetree, galak, grant.likely, ijc+devicetree, james.hogan, linux-arm-kernel, linux, m.chehab, mark.rutland, maxime.ripard, pawel.moll, rdunlap, robh+dt, sean, srinivas.kandagatla, wingrime, linux-doc, linux-kernel, linux-media Cc: Alexander Bersenev This patch adds driver for sunxi IR controller. It is based on Alexsey Shestacov's work based on the original driver supplied by Allwinner. Signed-off-by: Alexander Bersenev <bay@hackerdom.ru> Signed-off-by: Alexsey Shestacov <wingrime@linux-sunxi.org> --- drivers/media/rc/Kconfig | 10 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/sunxi-cir.c | 334 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 345 insertions(+) create mode 100644 drivers/media/rc/sunxi-cir.c diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig index 8fbd377..9427fad 100644 --- a/drivers/media/rc/Kconfig +++ b/drivers/media/rc/Kconfig @@ -343,4 +343,14 @@ config RC_ST If you're not sure, select N here. +config IR_SUNXI + tristate "SUNXI IR remote control" + depends on RC_CORE + depends on ARCH_SUNXI + ---help--- + Say Y if you want to use sunXi internal IR Controller + + To compile this driver as a module, choose M here: the module will + be called sunxi-ir. + endif #RC_DEVICES diff --git a/drivers/media/rc/Makefile b/drivers/media/rc/Makefile index f8b54ff..9ee9ee7 100644 --- a/drivers/media/rc/Makefile +++ b/drivers/media/rc/Makefile @@ -32,4 +32,5 @@ obj-$(CONFIG_IR_GPIO_CIR) += gpio-ir-recv.o obj-$(CONFIG_IR_IGUANA) += iguanair.o obj-$(CONFIG_IR_TTUSBIR) += ttusbir.o obj-$(CONFIG_RC_ST) += st_rc.o +obj-$(CONFIG_IR_SUNXI) += sunxi-cir.o obj-$(CONFIG_IR_IMG) += img-ir/ diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c new file mode 100644 index 0000000..25eb175 --- /dev/null +++ b/drivers/media/rc/sunxi-cir.c @@ -0,0 +1,334 @@ +/* + * Driver for Allwinner sunXi IR controller + * + * Copyright (C) 2014 Alexsey Shestacov <wingrime@linux-sunxi.org> + * Copyright (C) 2014 Alexander Bersenev <bay@hackerdom.ru> + * + * Based on sun5i-ir.c: + * Copyright (C) 2007-2012 Daniel Wang + * Allwinner Technology Co., Ltd. <www.allwinnertech.com> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/clk.h> +#include <linux/interrupt.h> +#include <linux/module.h> +#include <linux/of_platform.h> +#include <media/rc-core.h> + +#define SUNXI_IR_DEV "sunxi-ir" + +/* Registers */ +/* IR Control */ +#define SUNXI_IR_CTL_REG 0x00 +/* Rx Config */ +#define SUNXI_IR_RXCTL_REG 0x10 +/* Rx Data */ +#define SUNXI_IR_RXFIFO_REG 0x20 +/* Rx Interrupt Enable */ +#define SUNXI_IR_RXINT_REG 0x2C +/* Rx Interrupt Status */ +#define SUNXI_IR_RXSTA_REG 0x30 +/* IR Sample Config */ +#define SUNXI_IR_CIR_REG 0x34 + +/* Global Enable for IR_CTL Register */ +#define REG_CTL_GEN BIT(0) +/* RX block enable for IR_CTL Register */ +#define REG_CTL_RXEN BIT(1) +/* CIR mode for IR_CTL Register */ +#define REG_CTL_MD (BIT(4)|BIT(5)) + +/* IR_RXCTL_REG Register Receiver Pulse Polarity Invert flag */ +#define REG_RXCTL_RPPI BIT(2) + +/* IR_RXINT_REG Register fields */ +#define REG_RXINT_ROI_EN BIT(0) /* Rx FIFO Overflow */ +#define REG_RXINT_RPEI_EN BIT(1) /* Rx Packet End */ +#define REG_RXINT_RAI_EN BIT(4) /* Rx FIFO Data Available */ +/* Rx FIFO available byte level */ +#define REG_RXINT_RAL__MASK (BIT(8)|BIT(9)|BIT(10)|BIT(11)) +#define REG_RXINT_RAL__SHIFT 8 +static inline uint32_t REG_RXINT_RAL(uint16_t val) +{ + return (val << REG_RXINT_RAL__SHIFT) & REG_RXINT_RAL__MASK; +} + +/* CIR_REG register noise threshold */ +#define REG_CIR_NTHR__MASK (BIT(2)|BIT(3)|BIT(4)|BIT(5)|BIT(6)|BIT(7)) +#define REG_CIR_NTHR__SHIFT 2 +static inline uint32_t REG_CIR_NTHR(uint16_t val) +{ + return (val << REG_CIR_NTHR__SHIFT) & REG_CIR_NTHR__MASK; +} +/* CIR_REG register idle threshold */ +#define REG_CIR_ITHR__MASK (BIT(8)|BIT(9)|BIT(10)|BIT(11)|BIT(12)|BIT(13) \ + |BIT(14)|BIT(15)) +#define REG_CIR_ITHR__SHIFT 8 +static inline uint32_t REG_CIR_ITHR(uint16_t val) +{ + return (val << REG_CIR_ITHR__SHIFT) & REG_CIR_ITHR__MASK; +} + +/* RXSTA_REG Register RX FIFO Available Counter */ +#define REG_RXSTA_RAC__SHIFT 8 +#define REG_RXSTA_RAC__MASK 0x3f + +/* Clear all interrupt status value */ +#define REG_RXSTA_CLEARALL 0xff + +/* Hardware supported fifo size */ +#define SUNXI_IR_FIFO_SIZE 16 +/* How many messages in FIFO trigger IRQ */ +#define TRIGGER_LEVEL 8 +/* Required frequency for IR0 or IR1 clock in CIR mode */ +#define SUNXI_IR_BASE_CLK 8000000 +/* Frequency after IR internal divider */ +#define SUNXI_IR_CLK (SUNXI_IR_BASE_CLK / 64) +/* Sample period in ns */ +#define SUNXI_IR_SAMPLE (1000000000ul / SUNXI_IR_CLK) +/* Noise threshold in samples */ +#define SUNXI_IR_RXNOISE 1 +/* Idle Threshold in samples */ +#define SUNXI_IR_RXIDLE 20 +/* Time after which device stops sending data in ms */ +#define SUNXI_IR_TIMEOUT 120 + +struct sunxi_ir { + spinlock_t ir_lock; + struct rc_dev *rc; + void __iomem *base; + int irq; + struct clk *clk; + struct clk *apb_clk; + const char *map_name; +}; + +static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) +{ + unsigned long status; + unsigned char dt; + unsigned int cnt, rc; + struct sunxi_ir *ir = dev_id; + DEFINE_IR_RAW_EVENT(rawir); + + spin_lock(&ir->ir_lock); + + status = readl(ir->base + SUNXI_IR_RXSTA_REG); + + /* clean all pending statuses */ + writel(status | REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); + + if (status & REG_RXINT_RAI_EN) { + /* How many messages in fifo */ + rc = (status >> REG_RXSTA_RAC__SHIFT) & REG_RXSTA_RAC__MASK; + /* Sanity check */ + rc = rc > SUNXI_IR_FIFO_SIZE ? SUNXI_IR_FIFO_SIZE : rc; + /* If we have data */ + for (cnt = 0; cnt < rc; cnt++) { + /* for each bit in fifo */ + dt = readb(ir->base + SUNXI_IR_RXFIFO_REG); + rawir.pulse = (dt & 0x80) != 0; + rawir.duration = (dt & 0x7f) * SUNXI_IR_SAMPLE; + ir_raw_event_store_with_filter(ir->rc, &rawir); + } + } + + if (status & REG_RXINT_ROI_EN) { + ir_raw_event_reset(ir->rc); + } else if (status & REG_RXINT_RPEI_EN) { + ir_raw_event_set_idle(ir->rc, true); + ir_raw_event_handle(ir->rc); + } + + spin_unlock(&ir->ir_lock); + + return IRQ_HANDLED; +} + + +static int sunxi_ir_probe(struct platform_device *pdev) +{ + int ret = 0; + unsigned long tmp = 0; + + struct device *dev = &pdev->dev; + struct device_node *dn = dev->of_node; + struct resource *res; + struct sunxi_ir *ir; + + ir = devm_kzalloc(dev, sizeof(struct sunxi_ir), GFP_KERNEL); + if (!ir) + return -ENOMEM; + + /* Clock */ + ir->apb_clk = devm_clk_get(dev, "apb"); + if (IS_ERR(ir->apb_clk)) { + dev_err(dev, "failed to get a apb clock.\n"); + return PTR_ERR(ir->apb_clk); + } + ir->clk = devm_clk_get(dev, "ir"); + if (IS_ERR(ir->clk)) { + dev_err(dev, "failed to get a ir clock.\n"); + return PTR_ERR(ir->clk); + } + + ret = clk_set_rate(ir->clk, SUNXI_IR_BASE_CLK); + if (ret) { + dev_err(dev, "set ir base clock failed!\n"); + return ret; + } + + if (clk_prepare_enable(ir->apb_clk)) { + dev_err(dev, "try to enable apb_ir_clk failed\n"); + return -EINVAL; + } + + if (clk_prepare_enable(ir->clk)) { + dev_err(dev, "try to enable ir_clk failed\n"); + ret = -EINVAL; + goto exit_clkdisable_apb_clk; + } + + /* IO */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + + ir->base = devm_ioremap_resource(dev, res); + if (IS_ERR(ir->base)) { + dev_err(dev, "failed to map registers\n"); + ret = PTR_ERR(ir->base); + goto exit_clkdisable_clk; + } + + /* IRQ */ + ir->irq = platform_get_irq(pdev, 0); + if (ir->irq < 0) { + dev_err(dev, "no irq resource\n"); + ret = ir->irq; + goto exit_clkdisable_clk; + } + + ret = devm_request_irq(dev, ir->irq, sunxi_ir_irq, 0, SUNXI_IR_DEV, ir); + if (ret) { + dev_err(dev, "failed request irq\n"); + goto exit_clkdisable_clk; + } + + ir->rc = rc_allocate_device(); + + if (!ir->rc) { + dev_err(dev, "failed to allocate device\n"); + ret = -ENOMEM; + goto exit_clkdisable_clk; + } + + ir->rc->priv = ir; + ir->rc->input_name = SUNXI_IR_DEV; + ir->rc->input_phys = "sunxi-ir/input0"; + ir->rc->input_id.bustype = BUS_HOST; + ir->rc->input_id.vendor = 0x0001; + ir->rc->input_id.product = 0x0001; + ir->rc->input_id.version = 0x0100; + ir->map_name = of_get_property(dn, "linux,rc-map-name", NULL); + ir->rc->map_name = ir->map_name ?: RC_MAP_EMPTY; + ir->rc->dev.parent = dev; + ir->rc->driver_type = RC_DRIVER_IR_RAW; + rc_set_allowed_protocols(ir->rc, RC_BIT_ALL); + ir->rc->rx_resolution = SUNXI_IR_SAMPLE; + ir->rc->timeout = MS_TO_NS(SUNXI_IR_TIMEOUT); + ir->rc->driver_name = SUNXI_IR_DEV; + + ret = rc_register_device(ir->rc); + if (ret) { + dev_err(dev, "failed to register rc device\n"); + goto exit_free_dev; + } + + platform_set_drvdata(pdev, ir); + + /* Enable CIR Mode */ + writel(REG_CTL_MD, ir->base+SUNXI_IR_CTL_REG); + + /* Set noise threshold and idle threshold */ + writel(REG_CIR_NTHR(SUNXI_IR_RXNOISE)|REG_CIR_ITHR(SUNXI_IR_RXIDLE), + ir->base + SUNXI_IR_CIR_REG); + + /* Invert Input Signal */ + writel(REG_RXCTL_RPPI, ir->base + SUNXI_IR_RXCTL_REG); + + /* Clear All Rx Interrupt Status */ + writel(REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); + + /* Enable IRQ on overflow, packet end, FIFO available with trigger + level */ + writel(REG_RXINT_ROI_EN | REG_RXINT_RPEI_EN | + REG_RXINT_RAI_EN | REG_RXINT_RAL(TRIGGER_LEVEL - 1), + ir->base + SUNXI_IR_RXINT_REG); + + /* Enable IR Module */ + tmp = readl(ir->base + SUNXI_IR_CTL_REG); + writel(tmp | REG_CTL_GEN | REG_CTL_RXEN, ir->base + SUNXI_IR_CTL_REG); + + dev_info(dev, "initialized sunXi IR driver\n"); + return 0; + +exit_free_dev: + rc_free_device(ir->rc); +exit_clkdisable_clk: + clk_disable_unprepare(ir->clk); +exit_clkdisable_apb_clk: + clk_disable_unprepare(ir->apb_clk); + + return ret; +} + +static int sunxi_ir_remove(struct platform_device *pdev) +{ + unsigned long flags; + struct sunxi_ir *ir = platform_get_drvdata(pdev); + + clk_disable_unprepare(ir->clk); + clk_disable_unprepare(ir->apb_clk); + + spin_lock_irqsave(&ir->ir_lock, flags); + /* disable IR IRQ */ + writel(0, ir->base + SUNXI_IR_RXINT_REG); + /* clear All Rx Interrupt Status */ + writel(REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); + /* disable IR */ + writel(0, ir->base + SUNXI_IR_CTL_REG); + spin_unlock_irqrestore(&ir->ir_lock, flags); + + rc_unregister_device(ir->rc); + return 0; +} + +static const struct of_device_id sunxi_ir_match[] = { + { .compatible = "allwinner,sun7i-a20-ir", }, + {}, +}; + +static struct platform_driver sunxi_ir_driver = { + .probe = sunxi_ir_probe, + .remove = sunxi_ir_remove, + .driver = { + .name = SUNXI_IR_DEV, + .owner = THIS_MODULE, + .of_match_table = sunxi_ir_match, + }, +}; + +module_platform_driver(sunxi_ir_driver); + +MODULE_DESCRIPTION("Allwinner sunXi IR controller driver"); +MODULE_AUTHOR("Alexsey Shestacov <wingrime@linux-sunxi.org>"); +MODULE_LICENSE("GPL"); -- 1.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver 2014-05-14 21:56 ` [PATCH v7 2/3] [media] rc: add sunxi-ir driver Alexander Bersenev @ 2014-05-15 7:24 ` Maxime Ripard 2014-05-19 8:17 ` Maxime Ripard 2014-05-19 20:26 ` David Härdeman 2 siblings, 0 replies; 7+ messages in thread From: Maxime Ripard @ 2014-05-15 7:24 UTC (permalink / raw) To: Alexander Bersenev Cc: linux-sunxi, david, devicetree, galak, grant.likely, ijc+devicetree, james.hogan, linux-arm-kernel, linux, m.chehab, mark.rutland, pawel.moll, rdunlap, robh+dt, sean, srinivas.kandagatla, wingrime, linux-doc, linux-kernel, linux-media [-- Attachment #1: Type: text/plain, Size: 9431 bytes --] On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote: > This patch adds driver for sunxi IR controller. > It is based on Alexsey Shestacov's work based on the original driver > supplied by Allwinner. > > Signed-off-by: Alexander Bersenev <bay@hackerdom.ru> > Signed-off-by: Alexsey Shestacov <wingrime@linux-sunxi.org> > --- > drivers/media/rc/Kconfig | 10 ++ > drivers/media/rc/Makefile | 1 + > drivers/media/rc/sunxi-cir.c | 334 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 345 insertions(+) > create mode 100644 drivers/media/rc/sunxi-cir.c > > diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig > index 8fbd377..9427fad 100644 > --- a/drivers/media/rc/Kconfig > +++ b/drivers/media/rc/Kconfig > @@ -343,4 +343,14 @@ config RC_ST > > If you're not sure, select N here. > > +config IR_SUNXI > + tristate "SUNXI IR remote control" > + depends on RC_CORE > + depends on ARCH_SUNXI > + ---help--- > + Say Y if you want to use sunXi internal IR Controller > + > + To compile this driver as a module, choose M here: the module will > + be called sunxi-ir. > + > endif #RC_DEVICES > diff --git a/drivers/media/rc/Makefile b/drivers/media/rc/Makefile > index f8b54ff..9ee9ee7 100644 > --- a/drivers/media/rc/Makefile > +++ b/drivers/media/rc/Makefile > @@ -32,4 +32,5 @@ obj-$(CONFIG_IR_GPIO_CIR) += gpio-ir-recv.o > obj-$(CONFIG_IR_IGUANA) += iguanair.o > obj-$(CONFIG_IR_TTUSBIR) += ttusbir.o > obj-$(CONFIG_RC_ST) += st_rc.o > +obj-$(CONFIG_IR_SUNXI) += sunxi-cir.o > obj-$(CONFIG_IR_IMG) += img-ir/ > diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c > new file mode 100644 > index 0000000..25eb175 > --- /dev/null > +++ b/drivers/media/rc/sunxi-cir.c > @@ -0,0 +1,334 @@ > +/* > + * Driver for Allwinner sunXi IR controller > + * > + * Copyright (C) 2014 Alexsey Shestacov <wingrime@linux-sunxi.org> > + * Copyright (C) 2014 Alexander Bersenev <bay@hackerdom.ru> > + * > + * Based on sun5i-ir.c: > + * Copyright (C) 2007-2012 Daniel Wang > + * Allwinner Technology Co., Ltd. <www.allwinnertech.com> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include <linux/clk.h> > +#include <linux/interrupt.h> > +#include <linux/module.h> > +#include <linux/of_platform.h> > +#include <media/rc-core.h> > + > +#define SUNXI_IR_DEV "sunxi-ir" > + > +/* Registers */ > +/* IR Control */ > +#define SUNXI_IR_CTL_REG 0x00 > +/* Rx Config */ > +#define SUNXI_IR_RXCTL_REG 0x10 > +/* Rx Data */ > +#define SUNXI_IR_RXFIFO_REG 0x20 > +/* Rx Interrupt Enable */ > +#define SUNXI_IR_RXINT_REG 0x2C > +/* Rx Interrupt Status */ > +#define SUNXI_IR_RXSTA_REG 0x30 > +/* IR Sample Config */ > +#define SUNXI_IR_CIR_REG 0x34 > + > +/* Global Enable for IR_CTL Register */ > +#define REG_CTL_GEN BIT(0) > +/* RX block enable for IR_CTL Register */ > +#define REG_CTL_RXEN BIT(1) > +/* CIR mode for IR_CTL Register */ > +#define REG_CTL_MD (BIT(4)|BIT(5)) > + > +/* IR_RXCTL_REG Register Receiver Pulse Polarity Invert flag */ > +#define REG_RXCTL_RPPI BIT(2) > + > +/* IR_RXINT_REG Register fields */ > +#define REG_RXINT_ROI_EN BIT(0) /* Rx FIFO Overflow */ > +#define REG_RXINT_RPEI_EN BIT(1) /* Rx Packet End */ > +#define REG_RXINT_RAI_EN BIT(4) /* Rx FIFO Data Available */ > +/* Rx FIFO available byte level */ > +#define REG_RXINT_RAL__MASK (BIT(8)|BIT(9)|BIT(10)|BIT(11)) > +#define REG_RXINT_RAL__SHIFT 8 > +static inline uint32_t REG_RXINT_RAL(uint16_t val) > +{ > + return (val << REG_RXINT_RAL__SHIFT) & REG_RXINT_RAL__MASK; > +} > + > +/* CIR_REG register noise threshold */ > +#define REG_CIR_NTHR__MASK (BIT(2)|BIT(3)|BIT(4)|BIT(5)|BIT(6)|BIT(7)) > +#define REG_CIR_NTHR__SHIFT 2 > +static inline uint32_t REG_CIR_NTHR(uint16_t val) > +{ > + return (val << REG_CIR_NTHR__SHIFT) & REG_CIR_NTHR__MASK; > +} > +/* CIR_REG register idle threshold */ > +#define REG_CIR_ITHR__MASK (BIT(8)|BIT(9)|BIT(10)|BIT(11)|BIT(12)|BIT(13) \ > + |BIT(14)|BIT(15)) > +#define REG_CIR_ITHR__SHIFT 8 > +static inline uint32_t REG_CIR_ITHR(uint16_t val) > +{ > + return (val << REG_CIR_ITHR__SHIFT) & REG_CIR_ITHR__MASK; > +} > + > +/* RXSTA_REG Register RX FIFO Available Counter */ > +#define REG_RXSTA_RAC__SHIFT 8 > +#define REG_RXSTA_RAC__MASK 0x3f > + > +/* Clear all interrupt status value */ > +#define REG_RXSTA_CLEARALL 0xff > + > +/* Hardware supported fifo size */ > +#define SUNXI_IR_FIFO_SIZE 16 > +/* How many messages in FIFO trigger IRQ */ > +#define TRIGGER_LEVEL 8 > +/* Required frequency for IR0 or IR1 clock in CIR mode */ > +#define SUNXI_IR_BASE_CLK 8000000 > +/* Frequency after IR internal divider */ > +#define SUNXI_IR_CLK (SUNXI_IR_BASE_CLK / 64) > +/* Sample period in ns */ > +#define SUNXI_IR_SAMPLE (1000000000ul / SUNXI_IR_CLK) > +/* Noise threshold in samples */ > +#define SUNXI_IR_RXNOISE 1 > +/* Idle Threshold in samples */ > +#define SUNXI_IR_RXIDLE 20 > +/* Time after which device stops sending data in ms */ > +#define SUNXI_IR_TIMEOUT 120 > + > +struct sunxi_ir { > + spinlock_t ir_lock; > + struct rc_dev *rc; > + void __iomem *base; > + int irq; > + struct clk *clk; > + struct clk *apb_clk; > + const char *map_name; > +}; > + > +static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) > +{ > + unsigned long status; > + unsigned char dt; > + unsigned int cnt, rc; > + struct sunxi_ir *ir = dev_id; > + DEFINE_IR_RAW_EVENT(rawir); > + > + spin_lock(&ir->ir_lock); > + > + status = readl(ir->base + SUNXI_IR_RXSTA_REG); > + > + /* clean all pending statuses */ > + writel(status | REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); > + > + if (status & REG_RXINT_RAI_EN) { > + /* How many messages in fifo */ > + rc = (status >> REG_RXSTA_RAC__SHIFT) & REG_RXSTA_RAC__MASK; > + /* Sanity check */ > + rc = rc > SUNXI_IR_FIFO_SIZE ? SUNXI_IR_FIFO_SIZE : rc; > + /* If we have data */ > + for (cnt = 0; cnt < rc; cnt++) { > + /* for each bit in fifo */ > + dt = readb(ir->base + SUNXI_IR_RXFIFO_REG); > + rawir.pulse = (dt & 0x80) != 0; > + rawir.duration = (dt & 0x7f) * SUNXI_IR_SAMPLE; > + ir_raw_event_store_with_filter(ir->rc, &rawir); > + } > + } > + > + if (status & REG_RXINT_ROI_EN) { > + ir_raw_event_reset(ir->rc); > + } else if (status & REG_RXINT_RPEI_EN) { > + ir_raw_event_set_idle(ir->rc, true); > + ir_raw_event_handle(ir->rc); > + } > + > + spin_unlock(&ir->ir_lock); > + > + return IRQ_HANDLED; > +} > + > + > +static int sunxi_ir_probe(struct platform_device *pdev) > +{ > + int ret = 0; > + unsigned long tmp = 0; > + > + struct device *dev = &pdev->dev; > + struct device_node *dn = dev->of_node; > + struct resource *res; > + struct sunxi_ir *ir; > + > + ir = devm_kzalloc(dev, sizeof(struct sunxi_ir), GFP_KERNEL); > + if (!ir) > + return -ENOMEM; > + > + /* Clock */ > + ir->apb_clk = devm_clk_get(dev, "apb"); > + if (IS_ERR(ir->apb_clk)) { > + dev_err(dev, "failed to get a apb clock.\n"); > + return PTR_ERR(ir->apb_clk); > + } > + ir->clk = devm_clk_get(dev, "ir"); > + if (IS_ERR(ir->clk)) { > + dev_err(dev, "failed to get a ir clock.\n"); > + return PTR_ERR(ir->clk); > + } > + > + ret = clk_set_rate(ir->clk, SUNXI_IR_BASE_CLK); > + if (ret) { > + dev_err(dev, "set ir base clock failed!\n"); > + return ret; > + } > + > + if (clk_prepare_enable(ir->apb_clk)) { > + dev_err(dev, "try to enable apb_ir_clk failed\n"); > + return -EINVAL; > + } > + > + if (clk_prepare_enable(ir->clk)) { > + dev_err(dev, "try to enable ir_clk failed\n"); > + ret = -EINVAL; > + goto exit_clkdisable_apb_clk; > + } > + > + /* IO */ > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + > + ir->base = devm_ioremap_resource(dev, res); > + if (IS_ERR(ir->base)) { > + dev_err(dev, "failed to map registers\n"); > + ret = PTR_ERR(ir->base); > + goto exit_clkdisable_clk; > + } > + You can drop the extra line here > + /* IRQ */ > + ir->irq = platform_get_irq(pdev, 0); > + if (ir->irq < 0) { > + dev_err(dev, "no irq resource\n"); > + ret = ir->irq; > + goto exit_clkdisable_clk; > + } > + > + ret = devm_request_irq(dev, ir->irq, sunxi_ir_irq, 0, SUNXI_IR_DEV, ir); Starting from here, your handler can be called, and you're far from ready to handle your interrupts. > + if (ret) { > + dev_err(dev, "failed request irq\n"); > + goto exit_clkdisable_clk; > + } > + > + ir->rc = rc_allocate_device(); > + You can drop the extra line here Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver 2014-05-14 21:56 ` [PATCH v7 2/3] [media] rc: add sunxi-ir driver Alexander Bersenev 2014-05-15 7:24 ` Maxime Ripard @ 2014-05-19 8:17 ` Maxime Ripard 2014-05-19 20:26 ` David Härdeman 2 siblings, 0 replies; 7+ messages in thread From: Maxime Ripard @ 2014-05-19 8:17 UTC (permalink / raw) To: Alexander Bersenev Cc: linux-sunxi, david, devicetree, galak, grant.likely, ijc+devicetree, james.hogan, linux-arm-kernel, linux, m.chehab, mark.rutland, pawel.moll, rdunlap, robh+dt, sean, srinivas.kandagatla, wingrime, linux-doc, linux-kernel, linux-media [-- Attachment #1: Type: text/plain, Size: 4982 bytes --] Hi, I missed a few things in my first review. On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote: > This patch adds driver for sunxi IR controller. > It is based on Alexsey Shestacov's work based on the original driver > supplied by Allwinner. > > Signed-off-by: Alexander Bersenev <bay@hackerdom.ru> > Signed-off-by: Alexsey Shestacov <wingrime@linux-sunxi.org> > --- > drivers/media/rc/Kconfig | 10 ++ > drivers/media/rc/Makefile | 1 + > drivers/media/rc/sunxi-cir.c | 334 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 345 insertions(+) > create mode 100644 drivers/media/rc/sunxi-cir.c > > diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig > index 8fbd377..9427fad 100644 > --- a/drivers/media/rc/Kconfig > +++ b/drivers/media/rc/Kconfig > @@ -343,4 +343,14 @@ config RC_ST > > If you're not sure, select N here. > > +config IR_SUNXI > + tristate "SUNXI IR remote control" > + depends on RC_CORE > + depends on ARCH_SUNXI > + ---help--- > + Say Y if you want to use sunXi internal IR Controller > + > + To compile this driver as a module, choose M here: the module will > + be called sunxi-ir. > + > endif #RC_DEVICES > diff --git a/drivers/media/rc/Makefile b/drivers/media/rc/Makefile > index f8b54ff..9ee9ee7 100644 > --- a/drivers/media/rc/Makefile > +++ b/drivers/media/rc/Makefile > @@ -32,4 +32,5 @@ obj-$(CONFIG_IR_GPIO_CIR) += gpio-ir-recv.o > obj-$(CONFIG_IR_IGUANA) += iguanair.o > obj-$(CONFIG_IR_TTUSBIR) += ttusbir.o > obj-$(CONFIG_RC_ST) += st_rc.o > +obj-$(CONFIG_IR_SUNXI) += sunxi-cir.o > obj-$(CONFIG_IR_IMG) += img-ir/ > diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c > new file mode 100644 > index 0000000..25eb175 > --- /dev/null > +++ b/drivers/media/rc/sunxi-cir.c > @@ -0,0 +1,334 @@ > +/* > + * Driver for Allwinner sunXi IR controller > + * > + * Copyright (C) 2014 Alexsey Shestacov <wingrime@linux-sunxi.org> > + * Copyright (C) 2014 Alexander Bersenev <bay@hackerdom.ru> > + * > + * Based on sun5i-ir.c: > + * Copyright (C) 2007-2012 Daniel Wang > + * Allwinner Technology Co., Ltd. <www.allwinnertech.com> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include <linux/clk.h> > +#include <linux/interrupt.h> > +#include <linux/module.h> > +#include <linux/of_platform.h> > +#include <media/rc-core.h> > + > +#define SUNXI_IR_DEV "sunxi-ir" > + > +/* Registers */ > +/* IR Control */ > +#define SUNXI_IR_CTL_REG 0x00 > +/* Rx Config */ > +#define SUNXI_IR_RXCTL_REG 0x10 > +/* Rx Data */ > +#define SUNXI_IR_RXFIFO_REG 0x20 > +/* Rx Interrupt Enable */ > +#define SUNXI_IR_RXINT_REG 0x2C > +/* Rx Interrupt Status */ > +#define SUNXI_IR_RXSTA_REG 0x30 > +/* IR Sample Config */ > +#define SUNXI_IR_CIR_REG 0x34 > + > +/* Global Enable for IR_CTL Register */ > +#define REG_CTL_GEN BIT(0) > +/* RX block enable for IR_CTL Register */ > +#define REG_CTL_RXEN BIT(1) > +/* CIR mode for IR_CTL Register */ > +#define REG_CTL_MD (BIT(4)|BIT(5)) I usually prefer to have the bits definition declared just below the defininition of the register itself, something like: #define SUNXI_CTRL_REG 0x00 #define SUNXI_CTRL_EN BIT(0) #define SUNXI_CTRL_RXEN BIT(1) etc... It's easier to read and avoids the comments to say in which register each bit belongs. > +/* IR_RXCTL_REG Register Receiver Pulse Polarity Invert flag */ > +#define REG_RXCTL_RPPI BIT(2) > + > +/* IR_RXINT_REG Register fields */ > +#define REG_RXINT_ROI_EN BIT(0) /* Rx FIFO Overflow */ > +#define REG_RXINT_RPEI_EN BIT(1) /* Rx Packet End */ > +#define REG_RXINT_RAI_EN BIT(4) /* Rx FIFO Data Available */ > +/* Rx FIFO available byte level */ > +#define REG_RXINT_RAL__MASK (BIT(8)|BIT(9)|BIT(10)|BIT(11)) > +#define REG_RXINT_RAL__SHIFT 8 > +static inline uint32_t REG_RXINT_RAL(uint16_t val) > +{ > + return (val << REG_RXINT_RAL__SHIFT) & REG_RXINT_RAL__MASK; > +} This should be turned either in a macro if you want to keep the upper case name, or have a lower case name if you want to keep it as a function. In both cases, you don't want your function to be declared in the middle of your defines. Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver 2014-05-14 21:56 ` [PATCH v7 2/3] [media] rc: add sunxi-ir driver Alexander Bersenev 2014-05-15 7:24 ` Maxime Ripard 2014-05-19 8:17 ` Maxime Ripard @ 2014-05-19 20:26 ` David Härdeman 2 siblings, 0 replies; 7+ messages in thread From: David Härdeman @ 2014-05-19 20:26 UTC (permalink / raw) To: Alexander Bersenev Cc: linux-sunxi, devicetree, galak, grant.likely, ijc+devicetree, james.hogan, linux-arm-kernel, linux, m.chehab, mark.rutland, maxime.ripard, pawel.moll, rdunlap, robh+dt, sean, srinivas.kandagatla, wingrime, linux-doc, linux-kernel, linux-media On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote: >This patch adds driver for sunxi IR controller. >It is based on Alexsey Shestacov's work based on the original driver >supplied by Allwinner. > ... >+static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) >+{ >+ unsigned long status; >+ unsigned char dt; >+ unsigned int cnt, rc; >+ struct sunxi_ir *ir = dev_id; >+ DEFINE_IR_RAW_EVENT(rawir); >+ >+ spin_lock(&ir->ir_lock); >+ >+ status = readl(ir->base + SUNXI_IR_RXSTA_REG); >+ >+ /* clean all pending statuses */ >+ writel(status | REG_RXSTA_CLEARALL, ir->base + SUNXI_IR_RXSTA_REG); >+ >+ if (status & REG_RXINT_RAI_EN) { >+ /* How many messages in fifo */ >+ rc = (status >> REG_RXSTA_RAC__SHIFT) & REG_RXSTA_RAC__MASK; >+ /* Sanity check */ >+ rc = rc > SUNXI_IR_FIFO_SIZE ? SUNXI_IR_FIFO_SIZE : rc; >+ /* If we have data */ >+ for (cnt = 0; cnt < rc; cnt++) { >+ /* for each bit in fifo */ >+ dt = readb(ir->base + SUNXI_IR_RXFIFO_REG); >+ rawir.pulse = (dt & 0x80) != 0; >+ rawir.duration = (dt & 0x7f) * SUNXI_IR_SAMPLE; Can the hardware actually return a zero duration or should that be dt & 0x7f + 1? (Not familiar with this particular hardware but I know I've seen that behaviour before). >+ ir_raw_event_store_with_filter(ir->rc, &rawir); >+ } >+ } >+ >+ if (status & REG_RXINT_ROI_EN) { >+ ir_raw_event_reset(ir->rc); >+ } else if (status & REG_RXINT_RPEI_EN) { >+ ir_raw_event_set_idle(ir->rc, true); >+ ir_raw_event_handle(ir->rc); >+ } >+ >+ spin_unlock(&ir->ir_lock); >+ >+ return IRQ_HANDLED; >+} .... ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v7 3/3] ARM: sunxi: Add IR controller support in DT on A20 2014-05-14 21:56 [PATCH v7 0/3] ARM: sunxi: Add support for consumer infrared devices Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 1/3] ARM: sunxi: Add documentation for sunxi " Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 2/3] [media] rc: add sunxi-ir driver Alexander Bersenev @ 2014-05-14 21:56 ` Alexander Bersenev 2 siblings, 0 replies; 7+ messages in thread From: Alexander Bersenev @ 2014-05-14 21:56 UTC (permalink / raw) To: linux-sunxi, david, devicetree, galak, grant.likely, ijc+devicetree, james.hogan, linux-arm-kernel, linux, m.chehab, mark.rutland, maxime.ripard, pawel.moll, rdunlap, robh+dt, sean, srinivas.kandagatla, wingrime, linux-doc, linux-kernel, linux-media Cc: Alexander Bersenev This patch adds IR controller in A20 Device-Tree: - Two IR devices found in A20 user manual - Pins for two devices - One IR device physically found on Cubieboard 2 - One IR device physically found on Cubietruck Signed-off-by: Alexander Bersenev <bay@hackerdom.ru> Signed-off-by: Alexsey Shestacov <wingrime@linux-sunxi.org> --- arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 6 ++++++ arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 ++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 32 +++++++++++++++++++++++++++++ 3 files changed, 44 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts b/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts index feeff64..b44d61b 100644 --- a/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts +++ b/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts @@ -65,6 +65,12 @@ }; }; + ir0: ir@01c21800 { + pinctrl-names = "default"; + pinctrl-0 = <&ir0_pins_a>; + status = "okay"; + }; + uart0: serial@01c28000 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>; diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts index e288562..5f5c31d 100644 --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts @@ -121,6 +121,12 @@ }; }; + ir0: ir@01c21800 { + pinctrl-names = "default"; + pinctrl-0 = <&ir0_pins_a>; + status = "okay"; + }; + uart0: serial@01c28000 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins_a>; diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index 0ae2b77..fe1f8ff 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -724,6 +724,20 @@ allwinner,drive = <2>; allwinner,pull = <0>; }; + + ir0_pins_a: ir0@0 { + allwinner,pins = "PB3","PB4"; + allwinner,function = "ir0"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; + + ir1_pins_a: ir1@0 { + allwinner,pins = "PB22","PB23"; + allwinner,function = "ir1"; + allwinner,drive = <0>; + allwinner,pull = <0>; + }; }; timer@01c20c00 { @@ -749,6 +763,24 @@ interrupts = <0 24 4>; }; + ir0: ir@01c21800 { + compatible = "allwinner,sun7i-a20-ir"; + clocks = <&apb0_gates 6>, <&ir0_clk>; + clock-names = "apb", "ir"; + interrupts = <0 5 4>; + reg = <0x01c21800 0x40>; + status = "disabled"; + }; + + ir1: ir@01c21c00 { + compatible = "allwinner,sun7i-a20-ir"; + clocks = <&apb0_gates 7>, <&ir1_clk>; + clock-names = "apb", "ir"; + interrupts = <0 6 4>; + reg = <0x01c21c00 0x40>; + status = "disabled"; + }; + lradc: lradc@01c22800 { compatible = "allwinner,sun4i-lradc-keys"; reg = <0x01c22800 0x100>; -- 1.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-05-19 20:33 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-05-14 21:56 [PATCH v7 0/3] ARM: sunxi: Add support for consumer infrared devices Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 1/3] ARM: sunxi: Add documentation for sunxi " Alexander Bersenev 2014-05-14 21:56 ` [PATCH v7 2/3] [media] rc: add sunxi-ir driver Alexander Bersenev 2014-05-15 7:24 ` Maxime Ripard 2014-05-19 8:17 ` Maxime Ripard 2014-05-19 20:26 ` David Härdeman 2014-05-14 21:56 ` [PATCH v7 3/3] ARM: sunxi: Add IR controller support in DT on A20 Alexander Bersenev
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).