* [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator
@ 2014-05-26 9:56 Axel Lin
2014-05-27 3:05 ` Yibin Gong
2014-05-27 11:26 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-05-26 9:56 UTC (permalink / raw)
To: Mark Brown; +Cc: Robin Gong, Fabio Estevam, Liam Girdwood, linux-kernel
Current code has .enable_reg and .enable_mask settings, but the implementation
for corresponding callbacks are missing. Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Robin,
Can you review and test this patch?
Thanks,
Axel
drivers/regulator/pfuze100-regulator.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 67e678c..b6b4529 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -125,6 +125,9 @@ static struct regulator_ops pfuze100_ldo_regulator_ops = {
};
static struct regulator_ops pfuze100_fixed_regulator_ops = {
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+ .is_enabled = regulator_is_enabled_regmap,
.list_voltage = regulator_list_voltage_linear,
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator
2014-05-26 9:56 [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator Axel Lin
@ 2014-05-27 3:05 ` Yibin Gong
2014-05-27 11:26 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Yibin Gong @ 2014-05-27 3:05 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: Fabio.Estevam, Liam Girdwood, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1419 bytes --]
Tested-by: Robin Gong <b38343@freescale.com>
Acked-by: Robin Gong <b38343@freescale.com>
-----Original Message-----
From: Axel Lin [mailto:axel.lin@ingics.com]
Sent: Monday, May 26, 2014 5:56 PM
To: Mark Brown
Cc: Gong Yibin-B38343; Estevam Fabio-R49496; Liam Girdwood; linux-kernel@vger.kernel.org
Subject: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator
Current code has .enable_reg and .enable_mask settings, but the implementation for corresponding callbacks are missing. Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Robin,
Can you review and test this patch?
Thanks,
Axel
drivers/regulator/pfuze100-regulator.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 67e678c..b6b4529 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -125,6 +125,9 @@ static struct regulator_ops pfuze100_ldo_regulator_ops = { };
static struct regulator_ops pfuze100_fixed_regulator_ops = {
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+ .is_enabled = regulator_is_enabled_regmap,
.list_voltage = regulator_list_voltage_linear, };
--
1.8.3.2
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator
2014-05-26 9:56 [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator Axel Lin
2014-05-27 3:05 ` Yibin Gong
@ 2014-05-27 11:26 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-05-27 11:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Robin Gong, Fabio Estevam, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
On Mon, May 26, 2014 at 05:56:13PM +0800, Axel Lin wrote:
> Current code has .enable_reg and .enable_mask settings, but the implementation
> for corresponding callbacks are missing. Fix it.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-27 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-26 9:56 [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator Axel Lin
2014-05-27 3:05 ` Yibin Gong
2014-05-27 11:26 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).