From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org,
kernel-janitors <kernel-janitors@vger.kernel.org>,
kernelnewbies@kernelnewbies.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch
Date: Sat, 12 Jul 2014 11:29:37 -0700 [thread overview]
Message-ID: <1405189777.9132.27.camel@joe-AO725> (raw)
In-Reply-To: <20140712175526.GA17077@kroah.com>
On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote:
> Yes, the warnings are all due to line-length, but Joe, you shouldn't add
> a patch that causes more checkpatch warnings than before :)
Yeah, that was intentional though.
This script does a series of relatively discrete changes.
Lindent would more or less work, but it's _horrible_ at
wrapping overlong lines and merges all types of changes
together.
For now, people are probably better at line wrapping in
an acceptable way.
> While I always want to see more developers get involved with kernel
> development, there should be a minimum barrier to entry. And that
> barrier is the knowledge of the C language, and knowledge of how to edit
> a text file, and use git. This script takes that barrier away, for
> whitespace cleanups, with not much real use overall.
>
> So, I'll keep my local copy of this script now, just to have fun with at
> times when I'm bored. But I don't think it should be merged, as-is.
Dunno, I still think it's useful.
Maybe when you get new code, you might run it through a
script like this before committing it.
next prev parent reply other threads:[~2014-07-12 18:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 1:21 [PATCH] reformat_with_checkpatch: Add automation to checkpatch Joe Perches
2014-07-12 1:34 ` Greg KH
2014-07-12 1:40 ` Joe Perches
2014-07-12 2:34 ` Greg KH
2014-07-12 9:30 ` Dan Carpenter
2014-07-12 17:55 ` Greg KH
2014-07-12 18:29 ` Joe Perches [this message]
2014-07-12 19:28 ` Greg KH
2014-07-13 3:06 ` Joe Perches
2014-07-12 1:39 ` Greg KH
2014-07-12 1:46 ` Joe Perches
2014-07-12 2:01 ` Greg KH
2014-07-12 2:05 ` Greg KH
2014-07-12 2:09 ` [PATCH] checkpatch: Remove unnecessary + after {8,8} Joe Perches
2014-07-12 2:23 ` Greg KH
2014-08-31 20:58 ` Sören Brinkmann
2014-09-01 16:55 ` [PATCH - resend] " Joe Perches
2014-10-30 11:12 ` Borislav Petkov
2014-10-30 11:15 ` Borislav Petkov
2014-07-12 1:43 ` [PATCH] reformat_with_checkpatch: Add automation to checkpatch Greg KH
2014-07-12 1:50 ` Joe Perches
2014-07-12 1:53 ` Greg KH
2014-07-12 1:57 ` Joe Perches
2014-07-12 2:15 ` Greg KH
2014-07-12 8:08 ` Greg KH
2014-07-12 8:18 ` Greg KH
2014-07-12 10:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405189777.9132.27.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).