From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: devel@driverdev.osuosl.org,
kernel-janitors <kernel-janitors@vger.kernel.org>,
kernelnewbies@kernelnewbies.org,
LKML <linux-kernel@vger.kernel.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: [PATCH - resend] checkpatch: Remove unnecessary + after {8,8}
Date: Mon, 01 Sep 2014 09:55:06 -0700 [thread overview]
Message-ID: <1409590506.2614.4.camel@joe-AO725> (raw)
In-Reply-To: <20140712020520.GA18611@kroah.com>
There's a useless "+" use that needs to be removed as perl 5.20
emits a "Useless use of greediness modifier '+'" message each
time it's hit.
Reported-by: Greg KH <gregkh@linuxfoundation.org>
Signed-off-by: Joe Perches <joe@perches.com>
---
Resending, maybe Andrew's all-seeing eye blinked...
On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote:
> Ok, with linux-next I get the same thing:
Thanks Greg.
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5ac001..370a974 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2376,7 +2376,7 @@ sub process {
"please, no space before tabs\n" . $herevet) &&
$fix) {
while ($fixed[$fixlinenr] =~
- s/(^\+.*) {8,8}+\t/$1\t\t/) {}
+ s/(^\+.*) {8,8}\t/$1\t\t/) {}
while ($fixed[$fixlinenr] =~
s/(^\+.*) +\t/$1\t/) {}
}
next prev parent reply other threads:[~2014-09-01 16:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 1:21 [PATCH] reformat_with_checkpatch: Add automation to checkpatch Joe Perches
2014-07-12 1:34 ` Greg KH
2014-07-12 1:40 ` Joe Perches
2014-07-12 2:34 ` Greg KH
2014-07-12 9:30 ` Dan Carpenter
2014-07-12 17:55 ` Greg KH
2014-07-12 18:29 ` Joe Perches
2014-07-12 19:28 ` Greg KH
2014-07-13 3:06 ` Joe Perches
2014-07-12 1:39 ` Greg KH
2014-07-12 1:46 ` Joe Perches
2014-07-12 2:01 ` Greg KH
2014-07-12 2:05 ` Greg KH
2014-07-12 2:09 ` [PATCH] checkpatch: Remove unnecessary + after {8,8} Joe Perches
2014-07-12 2:23 ` Greg KH
2014-08-31 20:58 ` Sören Brinkmann
2014-09-01 16:55 ` Joe Perches [this message]
2014-10-30 11:12 ` [PATCH - resend] " Borislav Petkov
2014-10-30 11:15 ` Borislav Petkov
2014-07-12 1:43 ` [PATCH] reformat_with_checkpatch: Add automation to checkpatch Greg KH
2014-07-12 1:50 ` Joe Perches
2014-07-12 1:53 ` Greg KH
2014-07-12 1:57 ` Joe Perches
2014-07-12 2:15 ` Greg KH
2014-07-12 8:08 ` Greg KH
2014-07-12 8:18 ` Greg KH
2014-07-12 10:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409590506.2614.4.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).