From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
kernel-janitors <kernel-janitors@vger.kernel.org>,
kernelnewbies@kernelnewbies.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] reformat_with_checkpatch: Add automation to checkpatch
Date: Sat, 12 Jul 2014 12:30:43 +0300 [thread overview]
Message-ID: <20140712093043.GG25880@mwanda> (raw)
In-Reply-To: <1405129216.6751.18.camel@joe-AO725>
On Fri, Jul 11, 2014 at 06:40:16PM -0700, Joe Perches wrote:
> On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
> > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > > A simple script to run checkpatch --fix for various types of
> > > of cleanups.
> > >
> > > This script is useful primarily for staging.
> > >
> > > This reformats code to a more CodingStyle conforming style,
> > > compiles it, verifies that the object code hasn't changed,
> > > and git commits it too.
> >
> > And 'git commits' it?
>
> The thought I had was to made it easier to
> submit "my first kernel patch" correctly.
> like that tuxradar article you wrote a few
> years ago.
>
> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
>
> > Heh, I should just run this myself to clean up
> > staging and beat everyone else to it...
>
> At least for the whitespace noise, you could
> but I hope it'll encourage a few more people
> to try kernel patching instead.
I have always hate the idea of automated patches from random people
because I don't trust them to not be malicious so I have to review them
manually. There is a story that back in the day the US government paid
someone to send tons of checkpatch style patches to BSD. The guy
thought he was "cleaning up the code" but actually he was part of a
larger scheme to flood the maintainers with patches so another person
could slip in some malicious code.
It's better if someone just ran this on all new staging code before
adding it to the tree.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-12 9:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 1:21 [PATCH] reformat_with_checkpatch: Add automation to checkpatch Joe Perches
2014-07-12 1:34 ` Greg KH
2014-07-12 1:40 ` Joe Perches
2014-07-12 2:34 ` Greg KH
2014-07-12 9:30 ` Dan Carpenter [this message]
2014-07-12 17:55 ` Greg KH
2014-07-12 18:29 ` Joe Perches
2014-07-12 19:28 ` Greg KH
2014-07-13 3:06 ` Joe Perches
2014-07-12 1:39 ` Greg KH
2014-07-12 1:46 ` Joe Perches
2014-07-12 2:01 ` Greg KH
2014-07-12 2:05 ` Greg KH
2014-07-12 2:09 ` [PATCH] checkpatch: Remove unnecessary + after {8,8} Joe Perches
2014-07-12 2:23 ` Greg KH
2014-08-31 20:58 ` Sören Brinkmann
2014-09-01 16:55 ` [PATCH - resend] " Joe Perches
2014-10-30 11:12 ` Borislav Petkov
2014-10-30 11:15 ` Borislav Petkov
2014-07-12 1:43 ` [PATCH] reformat_with_checkpatch: Add automation to checkpatch Greg KH
2014-07-12 1:50 ` Joe Perches
2014-07-12 1:53 ` Greg KH
2014-07-12 1:57 ` Joe Perches
2014-07-12 2:15 ` Greg KH
2014-07-12 8:08 ` Greg KH
2014-07-12 8:18 ` Greg KH
2014-07-12 10:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712093043.GG25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).