* [PATCH] drivers: scsi: #define missing include guards
@ 2014-08-22 12:37 Rasmus Villemoes
2014-08-22 13:28 ` Rasmus Villemoes
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Rasmus Villemoes @ 2014-08-22 12:37 UTC (permalink / raw)
To: James E.J. Bottomley; +Cc: linux-scsi, linux-kernel, Rasmus Villemoes
The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
drivers/scsi/ contain two-thirds of an include guard, but do not
elsewhere.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/scsi/aha1542.h | 1 +
drivers/scsi/aha1740.h | 1 +
drivers/scsi/gvp11.h | 1 +
drivers/scsi/mvme147.h | 1 +
4 files changed, 4 insertions(+)
diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h
index b871d2b..8f4e07a 100644
--- a/drivers/scsi/aha1542.h
+++ b/drivers/scsi/aha1542.h
@@ -1,4 +1,5 @@
#ifndef _AHA1542_H
+#define _AHA1542_H
/* $Id: aha1542.h,v 1.1 1992/07/24 06:27:38 root Exp root $
*
diff --git a/drivers/scsi/aha1740.h b/drivers/scsi/aha1740.h
index af23fd6..7ea484f 100644
--- a/drivers/scsi/aha1740.h
+++ b/drivers/scsi/aha1740.h
@@ -1,4 +1,5 @@
#ifndef _AHA1740_H
+#define _AHA1740_H
/* $Id$
*
diff --git a/drivers/scsi/gvp11.h b/drivers/scsi/gvp11.h
index 852913c..5aabe90 100644
--- a/drivers/scsi/gvp11.h
+++ b/drivers/scsi/gvp11.h
@@ -1,4 +1,5 @@
#ifndef GVP11_H
+#define GVP11_H
/* $Id: gvp11.h,v 1.4 1997/01/19 23:07:12 davem Exp $
*
diff --git a/drivers/scsi/mvme147.h b/drivers/scsi/mvme147.h
index bfd4566..479e9b4 100644
--- a/drivers/scsi/mvme147.h
+++ b/drivers/scsi/mvme147.h
@@ -1,4 +1,5 @@
#ifndef MVME147_H
+#define MVME147_H
/* $Id: mvme147.h,v 1.4 1997/01/19 23:07:10 davem Exp $
*
--
1.9.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: scsi: #define missing include guards
2014-08-22 12:37 [PATCH] drivers: scsi: #define missing include guards Rasmus Villemoes
@ 2014-08-22 13:28 ` Rasmus Villemoes
2014-08-24 15:35 ` Christoph Hellwig
2014-08-26 9:26 ` [PATCH] " Hannes Reinecke
2 siblings, 0 replies; 5+ messages in thread
From: Rasmus Villemoes @ 2014-08-22 13:28 UTC (permalink / raw)
To: James E.J. Bottomley; +Cc: linux-scsi, linux-kernel
Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
> The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
> drivers/scsi/ contain two-thirds of an include guard, but do not
> elsewhere.
>
Argh, git commit ate a line because it happened to start with #. This
was supposed to be something like "...but do not #define the macro. git
grep says that the macro names are not defined elsewhere."
Rasmus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: scsi: #define missing include guards
2014-08-22 12:37 [PATCH] drivers: scsi: #define missing include guards Rasmus Villemoes
2014-08-22 13:28 ` Rasmus Villemoes
@ 2014-08-24 15:35 ` Christoph Hellwig
2014-08-25 8:10 ` [PATCH v2] " Rasmus Villemoes
2014-08-26 9:26 ` [PATCH] " Hannes Reinecke
2 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2014-08-24 15:35 UTC (permalink / raw)
To: Rasmus Villemoes; +Cc: James E.J. Bottomley, linux-scsi, linux-kernel
On Fri, Aug 22, 2014 at 02:37:33PM +0200, Rasmus Villemoes wrote:
> The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
> drivers/scsi/ contain two-thirds of an include guard, but do not
> elsewhere.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Looks reasonable to me, can I get a quick review for it?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drivers: scsi: #define missing include guards
2014-08-24 15:35 ` Christoph Hellwig
@ 2014-08-25 8:10 ` Rasmus Villemoes
0 siblings, 0 replies; 5+ messages in thread
From: Rasmus Villemoes @ 2014-08-25 8:10 UTC (permalink / raw)
To: James E.J. Bottomley, Christoph Hellwig
Cc: linux-scsi, linux-kernel, Rasmus Villemoes
The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
drivers/scsi/ contain two-thirds of an include guard, but do not
#define the macro. Add those #defines. git grep says the macro names
are not defined elsewhere.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
For good measure, here's a version with a non-broken commit message.
drivers/scsi/aha1542.h | 1 +
drivers/scsi/aha1740.h | 1 +
drivers/scsi/gvp11.h | 1 +
drivers/scsi/mvme147.h | 1 +
4 files changed, 4 insertions(+)
diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h
index b871d2b..8f4e07a 100644
--- a/drivers/scsi/aha1542.h
+++ b/drivers/scsi/aha1542.h
@@ -1,4 +1,5 @@
#ifndef _AHA1542_H
+#define _AHA1542_H
/* $Id: aha1542.h,v 1.1 1992/07/24 06:27:38 root Exp root $
*
diff --git a/drivers/scsi/aha1740.h b/drivers/scsi/aha1740.h
index af23fd6..7ea484f 100644
--- a/drivers/scsi/aha1740.h
+++ b/drivers/scsi/aha1740.h
@@ -1,4 +1,5 @@
#ifndef _AHA1740_H
+#define _AHA1740_H
/* $Id$
*
diff --git a/drivers/scsi/gvp11.h b/drivers/scsi/gvp11.h
index 852913c..5aabe90 100644
--- a/drivers/scsi/gvp11.h
+++ b/drivers/scsi/gvp11.h
@@ -1,4 +1,5 @@
#ifndef GVP11_H
+#define GVP11_H
/* $Id: gvp11.h,v 1.4 1997/01/19 23:07:12 davem Exp $
*
diff --git a/drivers/scsi/mvme147.h b/drivers/scsi/mvme147.h
index bfd4566..479e9b4 100644
--- a/drivers/scsi/mvme147.h
+++ b/drivers/scsi/mvme147.h
@@ -1,4 +1,5 @@
#ifndef MVME147_H
+#define MVME147_H
/* $Id: mvme147.h,v 1.4 1997/01/19 23:07:10 davem Exp $
*
--
2.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: scsi: #define missing include guards
2014-08-22 12:37 [PATCH] drivers: scsi: #define missing include guards Rasmus Villemoes
2014-08-22 13:28 ` Rasmus Villemoes
2014-08-24 15:35 ` Christoph Hellwig
@ 2014-08-26 9:26 ` Hannes Reinecke
2 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2014-08-26 9:26 UTC (permalink / raw)
To: Rasmus Villemoes, James E.J. Bottomley; +Cc: linux-scsi, linux-kernel
On 08/22/2014 02:37 PM, Rasmus Villemoes wrote:
> The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
> drivers/scsi/ contain two-thirds of an include guard, but do not
> elsewhere.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/scsi/aha1542.h | 1 +
> drivers/scsi/aha1740.h | 1 +
> drivers/scsi/gvp11.h | 1 +
> drivers/scsi/mvme147.h | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h
> index b871d2b..8f4e07a 100644
> --- a/drivers/scsi/aha1542.h
> +++ b/drivers/scsi/aha1542.h
> @@ -1,4 +1,5 @@
> #ifndef _AHA1542_H
> +#define _AHA1542_H
>
> /* $Id: aha1542.h,v 1.1 1992/07/24 06:27:38 root Exp root $
> *
> diff --git a/drivers/scsi/aha1740.h b/drivers/scsi/aha1740.h
> index af23fd6..7ea484f 100644
> --- a/drivers/scsi/aha1740.h
> +++ b/drivers/scsi/aha1740.h
> @@ -1,4 +1,5 @@
> #ifndef _AHA1740_H
> +#define _AHA1740_H
>
> /* $Id$
> *
> diff --git a/drivers/scsi/gvp11.h b/drivers/scsi/gvp11.h
> index 852913c..5aabe90 100644
> --- a/drivers/scsi/gvp11.h
> +++ b/drivers/scsi/gvp11.h
> @@ -1,4 +1,5 @@
> #ifndef GVP11_H
> +#define GVP11_H
>
> /* $Id: gvp11.h,v 1.4 1997/01/19 23:07:12 davem Exp $
> *
> diff --git a/drivers/scsi/mvme147.h b/drivers/scsi/mvme147.h
> index bfd4566..479e9b4 100644
> --- a/drivers/scsi/mvme147.h
> +++ b/drivers/scsi/mvme147.h
> @@ -1,4 +1,5 @@
> #ifndef MVME147_H
> +#define MVME147_H
>
> /* $Id: mvme147.h,v 1.4 1997/01/19 23:07:10 davem Exp $
> *
>
Not that it matter much, but:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-26 9:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 12:37 [PATCH] drivers: scsi: #define missing include guards Rasmus Villemoes
2014-08-22 13:28 ` Rasmus Villemoes
2014-08-24 15:35 ` Christoph Hellwig
2014-08-25 8:10 ` [PATCH v2] " Rasmus Villemoes
2014-08-26 9:26 ` [PATCH] " Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).