From: Gyungoh Yoo <gyungoh@gmail.com>
To: lgirdwood@gmail.com, broonie@kernel.org
Cc: grant.likely@linaro.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Gyungoh Yoo <jack.yoo@skyworksinc.com>
Subject: [PATCH v2.2 1/2] regulator: sky81452: Adding compatible attribute in DT
Date: Mon, 1 Sep 2014 11:40:17 +0900 [thread overview]
Message-ID: <1409539218-5571-2-git-send-email-jack.yoo@skyworksinc.com> (raw)
In-Reply-To: <1409539218-5571-1-git-send-email-jack.yoo@skyworksinc.com>
Adding compatible attriubute in DT.
Fixed typo.
---
drivers/regulator/sky81452-regulator.c | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/sky81452-regulator.c b/drivers/regulator/sky81452-regulator.c
index 97aff0c..b9c54c6 100644
--- a/drivers/regulator/sky81452-regulator.c
+++ b/drivers/regulator/sky81452-regulator.c
@@ -68,12 +68,11 @@ static const struct regulator_desc sky81452_reg = {
static struct regulator_init_data *sky81452_reg_parse_dt(struct device *dev)
{
struct regulator_init_data *init_data;
- struct device_node *np;
+ struct device_node *np = of_node_get(dev->of_node);
- np = of_get_child_by_name(dev->parent->of_node, "regulator");
- if (unlikely(!np)) {
+ if (!np) {
dev_err(dev, "regulator node not found");
- return NULL;
+ return ERR_PTR(-ENODATA);
}
init_data = of_get_regulator_init_data(dev, np);
@@ -107,17 +106,28 @@ static int sky81452_reg_probe(struct platform_device *pdev)
config.regmap = dev_get_drvdata(dev->parent);
rdev = devm_regulator_register(dev, &sky81452_reg, &config);
- if (IS_ERR(rdev))
+ if (IS_ERR(rdev)) {
+ dev_err(dev, "failed to register regulator:%d", PTR_ERR(rdev));
return PTR_ERR(rdev);
+ }
platform_set_drvdata(pdev, rdev);
return 0;
}
+#ifdef CONFIG_OF
+static const struct of_device_id sky81452_reg_of_match[] = {
+ { .compatible = "skyworks,sky81452-regulator", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, sky81452_reg_of_match);
+#endif
+
static struct platform_driver sky81452_reg_driver = {
.driver = {
.name = "sky81452-regulator",
+ .of_match_table = of_match_ptr(sky81452_reg_of_match),
},
.probe = sky81452_reg_probe,
};
@@ -127,4 +137,4 @@ module_platform_driver(sky81452_reg_driver);
MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver");
MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
+MODULE_VERSION("1.1");
--
1.9.1
next prev parent reply other threads:[~2014-09-01 2:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 9:10 [PATCH 2/3] Adding Skyworks SKY81452 regulator driver Gyungoh Yoo
2014-08-13 19:04 ` Mark Brown
2014-09-01 2:40 ` [PATCH v2.2 0/2] regulator: sky81452: Adding compatible attribute in DT document Gyungoh Yoo
2014-09-01 2:40 ` Gyungoh Yoo [this message]
2014-09-01 2:40 ` [PATCH v2.2 2/2] dt-bindings: Adding compatible attribute for SKY81452 regulator Gyungoh Yoo
2014-09-01 10:31 ` Mark Brown
2014-09-05 1:55 ` Gyungoh Yoo
2014-09-06 14:38 ` Mark Brown
2014-09-11 5:22 ` Gyungoh Yoo
2014-09-15 22:35 ` Mark Brown
2014-09-19 6:17 ` Gyungoh Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409539218-5571-2-git-send-email-jack.yoo@skyworksinc.com \
--to=gyungoh@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jack.yoo@skyworksinc.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).