* [PATCH 02/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 03/12] " An Ha
` (10 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue which requires a space before the open
curly brace '{'.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index cff300c..b9afcfc 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -43,7 +43,7 @@ void rtl8821ae_dm_bt_reject_ap_aggregated_packet(struct ieee80211_hw *hw, bool b
struct rtl_priv rtlpriv = rtl_priv(hw);
PRX_TS_RECORD pRxTs = NULL;
- if(b_reject){
+ if(b_reject) {
/* Do not allow receiving A-MPDU aggregation. */
if (rtlpriv->mac80211.vendor == PEER_CISCO) {
if (pHTInfo->bAcceptAddbaReq) {
@@ -224,7 +224,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state(struct ieee80211_hw *hw,
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_MEDIUM;
if ((rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
- (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_LOW)){
+ (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_LOW)) {
if (undecoratedsmoothed_pwdb
>= (rssi_thresh + BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_HIGH;
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 03/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
2014-09-02 0:29 ` [PATCH 02/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 04/12] " An Ha
` (9 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue which requires a space after the open
parenthesis '('.
Signed-off-by: An Ha <zero579911@gmail.com>
---
.../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 50 +++++++++++-----------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index b9afcfc..bce3771 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -43,13 +43,13 @@ void rtl8821ae_dm_bt_reject_ap_aggregated_packet(struct ieee80211_hw *hw, bool b
struct rtl_priv rtlpriv = rtl_priv(hw);
PRX_TS_RECORD pRxTs = NULL;
- if(b_reject) {
+ if (b_reject) {
/* Do not allow receiving A-MPDU aggregation. */
if (rtlpriv->mac80211.vendor == PEER_CISCO) {
if (pHTInfo->bAcceptAddbaReq) {
RTPRINT(FBT, BT_TRACE, ("BT_Disallow AMPDU \n"));
pHTInfo->bAcceptAddbaReq = FALSE;
- if(GetTs(Adapter, (PTS_COMMON_INFO*)(&pRxTs), pMgntInfo->Bssid, 0, RX_DIR, FALSE))
+ if (GetTs(Adapter, (PTS_COMMON_INFO*)(&pRxTs), pMgntInfo->Bssid, 0, RX_DIR, FALSE))
TsInitDelBA(Adapter, (PTS_COMMON_INFO)pRxTs, RX_DIR);
}
} else {
@@ -59,7 +59,7 @@ void rtl8821ae_dm_bt_reject_ap_aggregated_packet(struct ieee80211_hw *hw, bool b
}
}
} else {
- if(rtlpriv->mac80211.vendor == PEER_CISCO) {
+ if (rtlpriv->mac80211.vendor == PEER_CISCO) {
if (!pHTInfo->bAcceptAddbaReq) {
RTPRINT(FBT, BT_TRACE, ("BT_Allow AMPDU \n"));
pHTInfo->bAcceptAddbaReq = TRUE;
@@ -78,13 +78,13 @@ struct rtl_phy *rtlphy = &(rtlpriv->phy);
if (rtlpriv->link_info.b_busytraffic) {
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_IDLE;
- if(rtlpriv->link_info.b_tx_busy_traffic) {
+ if (rtlpriv->link_info.b_tx_busy_traffic) {
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_UPLINK;
} else {
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_UPLINK;
}
- if(rtlpriv->link_info.b_rx_busy_traffic) {
+ if (rtlpriv->link_info.b_rx_busy_traffic) {
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_DOWNLINK;
} else {
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_DOWNLINK;
@@ -102,7 +102,7 @@ if (rtlpriv->mac80211.mode == WIRELESS_MODE_G
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_HT40;
} else {
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_LEGACY;
- if(rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40) {
+ if (rtlphy->current_chan_bw == HT_CHANNEL_WIDTH_20_40) {
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_HT40;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_HT20;
} else {
@@ -130,12 +130,12 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
undecoratedsmoothed_pwdb = rtl8821ae_dm_bt_get_rx_ss(hw);
- if(level_num == 2) {
+ if (level_num == 2) {
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_MEDIUM;
- if( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
+ if ( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
(rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_LOW)) {
- if(undecoratedsmoothed_pwdb >= (rssi_thresh + BT_FW_COEX_THRESH_TOL)) {
+ if (undecoratedsmoothed_pwdb >= (rssi_thresh + BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_HIGH;
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_RSSI_1_HIGH;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_LOW;
@@ -145,7 +145,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state stay at Low\n"));
}
} else {
- if(undecoratedsmoothed_pwdb < rssi_thresh) {
+ if (undecoratedsmoothed_pwdb < rssi_thresh) {
bt_rssi_state = BT_RSSI_STATE_LOW;
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_RSSI_1_LOW;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_HIGH;
@@ -155,15 +155,15 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state stay at High\n"));
}
}
- } else if(level_num == 3) {
- if(rssi_thresh > rssi_thresh1) {
+ } else if (level_num == 3) {
+ if (rssi_thresh > rssi_thresh1) {
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 thresh error!!\n"));
return rtlpcipriv->btcoexist.bt_pre_rssi_state;
}
- if( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
+ if ( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
(rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_LOW)) {
- if(undecoratedsmoothed_pwdb >= (rssi_thresh+BT_FW_COEX_THRESH_TOL)) {
+ if (undecoratedsmoothed_pwdb >= (rssi_thresh+BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_MEDIUM;
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_RSSI_1_MEDIUM;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_LOW;
@@ -173,15 +173,15 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
bt_rssi_state = BT_RSSI_STATE_STAY_LOW;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state stay at Low\n"));
}
- } else if( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_MEDIUM) ||
+ } else if ( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_MEDIUM) ||
(rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_MEDIUM)) {
- if(undecoratedsmoothed_pwdb >= (rssi_thresh1 + BT_FW_COEX_THRESH_TOL)) {
+ if (undecoratedsmoothed_pwdb >= (rssi_thresh1 + BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_HIGH;
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_RSSI_1_HIGH;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_LOW;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_MEDIUM;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state switch to High\n"));
- } else if(undecoratedsmoothed_pwdb < rssi_thresh) {
+ } else if (undecoratedsmoothed_pwdb < rssi_thresh) {
bt_rssi_state = BT_RSSI_STATE_LOW;
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_RSSI_1_LOW;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_HIGH;
@@ -192,7 +192,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state stay at Medium\n"));
}
} else {
- if(undecoratedsmoothed_pwdb < rssi_thresh1) {
+ if (undecoratedsmoothed_pwdb < rssi_thresh1) {
bt_rssi_state = BT_RSSI_STATE_MEDIUM;
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_RSSI_1_MEDIUM;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_HIGH;
@@ -263,7 +263,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state(struct ieee80211_hw *hw,
}
if ((rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
(rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_LOW)) {
- if(undecoratedsmoothed_pwdb
+ if (undecoratedsmoothed_pwdb
>= (rssi_thresh + BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_MEDIUM;
rtlpcipriv->btcoexist.current_state
@@ -292,7 +292,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state(struct ieee80211_hw *hw,
&= ~BT_COEX_STATE_WIFI_RSSI_MEDIUM;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("[DM][BT], RSSI state switch to High\n"));
- } else if(undecoratedsmoothed_pwdb < rssi_thresh)
+ } else if (undecoratedsmoothed_pwdb < rssi_thresh)
{
bt_rssi_state = BT_RSSI_STATE_LOW;
rtlpcipriv->btcoexist.current_state
@@ -309,7 +309,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state(struct ieee80211_hw *hw,
("[DM][BT], RSSI state stay at Medium\n"));
}
} else {
- if(undecoratedsmoothed_pwdb < rssi_thresh1) {
+ if (undecoratedsmoothed_pwdb < rssi_thresh1) {
bt_rssi_state = BT_RSSI_STATE_MEDIUM;
rtlpcipriv->btcoexist.current_state
|= BT_COEX_STATE_WIFI_RSSI_MEDIUM;
@@ -443,7 +443,7 @@ void rtl8821ae_dm_bt_fw_coex_all_off(struct ieee80211_hw *hw)
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("rtl8821ae_dm_bt_fw_coex_all_off()\n"));
- if(rtlpcipriv->btcoexist.b_fw_coexist_all_off)
+ if (rtlpcipriv->btcoexist.b_fw_coexist_all_off)
return;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
@@ -460,7 +460,7 @@ void rtl8821ae_dm_bt_sw_coex_all_off(struct ieee80211_hw *hw)
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("rtl8821ae_dm_bt_sw_coex_all_off()\n"));
- if(rtlpcipriv->btcoexist.b_sw_coexist_all_off)
+ if (rtlpcipriv->btcoexist.b_sw_coexist_all_off)
return;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
@@ -477,7 +477,7 @@ void rtl8821ae_dm_bt_hw_coex_all_off(struct ieee80211_hw *hw)
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("rtl8821ae_dm_bt_hw_coex_all_off()\n"));
- if(rtlpcipriv->btcoexist.b_hw_coexist_all_off)
+ if (rtlpcipriv->btcoexist.b_hw_coexist_all_off)
return;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("rtl8821ae_dm_bt_hw_coex_all_off(), real Do\n"));
@@ -498,7 +498,7 @@ bool rtl8821ae_dm_bt_is_coexist_state_changed(struct ieee80211_hw *hw)
{
struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
- if((rtlpcipriv->btcoexist.previous_state
+ if ((rtlpcipriv->btcoexist.previous_state
== rtlpcipriv->btcoexist.current_state)
&& (rtlpcipriv->btcoexist.previous_state_h
== rtlpcipriv->btcoexist.current_state_h))
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 04/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
2014-09-02 0:29 ` [PATCH 02/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue An Ha
2014-09-02 0:29 ` [PATCH 03/12] " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 05/12] Staging: rtl8821ae: hal_bt_coexist: fix pointer placement " An Ha
` (8 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue which requires a space after a comma.
Signed-off-by: An Ha <zero579911@gmail.com>
---
.../staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 26 +++++++++++-----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index bce3771..48c6160 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -197,7 +197,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_RSSI_1_MEDIUM;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_HIGH;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_LOW;
- RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,("[DM][BT], RSSI_1 state switch to Medium\n"));
+ RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state switch to Medium\n"));
} else {
bt_rssi_state = BT_RSSI_STATE_STAY_HIGH;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state stay at High\n"));
@@ -382,11 +382,11 @@ void rtl8821ae_dm_bt_agc_table(struct ieee80211_hw *hw, u8 type)
if (type == BT_AGCTABLE_OFF) {
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[BT]AGCTable Off!\n"));
- rtl_write_dword(rtlpriv, 0xc78,0x641c0001);
- rtl_write_dword(rtlpriv, 0xc78,0x631d0001);
- rtl_write_dword(rtlpriv, 0xc78,0x621e0001);
- rtl_write_dword(rtlpriv, 0xc78,0x611f0001);
- rtl_write_dword(rtlpriv, 0xc78,0x60200001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x641c0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x631d0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x621e0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x611f0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x60200001);
rtl8821ae_phy_set_rf_reg(hw, RF90_PATH_A,
RF_RX_AGC_HP, 0xfffff, 0x32000);
@@ -400,11 +400,11 @@ void rtl8821ae_dm_bt_agc_table(struct ieee80211_hw *hw, u8 type)
RF_RX_G1, 0xfffff, 0x30355);
} else if (type == BT_AGCTABLE_ON) {
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[BT]AGCTable On!\n"));
- rtl_write_dword(rtlpriv, 0xc78,0x4e1c0001);
- rtl_write_dword(rtlpriv, 0xc78,0x4d1d0001);
- rtl_write_dword(rtlpriv, 0xc78,0x4c1e0001);
- rtl_write_dword(rtlpriv, 0xc78,0x4b1f0001);
- rtl_write_dword(rtlpriv, 0xc78,0x4a200001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x4e1c0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x4d1d0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x4c1e0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x4b1f0001);
+ rtl_write_dword(rtlpriv, 0xc78, 0x4a200001);
rtl8821ae_phy_set_rf_reg(hw, RF90_PATH_A,
RF_RX_AGC_HP, 0xfffff, 0xdc000);
@@ -428,10 +428,10 @@ void rtl8821ae_dm_bt_bb_back_off_level(struct ieee80211_hw *hw, u8 type)
if (type == BT_BB_BACKOFF_OFF) {
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[BT]BBBackOffLevel Off!\n"));
- rtl_write_dword(rtlpriv, 0xc04,0x3a05611);
+ rtl_write_dword(rtlpriv, 0xc04, 0x3a05611);
} else if (type == BT_BB_BACKOFF_ON) {
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[BT]BBBackOffLevel On!\n"));
- rtl_write_dword(rtlpriv, 0xc04,0x3a07611);
+ rtl_write_dword(rtlpriv, 0xc04, 0x3a07611);
rtlpcipriv->btcoexist.b_sw_coexist_all_off = false;
}
}
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 05/12] Staging: rtl8821ae: hal_bt_coexist: fix pointer placement coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (2 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 04/12] " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 06/12] Staging: rtl8821ae: hal_bt_coexist: fix " An Ha
` (7 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix pointer placement coding style issue, where using "foo *" is
preferable over "foo*".
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index 48c6160..a478ee4 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -49,7 +49,7 @@ void rtl8821ae_dm_bt_reject_ap_aggregated_packet(struct ieee80211_hw *hw, bool b
if (pHTInfo->bAcceptAddbaReq) {
RTPRINT(FBT, BT_TRACE, ("BT_Disallow AMPDU \n"));
pHTInfo->bAcceptAddbaReq = FALSE;
- if (GetTs(Adapter, (PTS_COMMON_INFO*)(&pRxTs), pMgntInfo->Bssid, 0, RX_DIR, FALSE))
+ if (GetTs(Adapter, (PTS_COMMON_INFO *)(&pRxTs), pMgntInfo->Bssid, 0, RX_DIR, FALSE))
TsInitDelBA(Adapter, (PTS_COMMON_INFO)pRxTs, RX_DIR);
}
} else {
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 06/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (3 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 05/12] Staging: rtl8821ae: hal_bt_coexist: fix pointer placement " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 07/12] " An Ha
` (6 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Remove whitespace after open parenthesis '('.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index a478ee4..b0326c9 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -133,7 +133,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
if (level_num == 2) {
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_RSSI_1_MEDIUM;
- if ( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
+ if ((rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
(rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_LOW)) {
if (undecoratedsmoothed_pwdb >= (rssi_thresh + BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_HIGH;
@@ -161,7 +161,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
return rtlpcipriv->btcoexist.bt_pre_rssi_state;
}
- if ( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
+ if ((rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_LOW) ||
(rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_LOW)) {
if (undecoratedsmoothed_pwdb >= (rssi_thresh+BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_MEDIUM;
@@ -173,7 +173,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
bt_rssi_state = BT_RSSI_STATE_STAY_LOW;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE, ("[DM][BT], RSSI_1 state stay at Low\n"));
}
- } else if ( (rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_MEDIUM) ||
+ } else if ((rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_MEDIUM) ||
(rtlpcipriv->btcoexist.bt_pre_rssi_state == BT_RSSI_STATE_STAY_MEDIUM)) {
if (undecoratedsmoothed_pwdb >= (rssi_thresh1 + BT_FW_COEX_THRESH_TOL)) {
bt_rssi_state = BT_RSSI_STATE_HIGH;
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 07/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (4 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 06/12] Staging: rtl8821ae: hal_bt_coexist: fix " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 08/12] " An Ha
` (5 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Remove unnecessary whitespace before a quoted newline.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index b0326c9..938c98a 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -47,7 +47,7 @@ void rtl8821ae_dm_bt_reject_ap_aggregated_packet(struct ieee80211_hw *hw, bool b
/* Do not allow receiving A-MPDU aggregation. */
if (rtlpriv->mac80211.vendor == PEER_CISCO) {
if (pHTInfo->bAcceptAddbaReq) {
- RTPRINT(FBT, BT_TRACE, ("BT_Disallow AMPDU \n"));
+ RTPRINT(FBT, BT_TRACE, ("BT_Disallow AMPDU\n"));
pHTInfo->bAcceptAddbaReq = FALSE;
if (GetTs(Adapter, (PTS_COMMON_INFO *)(&pRxTs), pMgntInfo->Bssid, 0, RX_DIR, FALSE))
TsInitDelBA(Adapter, (PTS_COMMON_INFO)pRxTs, RX_DIR);
@@ -61,7 +61,7 @@ void rtl8821ae_dm_bt_reject_ap_aggregated_packet(struct ieee80211_hw *hw, bool b
} else {
if (rtlpriv->mac80211.vendor == PEER_CISCO) {
if (!pHTInfo->bAcceptAddbaReq) {
- RTPRINT(FBT, BT_TRACE, ("BT_Allow AMPDU \n"));
+ RTPRINT(FBT, BT_TRACE, ("BT_Allow AMPDU\n"));
pHTInfo->bAcceptAddbaReq = TRUE;
}
}
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 08/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (5 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 07/12] " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 09/12] " An Ha
` (4 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue where the if statement unnecessarily uses curly
braces for one line statements.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index 938c98a..f1cf373 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -78,17 +78,15 @@ struct rtl_phy *rtlphy = &(rtlpriv->phy);
if (rtlpriv->link_info.b_busytraffic) {
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_IDLE;
- if (rtlpriv->link_info.b_tx_busy_traffic) {
+ if (rtlpriv->link_info.b_tx_busy_traffic)
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_UPLINK;
- } else {
+ else
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_UPLINK;
- }
- if (rtlpriv->link_info.b_rx_busy_traffic) {
+ if (rtlpriv->link_info.b_rx_busy_traffic)
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_DOWNLINK;
- } else {
+ else
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_DOWNLINK;
- }
} else {
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_WIFI_IDLE;
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_WIFI_UPLINK;
@@ -111,12 +109,11 @@ if (rtlpriv->mac80211.mode == WIRELESS_MODE_G
}
}
-if (bt_operation_on) {
+if (bt_operation_on)
rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_BT30;
-} else {
+else
rtlpcipriv->btcoexist.current_state &= ~BT_COEX_STATE_BT30;
}
-}
u8 rtl8821ae_dm_bt_check_coex_rssi_state1(struct ieee80211_hw *hw,
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 09/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (6 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 08/12] " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 10/12] " An Ha
` (3 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue where the else conditional statement should
follow the closing curly brace '}'.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index f1cf373..869b094 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -251,8 +251,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state(struct ieee80211_hw *hw,
("[DM][BT], RSSI state stay at High\n"));
}
}
- }
- else if (level_num == 3) {
+ } else if (level_num == 3) {
if (rssi_thresh > rssi_thresh1) {
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("[DM][BT], RSSI thresh error!!\n"));
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 10/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (7 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 09/12] " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 11/12] " An Ha
` (2 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue where the open curly brace '{' should be on
the same line as the if statement.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index 869b094..38addec 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -288,8 +288,7 @@ u8 rtl8821ae_dm_bt_check_coex_rssi_state(struct ieee80211_hw *hw,
&= ~BT_COEX_STATE_WIFI_RSSI_MEDIUM;
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("[DM][BT], RSSI state switch to High\n"));
- } else if (undecoratedsmoothed_pwdb < rssi_thresh)
- {
+ } else if (undecoratedsmoothed_pwdb < rssi_thresh) {
bt_rssi_state = BT_RSSI_STATE_LOW;
rtlpcipriv->btcoexist.current_state
|= BT_COEX_STATE_WIFI_RSSI_LOW;
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 11/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (8 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 10/12] " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 0:29 ` [PATCH 12/12] " An Ha
2014-09-02 9:19 ` [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style Dan Carpenter
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue which requires a space after the equal sign '='.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index 38addec..d587072 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -347,7 +347,7 @@ void rtl8821ae_dm_bt_balance(struct ieee80211_hw *hw,
{
struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
struct rtl_priv *rtlpriv = rtl_priv(hw);
- u8 h2c_parameter[3] ={0};
+ u8 h2c_parameter[3] = {0};
if (b_balance_on) {
h2c_parameter[2] = 1;
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 12/12] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (9 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 11/12] " An Ha
@ 2014-09-02 0:29 ` An Ha
2014-09-02 9:19 ` [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style Dan Carpenter
11 siblings, 0 replies; 15+ messages in thread
From: An Ha @ 2014-09-02 0:29 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, An Ha
Fix coding style issue which requires a blank line after declarations.
Signed-off-by: An Ha <zero579911@gmail.com>
---
drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
index d587072..293bf9d 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_bt_coexist.c
@@ -435,6 +435,7 @@ void rtl8821ae_dm_bt_fw_coex_all_off(struct ieee80211_hw *hw)
{
struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
struct rtl_priv *rtlpriv = rtl_priv(hw);
+
RT_TRACE(COMP_BT_COEXIST, DBG_TRACE,
("rtl8821ae_dm_bt_fw_coex_all_off()\n"));
--
2.1.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style
2014-09-02 0:29 [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style An Ha
` (10 preceding siblings ...)
2014-09-02 0:29 ` [PATCH 12/12] " An Ha
@ 2014-09-02 9:19 ` Dan Carpenter
2014-09-02 11:22 ` An Tuan Ha
11 siblings, 1 reply; 15+ messages in thread
From: Dan Carpenter @ 2014-09-02 9:19 UTC (permalink / raw)
To: An Ha; +Cc: gregkh, devel, linux-kernel
Hm... Now you've broken it into *too* many separate patches. Also the
subjects are the same. Also the subjects are too vague. Which coding
style issue is addressed?
It should be something like:
patch 1: comments
patch 2: add/remove spaces
patch 3: fix quoted text
patch 4: braces
patch 5: add a blank line
regards,
dan carpenter
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style
2014-09-02 9:19 ` [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style Dan Carpenter
@ 2014-09-02 11:22 ` An Tuan Ha
2014-09-02 13:35 ` Dan Carpenter
0 siblings, 1 reply; 15+ messages in thread
From: An Tuan Ha @ 2014-09-02 11:22 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, linux-kernel
I see, thanks, I will fix it, I was just worried about the subjects
being too long so I just stuck with the same subject; is there a
character limit on how long the subject line should be? Or as long as
it's reasonable, it'll be fine?
On Tue, Sep 02, 2014 at 12:19:40PM +0300, Dan Carpenter wrote:
> Hm... Now you've broken it into *too* many separate patches. Also the
> subjects are the same. Also the subjects are too vague. Which coding
> style issue is addressed?
>
> It should be something like:
> patch 1: comments
> patch 2: add/remove spaces
> patch 3: fix quoted text
> patch 4: braces
> patch 5: add a blank line
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting style
2014-09-02 11:22 ` An Tuan Ha
@ 2014-09-02 13:35 ` Dan Carpenter
0 siblings, 0 replies; 15+ messages in thread
From: Dan Carpenter @ 2014-09-02 13:35 UTC (permalink / raw)
To: An Tuan Ha; +Cc: gregkh, devel, linux-kernel
On Tue, Sep 02, 2014 at 07:22:12AM -0400, An Tuan Ha wrote:
> I see, thanks, I will fix it, I was just worried about the subjects
> being too long so I just stuck with the same subject; is there a
> character limit on how long the subject line should be? Or as long as
> it's reasonable, it'll be fine?
Reasonable is fine.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 15+ messages in thread