* [PATCH v2 0/4] Add picoPHY usb phy driver found on stih407 family SoC's
@ 2014-09-09 9:00 Peter Griffin
2014-09-09 9:00 ` [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family Peter Griffin
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Peter Griffin @ 2014-09-09 9:00 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard
Cc: peter.griffin, lee.jones, peppe.cavallaro, devicetree
This series adds support for the picoPHY usb phy which is used by the usb2
and usb3 host controllers when controlling usb2/1.1 devices. It is found on
stih407 family SoC's from the consumer electronics devision of STMicroelectronics.
Changes since v1:
- Remove reference to stih410 in dt documentation
- Fix alignment issue in dt example
- usbpicophy@f8 since you have a reg property
Peter Griffin (4):
phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC
family
phy: phy-stih407-usb: Add dt documentation for USB picophy found on
stih407 SoC family
MAINTAINERS: Add phy-stih407-usb.c file to ARCH/STI architecture
ARM: multi_v7_defconfig: Enable stih407 usb picophy
.../devicetree/bindings/phy/phy-stih407-usb.txt | 30 ++++
MAINTAINERS | 1 +
arch/arm/configs/multi_v7_defconfig | 1 +
drivers/phy/Kconfig | 8 +
drivers/phy/Makefile | 2 +
drivers/phy/phy-stih407-usb.c | 185 +++++++++++++++++++++
6 files changed, 227 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-stih407-usb.txt
create mode 100644 drivers/phy/phy-stih407-usb.c
--
1.9.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family
2014-09-09 9:00 [PATCH v2 0/4] Add picoPHY usb phy driver found on stih407 family SoC's Peter Griffin
@ 2014-09-09 9:00 ` Peter Griffin
2014-09-09 9:08 ` Arnd Bergmann
2014-09-09 11:52 ` Bartlomiej Zolnierkiewicz
2014-09-09 9:00 ` [PATCH v2 2/4] phy: phy-stih407-usb: Add dt documentation for USB picophy " Peter Griffin
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Peter Griffin @ 2014-09-09 9:00 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard
Cc: peter.griffin, lee.jones, peppe.cavallaro, devicetree
This is the generic phy driver for the picoPHY ports used by the
USB2 and USB3 Host controllers when controlling usb2/1.1 devices. It
is found on STiH407 SoC family from STMicroelectronics.
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/phy/Kconfig | 8 ++
drivers/phy/Makefile | 2 +
drivers/phy/phy-stih407-usb.c | 185 ++++++++++++++++++++++++++++++++++++++++++
3 files changed, 195 insertions(+)
create mode 100644 drivers/phy/phy-stih407-usb.c
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 0dd7427..58018f7 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -230,4 +230,12 @@ config PHY_XGENE
help
This option enables support for APM X-Gene SoC multi-purpose PHY.
+config PHY_STIH407_USB
+ tristate "STMicroelectronics USB2 picoPHY driver for STiH407 family"
+ depends on ARCH_STI
+ depends on GENERIC_PHY
+ help
+ Enable this support to enable the picoPHY device used by USB2
+ and USB3 controllers on STMicroelectronics STiH407 SoC families.
+
endmenu
diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
index 95c69ed..c82ac59 100644
--- a/drivers/phy/Makefile
+++ b/drivers/phy/Makefile
@@ -28,3 +28,5 @@ obj-$(CONFIG_PHY_QCOM_IPQ806X_SATA) += phy-qcom-ipq806x-sata.o
obj-$(CONFIG_PHY_ST_SPEAR1310_MIPHY) += phy-spear1310-miphy.o
obj-$(CONFIG_PHY_ST_SPEAR1340_MIPHY) += phy-spear1340-miphy.o
obj-$(CONFIG_PHY_XGENE) += phy-xgene.o
+obj-$(CONFIG_PHY_STIH407_USB) += phy-stih407-usb.o
+
diff --git a/drivers/phy/phy-stih407-usb.c b/drivers/phy/phy-stih407-usb.c
new file mode 100644
index 0000000..8019e3b
--- /dev/null
+++ b/drivers/phy/phy-stih407-usb.c
@@ -0,0 +1,185 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics
+ *
+ * STMicroelectronics Generic PHY driver for STiH407 USB2.
+ *
+ * Author: Giuseppe Cavallaro <peppe.cavallaro@st.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2, as
+ * published by the Free Software Foundation.
+ *
+ */
+#include <linux/platform_device.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/clk.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>
+#include <linux/mfd/syscon.h>
+#include <linux/phy/phy.h>
+
+/* Default PHY_SEL and REFCLKSEL configuration */
+#define STIH407_USB_PICOPHY_CTRL_PORT_CONF 0x6
+#define STIH407_USB_PICOPHY_CTRL_PORT_MASK 0x1f
+
+/* ports parameters overriding */
+#define STIH407_USB_PICOPHY_PARAM_DEF 0x39a4dc
+#define STIH407_USB_PICOPHY_PARAM_MASK 0xffffffff
+
+struct stih407_usb2_picophy {
+ struct phy *phy;
+ struct regmap *regmap;
+ struct device *dev;
+ struct reset_control *rstc;
+ struct reset_control *rstport;
+ int ctrl;
+ int param;
+};
+
+static int stih407_usb2_pico_ctrl(struct stih407_usb2_picophy *phy_dev)
+{
+ reset_control_deassert(phy_dev->rstc);
+
+ return regmap_update_bits(phy_dev->regmap, phy_dev->ctrl,
+ STIH407_USB_PICOPHY_CTRL_PORT_MASK,
+ STIH407_USB_PICOPHY_CTRL_PORT_CONF);
+}
+
+static int stih407_usb2_init_port(struct phy *phy)
+{
+ int ret;
+ struct stih407_usb2_picophy *phy_dev = phy_get_drvdata(phy);
+
+ stih407_usb2_pico_ctrl(phy_dev);
+
+ ret = regmap_update_bits(phy_dev->regmap,
+ phy_dev->param,
+ STIH407_USB_PICOPHY_PARAM_MASK,
+ STIH407_USB_PICOPHY_PARAM_DEF);
+ if (ret)
+ return ret;
+
+ return reset_control_deassert(phy_dev->rstport);
+}
+
+static int stih407_usb2_exit_port(struct phy *phy)
+{
+ struct stih407_usb2_picophy *phy_dev = phy_get_drvdata(phy);
+
+ /*
+ * Only port reset is asserted, phy global reset is kept untouched
+ * as other ports may still be active. When all ports are in reset
+ * state, assumption is made that power will be cut off on the phy, in
+ * case of suspend for instance. Theoretically, asserting individual
+ * reset (like here) or global reset should be equivalent.
+ */
+ return reset_control_assert(phy_dev->rstport);
+}
+
+static const struct phy_ops stih407_usb2_picophy_data = {
+ .init = stih407_usb2_init_port,
+ .exit = stih407_usb2_exit_port,
+ .owner = THIS_MODULE,
+};
+
+static const struct of_device_id stih407_usb2_picophy_of_match[];
+
+static int stih407_usb2_picophy_probe(struct platform_device *pdev)
+{
+ const struct of_device_id *match;
+ struct stih407_usb2_picophy *phy_dev;
+ struct device *dev = &pdev->dev;
+ struct device_node *np = dev->of_node;
+ struct phy_provider *phy_provider;
+ struct phy *phy;
+ struct resource *res;
+
+ phy_dev = devm_kzalloc(dev, sizeof(*phy_dev), GFP_KERNEL);
+ if (!phy_dev)
+ return -ENOMEM;
+
+ match = of_match_device(stih407_usb2_picophy_of_match, dev);
+ if (!match)
+ return -ENODEV;
+
+ phy_dev->dev = dev;
+ dev_set_drvdata(dev, phy_dev);
+
+ phy_dev->rstc = devm_reset_control_get(dev, "global");
+ if (IS_ERR(phy_dev->rstc)) {
+ dev_err(dev, "failed to ctrl picoPHY reset\n");
+ return PTR_ERR(phy_dev->rstc);
+ }
+
+ phy_dev->rstport = devm_reset_control_get(dev, "port");
+ if (IS_ERR(phy_dev->rstport)) {
+ dev_err(dev, "failed to ctrl picoPHY reset\n");
+ return PTR_ERR(phy_dev->rstport);
+ }
+
+ /* Reset port by default: only deassert it in phy init */
+ reset_control_assert(phy_dev->rstport);
+
+ phy_dev->regmap = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
+ if (IS_ERR(phy_dev->regmap)) {
+ dev_err(dev, "No syscfg phandle specified\n");
+ return PTR_ERR(phy_dev->regmap);
+ }
+
+ res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");
+ if (!res) {
+ dev_err(dev, "No ctrl reg found\n");
+ return -ENXIO;
+ }
+ phy_dev->ctrl = res->start;
+
+ res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "param");
+ if (!res) {
+ dev_err(dev, "No param reg found\n");
+ return -ENXIO;
+ }
+ phy_dev->param = res->start;
+
+ phy = devm_phy_create(dev, NULL, match->data, NULL);
+ if (IS_ERR(phy)) {
+ dev_err(dev, "failed to create Display Port PHY\n");
+ return PTR_ERR(phy);
+ }
+
+ phy_dev->phy = phy;
+ phy_set_drvdata(phy, phy_dev);
+
+ phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
+ if (IS_ERR(phy_provider))
+ return PTR_ERR(phy_provider);
+
+ dev_info(dev, "STiH407 USB Generic picoPHY driver probed!");
+
+ return 0;
+}
+
+static const struct of_device_id stih407_usb2_picophy_of_match[] = {
+ { .compatible = "st,stih407-usb2-phy",
+ .data = &stih407_usb2_picophy_data },
+ { /*sentinel */ },
+};
+
+MODULE_DEVICE_TABLE(of, stih407_usb2_picophy_of_match);
+
+static struct platform_driver stih407_usb2_picophy_driver = {
+ .probe = stih407_usb2_picophy_probe,
+ .driver = {
+ .name = "stih407-usb-genphy",
+ .of_match_table = stih407_usb2_picophy_of_match,
+ }
+};
+
+module_platform_driver(stih407_usb2_picophy_driver);
+
+MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>");
+MODULE_DESCRIPTION("STMicroelectronics Generic picoPHY driver for STiH407");
+MODULE_LICENSE("GPL v2");
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/4] phy: phy-stih407-usb: Add dt documentation for USB picophy found on stih407 SoC family
2014-09-09 9:00 [PATCH v2 0/4] Add picoPHY usb phy driver found on stih407 family SoC's Peter Griffin
2014-09-09 9:00 ` [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family Peter Griffin
@ 2014-09-09 9:00 ` Peter Griffin
2014-09-09 9:00 ` [PATCH v2 3/4] MAINTAINERS: Add phy-stih407-usb.c file to ARCH/STI architecture Peter Griffin
2014-09-09 9:00 ` [PATCH v2 4/4] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
3 siblings, 0 replies; 9+ messages in thread
From: Peter Griffin @ 2014-09-09 9:00 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard
Cc: peter.griffin, lee.jones, peppe.cavallaro, devicetree
This patch adds the dt documentation for the usb picophy found on stih407 SoC family
available from STMicroelectronics.
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
.../devicetree/bindings/phy/phy-stih407-usb.txt | 30 ++++++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-stih407-usb.txt
diff --git a/Documentation/devicetree/bindings/phy/phy-stih407-usb.txt b/Documentation/devicetree/bindings/phy/phy-stih407-usb.txt
new file mode 100644
index 0000000..1ef8228
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/phy-stih407-usb.txt
@@ -0,0 +1,30 @@
+ST STiH407 USB PHY controller
+
+This file documents the dt bindings for the usb picoPHY driver which is the PHY for both USB2 and USB3
+host controllers (when controlling usb2/1.1 devices) available on STiH407 SoC family from STMicroelectronics.
+
+Required properties:
+- compatible : should be "st,stih407-usb2-phy"
+- reg : contain the offset and length of the system configuration registers
+ used as glue logic to control & parameter phy
+- reg-names : the names of the system configuration registers in "reg", should be "param" and "reg"
+- st,syscfg : sysconfig register to manage phy parameter at driver level
+- resets : list of phandle and reset specifier pairs. There should be two entries, one
+ for the whole phy and one for the port
+- reset-names : list of reset signal names. Should be "global" and "port"
+See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt
+See: Documentation/devicetree/bindings/reset/reset.txt
+
+Example:
+
+usb2_picophy0: usbpicophy@f8 {
+ compatible = "st,stih407-usb2-phy";
+ reg = <0xf8 0x04>, /* syscfg 5062 */
+ <0xf4 0x04>; /* syscfg 5061 */
+ reg-names = "param", "ctrl";
+ #phy-cells = <0>;
+ st,syscfg = <&syscfg_core>;
+ resets = <&softreset STIH407_PICOPHY_SOFTRESET>,
+ <&picophyreset STIH407_PICOPHY0_RESET>;
+ reset-names = "global", "port";
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/4] MAINTAINERS: Add phy-stih407-usb.c file to ARCH/STI architecture
2014-09-09 9:00 [PATCH v2 0/4] Add picoPHY usb phy driver found on stih407 family SoC's Peter Griffin
2014-09-09 9:00 ` [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family Peter Griffin
2014-09-09 9:00 ` [PATCH v2 2/4] phy: phy-stih407-usb: Add dt documentation for USB picophy " Peter Griffin
@ 2014-09-09 9:00 ` Peter Griffin
2014-09-09 9:00 ` [PATCH v2 4/4] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
3 siblings, 0 replies; 9+ messages in thread
From: Peter Griffin @ 2014-09-09 9:00 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard
Cc: peter.griffin, lee.jones, peppe.cavallaro, devicetree
This patch adds the new phy-stih407-usb.c usb phy driver found on
STMicroelectronics stih407 consumer electronics SoC's into the STI
arch section of the maintainers file.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index cf24bb5..3ccb4cc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1398,6 +1398,7 @@ F: drivers/media/rc/st_rc.c
F: drivers/i2c/busses/i2c-st.c
F: drivers/tty/serial/st-asc.c
F: drivers/mmc/host/sdhci-st.c
+F: drivers/phy/phy-stih407-usb.c
ARM/TECHNOLOGIC SYSTEMS TS7250 MACHINE SUPPORT
M: Lennert Buytenhek <kernel@wantstofly.org>
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 4/4] ARM: multi_v7_defconfig: Enable stih407 usb picophy
2014-09-09 9:00 [PATCH v2 0/4] Add picoPHY usb phy driver found on stih407 family SoC's Peter Griffin
` (2 preceding siblings ...)
2014-09-09 9:00 ` [PATCH v2 3/4] MAINTAINERS: Add phy-stih407-usb.c file to ARCH/STI architecture Peter Griffin
@ 2014-09-09 9:00 ` Peter Griffin
3 siblings, 0 replies; 9+ messages in thread
From: Peter Griffin @ 2014-09-09 9:00 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard
Cc: peter.griffin, lee.jones, peppe.cavallaro, devicetree
This patch enables the picoPHY usb phy which is used by
the usb2 and usb3 host controllers when controlling usb2/1.1
devices. It is found in stih407 family SoC's from STMicroelectronics.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 5fb95fb..65f4611 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -387,6 +387,7 @@ CONFIG_PWM_VT8500=y
CONFIG_OMAP_USB2=y
CONFIG_TI_PIPE3=y
CONFIG_PHY_MIPHY365X=y
+CONFIG_PHY_STIH407_USB=y
CONFIG_PHY_SUN4I_USB=y
CONFIG_EXT4_FS=y
CONFIG_VFAT_FS=y
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family
2014-09-09 9:00 ` [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family Peter Griffin
@ 2014-09-09 9:08 ` Arnd Bergmann
2014-09-09 10:26 ` Peter Griffin
2014-09-09 11:52 ` Bartlomiej Zolnierkiewicz
1 sibling, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2014-09-09 9:08 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Peter Griffin, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard, peppe.cavallaro, lee.jones,
devicetree
On Tuesday 09 September 2014 10:00:15 Peter Griffin wrote:
> This is the generic phy driver for the picoPHY ports used by the
> USB2 and USB3 Host controllers when controlling usb2/1.1 devices. It
> is found on STiH407 SoC family from STMicroelectronics.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Looks good overall, just one question:
> +
> + match = of_match_device(stih407_usb2_picophy_of_match, dev);
> + if (!match)
> + return -ENODEV;
....
> +
> + phy = devm_phy_create(dev, NULL, match->data, NULL);
> + if (IS_ERR(phy)) {
> + dev_err(dev, "failed to create Display Port PHY\n");
> + return PTR_ERR(phy);
> + }
> +
There is only one entry in the match table, so it always points to
stih407_usb2_picophy_data. Do you have plans to add another set of
operations soon?
If not, just remove the .data pointer and hardcode the operations
in the devm_phy_create call.
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family
2014-09-09 9:08 ` Arnd Bergmann
@ 2014-09-09 10:26 ` Peter Griffin
0 siblings, 0 replies; 9+ messages in thread
From: Peter Griffin @ 2014-09-09 10:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard, peppe.cavallaro, lee.jones,
devicetree
Hi Arnd,
Thanks for reviewing :-)
> > + phy = devm_phy_create(dev, NULL, match->data, NULL);
> > + if (IS_ERR(phy)) {
> > + dev_err(dev, "failed to create Display Port PHY\n");
> > + return PTR_ERR(phy);
> > + }
> > +
>
> There is only one entry in the match table, so it always points to
> stih407_usb2_picophy_data. Do you have plans to add another set of
> operations soon?
Nope.
> If not, just remove the .data pointer and hardcode the operations
> in the devm_phy_create call.
I've done as you suggest in v3 which I will send shortly.
regards,
Peter.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family
2014-09-09 9:00 ` [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family Peter Griffin
2014-09-09 9:08 ` Arnd Bergmann
@ 2014-09-09 11:52 ` Bartlomiej Zolnierkiewicz
2014-09-09 12:05 ` Arnd Bergmann
1 sibling, 1 reply; 9+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-09-09 11:52 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Peter Griffin, linux-kernel, kishon, srinivas.kandagatla,
maxime.coquelin, patrice.chotard, peppe.cavallaro, lee.jones,
devicetree
Hi,
On Tuesday, September 09, 2014 10:00:15 AM Peter Griffin wrote:
> This is the generic phy driver for the picoPHY ports used by the
> USB2 and USB3 Host controllers when controlling usb2/1.1 devices. It
> is found on STiH407 SoC family from STMicroelectronics.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> drivers/phy/Kconfig | 8 ++
> drivers/phy/Makefile | 2 +
> drivers/phy/phy-stih407-usb.c | 185 ++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 195 insertions(+)
> create mode 100644 drivers/phy/phy-stih407-usb.c
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 0dd7427..58018f7 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -230,4 +230,12 @@ config PHY_XGENE
> help
> This option enables support for APM X-Gene SoC multi-purpose PHY.
>
> +config PHY_STIH407_USB
> + tristate "STMicroelectronics USB2 picoPHY driver for STiH407 family"
> + depends on ARCH_STI
> + depends on GENERIC_PHY
I believe that this should use
select GENERIC_PHY
instead (just like all other PHY drivers except PHY_MIPHY365X which
also should be fixed to use select).
> + help
> + Enable this support to enable the picoPHY device used by USB2
> + and USB3 controllers on STMicroelectronics STiH407 SoC families.
> +
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family
2014-09-09 11:52 ` Bartlomiej Zolnierkiewicz
@ 2014-09-09 12:05 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2014-09-09 12:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Bartlomiej Zolnierkiewicz, devicetree, srinivas.kandagatla,
linux-kernel, patrice.chotard, Peter Griffin, peppe.cavallaro,
kishon, lee.jones, maxime.coquelin
On Tuesday 09 September 2014 13:52:54 Bartlomiej Zolnierkiewicz wrote:
> I believe that this should use
>
> select GENERIC_PHY
>
> instead (just like all other PHY drivers except PHY_MIPHY365X which
> also should be fixed to use select).
Right. It would also be good to change 'depends on ARCH_STI'
into 'depends on ARCH_STI || COMPILE_TEST', but only if it
actually compiles on x86.
Note that currently both providers and users of the PHY API
use 'select GENERIC_PHY', which probably not what we want:
only providers (like this one) should 'select' it, while
drivers using this interface could either 'depends on
GENERIC_PHY' or leave out the Kconfig dependency entirely.
Adding 'depends on' for drivers using the interface might
be cleaner, but can result in dependency loops.
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-09 12:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-09 9:00 [PATCH v2 0/4] Add picoPHY usb phy driver found on stih407 family SoC's Peter Griffin
2014-09-09 9:00 ` [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family Peter Griffin
2014-09-09 9:08 ` Arnd Bergmann
2014-09-09 10:26 ` Peter Griffin
2014-09-09 11:52 ` Bartlomiej Zolnierkiewicz
2014-09-09 12:05 ` Arnd Bergmann
2014-09-09 9:00 ` [PATCH v2 2/4] phy: phy-stih407-usb: Add dt documentation for USB picophy " Peter Griffin
2014-09-09 9:00 ` [PATCH v2 3/4] MAINTAINERS: Add phy-stih407-usb.c file to ARCH/STI architecture Peter Griffin
2014-09-09 9:00 ` [PATCH v2 4/4] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).