* [PATCH 1/2] cirrus: add missing drm_connector_register call [not found] <1411114297-13910-1-git-send-email-kraxel@redhat.com> @ 2014-09-19 8:11 ` Gerd Hoffmann 2014-09-19 8:37 ` David Herrmann 2014-09-19 8:11 ` [PATCH 2/2] bochs: " Gerd Hoffmann 1 sibling, 1 reply; 4+ messages in thread From: Gerd Hoffmann @ 2014-09-19 8:11 UTC (permalink / raw) To: airlied; +Cc: Gerd Hoffmann, David Airlie, open list:DRM DRIVERS, open list Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index e1c5c32..c7c5a9d 100644 --- a/drivers/gpu/drm/cirrus/cirrus_mode.c +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c @@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev) drm_connector_helper_add(connector, &cirrus_vga_connector_helper_funcs); + drm_connector_register(connector); return connector; } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] cirrus: add missing drm_connector_register call 2014-09-19 8:11 ` [PATCH 1/2] cirrus: add missing drm_connector_register call Gerd Hoffmann @ 2014-09-19 8:37 ` David Herrmann 2014-09-19 10:19 ` Gerd Hoffmann 0 siblings, 1 reply; 4+ messages in thread From: David Herrmann @ 2014-09-19 8:37 UTC (permalink / raw) To: Gerd Hoffmann; +Cc: Dave Airlie, open list:DRM DRIVERS, open list Hi On Fri, Sep 19, 2014 at 10:11 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c > index e1c5c32..c7c5a9d 100644 > --- a/drivers/gpu/drm/cirrus/cirrus_mode.c > +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c > @@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev) > > drm_connector_helper_add(connector, &cirrus_vga_connector_helper_funcs); > > + drm_connector_register(connector); Error checking? And should probably include "Cc: <stable@vger.kernel.org> # v3.15+". Thanks David > return connector; > } > > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] cirrus: add missing drm_connector_register call 2014-09-19 8:37 ` David Herrmann @ 2014-09-19 10:19 ` Gerd Hoffmann 0 siblings, 0 replies; 4+ messages in thread From: Gerd Hoffmann @ 2014-09-19 10:19 UTC (permalink / raw) To: David Herrmann; +Cc: Dave Airlie, open list:DRM DRIVERS, open list On Fr, 2014-09-19 at 10:37 +0200, David Herrmann wrote: > Hi > > On Fri, Sep 19, 2014 at 10:11 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > --- > > drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c > > index e1c5c32..c7c5a9d 100644 > > --- a/drivers/gpu/drm/cirrus/cirrus_mode.c > > +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c > > @@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev) > > > > drm_connector_helper_add(connector, &cirrus_vga_connector_helper_funcs); > > > > + drm_connector_register(connector); > > Error checking? Hmm, I see plenty of calls like this in the kernel. Also: What should happen on error? The driver itself and cirrusdrmfb works just fine without that, so I don't feel like failing driver initialization because of that, as that would break the console ... > And should probably include "Cc: <stable@vger.kernel.org> # v3.15+". Commit 2ee39452fa2fff1e8edb954ccb7e0daee9646557 (v3.17 merge window) exposes the bug, so stable kernels are working just fine. cheers, Gerd ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] bochs: add missing drm_connector_register call [not found] <1411114297-13910-1-git-send-email-kraxel@redhat.com> 2014-09-19 8:11 ` [PATCH 1/2] cirrus: add missing drm_connector_register call Gerd Hoffmann @ 2014-09-19 8:11 ` Gerd Hoffmann 1 sibling, 0 replies; 4+ messages in thread From: Gerd Hoffmann @ 2014-09-19 8:11 UTC (permalink / raw) To: airlied; +Cc: Gerd Hoffmann, David Airlie, open list:DRM DRIVERS, open list Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- drivers/gpu/drm/bochs/bochs_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index 9d7346b..6b7efcf3 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -250,6 +250,7 @@ static void bochs_connector_init(struct drm_device *dev) DRM_MODE_CONNECTOR_VIRTUAL); drm_connector_helper_add(connector, &bochs_connector_connector_helper_funcs); + drm_connector_register(connector); } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-19 10:19 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1411114297-13910-1-git-send-email-kraxel@redhat.com> 2014-09-19 8:11 ` [PATCH 1/2] cirrus: add missing drm_connector_register call Gerd Hoffmann 2014-09-19 8:37 ` David Herrmann 2014-09-19 10:19 ` Gerd Hoffmann 2014-09-19 8:11 ` [PATCH 2/2] bochs: " Gerd Hoffmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).