From: Feng Wu <feng.wu@intel.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, gleb@kernel.org, pbonzini@redhat.com,
dwmw2@infradead.org, joro@8bytes.org, alex.williamson@redhat.com,
jiang.liu@linux.intel.com
Cc: eric.auger@linaro.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, kvm@vger.kernel.org,
Feng Wu <feng.wu@intel.com>
Subject: [v3 13/26] KVM: Define a new interface kvm_find_dest_vcpu() for VT-d PI
Date: Fri, 12 Dec 2014 23:14:47 +0800 [thread overview]
Message-ID: <1418397300-10870-14-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1418397300-10870-1-git-send-email-feng.wu@intel.com>
This patch defines a new interface kvm_find_dest_vcpu for
VT-d PI, which can returns the destination vCPU of the
interrupt for guests.
Since VT-d PI cannot handle broadcast/multicast interrupt,
Here we only handle Fixed and Lowest priority interrupts.
The current method of handling guest lowest priority interrtups
is to use a counter 'apic_arb_prio' for each vCPU, we choose the
vCPU with smallest 'apic_arb_prio' and then increase it by 1.
However, for VT-d PI, we cannot re-use this, since we no longer
have control to 'apic_arb_prio' with posted interrupt direct
delivery by Hardware.
Here, we introduce a similar way with 'apic_arb_prio' to handle
guest lowest priority interrtups when VT-d PI is used. Here is the
ideas:
- Each vCPU has a counter 'round_robin_counter'.
- When guests sets an interrupts to lowest priority, we choose
the vCPU with smallest 'round_robin_counter' as the destination,
then increase it.
Signed-off-by: Feng Wu <feng.wu@intel.com>
---
arch/x86/include/asm/kvm_host.h | 4 ++++
virt/kvm/irq_comm.c | 41 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+)
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 6ed0c30..7a41808 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -358,6 +358,7 @@ struct kvm_vcpu_arch {
struct kvm_lapic *apic; /* kernel irqchip context */
unsigned long apic_attention;
int32_t apic_arb_prio;
+ int32_t round_robin_counter;
int mp_state;
u64 ia32_misc_enable_msr;
bool tpr_access_reporting;
@@ -1093,4 +1094,7 @@ int kvm_pmu_read_pmc(struct kvm_vcpu *vcpu, unsigned pmc, u64 *data);
void kvm_handle_pmu_event(struct kvm_vcpu *vcpu);
void kvm_deliver_pmi(struct kvm_vcpu *vcpu);
+bool kvm_find_dest_vcpu(struct kvm *kvm, struct kvm_lapic_irq *irq,
+ struct kvm_vcpu **dest_vcpu);
+
#endif /* _ASM_X86_KVM_HOST_H */
diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
index 963b899..f3c5d69 100644
--- a/virt/kvm/irq_comm.c
+++ b/virt/kvm/irq_comm.c
@@ -317,6 +317,47 @@ out:
return r;
}
+int kvm_compare_rr_counter(struct kvm_vcpu *vcpu1, struct kvm_vcpu *vcpu2)
+{
+ return vcpu1->arch.round_robin_counter -
+ vcpu2->arch.round_robin_counter;
+}
+
+bool kvm_find_dest_vcpu(struct kvm *kvm, struct kvm_lapic_irq *irq,
+ struct kvm_vcpu **dest_vcpu)
+{
+ int i, r = 0;
+ struct kvm_vcpu *vcpu, *dest = NULL;
+
+ kvm_for_each_vcpu(i, vcpu, kvm) {
+ if (!kvm_apic_present(vcpu))
+ continue;
+
+ if (!kvm_apic_match_dest(vcpu, NULL, irq->shorthand,
+ irq->dest_id, irq->dest_mode))
+ continue;
+
+ if (!kvm_is_dm_lowest_prio(irq)) {
+ r++;
+ *dest_vcpu = vcpu;
+ } else if (kvm_lapic_enabled(vcpu)) {
+ if (!dest)
+ dest = vcpu;
+ else if (kvm_compare_rr_counter(vcpu, dest) < 0)
+ dest = vcpu;
+ }
+ }
+
+ if (dest) {
+ dest->arch.round_robin_counter++;
+ *dest_vcpu = dest;
+ return true;
+ } else if (r == 1)
+ return true;
+
+ return false;
+}
+
#define IOAPIC_ROUTING_ENTRY(irq) \
{ .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP, \
.u.irqchip = { .irqchip = KVM_IRQCHIP_IOAPIC, .pin = (irq) } }
--
1.9.1
next prev parent reply other threads:[~2014-12-12 15:25 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 15:14 [v3 00/26] Add VT-d Posted-Interrupts support Feng Wu
2014-12-12 15:14 ` [v3 01/26] genirq: Introduce irq_set_vcpu_affinity() to target an interrupt to a VCPU Feng Wu
2014-12-12 15:14 ` [v3 02/26] iommu: Add new member capability to struct irq_remap_ops Feng Wu
2015-01-28 15:22 ` David Woodhouse
2015-01-29 8:34 ` Wu, Feng
2014-12-12 15:14 ` [v3 03/26] iommu, x86: Define new irte structure for VT-d Posted-Interrupts Feng Wu
2015-01-28 15:26 ` David Woodhouse
2014-12-12 15:14 ` [v3 04/26] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip Feng Wu
2015-01-28 15:26 ` David Woodhouse
2015-01-29 7:55 ` Wu, Feng
2014-12-12 15:14 ` [v3 05/26] x86, irq: Implement irq_set_vcpu_affinity for pci_msi_ir_controller Feng Wu
2014-12-12 15:14 ` [v3 06/26] iommu, x86: No need to migrating irq for VT-d Posted-Interrupts Feng Wu
2014-12-18 14:26 ` Zhang, Yang Z
2014-12-19 1:40 ` Wu, Feng
2014-12-19 1:46 ` Zhang, Yang Z
2014-12-19 11:59 ` Paolo Bonzini
2014-12-23 0:37 ` Zhang, Yang Z
2014-12-23 8:47 ` Paolo Bonzini
2014-12-23 9:07 ` Wu, Feng
2014-12-23 9:34 ` Paolo Bonzini
2014-12-24 1:38 ` Zhang, Yang Z
2014-12-24 2:12 ` Jiang Liu
2014-12-24 2:32 ` Zhang, Yang Z
2014-12-24 3:08 ` Wu, Feng
2014-12-24 4:04 ` Zhang, Yang Z
2014-12-24 4:54 ` Jiang Liu
2015-01-28 15:29 ` David Woodhouse
2014-12-12 15:14 ` [v3 07/26] iommu, x86: Add cap_pi_support() to detect VT-d PI capability Feng Wu
2015-01-28 15:32 ` David Woodhouse
2014-12-12 15:14 ` [v3 08/26] iommu, x86: Add intel_irq_remapping_capability() for Intel Feng Wu
2015-01-28 15:37 ` David Woodhouse
2015-01-29 8:57 ` Wu, Feng
2014-12-12 15:14 ` [v3 09/26] iommu, x86: define irq_remapping_cap() Feng Wu
2014-12-12 15:14 ` [v3 10/26] KVM: change struct pi_desc for VT-d Posted-Interrupts Feng Wu
2014-12-12 15:14 ` [v3 11/26] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2014-12-12 15:14 ` [v3 12/26] KVM: Initialize VT-d Posted-Interrupts Descriptor Feng Wu
2014-12-18 15:19 ` Zhang, Yang Z
2014-12-12 15:14 ` Feng Wu [this message]
2014-12-18 14:49 ` [v3 13/26] KVM: Define a new interface kvm_find_dest_vcpu() for VT-d PI Zhang, Yang Z
2014-12-18 16:58 ` Paolo Bonzini
2014-12-19 1:13 ` Zhang, Yang Z
2014-12-19 1:30 ` Wu, Feng
2014-12-19 1:30 ` Wu, Feng
2014-12-19 1:47 ` Zhang, Yang Z
2014-12-19 11:59 ` Paolo Bonzini
2014-12-19 23:48 ` Wu, Feng
2014-12-20 13:16 ` Paolo Bonzini
2014-12-22 4:48 ` Wu, Feng
2014-12-22 9:27 ` Paolo Bonzini
2014-12-22 11:04 ` Wu, Feng
2014-12-22 11:06 ` Paolo Bonzini
2014-12-22 11:17 ` Wu, Feng
2014-12-22 11:23 ` Paolo Bonzini
2014-12-22 14:13 ` Yong Wang
2015-01-09 14:54 ` Radim Krčmář
2015-01-09 14:56 ` Paolo Bonzini
2015-01-09 15:12 ` Radim Krčmář
2015-01-09 15:18 ` Paolo Bonzini
2015-01-09 15:47 ` Radim Krčmář
2015-01-13 0:27 ` Wu, Feng
2015-01-13 16:17 ` Radim Kr?má?
2015-01-14 1:27 ` Wu, Feng
2015-01-14 13:02 ` Paolo Bonzini
2015-01-14 16:59 ` Radim Kr?má?
2015-01-20 21:04 ` Nadav Amit
2015-01-21 21:16 ` Radim Kr?má?
2014-12-12 15:14 ` [v3 14/26] KVM: Get Posted-Interrupts descriptor address from struct kvm_vcpu Feng Wu
2014-12-12 15:14 ` [v3 15/26] KVM: add interfaces to control PI outside vmx Feng Wu
2014-12-12 15:14 ` [v3 16/26] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2014-12-17 16:17 ` Paolo Bonzini
2014-12-19 2:19 ` Wu, Feng
2014-12-19 11:59 ` Paolo Bonzini
2014-12-19 23:39 ` Wu, Feng
2014-12-12 15:14 ` [v3 17/26] KVM: make kvm_set_msi_irq() public Feng Wu
2014-12-17 17:32 ` Paolo Bonzini
2014-12-12 15:14 ` [v3 18/26] KVM: kvm-vfio: User API for VT-d Posted-Interrupts Feng Wu
2014-12-12 15:14 ` [v3 19/26] KVM: kvm-vfio: implement the VFIO skeleton " Feng Wu
2014-12-12 15:14 ` [v3 20/26] KVM: x86: kvm-vfio: VT-d posted-interrupts setup Feng Wu
2014-12-12 15:14 ` [v3 21/26] x86, irq: Define a global vector for VT-d Posted-Interrupts Feng Wu
2014-12-18 14:54 ` Zhang, Yang Z
2014-12-19 0:52 ` Wu, Feng
2015-01-30 18:18 ` H. Peter Anvin
2015-02-02 1:06 ` Wu, Feng
2015-02-23 22:04 ` Marcelo Tosatti
2014-12-12 15:14 ` [v3 22/26] KVM: Define a wakeup worker thread for vCPU Feng Wu
2014-12-12 15:14 ` [v3 23/26] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
2014-12-17 17:11 ` Paolo Bonzini
2014-12-18 3:15 ` Wu, Feng
2014-12-18 8:32 ` Paolo Bonzini
2014-12-19 2:09 ` Wu, Feng
2015-02-23 22:21 ` Marcelo Tosatti
2015-03-02 9:12 ` Wu, Feng
2014-12-12 15:14 ` [v3 24/26] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
2014-12-17 17:09 ` Paolo Bonzini
2014-12-18 3:16 ` Wu, Feng
2014-12-18 8:37 ` Paolo Bonzini
2014-12-19 2:51 ` Wu, Feng
2015-02-25 21:50 ` Marcelo Tosatti
2015-02-26 8:08 ` Wu, Feng
2015-02-26 23:41 ` Marcelo Tosatti
2015-02-26 23:40 ` Marcelo Tosatti
2015-03-02 13:36 ` Wu, Feng
2015-03-04 12:06 ` Marcelo Tosatti
2015-03-06 6:51 ` Wu, Feng
2015-03-12 1:15 ` Marcelo Tosatti
2015-03-16 11:42 ` Wu, Feng
2015-03-25 23:17 ` Marcelo Tosatti
2015-03-27 6:34 ` Wu, Feng
2015-03-27 19:30 ` Marcelo Tosatti
2015-03-30 4:46 ` Wu, Feng
2015-03-30 23:55 ` Marcelo Tosatti
2015-03-31 1:13 ` Wu, Feng
2015-04-14 7:37 ` Wu, Feng
2015-06-05 21:59 ` Marcelo Tosatti
2015-06-08 1:43 ` Wu, Feng
2014-12-12 15:14 ` [v3 25/26] KVM: Suppress posted-interrupt when 'SN' is set Feng Wu
2014-12-17 17:42 ` Paolo Bonzini
2014-12-18 3:14 ` Wu, Feng
2014-12-18 8:38 ` Paolo Bonzini
2014-12-18 15:09 ` Zhang, Yang Z
2014-12-19 2:58 ` Wu, Feng
2014-12-19 3:32 ` Zhang, Yang Z
2014-12-19 4:34 ` Wu, Feng
2014-12-19 4:44 ` Zhang, Yang Z
2014-12-19 4:49 ` Wu, Feng
2014-12-19 5:25 ` Zhang, Yang Z
2014-12-19 5:46 ` Wu, Feng
2014-12-19 7:04 ` Zhang, Yang Z
2014-12-19 12:00 ` Paolo Bonzini
2014-12-19 23:34 ` Wu, Feng
2014-12-12 15:15 ` [v3 26/26] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-01-28 15:39 ` David Woodhouse
2014-12-16 9:04 ` [v3 00/26] Add VT-d Posted-Interrupts support Wu, Feng
2015-01-06 1:10 ` Wu, Feng
2015-01-09 12:46 ` joro
2015-01-09 13:58 ` Wu, Feng
2015-01-21 2:25 ` Wu, Feng
2015-01-28 3:01 ` Wu, Feng
2015-01-28 3:44 ` Alex Williamson
2015-01-28 4:44 ` Wu, Feng
[not found] <1415059685.1337085.1419266271242.JavaMail.zimbra@zmail13.collab.prod.int.phx2.redhat.com>
2014-12-23 0:46 ` [v3 13/26] KVM: Define a new interface kvm_find_dest_vcpu() for VT-d PI Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418397300-10870-14-git-send-email-feng.wu@intel.com \
--to=feng.wu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eric.auger@linaro.org \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).