linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: linux-kernel@vger.kernel.org,
	Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: [PATCH v13 1/6] clk: Remove unneeded NULL checks
Date: Fri, 23 Jan 2015 12:03:28 +0100	[thread overview]
Message-ID: <1422011024-32283-2-git-send-email-tomeu.vizoso@collabora.com> (raw)
In-Reply-To: <1422011024-32283-1-git-send-email-tomeu.vizoso@collabora.com>

As clk_unprepare_unused_subtree and clk_disable_unused_subtree are
always called with a valid struct clk.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/clk.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index f4963b7..97f3425 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -432,9 +432,6 @@ static void clk_unprepare_unused_subtree(struct clk *clk)
 {
 	struct clk *child;
 
-	if (!clk)
-		return;
-
 	hlist_for_each_entry(child, &clk->children, child_node)
 		clk_unprepare_unused_subtree(child);
 
@@ -458,9 +455,6 @@ static void clk_disable_unused_subtree(struct clk *clk)
 	struct clk *child;
 	unsigned long flags;
 
-	if (!clk)
-		goto out;
-
 	hlist_for_each_entry(child, &clk->children, child_node)
 		clk_disable_unused_subtree(child);
 
@@ -486,9 +480,6 @@ static void clk_disable_unused_subtree(struct clk *clk)
 
 unlock_out:
 	clk_enable_unlock(flags);
-
-out:
-	return;
 }
 
 static bool clk_ignore_unused;
-- 
1.9.3


  reply	other threads:[~2015-01-23 11:04 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 11:03 [PATCH v13 0/6] Per-user clock constraints Tomeu Vizoso
2015-01-23 11:03 ` Tomeu Vizoso [this message]
2015-01-23 11:03 ` [PATCH v13 2/6] clk: Remove __clk_register Tomeu Vizoso
2015-01-23 11:03 ` [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances Tomeu Vizoso
2015-02-01 21:24   ` Mike Turquette
2015-02-02 17:04     ` Tony Lindgren
2015-02-02 19:32     ` Tero Kristo
2015-02-02 20:44       ` Tony Lindgren
2015-02-02 22:48         ` Mike Turquette
2015-02-02 23:11           ` Tony Lindgren
2015-02-02 22:41       ` Mike Turquette
2015-02-02 22:52         ` Stephen Boyd
2015-02-03  7:03         ` Tomeu Vizoso
2015-02-03  8:46           ` Tero Kristo
2015-02-03 15:22             ` Tony Lindgren
2015-02-02 20:45     ` Stephen Boyd
2015-02-02 21:31       ` Julia Lawall
2015-02-02 22:35         ` Stephen Boyd
2015-02-02 22:50           ` Mike Turquette
2015-02-03 16:04             ` [Cocci] " Quentin Lambert
2015-02-04 23:26               ` Stephen Boyd
2015-02-05 15:45                 ` Quentin Lambert
2015-02-05 16:02                   ` Quentin Lambert
2015-02-06  1:49                     ` Stephen Boyd
2015-02-06  2:15                   ` Stephen Boyd
2015-02-06  9:01                     ` Quentin Lambert
2015-02-06  9:12                       ` Julia Lawall
2015-02-06 17:15                         ` Stephen Boyd
2015-02-17 22:01                     ` Stephen Boyd
2015-03-12 17:20                       ` Sebastian Andrzej Siewior
2015-03-12 19:43                         ` Stephen Boyd
2015-03-13  3:29                           ` Shawn Guo
2015-03-13  8:20                             ` Sebastian Andrzej Siewior
2015-03-13 13:42                               ` Shawn Guo
2015-03-13 17:42                             ` Stephen Boyd
2015-02-05 19:44   ` Sylwester Nawrocki
2015-02-05 20:06     ` Sylwester Nawrocki
2015-02-05 20:07     ` Stephen Boyd
2015-02-05 22:14       ` Stephen Boyd
2015-02-06  0:42         ` Russell King - ARM Linux
2015-02-06  1:35           ` Stephen Boyd
2015-02-06 13:39             ` Russell King - ARM Linux
2015-02-06 19:30               ` Stephen Boyd
2015-02-06 19:37                 ` Russell King - ARM Linux
2015-02-06 19:41                   ` Stephen Boyd
2015-02-19 21:32                 ` Mike Turquette
2015-02-24 14:08                   ` Russell King - ARM Linux
2015-01-23 11:03 ` [PATCH v13 4/6] clk: Add rate constraints to clocks Tomeu Vizoso
2015-01-29 13:31   ` Geert Uytterhoeven
2015-01-29 19:13     ` Stephen Boyd
2015-01-31  1:31       ` Stephen Boyd
2015-01-31 18:36         ` Tomeu Vizoso
2015-02-01 22:18           ` Mike Turquette
2015-02-02  7:59             ` Geert Uytterhoeven
2015-02-02 16:12               ` Tony Lindgren
2015-02-02 17:46                 ` Mike Turquette
2015-02-02 17:49                   ` Russell King - ARM Linux
2015-02-02 19:21                   ` Tony Lindgren
2015-02-02 20:47                     ` Tony Lindgren
2015-01-23 11:03 ` [PATCH v13 5/6] clkdev: Export clk_register_clkdev Tomeu Vizoso
2015-02-03 17:35   ` Andy Shevchenko
2015-02-03 17:43     ` Andy Shevchenko
2015-01-23 11:03 ` [PATCH v13 6/6] clk: Add module for unit tests Tomeu Vizoso
2015-01-27  0:55 ` [PATCH v13 0/6] Per-user clock constraints Stephen Boyd
2015-01-27  6:29   ` Tomeu Vizoso
2015-01-28  6:59   ` Tomeu Vizoso
     [not found]     ` <20150129022633.22722.78592@quantum>
2015-01-29  6:41       ` Tomeu Vizoso
2015-01-29 14:29         ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422011024-32283-2-git-send-email-tomeu.vizoso@collabora.com \
    --to=tomeu.vizoso@collabora.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).