Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

From: Julia Lawall <julia.lawall@lip6.fr>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	Mike Turquette <mturquette@linaro.org>,
	Julia Lawall <julia.lawall@lip6.fr>,
	Paul Walmsley <paul@pwsan.com>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-kernel@vger.kernel.org, t-kristo@ti.com,
	linux-omap@vger.kernel.org, cocci@systeme.lip6.fr,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances
Date: Fri, 6 Feb 2015 10:12:22 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.10.1502061009320.2538@hadrien> (raw)
In-Reply-To: <54D482EE.6050004@gmail.com>

On Fri, 6 Feb 2015, Quentin Lambert wrote:

>
> On 06/02/2015 03:15, Stephen Boyd wrote:
> > Thanks for the coccinelle patch. Thinking more about it, I don't think
> > we care if the pointer is dereferenced because that would require a
> > definition of struct clk and that is most likely not the case outside of
> > the clock framework. Did you scan the entire kernel?
> No I haven't.
> > I'm running it now
> > but it seems to be taking a while.
> >
> Yes, that's why, as a first step, I chose to limit the scan to the arm
> directory.

Are you sure to be using all of the options provided:

// Options: --recursive-includes --relax-include-path
// Options: --include-headers-for-types

And are you using 1.0.0-rc23 or 1.0.0-rc24?  Those should save parsed
header files so that they don't have to be parsed over and over.

If you are using rc24, then you can use the -j option for parallelism.
But then you should also use an option like --chunksize 10 (I don't know
what number would be good), because the default is chunksize 1, and in
that case the saved parsed header files are not reused, because the fies
are all processed individually.  In general, it is only the files within a
chunk that will share parsed header files.

julia