From: Scott Wood <scottwood@freescale.com>
To: Filip Brozovic <fbrozovic@gmail.com>
Cc: <galak@kernel.crashing.org>, <benh@kernel.crashing.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/83xx: add support for mpc8306
Date: Tue, 31 Mar 2015 12:54:53 -0500 [thread overview]
Message-ID: <1427824493.22867.226.camel@freescale.com> (raw)
In-Reply-To: <1427561968-32049-1-git-send-email-fbrozovic@gmail.com>
On Sat, 2015-03-28 at 17:59 +0100, Filip Brozovic wrote:
> diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
> index c2518cd..f967ff6 100644
> --- a/arch/powerpc/sysdev/qe_lib/qe.c
> +++ b/arch/powerpc/sysdev/qe_lib/qe.c
> @@ -278,12 +278,17 @@ static void qe_snums_init(void)
> 0xF4, 0xF5, 0xFC, 0xFD,
> };
> static const u8 snum_init_46[] = {
> +#if !defined(CONFIG_QE_8306)
> 0x04, 0x05, 0x0C, 0x0D, 0x14, 0x15, 0x1C, 0x1D,
> - 0x24, 0x25, 0x2C, 0x2D, 0x34, 0x35, 0x88, 0x89,
> - 0x98, 0x99, 0xA8, 0xA9, 0xB8, 0xB9, 0xC8, 0xC9,
> - 0xD8, 0xD9, 0xE8, 0xE9, 0x08, 0x09, 0x18, 0x19,
> - 0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
> - 0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
> + 0x24, 0x25, 0x2C, 0x2D, 0x34, 0x35,
> +#endif
> + 0x88, 0x89, 0x98, 0x99, 0xA8, 0xA9, 0xB8, 0xB9,
> + 0xC8, 0xC9, 0xD8, 0xD9, 0xE8, 0xE9,
> +#if !defined(CONFIG_QE_8306)
> + 0x08, 0x09, 0x18, 0x19, 0x28, 0x29, 0x38, 0x39,
> + 0x48, 0x49, 0x58, 0x59, 0x68, 0x69, 0x78, 0x79,
> + 0x80, 0x81,
> +#endif
> };
> static const u8 *snum_init;
This breaks multiplatform support. You need to determine this at
runtime.
-Scott
next prev parent reply other threads:[~2015-03-31 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 16:59 [PATCH] powerpc/83xx: add support for mpc8306 Filip Brozovic
2015-03-31 17:54 ` Scott Wood [this message]
2015-03-31 19:58 ` Filip Brozović
2015-04-02 23:50 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427824493.22867.226.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=fbrozovic@gmail.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).