From: "Filip Brozović" <fbrozovic@gmail.com>
To: Scott Wood <scottwood@freescale.com>
Cc: galak@kernel.crashing.org, benh@kernel.crashing.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/83xx: add support for mpc8306
Date: Tue, 31 Mar 2015 21:58:54 +0200 [thread overview]
Message-ID: <551AFC7E.8090108@gmail.com> (raw)
In-Reply-To: <1427824493.22867.226.camel@freescale.com>
On 3/31/2015 7:54 PM, Scott Wood wrote:
> This breaks multiplatform support. You need to determine this at
> runtime.
Understood, but I'm unsure of how to do this exactly. Would it be
appropriate to define another array, snum_init_14, with the SNUM values
for the MPC8306 QE, change the minimum number of SNUMs in
qe_get_num_of_snums() to 14 and set the correct values this way? In that
case, compatibility with other platforms would be kept intact, and the
QE device tree node for MPC8306 (and MPC8309) boards would just have to
have the fsl,qe-num-snums property set to 14 in order for the driver to
set the correct values.
next prev parent reply other threads:[~2015-03-31 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 16:59 [PATCH] powerpc/83xx: add support for mpc8306 Filip Brozovic
2015-03-31 17:54 ` Scott Wood
2015-03-31 19:58 ` Filip Brozović [this message]
2015-04-02 23:50 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AFC7E.8090108@gmail.com \
--to=fbrozovic@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).