From: Joe Perches <joe@perches.com>
To: Jason Low <jason.low2@hp.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH V2 19/25] sched: Use bool function return values of true/false not 1/0
Date: Tue, 31 Mar 2015 22:46:26 -0700 [thread overview]
Message-ID: <1427867186.18175.60.camel@perches.com> (raw)
In-Reply-To: <CAGQ1y=5742GKZx7YWOMnD+wuVy7zX=sirUYVipHYw7fzjP66xw@mail.gmail.com>
Use the normal return values for bool functions
Update the other sets of ret in try_wait_for_completion.
Signed-off-by: Joe Perches <joe@perches.com>
---
On Tue, 2015-03-31 at 22:17 -0700, Jason Low wrote:
> On Mon, Mar 30, 2015 at 4:46 PM, Joe Perches <joe@perches.com> wrote:
>
> > * try_wait_for_completion - try to decrement a completion without blocking
> > * @x: completion structure
> > *
> > - * Return: 0 if a decrement cannot be done without blocking
> > - * 1 if a decrement succeeded.
> > + * Return: true if a decrement cannot be done without blocking
> > + * false if a decrement succeeded.
> The boolean logic was reversed in this comment. The function should be
> returning false if a decrement cannot be done without blocking, and
> true if a decrement succeeded.
Hi Jason, right, my typo, thanks for noticing.
kernel/sched/auto_group.h | 2 +-
kernel/sched/completion.c | 16 +++++++++-------
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/kernel/sched/auto_group.h b/kernel/sched/auto_group.h
index 8bd0471..309b6f2 100644
--- a/kernel/sched/auto_group.h
+++ b/kernel/sched/auto_group.h
@@ -45,7 +45,7 @@ static inline void autogroup_init(struct task_struct *init_task) { }
static inline void autogroup_free(struct task_group *tg) { }
static inline bool task_group_is_autogroup(struct task_group *tg)
{
- return 0;
+ return false;
}
static inline struct task_group *
diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c
index 8d0f35d..cbccaa0 100644
--- a/kernel/sched/completion.c
+++ b/kernel/sched/completion.c
@@ -255,8 +255,8 @@ EXPORT_SYMBOL(wait_for_completion_killable_timeout);
* try_wait_for_completion - try to decrement a completion without blocking
* @x: completion structure
*
- * Return: 0 if a decrement cannot be done without blocking
- * 1 if a decrement succeeded.
+ * Return: false if a decrement cannot be done without blocking
+ * true if a decrement succeeded.
*
* If a completion is being used as a counting completion,
* attempt to decrement the counter without blocking. This
@@ -266,7 +266,7 @@ EXPORT_SYMBOL(wait_for_completion_killable_timeout);
bool try_wait_for_completion(struct completion *x)
{
unsigned long flags;
- int ret = 1;
+ bool ret;
/*
* Since x->done will need to be locked only
@@ -275,13 +275,15 @@ bool try_wait_for_completion(struct completion *x)
* return early in the blocking case.
*/
if (!READ_ONCE(x->done))
- return 0;
+ return false;
spin_lock_irqsave(&x->wait.lock, flags);
- if (!x->done)
- ret = 0;
- else
+ if (!x->done) {
+ ret = false;
+ } else {
x->done--;
+ ret = true;
+ }
spin_unlock_irqrestore(&x->wait.lock, flags);
return ret;
}
next prev parent reply other threads:[~2015-04-01 5:46 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
2015-03-31 15:54 ` Tony Lindgren
2015-03-31 15:58 ` Paolo Bonzini
2015-03-31 16:05 ` Marc Zyngier
2015-03-30 23:46 ` [PATCH 02/25] arm64: " Joe Perches
2015-03-31 15:29 ` Will Deacon
2015-03-30 23:46 ` [PATCH 03/25] hexagon: " Joe Perches
2015-03-30 23:46 ` [PATCH 04/25] ia64: " Joe Perches
2015-03-30 23:46 ` [PATCH 05/25] mips: " Joe Perches
2015-03-30 23:46 ` [PATCH 06/25] powerpc: " Joe Perches
2015-03-31 1:49 ` Benjamin Herrenschmidt
2015-03-31 1:57 ` Joe Perches
2015-03-30 23:46 ` [PATCH 07/25] s390: " Joe Perches
2015-03-31 7:13 ` Heiko Carstens
2015-03-30 23:46 ` [PATCH 08/25] sparc: " Joe Perches
2015-03-30 23:46 ` [PATCH 09/25] tile: " Joe Perches
2015-03-30 23:46 ` [PATCH 10/25] unicore32: " Joe Perches
2015-03-30 23:46 ` [PATCH 11/25] x86: " Joe Perches
2015-03-31 16:05 ` Paolo Bonzini
2015-03-30 23:46 ` [PATCH 12/25] virtio_console: " Joe Perches
2015-03-31 5:32 ` Amit Shah
2015-03-30 23:46 ` [PATCH 13/25] csiostor: " Joe Perches
2015-03-30 23:46 ` [PATCH 14/25] dcache: " Joe Perches
2015-03-30 23:46 ` [PATCH 15/25] nfsd: nfs4state: " Joe Perches
2015-03-30 23:46 ` [PATCH 16/25] include/linux: " Joe Perches
2015-03-31 7:41 ` Lee Jones
2015-04-06 19:39 ` Sebastian Reichel
2015-03-30 23:46 ` [PATCH 17/25] sound: " Joe Perches
2015-03-31 7:11 ` Mark Brown
2015-03-30 23:46 ` [PATCH 18/25] rcu: tree_plugin: " Joe Perches
2015-03-30 23:46 ` [PATCH 19/25] sched: " Joe Perches
2015-03-31 8:53 ` Peter Zijlstra
2015-03-31 9:03 ` Ingo Molnar
2015-03-31 16:46 ` Joe Perches
2015-04-01 6:58 ` Peter Zijlstra
2015-04-07 9:12 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Ingo Molnar
2015-04-07 9:27 ` Ingo Molnar
2015-04-07 9:36 ` about the flood of trivial patches and the Code of Conflict " Ingo Molnar
2015-04-07 9:39 ` Ingo Molnar
2015-04-07 11:00 ` about the flood of trivial patches and the Code of Conduct " Greg Kroah-Hartman
2015-04-07 11:18 ` Ingo Molnar
2015-04-07 11:27 ` Peter Zijlstra
2015-04-07 13:21 ` about the flood of trivial patches and the Code of Conduct Peter Hurley
2015-04-07 11:28 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Richard Weinberger
2015-04-07 11:32 ` Peter Zijlstra
2015-04-07 11:50 ` about the flood of trivial patches and the Code of Conduct Richard Weinberger
2015-04-07 13:21 ` Steven Rostedt
2015-04-07 13:28 ` Richard Weinberger
2015-04-07 12:31 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Rafael J. Wysocki
2015-04-07 13:28 ` Steven Rostedt
2015-04-08 23:37 ` Rafael J. Wysocki
2015-04-09 0:04 ` Joe Perches
2015-04-13 12:17 ` One Thousand Gnomes
2015-04-08 3:22 ` Theodore Ts'o
2015-04-07 12:35 ` Joe Perches
2015-03-31 9:09 ` [PATCH 19/25] sched: Use bool function return values of true/false not 1/0 Joe Perches
2015-04-01 5:17 ` Jason Low
2015-04-01 5:46 ` Joe Perches [this message]
2015-03-30 23:46 ` [PATCH 20/25] ftrace: " Joe Perches
2015-03-30 23:46 ` [PATCH 21/25] slub: " Joe Perches
2015-04-01 3:29 ` David Rientjes
2015-03-30 23:46 ` [PATCH 22/25] bridge: " Joe Perches
2015-03-30 23:46 ` [PATCH 23/25] netfilter: " Joe Perches
2015-03-31 16:58 ` Pablo Neira Ayuso
2015-03-30 23:46 ` [PATCH 24/25] security: " Joe Perches
2015-03-31 6:03 ` John Johansen
2015-03-30 23:46 ` [PATCH 25/25] sound: wm5100-tables: " Joe Perches
2015-04-01 11:54 ` Charles Keepax
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
2015-03-31 0:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427867186.18175.60.camel@perches.com \
--to=joe@perches.com \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).