From: Ingo Molnar <mingo@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Joe Perches <joe@perches.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0)
Date: Tue, 7 Apr 2015 13:18:56 +0200 [thread overview]
Message-ID: <20150407111855.GD14136@gmail.com> (raw)
In-Reply-To: <20150407110049.GA11218@kroah.com>
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Tue, Apr 07, 2015 at 11:12:46AM +0200, Ingo Molnar wrote:
> > Pointing out this truth and protecting against such abusive flood of
> > trivial patches is not against the code of conduct I signed.
>
> I totally agree, it's not "against" the code of conflict that I
> helped write.
>
> Joe, you know better than to send trivial stuff to maintainers who
> don't want it. Send it through the trivial maintainer for
> subsystems that have expressed annoyance at this, it's not the first
> time this has happened.
I argue that they should not be sent _at all_ in such cases, not even
via the trivial tree: firstly because typically I'll pick up the bits
from the trivial tree as well, and secondly because most of the
arguments I listed against bulk trivial commits (weaker bisectability,
taking up reviewer bandwidth, taking up Git space, etc.) still stand.
Frankly IMHO such a */25 series could be a net negative contribution
when coming from a kernel contributor who has written 2000+ trivial
patches already...
> Some maintainers, like me, are fine with your types of patches, I'd
> stick to those subsystems if you like doing this type of work.
So sending trivial patches for things like totally unreadable code in
say drivers/staging/ is probably OK, as they materially transform the
code and make it more maintainable.
For the rest it can be more harmful than beneficial, for the reasons I
outlined.
Thanks,
Ingo
next prev parent reply other threads:[~2015-04-07 11:19 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
2015-03-31 15:54 ` Tony Lindgren
2015-03-31 15:58 ` Paolo Bonzini
2015-03-31 16:05 ` Marc Zyngier
2015-03-30 23:46 ` [PATCH 02/25] arm64: " Joe Perches
2015-03-31 15:29 ` Will Deacon
2015-03-30 23:46 ` [PATCH 03/25] hexagon: " Joe Perches
2015-03-30 23:46 ` [PATCH 04/25] ia64: " Joe Perches
2015-03-30 23:46 ` [PATCH 05/25] mips: " Joe Perches
2015-03-30 23:46 ` [PATCH 06/25] powerpc: " Joe Perches
2015-03-31 1:49 ` Benjamin Herrenschmidt
2015-03-31 1:57 ` Joe Perches
2015-03-30 23:46 ` [PATCH 07/25] s390: " Joe Perches
2015-03-31 7:13 ` Heiko Carstens
2015-03-30 23:46 ` [PATCH 08/25] sparc: " Joe Perches
2015-03-30 23:46 ` [PATCH 09/25] tile: " Joe Perches
2015-03-30 23:46 ` [PATCH 10/25] unicore32: " Joe Perches
2015-03-30 23:46 ` [PATCH 11/25] x86: " Joe Perches
2015-03-31 16:05 ` Paolo Bonzini
2015-03-30 23:46 ` [PATCH 12/25] virtio_console: " Joe Perches
2015-03-31 5:32 ` Amit Shah
2015-03-30 23:46 ` [PATCH 13/25] csiostor: " Joe Perches
2015-03-30 23:46 ` [PATCH 14/25] dcache: " Joe Perches
2015-03-30 23:46 ` [PATCH 15/25] nfsd: nfs4state: " Joe Perches
2015-03-30 23:46 ` [PATCH 16/25] include/linux: " Joe Perches
2015-03-31 7:41 ` Lee Jones
2015-04-06 19:39 ` Sebastian Reichel
2015-03-30 23:46 ` [PATCH 17/25] sound: " Joe Perches
2015-03-31 7:11 ` Mark Brown
2015-03-30 23:46 ` [PATCH 18/25] rcu: tree_plugin: " Joe Perches
2015-03-30 23:46 ` [PATCH 19/25] sched: " Joe Perches
2015-03-31 8:53 ` Peter Zijlstra
2015-03-31 9:03 ` Ingo Molnar
2015-03-31 16:46 ` Joe Perches
2015-04-01 6:58 ` Peter Zijlstra
2015-04-07 9:12 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Ingo Molnar
2015-04-07 9:27 ` Ingo Molnar
2015-04-07 9:36 ` about the flood of trivial patches and the Code of Conflict " Ingo Molnar
2015-04-07 9:39 ` Ingo Molnar
2015-04-07 11:00 ` about the flood of trivial patches and the Code of Conduct " Greg Kroah-Hartman
2015-04-07 11:18 ` Ingo Molnar [this message]
2015-04-07 11:27 ` Peter Zijlstra
2015-04-07 13:21 ` about the flood of trivial patches and the Code of Conduct Peter Hurley
2015-04-07 11:28 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Richard Weinberger
2015-04-07 11:32 ` Peter Zijlstra
2015-04-07 11:50 ` about the flood of trivial patches and the Code of Conduct Richard Weinberger
2015-04-07 13:21 ` Steven Rostedt
2015-04-07 13:28 ` Richard Weinberger
2015-04-07 12:31 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Rafael J. Wysocki
2015-04-07 13:28 ` Steven Rostedt
2015-04-08 23:37 ` Rafael J. Wysocki
2015-04-09 0:04 ` Joe Perches
2015-04-13 12:17 ` One Thousand Gnomes
2015-04-08 3:22 ` Theodore Ts'o
2015-04-07 12:35 ` Joe Perches
2015-03-31 9:09 ` [PATCH 19/25] sched: Use bool function return values of true/false not 1/0 Joe Perches
2015-04-01 5:17 ` Jason Low
2015-04-01 5:46 ` [PATCH V2 " Joe Perches
2015-03-30 23:46 ` [PATCH 20/25] ftrace: " Joe Perches
2015-03-30 23:46 ` [PATCH 21/25] slub: " Joe Perches
2015-04-01 3:29 ` David Rientjes
2015-03-30 23:46 ` [PATCH 22/25] bridge: " Joe Perches
2015-03-30 23:46 ` [PATCH 23/25] netfilter: " Joe Perches
2015-03-31 16:58 ` Pablo Neira Ayuso
2015-03-30 23:46 ` [PATCH 24/25] security: " Joe Perches
2015-03-31 6:03 ` John Johansen
2015-03-30 23:46 ` [PATCH 25/25] sound: wm5100-tables: " Joe Perches
2015-04-01 11:54 ` Charles Keepax
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
2015-03-31 0:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407111855.GD14136@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).