From: Marc Zyngier <marc.zyngier@arm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Joe Perches <joe@perches.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoffer Dall <christoffer.dall@linaro.org>,
Gleb Natapov <gleb@kernel.org>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 01/25] arm: Use bool function return values of true/false not 1/0
Date: Tue, 31 Mar 2015 17:05:30 +0100 [thread overview]
Message-ID: <20150331170530.0479b9ab@arm.com> (raw)
In-Reply-To: <551AC424.9010802@redhat.com>
On Tue, 31 Mar 2015 16:58:28 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 31/03/2015 01:45, Joe Perches wrote:
> > Use the normal return values for bool functions
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > arch/arm/include/asm/dma-mapping.h | 8 ++++----
> > arch/arm/include/asm/kvm_emulate.h | 2 +-
> > arch/arm/mach-omap2/powerdomain.c | 14 +++++++-------
> > 3 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> > index b52101d..166e1e1 100644
> > --- a/arch/arm/include/asm/dma-mapping.h
> > +++ b/arch/arm/include/asm/dma-mapping.h
> > @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> > u64 limit, mask;
> >
> > if (!dev->dma_mask)
> > - return 0;
> > + return false;
> >
> > mask = *dev->dma_mask;
> >
> > limit = (mask + 1) & ~mask;
> > if (limit && size > limit)
> > - return 0;
> > + return false;
> >
> > if ((addr | (addr + size - 1)) & ~mask)
> > - return 0;
> > + return false;
> >
> > - return 1;
> > + return true;
> > }
> >
> > static inline void dma_mark_clean(void *addr, size_t size) { }
> > diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h
> > index a9c80a2..ad200a0 100644
> > --- a/arch/arm/include/asm/kvm_emulate.h
> > +++ b/arch/arm/include/asm/kvm_emulate.h
> > @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr)
> >
> > static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu)
> > {
> > - return 1;
> > + return true;
> > }
> >
> > static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu)
> > diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> > index 78af6d8..897f9fb 100644
> > --- a/arch/arm/mach-omap2/powerdomain.c
> > +++ b/arch/arm/mach-omap2/powerdomain.c
> > @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm)
> > */
> > bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
> > {
> > - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0;
> > + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR);
> > }
> >
> > int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
> > @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm)
> > if (!pwrdm) {
> > pr_debug("powerdomain: %s: invalid powerdomain pointer\n",
> > __func__);
> > - return 1;
> > + return true;
> > }
> >
> > if (pwrdm->pwrsts & PWRSTS_OFF)
> > - return 1;
> > + return true;
> >
> > if (pwrdm->pwrsts & PWRSTS_RET) {
> > if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF)
> > - return 1;
> > + return true;
> >
> > for (i = 0; i < pwrdm->banks; i++)
> > if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF)
> > - return 1;
> > + return true;
> > }
> >
> > for (i = 0; i < pwrdm->banks; i++)
> > if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF)
> > - return 1;
> > + return true;
> >
> > - return 0;
> > + return false;
> > }
> >
>
> Marc/Christoffer, please pick this up yourself.
Given that it touches a range of completely unrelated files, for the
KVM part:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2015-03-31 16:06 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:45 ` [PATCH 01/25] arm: " Joe Perches
2015-03-31 15:54 ` Tony Lindgren
2015-03-31 15:58 ` Paolo Bonzini
2015-03-31 16:05 ` Marc Zyngier [this message]
2015-03-30 23:46 ` [PATCH 02/25] arm64: " Joe Perches
2015-03-31 15:29 ` Will Deacon
2015-03-30 23:46 ` [PATCH 03/25] hexagon: " Joe Perches
2015-03-30 23:46 ` [PATCH 04/25] ia64: " Joe Perches
2015-03-30 23:46 ` [PATCH 05/25] mips: " Joe Perches
2015-03-30 23:46 ` [PATCH 06/25] powerpc: " Joe Perches
2015-03-31 1:49 ` Benjamin Herrenschmidt
2015-03-31 1:57 ` Joe Perches
2015-03-30 23:46 ` [PATCH 07/25] s390: " Joe Perches
2015-03-31 7:13 ` Heiko Carstens
2015-03-30 23:46 ` [PATCH 08/25] sparc: " Joe Perches
2015-03-30 23:46 ` [PATCH 09/25] tile: " Joe Perches
2015-03-30 23:46 ` [PATCH 10/25] unicore32: " Joe Perches
2015-03-30 23:46 ` [PATCH 11/25] x86: " Joe Perches
2015-03-31 16:05 ` Paolo Bonzini
2015-03-30 23:46 ` [PATCH 12/25] virtio_console: " Joe Perches
2015-03-31 5:32 ` Amit Shah
2015-03-30 23:46 ` [PATCH 13/25] csiostor: " Joe Perches
2015-03-30 23:46 ` [PATCH 14/25] dcache: " Joe Perches
2015-03-30 23:46 ` [PATCH 15/25] nfsd: nfs4state: " Joe Perches
2015-03-30 23:46 ` [PATCH 16/25] include/linux: " Joe Perches
2015-03-31 7:41 ` Lee Jones
2015-04-06 19:39 ` Sebastian Reichel
2015-03-30 23:46 ` [PATCH 17/25] sound: " Joe Perches
2015-03-31 7:11 ` Mark Brown
2015-03-30 23:46 ` [PATCH 18/25] rcu: tree_plugin: " Joe Perches
2015-03-30 23:46 ` [PATCH 19/25] sched: " Joe Perches
2015-03-31 8:53 ` Peter Zijlstra
2015-03-31 9:03 ` Ingo Molnar
2015-03-31 16:46 ` Joe Perches
2015-04-01 6:58 ` Peter Zijlstra
2015-04-07 9:12 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Ingo Molnar
2015-04-07 9:27 ` Ingo Molnar
2015-04-07 9:36 ` about the flood of trivial patches and the Code of Conflict " Ingo Molnar
2015-04-07 9:39 ` Ingo Molnar
2015-04-07 11:00 ` about the flood of trivial patches and the Code of Conduct " Greg Kroah-Hartman
2015-04-07 11:18 ` Ingo Molnar
2015-04-07 11:27 ` Peter Zijlstra
2015-04-07 13:21 ` about the flood of trivial patches and the Code of Conduct Peter Hurley
2015-04-07 11:28 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Richard Weinberger
2015-04-07 11:32 ` Peter Zijlstra
2015-04-07 11:50 ` about the flood of trivial patches and the Code of Conduct Richard Weinberger
2015-04-07 13:21 ` Steven Rostedt
2015-04-07 13:28 ` Richard Weinberger
2015-04-07 12:31 ` about the flood of trivial patches and the Code of Conduct (was: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0) Rafael J. Wysocki
2015-04-07 13:28 ` Steven Rostedt
2015-04-08 23:37 ` Rafael J. Wysocki
2015-04-09 0:04 ` Joe Perches
2015-04-13 12:17 ` One Thousand Gnomes
2015-04-08 3:22 ` Theodore Ts'o
2015-04-07 12:35 ` Joe Perches
2015-03-31 9:09 ` [PATCH 19/25] sched: Use bool function return values of true/false not 1/0 Joe Perches
2015-04-01 5:17 ` Jason Low
2015-04-01 5:46 ` [PATCH V2 " Joe Perches
2015-03-30 23:46 ` [PATCH 20/25] ftrace: " Joe Perches
2015-03-30 23:46 ` [PATCH 21/25] slub: " Joe Perches
2015-04-01 3:29 ` David Rientjes
2015-03-30 23:46 ` [PATCH 22/25] bridge: " Joe Perches
2015-03-30 23:46 ` [PATCH 23/25] netfilter: " Joe Perches
2015-03-31 16:58 ` Pablo Neira Ayuso
2015-03-30 23:46 ` [PATCH 24/25] security: " Joe Perches
2015-03-31 6:03 ` John Johansen
2015-03-30 23:46 ` [PATCH 25/25] sound: wm5100-tables: " Joe Perches
2015-04-01 11:54 ` Charles Keepax
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
2015-03-31 0:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331170530.0479b9ab@arm.com \
--to=marc.zyngier@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=gleb@kernel.org \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pbonzini@redhat.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).