[PATCH] phy: ulpi_phy: Add const qualifier to ops

[PATCH] phy: ulpi_phy: Add const qualifier to ops

[Axel Lin]

The ops is never changed in ulpi_phy_create(), so make it const.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/phy/ulpi_phy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h
index ac49fb6..f2ebe49 100644
--- a/drivers/phy/ulpi_phy.h
+++ b/drivers/phy/ulpi_phy.h
@@ -5,7 +5,7 @@
  * and it's controller, which is always the parent.
  */
 static inline struct phy
-*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops)
+*ulpi_phy_create(struct ulpi *ulpi, const struct phy_ops *ops)
 {
 	struct phy *phy;
 	int ret;
-- 
2.1.0

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

[Axel Lin]

2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> The ops is never changed in ulpi_phy_create(), so make it const.

Hi Kishon,

Would you pick up this patch?
Without this patch, passing a const struct phy_ops* to ulip_phy_create will
have compiler warning.
It should be fine to pass a const struct phy_ops* to ulip_phy_create and
since the drivers usually never change phy_ops after initialized,
it can be const.

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

[Kishon Vijay Abraham I]

Hi Axel,

On Wednesday 15 July 2015 12:40 PM, Axel Lin wrote:
> 2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
>> The ops is never changed in ulpi_phy_create(), so make it const.
> 
> Hi Kishon,
> 
> Would you pick up this patch?

yes.. I'll take once I start queuing the patches.

Thanks
Kishon