* [PATCH] ARM: dts: vf610: Extend I2C support to all available buses.
@ 2015-06-15 0:19 Cory Tusar
2015-06-16 8:50 ` Stefan Agner
2015-07-08 9:17 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Cory Tusar @ 2015-06-15 0:19 UTC (permalink / raw)
To: shawn.guo, kernel, stefan
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
linux-arm-kernel, devicetree, linux-kernel, andrew, Cory Tusar
This commit extends the existing Vybrid I2C support to cover buses i2c1,
i2c2, and i2c3. Based in (very) large part on an initial patch by
Stefan Agner that was just lacking a couple of DMA assignments.
Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
---
arch/arm/boot/dts/vfxxx.dtsi | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 4aa3351..25f2615 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi
@@ -347,6 +347,20 @@
status = "disabled";
};
+ i2c1: i2c@40067000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,vf610-i2c";
+ reg = <0x40067000 0x1000>;
+ interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks VF610_CLK_I2C1>;
+ clock-names = "ipg";
+ dmas = <&edma0 0 52>,
+ <&edma0 0 53>;
+ dma-names = "rx","tx";
+ status = "disabled";
+ };
+
clks: ccm@4006b000 {
compatible = "fsl,vf610-ccm";
reg = <0x4006b000 0x1000>;
@@ -520,6 +534,33 @@
status = "disabled";
};
+ i2c2: i2c@400e6000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,vf610-i2c";
+ reg = <0x400e6000 0x1000>;
+ interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks VF610_CLK_I2C2>;
+ clock-names = "ipg";
+ dmas = <&edma0 1 36>,
+ <&edma0 1 37>;
+ dma-names = "rx","tx";
+ status = "disabled";
+ };
+
+ i2c3: i2c@400e7000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,vf610-i2c";
+ reg = <0x400e7000 0x1000>;
+ interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks VF610_CLK_I2C3>;
+ clock-names = "ipg";
+ dmas = <&edma0 1 38>,
+ <&edma0 1 39>;
+ dma-names = "rx","tx";
+ status = "disabled";
+ };
};
};
};
--
2.3.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Extend I2C support to all available buses.
2015-06-15 0:19 [PATCH] ARM: dts: vf610: Extend I2C support to all available buses Cory Tusar
@ 2015-06-16 8:50 ` Stefan Agner
2015-06-30 2:20 ` Cory Tusar
2015-07-08 9:17 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Agner @ 2015-06-16 8:50 UTC (permalink / raw)
To: Cory Tusar
Cc: shawn.guo, kernel, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, linux-arm-kernel, devicetree,
linux-kernel, andrew
On 2015-06-15 02:19, Cory Tusar wrote:
> This commit extends the existing Vybrid I2C support to cover buses i2c1,
> i2c2, and i2c3. Based in (very) large part on an initial patch by
> Stefan Agner that was just lacking a couple of DMA assignments.
>
> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
Thx Cory for picking that up.
So with that patch we use the second Mux of DMA0 the first time. Another
option would have been to use the first Mux of DMA1, however I think its
better to leave DMA1 for dedicated purposes or the secondary Cortex-M4
core... If a board needs different configuration, one would also have
the option to overwrite the properties.
Acked-by: Stefan Agner <stefan@agner.ch>
--
Stefan
> ---
> arch/arm/boot/dts/vfxxx.dtsi | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..25f2615 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -347,6 +347,20 @@
> status = "disabled";
> };
>
> + i2c1: i2c@40067000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,vf610-i2c";
> + reg = <0x40067000 0x1000>;
> + interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_I2C1>;
> + clock-names = "ipg";
> + dmas = <&edma0 0 52>,
> + <&edma0 0 53>;
> + dma-names = "rx","tx";
> + status = "disabled";
> + };
> +
> clks: ccm@4006b000 {
> compatible = "fsl,vf610-ccm";
> reg = <0x4006b000 0x1000>;
> @@ -520,6 +534,33 @@
> status = "disabled";
> };
>
> + i2c2: i2c@400e6000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,vf610-i2c";
> + reg = <0x400e6000 0x1000>;
> + interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_I2C2>;
> + clock-names = "ipg";
> + dmas = <&edma0 1 36>,
> + <&edma0 1 37>;
> + dma-names = "rx","tx";
> + status = "disabled";
> + };
> +
> + i2c3: i2c@400e7000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,vf610-i2c";
> + reg = <0x400e7000 0x1000>;
> + interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_I2C3>;
> + clock-names = "ipg";
> + dmas = <&edma0 1 38>,
> + <&edma0 1 39>;
> + dma-names = "rx","tx";
> + status = "disabled";
> + };
> };
> };
> };
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Extend I2C support to all available buses.
2015-06-16 8:50 ` Stefan Agner
@ 2015-06-30 2:20 ` Cory Tusar
0 siblings, 0 replies; 4+ messages in thread
From: Cory Tusar @ 2015-06-30 2:20 UTC (permalink / raw)
To: Stefan Agner
Cc: shawn.guo, kernel, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, linux-arm-kernel, devicetree,
linux-kernel, andrew
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/16/2015 04:50 AM, Stefan Agner wrote:
> On 2015-06-15 02:19, Cory Tusar wrote:
>> This commit extends the existing Vybrid I2C support to cover buses i2c1,
>> i2c2, and i2c3. Based in (very) large part on an initial patch by
>> Stefan Agner that was just lacking a couple of DMA assignments.
>>
>> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
>
> Thx Cory for picking that up.
>
> So with that patch we use the second Mux of DMA0 the first time. Another
> option would have been to use the first Mux of DMA1, however I think its
> better to leave DMA1 for dedicated purposes or the secondary Cortex-M4
> core... If a board needs different configuration, one would also have
> the option to overwrite the properties.
>
> Acked-by: Stefan Agner <stefan@agner.ch>
Just a status check on this...any additional comments?
Regards,
- -Cory
>> ---
>> arch/arm/boot/dts/vfxxx.dtsi | 41 +++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 41 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
>> index 4aa3351..25f2615 100644
>> --- a/arch/arm/boot/dts/vfxxx.dtsi
>> +++ b/arch/arm/boot/dts/vfxxx.dtsi
>> @@ -347,6 +347,20 @@
>> status = "disabled";
>> };
>>
>> + i2c1: i2c@40067000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "fsl,vf610-i2c";
>> + reg = <0x40067000 0x1000>;
>> + interrupts = <72 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks VF610_CLK_I2C1>;
>> + clock-names = "ipg";
>> + dmas = <&edma0 0 52>,
>> + <&edma0 0 53>;
>> + dma-names = "rx","tx";
>> + status = "disabled";
>> + };
>> +
>> clks: ccm@4006b000 {
>> compatible = "fsl,vf610-ccm";
>> reg = <0x4006b000 0x1000>;
>> @@ -520,6 +534,33 @@
>> status = "disabled";
>> };
>>
>> + i2c2: i2c@400e6000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "fsl,vf610-i2c";
>> + reg = <0x400e6000 0x1000>;
>> + interrupts = <73 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks VF610_CLK_I2C2>;
>> + clock-names = "ipg";
>> + dmas = <&edma0 1 36>,
>> + <&edma0 1 37>;
>> + dma-names = "rx","tx";
>> + status = "disabled";
>> + };
>> +
>> + i2c3: i2c@400e7000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "fsl,vf610-i2c";
>> + reg = <0x400e7000 0x1000>;
>> + interrupts = <74 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks VF610_CLK_I2C3>;
>> + clock-names = "ipg";
>> + dmas = <&edma0 1 38>,
>> + <&edma0 1 39>;
>> + dma-names = "rx","tx";
>> + status = "disabled";
>> + };
>> };
>> };
>> };
>
- --
Cory Tusar
Principal
PID 1 Solutions, Inc.
"There are two ways of constructing a software design. One way is to
make it so simple that there are obviously no deficiencies, and the
other way is to make it so complicated that there are no obvious
deficiencies." --Sir Charles Anthony Richard Hoare
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlWR/O0ACgkQHT1tsfGwHJ9+zgCfRPTTiszNMsDy8nVnfdjIYGGO
iv0An2go86s+1hbrpAF1VbpCrKmYqF0J
=EatS
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: vf610: Extend I2C support to all available buses.
2015-06-15 0:19 [PATCH] ARM: dts: vf610: Extend I2C support to all available buses Cory Tusar
2015-06-16 8:50 ` Stefan Agner
@ 2015-07-08 9:17 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2015-07-08 9:17 UTC (permalink / raw)
To: Cory Tusar
Cc: shawn.guo, kernel, stefan, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, linux-arm-kernel, devicetree,
linux-kernel, andrew
On Sun, Jun 14, 2015 at 08:19:59PM -0400, Cory Tusar wrote:
> This commit extends the existing Vybrid I2C support to cover buses i2c1,
> i2c2, and i2c3. Based in (very) large part on an initial patch by
> Stefan Agner that was just lacking a couple of DMA assignments.
>
> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-08 9:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-15 0:19 [PATCH] ARM: dts: vf610: Extend I2C support to all available buses Cory Tusar
2015-06-16 8:50 ` Stefan Agner
2015-06-30 2:20 ` Cory Tusar
2015-07-08 9:17 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).