From: WEN Pingbo <pingbo.wen@linaro.org>
To: linux-usb@vger.kernel.org
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, balbi@ti.com, peter@stuge.se,
stern@rowland.harvard.edu, WEN Pingbo <pingbo.wen@linaro.org>
Subject: [PATCH V3] dummy_hcd: replace timeval with timespec64
Date: Fri, 18 Sep 2015 10:51:26 +0800 [thread overview]
Message-ID: <1442544686-15571-1-git-send-email-pingbo.wen@linaro.org> (raw)
In-Reply-To: <1527029.ps0FmI1B3T@wuerfel>
The millisecond of the last second will be normal if tv_sec is
overflowed. But for y2038 consistency and demonstration purpose,
and avoiding further risks, we need to remove 'timeval' in this
driver, to avoid similair problems.
Signed-off-by: Pingbo Wen <pingbo.wen@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
V3 Updates:
- using ts64 variable name to avoid confusion
V2 Updates:
- using monotonic time here by replacing getnstimeofday() with
ktime_get_ts64(), to avoid leap second issues. The frame time in USB
is always 1ms, no matter what speed, so ktime_get_ts64() have enough
resolution to cover this.
- using NSEC_PER_MSEC instead of hard code.
drivers/usb/gadget/udc/dummy_hcd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 1379ad4..2ac9a13 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -833,10 +833,10 @@ static const struct usb_ep_ops dummy_ep_ops = {
/* there are both host and device side versions of this call ... */
static int dummy_g_get_frame(struct usb_gadget *_gadget)
{
- struct timeval tv;
+ struct timespec64 ts64;
- do_gettimeofday(&tv);
- return tv.tv_usec / 1000;
+ ktime_get_ts64(&ts64);
+ return ts64.tv_nsec / NSEC_PER_MSEC;
}
static int dummy_wakeup(struct usb_gadget *_gadget)
--
1.9.1
next prev parent reply other threads:[~2015-09-18 2:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2640620.MF43KccxAS@wuerfel>
2015-09-17 3:09 ` [PATCH V2] dummy_hcd: replace timeval with timespec64 WEN Pingbo
2015-09-17 3:13 ` Pingbo Wen
2015-09-17 8:12 ` Arnd Bergmann
2015-09-18 2:51 ` WEN Pingbo [this message]
2015-09-17 9:59 ` Peter Stuge
2015-09-17 11:42 ` Pingbo Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442544686-15571-1-git-send-email-pingbo.wen@linaro.org \
--to=pingbo.wen@linaro.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@stuge.se \
--cc=stern@rowland.harvard.edu \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).