From: Pingbo Wen <pingbo.wen@linaro.org>
To: peter@stuge.se
Cc: linux-usb@vger.kernel.org, Y2038 <y2038@lists.linaro.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH V2] dummy_hcd: replace timeval with timespec64
Date: Thu, 17 Sep 2015 19:42:31 +0800 [thread overview]
Message-ID: <55FAA727.4070206@linaro.org> (raw)
In-Reply-To: <20150917095906.28220.qmail@stuge.se>
On Thursday, September 17, 2015 05:59 PM, Peter Stuge wrote:
> WEN Pingbo wrote:
>> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
>> @@ -833,10 +833,10 @@ static const struct usb_ep_ops dummy_ep_ops = {
>> /* there are both host and device side versions of this call ... */
>> static int dummy_g_get_frame(struct usb_gadget *_gadget)
>> {
>> - struct timeval tv;
>> + struct timespec64 tv;
>
> tv is very often used for timeval structs.
>
> I suggest also changing the variable name, for example to ts, to
> avoid some possible confusion.
>
Hi Peter,
Thanks for pointing it out, I will fix it in next version.
Pingbo
prev parent reply other threads:[~2015-09-17 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2640620.MF43KccxAS@wuerfel>
2015-09-17 3:09 ` [PATCH V2] dummy_hcd: replace timeval with timespec64 WEN Pingbo
2015-09-17 3:13 ` Pingbo Wen
2015-09-17 8:12 ` Arnd Bergmann
2015-09-18 2:51 ` [PATCH V3] " WEN Pingbo
2015-09-17 9:59 ` [PATCH V2] " Peter Stuge
2015-09-17 11:42 ` Pingbo Wen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAA727.4070206@linaro.org \
--to=pingbo.wen@linaro.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@stuge.se \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).