From: Pingbo Wen <pingbo.wen@linaro.org>
To: linux-usb@vger.kernel.org
Cc: Y2038 <y2038@lists.linaro.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Felipe Balbi <balbi@ti.com>,
stern@rowland.harvard.edu
Subject: Re: [PATCH V2] dummy_hcd: replace timeval with timespec64
Date: Thu, 17 Sep 2015 11:13:41 +0800 [thread overview]
Message-ID: <55FA2FE5.1080900@linaro.org> (raw)
In-Reply-To: <1442459389-11171-1-git-send-email-pingbo.wen@linaro.org>
add Alan Stern
On Thursday, September 17, 2015 11:09 AM, WEN Pingbo wrote:
> The millisecond of the last second will be normal if tv_sec is
> overflowed. But for y2038 consistency and demonstration purpose,
> and avoiding further risks, we need to remove 'timeval' in this
> driver, to avoid similair problems.
>
> V2 Updates:
> - using monotonic time here by replacing getnstimeofday() with
> ktime_get_ts64(), to avoid leap second issues. The frame time in USB
> is always 1ms, no matter what speed, so ktime_get_ts64() have enough
> resolution to cover this.
> - using NSEC_PER_MSEC instead of hard code.
>
> Signed-off-by: Pingbo Wen <pingbo.wen@linaro.org>
> Cc: Y2038 <y2038@lists.linaro.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Felipe Balbi <balbi@ti.com>
> Signed-off-by: WEN Pingbo <pingbo.wen@linaro.org>
> ---
> drivers/usb/gadget/udc/dummy_hcd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> index 1379ad4..6d1ed35 100644
> --- a/drivers/usb/gadget/udc/dummy_hcd.c
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -833,10 +833,10 @@ static const struct usb_ep_ops dummy_ep_ops = {
> /* there are both host and device side versions of this call ... */
> static int dummy_g_get_frame(struct usb_gadget *_gadget)
> {
> - struct timeval tv;
> + struct timespec64 tv;
>
> - do_gettimeofday(&tv);
> - return tv.tv_usec / 1000;
> + ktime_get_ts64(&tv);
> + return tv.tv_nsec / NSEC_PER_MSEC;
> }
>
> static int dummy_wakeup(struct usb_gadget *_gadget)
>
next prev parent reply other threads:[~2015-09-17 3:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2640620.MF43KccxAS@wuerfel>
2015-09-17 3:09 ` [PATCH V2] dummy_hcd: replace timeval with timespec64 WEN Pingbo
2015-09-17 3:13 ` Pingbo Wen [this message]
2015-09-17 8:12 ` Arnd Bergmann
2015-09-18 2:51 ` [PATCH V3] " WEN Pingbo
2015-09-17 9:59 ` [PATCH V2] " Peter Stuge
2015-09-17 11:42 ` Pingbo Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FA2FE5.1080900@linaro.org \
--to=pingbo.wen@linaro.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).