From: Scott Wood <scottwood@freescale.com>
To: Zhao Qiang-B45475 <qiang.zhao@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"lauraa@codeaurora.org" <lauraa@codeaurora.org>,
Xie Xiaobo-R63061 <X.Xie@freescale.com>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
Li Yang-Leo-R58472 <LeoLi@freescale.com>,
"paulus@samba.org" <paulus@samba.org>
Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc
Date: Fri, 23 Oct 2015 15:55:39 -0500 [thread overview]
Message-ID: <1445633739.701.227.camel@freescale.com> (raw)
In-Reply-To: <SN1PR0301MB155072B05697D15EC990E0229B260@SN1PR0301MB1550.namprd03.prod.outlook.com>
On Fri, 2015-10-23 at 02:49 -0500, Zhao Qiang-B45475 wrote:
> On Fri, Oct 23, 2015 at 11:20 AM, Wood Scott-B07421 <scottwood@freescale.com
> > wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, October 23, 2015 11:20 AM
> > To: Zhao Qiang-B45475 <qiang.zhao@freescale.com>
> > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > lauraa@codeaurora.org; Xie Xiaobo-R63061 <X.Xie@freescale.com>;
> > benh@kernel.crashing.org; Li Yang-Leo-R58472 <LeoLi@freescale.com>;
> > paulus@samba.org
> > Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc
> >
> > On Wed, Oct 14, 2015 at 03:16:08PM +0800, Zhao Qiang wrote:
> >
> >
> > > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig
> > > b/drivers/soc/fsl/qe/Kconfig similarity index 50% copy from
> > > arch/powerpc/sysdev/qe_lib/Kconfig
> > > copy to drivers/soc/fsl/qe/Kconfig
> > > index 3c25199..283fe0d 100644
> > > --- a/arch/powerpc/sysdev/qe_lib/Kconfig
> > > +++ b/drivers/soc/fsl/qe/Kconfig
> > > @@ -2,6 +2,17 @@
> > > # QE Communication options
> > > #
> > >
> > > +config QUICC_ENGINE
> > > + bool "Freescale QUICC Engine (QE) Support"
> > > + depends on FSL_SOC && PPC32
> > > + select GENERIC_ALLOCATOR
> > > + select CRC32
> > > + help
> > > + The QUICC Engine (QE) is a new generation of communications
> > > + coprocessors on Freescale embedded CPUs (akin to CPM in older
> > chips).
> > > + Selecting this option means that you wish to build a kernel
> > > + for a machine with a QE coprocessor.
> > > +
> > > config UCC_SLOW
> > > bool
> > > default y if SERIAL_QE
> > > @@ -19,9 +30,3 @@ config UCC_FAST
> > > config UCC
> > > bool
> > > default y if UCC_FAST || UCC_SLOW
> > > -
> > > -config QE_USB
> > > - bool
> > > - default y if USB_FSL_QE
> > > - help
> > > - QE USB Controller support
> >
> > Why did some config symbols get moved and others not?
>
> Because QE_USB should be putted under drivers/usb,
> It is independent of this patchset.
If it's independent of this patchset then don't put it in this patchset.
Move all the QE stuff to drivers/soc and then later if something belongs
somewhere else, have a separate patch move it there.
-Scott
next prev parent reply other threads:[~2015-10-23 20:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 7:16 [PATCH v12 1/6] genalloc:support memory-allocation with bytes-alignment to genalloc Zhao Qiang
2015-10-14 7:16 ` [PATCH v12 2/6] genalloc:support allocating specific region Zhao Qiang
2015-10-14 7:16 ` [PATCH v12 3/6] CPM/QE: use genalloc to manage CPM/QE muram Zhao Qiang
2015-10-23 2:59 ` Scott Wood
[not found] ` <SN1PR0301MB1550906A0C2A2F6BA4EF807D9B260@SN1PR0301MB1550.namprd03.prod.outlook.com>
2015-10-23 20:59 ` Scott Wood
2015-10-26 3:15 ` Zhao Qiang
2015-10-27 4:50 ` Scott Wood
2015-10-14 7:16 ` [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common Zhao Qiang
2015-10-23 3:09 ` Scott Wood
2015-10-23 7:45 ` Zhao Qiang
2015-10-23 20:56 ` Scott Wood
2015-10-26 2:42 ` Zhao Qiang
2015-10-27 4:48 ` Scott Wood
2015-10-27 6:24 ` Zhao Qiang
2015-10-27 6:50 ` Scott Wood
2015-10-27 7:34 ` Zhao Qiang
2015-10-27 7:36 ` Scott Wood
2015-10-14 7:16 ` [PATCH v12 5/6] QE: use subsys_initcall to init qe Zhao Qiang
2015-10-23 3:11 ` Scott Wood
2015-10-14 7:16 ` [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc Zhao Qiang
2015-10-23 3:19 ` Scott Wood
2015-10-23 7:49 ` Zhao Qiang
2015-10-23 20:55 ` Scott Wood [this message]
2015-10-26 2:33 ` Zhao Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445633739.701.227.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=LeoLi@freescale.com \
--cc=X.Xie@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qiang.zhao@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).