From: Scott Wood <scottwood@freescale.com>
To: Zhao Qiang-B45475 <qiang.zhao@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"lauraa@codeaurora.org" <lauraa@codeaurora.org>,
Xie Xiaobo-R63061 <X.Xie@freescale.com>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
Li Yang-Leo-R58472 <LeoLi@freescale.com>,
"paulus@samba.org" <paulus@samba.org>
Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common
Date: Mon, 26 Oct 2015 23:48:09 -0500 [thread overview]
Message-ID: <1445921289.701.301.camel@freescale.com> (raw)
In-Reply-To: <SN1PR0301MB155083232AD1076F0779F7A49B230@SN1PR0301MB1550.namprd03.prod.outlook.com>
On Sun, 2015-10-25 at 21:42 -0500, Zhao Qiang-B45475 wrote:
> On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, October 24, 2015 4:56 AM
> > To: Zhao Qiang-B45475 <qiang.zhao@freescale.com>
> > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > lauraa@codeaurora.org; Xie Xiaobo-R63061 <X.Xie@freescale.com>;
> > benh@kernel.crashing.org; Li Yang-Leo-R58472 <LeoLi@freescale.com>;
> > paulus@samba.org
> > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to
> > qe_common
> >
> > On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote:
> > > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421
> > > <scottwood@freescale.com>
> > > wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Friday, October 23, 2015 11:10 AM
> > > > To: Zhao Qiang-B45475 <qiang.zhao@freescale.com>
> > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 <X.Xie@freescale.com>;
> > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 <LeoLi@freescale.com>;
> > > > paulus@samba.org
> > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management
> > functions
> > > > to qe_common
> > > >
> > > > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote:
> > > > > QE and CPM have the same muram, they use the same management
> > > > > functions. Now QE support both ARM and PowerPC, it is necessary to
> > > > > move QE to "driver/soc", so move the muram management functions
> > > > > from cpm_common to qe_common for preparing to move QE code to
> > "driver/soc"
> > > > >
> > > > > Signed-off-by: Zhao Qiang <qiang.zhao@freescale.com>
> > > > > ---
> > > > > Changes for v2:
> > > > > - no changes
> > > > > Changes for v3:
> > > > > - no changes
> > > > > Changes for v4:
> > > > > - no changes
> > > > > Changes for v5:
> > > > > - no changes
> > > > > Changes for v6:
> > > > > - using genalloc instead rheap to manage QE MURAM
> > > > > - remove qe_reset from platform file, using
> > > > > - subsys_initcall to call qe_init function.
> > > > > Changes for v7:
> > > > > - move this patch from 3/3 to 2/3
> > > > > - convert cpm with genalloc
> > > > > - check for gen_pool allocation failure Changes for v8:
> > > > > - rebase
> > > > > - move BD_SC_* macro instead of copy Changes for v9:
> > > > > - doesn't modify CPM, add a new patch to modify.
> > > > > - rebase
> > > > > Changes for v10:
> > > > > - rebase
> > > > > Changes for v11:
> > > > > - remove renaming
> > > > > - delete removing qe_reset and delete adding qe_init.
> > > > > Changes for v12:
> > > > > - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for it.
> > > >
> > > > Why is the SPI change part of this patch? Why is it even part of
> > > > this patchset, rather than an independent patch sent to the SPI list
> > > > and maintainer? If it's tied to other changes you're making,
> > > > explain that. As is, there is zero mention of the SPI change in the
> > > > part of the e-mail that will become the git changelog.
> > > >
> > > This SPI_FSL_CPM is cpm-spi, it is part of CPM.
> >
> > So then why are you selecting QUICC_ENGINE? And again, what does it have
> > to do with this patch?
>
> Cpm-spi is dependent on qe_muram, if not select it, Cpm-spi will failed to
> build.
Why QUICC_ENGINE and not CPM?
-Scott
next prev parent reply other threads:[~2015-10-27 4:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 7:16 [PATCH v12 1/6] genalloc:support memory-allocation with bytes-alignment to genalloc Zhao Qiang
2015-10-14 7:16 ` [PATCH v12 2/6] genalloc:support allocating specific region Zhao Qiang
2015-10-14 7:16 ` [PATCH v12 3/6] CPM/QE: use genalloc to manage CPM/QE muram Zhao Qiang
2015-10-23 2:59 ` Scott Wood
[not found] ` <SN1PR0301MB1550906A0C2A2F6BA4EF807D9B260@SN1PR0301MB1550.namprd03.prod.outlook.com>
2015-10-23 20:59 ` Scott Wood
2015-10-26 3:15 ` Zhao Qiang
2015-10-27 4:50 ` Scott Wood
2015-10-14 7:16 ` [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common Zhao Qiang
2015-10-23 3:09 ` Scott Wood
2015-10-23 7:45 ` Zhao Qiang
2015-10-23 20:56 ` Scott Wood
2015-10-26 2:42 ` Zhao Qiang
2015-10-27 4:48 ` Scott Wood [this message]
2015-10-27 6:24 ` Zhao Qiang
2015-10-27 6:50 ` Scott Wood
2015-10-27 7:34 ` Zhao Qiang
2015-10-27 7:36 ` Scott Wood
2015-10-14 7:16 ` [PATCH v12 5/6] QE: use subsys_initcall to init qe Zhao Qiang
2015-10-23 3:11 ` Scott Wood
2015-10-14 7:16 ` [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc Zhao Qiang
2015-10-23 3:19 ` Scott Wood
2015-10-23 7:49 ` Zhao Qiang
2015-10-23 20:55 ` Scott Wood
2015-10-26 2:33 ` Zhao Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445921289.701.301.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=LeoLi@freescale.com \
--cc=X.Xie@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qiang.zhao@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).