* [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()
@ 2015-10-26 19:51 Punit Vara
2015-10-27 5:29 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Punit Vara @ 2015-10-26 19:51 UTC (permalink / raw)
To: gregkh; +Cc: johnny.kim, linux-wireless, devel, linux-kernel, Punit Vara
This patch is to the host_interface.c that fixes up following
warning by checkpatch.pl:
-Prefer eth_broadcast_addr() over memset()
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 09a6c98..87b4eb8 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -4688,7 +4688,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
msg.drv = hif_drv;
if (pu8MacAddr == NULL)
- memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
+ eth_broadcast_addr(pstrDelStationMsg->mac_addr);
else
memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);
--
2.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()
2015-10-26 19:51 [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset() Punit Vara
@ 2015-10-27 5:29 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-10-27 5:29 UTC (permalink / raw)
To: Punit Vara; +Cc: devel, linux-wireless, johnny.kim, linux-kernel
On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch.pl:
>
> -Prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 09a6c98..87b4eb8 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -4688,7 +4688,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
> msg.drv = hif_drv;
>
> if (pu8MacAddr == NULL)
> - memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
> + eth_broadcast_addr(pstrDelStationMsg->mac_addr);
> else
> memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);
>
Doesn't apply to my staging.git tree at all :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-27 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-26 19:51 [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset() Punit Vara
2015-10-27 5:29 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).