Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"madalin.bucur@freescale.com" <madalin.bucur@freescale.com>
Cc: "scottwood@freescale.com" <scottwood@freescale.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"ppc@mindchasers.com" <ppc@mindchasers.com>,
	"roy.pledge@freescale.com" <roy.pledge@freescale.com>,
	"igal.liberman@freescale.com" <igal.liberman@freescale.com>,
	"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
	"joe@perches.com" <joe@perches.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet
Date: Tue, 3 Nov 2015 07:55:57 +0000	[thread overview]
Message-ID: <1446537357.21216.49.camel@transmode.se> (raw)
In-Reply-To: <1446485500-9782-3-git-send-email-madalin.bucur@freescale.com>

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> +       if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> +               if (net_ratelimit())
> +                       netif_warn(priv, hw, net_dev, "FD status = 0x%08x\n",
> +                                  fd_status & FM_FD_STAT_RX_ERRORS);
> +
> +               percpu_stats->rx_errors++;
> +               goto _release_frame;
> +       }

I cannot find any detailed error accounting(maybe I am not looking hard enough) but I
would appreciate if both TX and RX errors where better accounted(rx_length_errors, rx_frame_errors,
rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the past diagnosing
board HW problems.

 Jocke