linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
To: Joe Perches <joe@perches.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Scott Wood <scottwood@freescale.com>,
	Liberman Igal <Igal.Liberman@freescale.com>,
	"Roy Pledge" <roy.pledge@freescale.com>,
	"ppc@mindchasers.com" <ppc@mindchasers.com>,
	"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
	"joakim.tjernlund@transmode.se" <joakim.tjernlund@transmode.se>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: RE: [net-next v4 3/8] dpaa_eth: add support for S/G frames
Date: Tue, 3 Nov 2015 09:41:14 +0000	[thread overview]
Message-ID: <BL2PR03MB5455FAD900C81B20022392CE62B0@BL2PR03MB545.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1446494829.24485.63.camel@perches.com>

> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> 
> On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> > Add support for Scater/Gather (S/G) frames. The FMan can place
> > the frame content into multiple buffers and provide a S/G Table
> > (SGT) into one first buffer with references to the others.
> 
> trivia: scatter
> 
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_common.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_common.c
> []
> > @@ -1177,10 +1177,42 @@ void dpaa_eth_init_ports(struct mac_device
> *mac_dev,
> >  			      port_fqs->rx_defq, &buf_layout[RX]);
> >  }
> >
> > +void dpa_release_sgt(struct qm_sg_entry *sgt)
> > +{
> > +	struct dpa_bp *dpa_bp;
> > +	struct bm_buffer bmb[DPA_BUFF_RELEASE_MAX];
> 
> Where is "struct bm_buffer" defined?
> 

Thank you, I'll address this and the other observations you have sent.
The struct bm_buffer is defined in the Buffer Manager driver header file,
in include/soc/fsl/bman.h.

Madalin

  reply	other threads:[~2015-11-03  9:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 17:31 [net-next v4 0/8] dpaa_eth: Add the Freescale DPAA Ethernet driver Madalin Bucur
2015-11-02 17:31 ` [net-next v4 1/8] devres: add devm_alloc_percpu() Madalin Bucur
2015-11-02 19:51   ` Joe Perches
2015-11-02 17:31 ` [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Madalin Bucur
2015-11-02 19:51   ` Joe Perches
2015-11-03  7:55   ` Joakim Tjernlund
2015-11-03  9:37     ` Madalin-Cristian Bucur
2015-11-03 11:23       ` Joakim Tjernlund
2015-11-03 13:21         ` Madalin-Cristian Bucur
2015-11-11  3:35   ` Scott Wood
2015-11-02 17:31 ` [net-next v4 3/8] dpaa_eth: add support for S/G frames Madalin Bucur
2015-11-02 20:07   ` Joe Perches
2015-11-03  9:41     ` Madalin-Cristian Bucur [this message]
2015-11-02 21:03   ` Joe Perches
2015-11-02 17:31 ` [net-next v4 4/8] dpaa_eth: add driver's Tx queue selection Madalin Bucur
2015-12-02 21:40   ` Scott Wood
2015-12-03 10:02     ` Madalin-Cristian Bucur
2015-12-03 19:37       ` Scott Wood
2015-11-02 17:31 ` [net-next v4 5/8] dpaa_eth: add ethtool functionality Madalin Bucur
2015-11-02 17:31 ` [net-next v4 6/8] dpaa_eth: add ethtool statistics Madalin Bucur
2015-11-02 20:39   ` Joe Perches
2015-11-02 17:31 ` [net-next v4 7/8] dpaa_eth: add sysfs exports Madalin Bucur
2015-11-02 17:31 ` [net-next v4 8/8] dpaa_eth: add trace points Madalin Bucur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL2PR03MB5455FAD900C81B20022392CE62B0@BL2PR03MB545.namprd03.prod.outlook.com \
    --to=madalin.bucur@freescale.com \
    --cc=Igal.Liberman@freescale.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joakim.tjernlund@transmode.se \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=ppc@mindchasers.com \
    --cc=roy.pledge@freescale.com \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).